1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
|
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
/* -*- indent-tabs-mode: nil; js-indent-level: 4 -*- */
"use strict";
loadRelativeToScript('utility.js');
loadRelativeToScript('annotations.js');
loadRelativeToScript('CFG.js');
loadRelativeToScript('dumpCFG.js');
var sourceRoot = (os.getenv('SOURCE') || '') + '/'
var functionName;
var functionBodies;
if (typeof scriptArgs[0] != 'string' || typeof scriptArgs[1] != 'string')
throw "Usage: analyzeRoots.js [-f function_name] <gcFunctions.lst> <gcEdges.txt> <limitedFunctions.lst> <gcTypes.txt> <typeInfo.txt> [start end [tmpfile]]";
var theFunctionNameToFind;
if (scriptArgs[0] == '--function' || scriptArgs[0] == '-f') {
theFunctionNameToFind = scriptArgs[1];
scriptArgs = scriptArgs.slice(2);
}
var gcFunctionsFile = scriptArgs[0] || "gcFunctions.lst";
var gcEdgesFile = scriptArgs[1] || "gcEdges.txt";
var limitedFunctionsFile = scriptArgs[2] || "limitedFunctions.lst";
var gcTypesFile = scriptArgs[3] || "gcTypes.txt";
var typeInfoFile = scriptArgs[4] || "typeInfo.txt";
var batch = (scriptArgs[5]|0) || 1;
var numBatches = (scriptArgs[6]|0) || 1;
var tmpfile = scriptArgs[7] || "tmp.txt";
var gcFunctions = {};
var text = snarf("gcFunctions.lst").split("\n");
assert(text.pop().length == 0);
for (var line of text)
gcFunctions[mangled(line)] = true;
var limitedFunctions = {};
var text = snarf(limitedFunctionsFile).split("\n");
assert(text.pop().length == 0);
for (var line of text) {
const [_, limits, func] = line.match(/(.*?) (.*)/);
assert(limits !== undefined);
limitedFunctions[func] = limits | 0;
}
text = null;
var typeInfo = loadTypeInfo(typeInfoFile);
var gcEdges = {};
text = snarf(gcEdgesFile).split('\n');
assert(text.pop().length == 0);
for (var line of text) {
var [ block, edge, func ] = line.split(" || ");
if (!(block in gcEdges))
gcEdges[block] = {}
gcEdges[block][edge] = func;
}
text = null;
var match;
var gcThings = {};
var gcPointers = {};
text = snarf(gcTypesFile).split("\n");
for (var line of text) {
if (match = /^GCThing: (.*)/.exec(line))
gcThings[match[1]] = true;
if (match = /^GCPointer: (.*)/.exec(line))
gcPointers[match[1]] = true;
}
text = null;
function isGCType(type)
{
if (type.Kind == "CSU")
return type.Name in gcThings;
else if (type.Kind == "Array")
return isGCType(type.Type);
return false;
}
function isUnrootedType(type)
{
if (type.Kind == "Pointer")
return isGCType(type.Type);
else if (type.Kind == "Array") {
if (!type.Type) {
printErr("Received Array Kind with no Type");
printErr(JSON.stringify(type));
printErr(getBacktrace({args: true, locals: true}));
}
return isUnrootedType(type.Type);
} else if (type.Kind == "CSU")
return type.Name in gcPointers;
else
return false;
}
function expressionUsesVariable(exp, variable)
{
if (exp.Kind == "Var" && sameVariable(exp.Variable, variable))
return true;
if (!("Exp" in exp))
return false;
for (var childExp of exp.Exp) {
if (expressionUsesVariable(childExp, variable))
return true;
}
return false;
}
function expressionUsesVariableContents(exp, variable)
{
if (!("Exp" in exp))
return false;
for (var childExp of exp.Exp) {
if (childExp.Kind == 'Drf') {
if (expressionUsesVariable(childExp, variable))
return true;
} else if (expressionUsesVariableContents(childExp, variable)) {
return true;
}
}
return false;
}
function isImmobileValue(exp) {
if (exp.Kind == "Int" && exp.String == "0") {
return true;
}
return false;
}
// Detect simple |return nullptr;| statements.
function isReturningImmobileValue(edge, variable)
{
if (variable.Kind == "Return") {
if (edge.Exp[0].Kind == "Var" && sameVariable(edge.Exp[0].Variable, variable)) {
if (isImmobileValue(edge.Exp[1]))
return true;
}
}
return false;
}
// If the edge uses the given variable's value, return the earliest point at
// which the use is definite. Usually, that means the source of the edge
// (anything that reaches that source point will end up using the variable, but
// there may be other ways to reach the destination of the edge.)
//
// Return values are implicitly used at the very last point in the function.
// This makes a difference: if an RAII class GCs in its destructor, we need to
// start looking at the final point in the function, not one point back from
// that, since that would skip over the GCing call.
//
// Note that this returns true only if the variable's incoming value is used.
// So this would return false for 'obj':
//
// obj = someFunction();
//
// but these would return true:
//
// obj = someFunction(obj);
// obj->foo = someFunction();
//
function edgeUsesVariable(edge, variable, body)
{
if (ignoreEdgeUse(edge, variable, body))
return 0;
if (variable.Kind == "Return" && body.Index[1] == edge.Index[1] && body.BlockId.Kind == "Function")
return edge.Index[1]; // Last point in function body uses the return value.
var src = edge.Index[0];
switch (edge.Kind) {
case "Assign": {
// Detect `Return := nullptr`.
if (isReturningImmobileValue(edge, variable))
return 0;
const [lhs, rhs] = edge.Exp;
// Detect `lhs := ...variable...`
if (expressionUsesVariable(rhs, variable))
return src;
// Detect `...variable... := rhs` but not `variable := rhs`. The latter
// overwrites the previous value of `variable` without using it.
if (expressionUsesVariable(lhs, variable) && !expressionIsVariable(lhs, variable))
return src;
return 0;
}
case "Assume":
return expressionUsesVariableContents(edge.Exp[0], variable) ? src : 0;
case "Call": {
const callee = edge.Exp[0];
if (expressionUsesVariable(callee, variable))
return src;
if ("PEdgeCallInstance" in edge) {
if (expressionUsesVariable(edge.PEdgeCallInstance.Exp, variable)) {
if (edgeKillsVariable(edge, variable)) {
// If the variable is being constructed, then the incoming
// value is not used here; it didn't exist before
// construction. (The analysis doesn't get told where
// variables are defined, so must infer it from
// construction. If the variable does not have a
// constructor, its live range may be larger than it really
// ought to be if it is defined within a loop body, but
// that is conservative.)
} else {
return src;
}
}
}
if ("PEdgeCallArguments" in edge) {
for (var exp of edge.PEdgeCallArguments.Exp) {
if (expressionUsesVariable(exp, variable))
return src;
}
}
if (edge.Exp.length == 1)
return 0;
// Assigning call result to a variable.
const lhs = edge.Exp[1];
if (expressionUsesVariable(lhs, variable) && !expressionIsVariable(lhs, variable))
return src;
return 0;
}
case "Loop":
return 0;
case "Assembly":
return 0;
default:
assert(false);
}
}
function expressionIsVariableAddress(exp, variable)
{
while (exp.Kind == "Fld")
exp = exp.Exp[0];
return exp.Kind == "Var" && sameVariable(exp.Variable, variable);
}
function edgeTakesVariableAddress(edge, variable, body)
{
if (ignoreEdgeUse(edge, variable, body))
return false;
if (ignoreEdgeAddressTaken(edge))
return false;
switch (edge.Kind) {
case "Assign":
return expressionIsVariableAddress(edge.Exp[1], variable);
case "Call":
if ("PEdgeCallArguments" in edge) {
for (var exp of edge.PEdgeCallArguments.Exp) {
if (expressionIsVariableAddress(exp, variable))
return true;
}
}
return false;
default:
return false;
}
}
function expressionIsVariable(exp, variable)
{
return exp.Kind == "Var" && sameVariable(exp.Variable, variable);
}
function expressionIsMethodOnVariable(exp, variable)
{
// This might be calling a method on a base class, in which case exp will
// be an unnamed field of the variable instead of the variable itself.
while (exp.Kind == "Fld" && exp.Field.Name[0].startsWith("field:"))
exp = exp.Exp[0];
return exp.Kind == "Var" && sameVariable(exp.Variable, variable);
}
// Return whether the edge terminates the live range of a variable's value when
// searching in reverse through the CFG, by setting it to some new value.
// Examples of killing 'obj's live range:
//
// obj = foo;
// obj = foo();
// obj = foo(obj); // uses previous value but then sets to new value
// SomeClass obj(true, 1); // constructor
//
function edgeKillsVariable(edge, variable)
{
// Direct assignments kill their lhs: var = value
if (edge.Kind == "Assign") {
const [lhs, rhs] = edge.Exp;
return (expressionIsVariable(lhs, variable) &&
!isReturningImmobileValue(edge, variable));
}
if (edge.Kind != "Call")
return false;
// Assignments of call results kill their lhs.
if (1 in edge.Exp) {
var lhs = edge.Exp[1];
if (expressionIsVariable(lhs, variable))
return true;
}
// Constructor calls kill their 'this' value.
if ("PEdgeCallInstance" in edge) {
var instance = edge.PEdgeCallInstance.Exp;
// Kludge around incorrect dereference on some constructor calls.
if (instance.Kind == "Drf")
instance = instance.Exp[0];
if (!expressionIsVariable(instance, variable))
return false;
var callee = edge.Exp[0];
if (callee.Kind != "Var")
return false;
assert(callee.Variable.Kind == "Func");
var calleeName = readable(callee.Variable.Name[0]);
// Constructor calls include the text 'Name::Name(' or 'Name<...>::Name('.
var openParen = calleeName.indexOf('(');
if (openParen < 0)
return false;
calleeName = calleeName.substring(0, openParen);
var lastColon = calleeName.lastIndexOf('::');
if (lastColon < 0)
return false;
var constructorName = calleeName.substr(lastColon + 2);
calleeName = calleeName.substr(0, lastColon);
var lastTemplateOpen = calleeName.lastIndexOf('<');
if (lastTemplateOpen >= 0)
calleeName = calleeName.substr(0, lastTemplateOpen);
if (calleeName.endsWith(constructorName))
return true;
}
return false;
}
function edgeMovesVariable(edge, variable)
{
if (edge.Kind != 'Call')
return false;
const callee = edge.Exp[0];
if (callee.Kind == 'Var' &&
callee.Variable.Kind == 'Func')
{
const { Variable: { Name: [ fullname, shortname ] } } = callee;
const [ mangled, unmangled ] = splitFunction(fullname);
// Match a UniquePtr move constructor.
if (unmangled.match(/::UniquePtr<[^>]*>::UniquePtr\((\w+::)*UniquePtr<[^>]*>&&/))
return true;
}
return false;
}
// Scan forward through the given 'body', starting at 'startpoint', looking for
// a call that passes 'variable' to a move constructor that "consumes" it (eg
// UniquePtr::UniquePtr(UniquePtr&&)).
function bodyEatsVariable(variable, body, startpoint)
{
const successors = getSuccessors(body);
const work = [startpoint];
while (work.length > 0) {
const point = work.shift();
if (!(point in successors))
continue;
for (const edge of successors[point]) {
if (edgeMovesVariable(edge, variable))
return true;
// edgeKillsVariable will find places where 'variable' is given a
// new value. Never observed in practice, since this function is
// only called with a temporary resulting from std::move(), which
// is used immediately for a call. But just to be robust to future
// uses:
if (!edgeKillsVariable(edge, variable))
work.push(edge.Index[1]);
}
}
return false;
}
// Return whether an edge "clears out" a variable's value. A simple example
// would be
//
// var = nullptr;
//
// for analyses for which nullptr is a "safe" value (eg GC rooting hazards; you
// can't get in trouble by holding a nullptr live across a GC.) A more complex
// example is a Maybe<T> that gets reset:
//
// Maybe<AutoCheckCannotGC> nogc;
// nogc.emplace(cx);
// nogc.reset();
// gc(); // <-- not a problem; nogc is invalidated by prev line
// nogc.emplace(cx);
// foo(nogc);
//
// Yet another example is a UniquePtr being passed by value, which means the
// receiver takes ownership:
//
// UniquePtr<JSObject*> uobj(obj);
// foo(uobj);
// gc();
//
// Compare to edgeKillsVariable: killing (in backwards direction) means the
// variable's value was live and is no longer. Invalidating means it wasn't
// actually live after all.
//
function edgeInvalidatesVariable(edge, variable, body)
{
// var = nullptr;
if (edge.Kind == "Assign") {
const [lhs, rhs] = edge.Exp;
return expressionIsVariable(lhs, variable) && isImmobileValue(rhs);
}
if (edge.Kind != "Call")
return false;
var callee = edge.Exp[0];
if (edge.Type.Kind == 'Function' &&
edge.Exp[0].Kind == 'Var' &&
edge.Exp[0].Variable.Kind == 'Func' &&
edge.Exp[0].Variable.Name[1] == 'move' &&
edge.Exp[0].Variable.Name[0].includes('std::move(') &&
expressionIsVariable(edge.PEdgeCallArguments.Exp[0], variable) &&
edge.Exp[1].Kind == 'Var' &&
edge.Exp[1].Variable.Kind == 'Temp')
{
// temp = std::move(var)
//
// If var is a UniquePtr, and we pass it into something that takes
// ownership, then it should be considered to be invalid. It really
// ought to be invalidated at the point of the function call that calls
// the move constructor, but given that we're creating a temporary here
// just for the purpose of passing it in, this edge is good enough.
const lhs = edge.Exp[1].Variable;
if (bodyEatsVariable(lhs, body, edge.Index[1]))
return true;
}
if (edge.Type.Kind == 'Function' &&
edge.Type.TypeFunctionCSU &&
edge.PEdgeCallInstance &&
expressionIsMethodOnVariable(edge.PEdgeCallInstance.Exp, variable))
{
const typeName = edge.Type.TypeFunctionCSU.Type.Name;
const m = typeName.match(/^(((\w|::)+?)(\w+))</);
if (m) {
const [, type, namespace,, classname] = m;
// special-case: the initial constructor that doesn't provide a value.
// Useful for things like Maybe<T>.
const ctorName = `${namespace}${classname}<T>::${classname}()`;
if (callee.Kind == 'Var' &&
typesWithSafeConstructors.has(type) &&
callee.Variable.Name[0].includes(ctorName))
{
return true;
}
// special-case: UniquePtr::reset() and similar.
if (callee.Kind == 'Var' &&
type in resetterMethods &&
resetterMethods[type].has(callee.Variable.Name[1]))
{
return true;
}
}
}
// special-case: passing UniquePtr<T> by value.
if (edge.Type.Kind == 'Function' &&
edge.Type.TypeFunctionArgument &&
edge.PEdgeCallArguments)
{
for (const i in edge.Type.TypeFunctionArgument) {
const param = edge.Type.TypeFunctionArgument[i];
if (param.Type.Kind != 'CSU')
continue;
if (!param.Type.Name.startsWith("mozilla::UniquePtr<"))
continue;
const arg = edge.PEdgeCallArguments.Exp[i];
if (expressionIsVariable(arg, variable)) {
return true;
}
}
}
return false;
}
function edgeCanGC(edge)
{
if (edge.Kind != "Call")
return false;
var callee = edge.Exp[0];
while (callee.Kind == "Drf")
callee = callee.Exp[0];
if (callee.Kind == "Var") {
var variable = callee.Variable;
if (variable.Kind == "Func") {
var func = mangled(variable.Name[0]);
if ((func in gcFunctions) || ((func + internalMarker) in gcFunctions))
return "'" + variable.Name[0] + "'";
return null;
}
var varName = variable.Name[0];
return indirectCallCannotGC(functionName, varName) ? null : "'*" + varName + "'";
}
if (callee.Kind == "Fld") {
var field = callee.Field;
var csuName = field.FieldCSU.Type.Name;
var fullFieldName = csuName + "." + field.Name[0];
if (fieldCallCannotGC(csuName, fullFieldName))
return null;
if (fullFieldName in gcFunctions)
return "'" + fullFieldName + "'";
return null;
}
}
// Search recursively through predecessors from the use of a variable's value,
// returning whether a GC call is reachable (in the reverse direction; this
// means that the variable use is reachable from the GC call, and therefore the
// variable is live after the GC call), along with some additional information.
// What info we want depends on whether the variable turns out to be live
// across a GC call. We are looking for both hazards (unrooted variables live
// across GC calls) and unnecessary roots (rooted variables that have no GC
// calls in their live ranges.)
//
// If not:
//
// - 'minimumUse': the earliest point in each body that uses the variable, for
// reporting on unnecessary roots.
//
// If so:
//
// - 'why': a path from the GC call to a use of the variable after the GC
// call, chained through a 'why' field in the returned edge descriptor
//
// - 'gcInfo': a direct pointer to the GC call edge
//
function findGCBeforeValueUse(start_body, start_point, suppressed, variable)
{
// Scan through all edges preceding an unrooted variable use, using an
// explicit worklist, looking for a GC call. A worklist contains an
// incoming edge together with a description of where it or one of its
// successors GC'd (if any).
var bodies_visited = new Map();
let worklist = [{body: start_body, ppoint: start_point, preGCLive: false, gcInfo: null, why: null}];
while (worklist.length) {
// Grab an entry off of the worklist, representing a point within the
// CFG identified by <body,ppoint>. If this point has a descendant
// later in the CFG that can GC, gcInfo will be set to the information
// about that GC call.
var entry = worklist.pop();
var { body, ppoint, gcInfo, preGCLive } = entry;
// Handle the case where there are multiple ways to reach this point
// (traversing backwards).
var visited = bodies_visited.get(body);
if (!visited)
bodies_visited.set(body, visited = new Map());
if (visited.has(ppoint)) {
var seenEntry = visited.get(ppoint);
// This point already knows how to GC through some other path, so
// we have nothing new to learn. (The other path will consider the
// predecessors.)
if (seenEntry.gcInfo)
continue;
// If this worklist's entry doesn't know of any way to GC, then
// there's no point in continuing the traversal through it. Perhaps
// another edge will be found that *can* GC; otherwise, the first
// route to the point will traverse through predecessors.
//
// Note that this means we may visit a point more than once, if the
// first time we visit we don't have a known reachable GC call and
// the second time we do.
if (!gcInfo)
continue;
}
visited.set(ppoint, {body: body, gcInfo: gcInfo});
// Check for hitting the entry point of the current body (which may be
// the outer function or a loop within it.)
if (ppoint == body.Index[0]) {
if (body.BlockId.Kind == "Loop") {
// Propagate to outer body parents that enter the loop body.
if ("BlockPPoint" in body) {
for (var parent of body.BlockPPoint) {
var found = false;
for (var xbody of functionBodies) {
if (sameBlockId(xbody.BlockId, parent.BlockId)) {
assert(!found);
found = true;
worklist.push({body: xbody, ppoint: parent.Index,
gcInfo: gcInfo, why: entry});
}
}
assert(found);
}
}
// Also propagate to the *end* of this loop, for the previous
// iteration.
worklist.push({body: body, ppoint: body.Index[1],
gcInfo: gcInfo, why: entry});
} else if ((variable.Kind == "Arg" || variable.Kind == "This") && gcInfo) {
// The scope of arguments starts at the beginning of the
// function
return entry;
} else if (entry.preGCLive) {
// We didn't find a "good" explanation beginning of the live
// range, but we do know the variable was live across the GC.
// This can happen if the live range started when a variable is
// used as a retparam.
return entry;
}
}
var predecessors = getPredecessors(body);
if (!(ppoint in predecessors))
continue;
for (var edge of predecessors[ppoint]) {
var source = edge.Index[0];
if (edgeInvalidatesVariable(edge, variable, body)) {
// Terminate the search through this point; we thought we were
// within the live range, but it turns out that the variable
// was set to a value that we don't care about.
continue;
}
var edge_kills = edgeKillsVariable(edge, variable);
var edge_uses = edgeUsesVariable(edge, variable, body);
if (edge_kills || edge_uses) {
if (!body.minimumUse || source < body.minimumUse)
body.minimumUse = source;
}
if (edge_kills) {
// This is a beginning of the variable's live range. If we can
// reach a GC call from here, then we're done -- we have a path
// from the beginning of the live range, through the GC call,
// to a use after the GC call that proves its live range
// extends at least that far.
if (gcInfo)
return {body: body, ppoint: source, gcInfo: gcInfo, why: entry };
// Otherwise, keep searching through the graph, but truncate
// this particular branch of the search at this edge.
continue;
}
var src_gcInfo = gcInfo;
var src_preGCLive = preGCLive;
if (!gcInfo && !(body.limits[source] & LIMIT_CANNOT_GC) && !suppressed) {
var gcName = edgeCanGC(edge, body);
if (gcName)
src_gcInfo = {name:gcName, body:body, ppoint:source};
}
if (edge_uses) {
// The live range starts at least this far back, so we're done
// for the same reason as with edge_kills. The only difference
// is that a GC on this edge indicates a hazard, whereas if
// we're killing a live range in the GC call then it's not live
// *across* the call.
//
// However, we may want to generate a longer usage chain for
// the variable than is minimally necessary. For example,
// consider:
//
// Value v = f();
// if (v.isUndefined())
// return false;
// gc();
// return v;
//
// The call to .isUndefined() is considered to be a use and
// therefore indicates that v must be live at that point. But
// it's more helpful to the user to continue the 'why' path to
// include the ancestor where the value was generated. So we
// will only return here if edge.Kind is Assign; otherwise,
// we'll pass a "preGCLive" value up through the worklist to
// remember that the variable *is* alive before the GC and so
// this function should be returning a true value even if we
// don't find an assignment.
if (src_gcInfo) {
src_preGCLive = true;
if (edge.Kind == 'Assign')
return {body:body, ppoint:source, gcInfo:src_gcInfo, why:entry};
}
}
if (edge.Kind == "Loop") {
// Additionally propagate the search into a loop body, starting
// with the exit point.
var found = false;
for (var xbody of functionBodies) {
if (sameBlockId(xbody.BlockId, edge.BlockId)) {
assert(!found);
found = true;
worklist.push({body:xbody, ppoint:xbody.Index[1],
preGCLive: src_preGCLive, gcInfo:src_gcInfo,
why:entry});
}
}
assert(found);
// Don't continue to predecessors here without going through
// the loop. (The points in this body that enter the loop will
// be traversed when we reach the entry point of the loop.)
break;
}
// Propagate the search to the predecessors of this edge.
worklist.push({body:body, ppoint:source,
preGCLive: src_preGCLive, gcInfo:src_gcInfo,
why:entry});
}
}
return null;
}
function variableLiveAcrossGC(suppressed, variable)
{
// A variable is live across a GC if (1) it is used by an edge (as in, it
// was at least initialized), and (2) it is used after a GC in a successor
// edge.
for (var body of functionBodies)
body.minimumUse = 0;
for (var body of functionBodies) {
if (!("PEdge" in body))
continue;
for (var edge of body.PEdge) {
// Examples:
//
// JSObject* obj = NewObject();
// cangc();
// obj = NewObject(); <-- mentions 'obj' but kills previous value
//
// This is not a hazard. Contrast this with:
//
// JSObject* obj = NewObject();
// cangc();
// obj = LookAt(obj); <-- uses 'obj' and kills previous value
//
// This is a hazard; the initial value of obj is live across
// cangc(). And a third possibility:
//
// JSObject* obj = NewObject();
// obj = CopyObject(obj);
//
// This is not a hazard, because even though CopyObject can GC, obj
// is not live across it. (obj is live before CopyObject, and
// probably after, but not across.) There may be a hazard within
// CopyObject, of course.
//
// Ignore uses that are just invalidating the previous value.
if (edgeInvalidatesVariable(edge, variable, body))
continue;
var usePoint = edgeUsesVariable(edge, variable, body);
if (usePoint) {
var call = findGCBeforeValueUse(body, usePoint, suppressed, variable);
if (!call)
continue;
call.afterGCUse = usePoint;
return call;
}
}
}
return null;
}
// An unrooted variable has its address stored in another variable via
// assignment, or passed into a function that can GC. If the address is
// assigned into some other variable, we can't track it to see if it is held
// live across a GC. If it is passed into a function that can GC, then it's
// sort of like a Handle to an unrooted location, and the callee could GC
// before overwriting it or rooting it.
function unsafeVariableAddressTaken(suppressed, variable)
{
for (var body of functionBodies) {
if (!("PEdge" in body))
continue;
for (var edge of body.PEdge) {
if (edgeTakesVariableAddress(edge, variable, body)) {
if (edge.Kind == "Assign" || (!suppressed && edgeCanGC(edge)))
return {body:body, ppoint:edge.Index[0]};
}
}
}
return null;
}
// Read out the brief (non-JSON, semi-human-readable) CFG description for the
// given function and store it.
function loadPrintedLines(functionName)
{
assert(!os.system("xdbfind src_body.xdb '" + functionName + "' > " + tmpfile));
var lines = snarf(tmpfile).split('\n');
for (var body of functionBodies)
body.lines = [];
// Distribute lines of output to the block they originate from.
var currentBody = null;
for (var line of lines) {
if (/^block:/.test(line)) {
if (match = /:(loop#[\d#]+)/.exec(line)) {
var loop = match[1];
var found = false;
for (var body of functionBodies) {
if (body.BlockId.Kind == "Loop" && body.BlockId.Loop == loop) {
assert(!found);
found = true;
currentBody = body;
}
}
assert(found);
} else {
for (var body of functionBodies) {
if (body.BlockId.Kind == "Function")
currentBody = body;
}
}
}
if (currentBody)
currentBody.lines.push(line);
}
}
function findLocation(body, ppoint, opts={brief: false})
{
var location = body.PPoint[ppoint - 1].Location;
var file = location.CacheString;
if (file.indexOf(sourceRoot) == 0)
file = file.substring(sourceRoot.length);
if (opts.brief) {
var m = /.*\/(.*)/.exec(file);
if (m)
file = m[1];
}
return file + ":" + location.Line;
}
function locationLine(text)
{
if (match = /:(\d+)$/.exec(text))
return match[1];
return 0;
}
function printEntryTrace(functionName, entry)
{
var gcPoint = entry.gcInfo ? entry.gcInfo.ppoint : 0;
if (!functionBodies[0].lines)
loadPrintedLines(functionName);
while (entry) {
var ppoint = entry.ppoint;
var lineText = findLocation(entry.body, ppoint, {"brief": true});
var edgeText = "";
if (entry.why && entry.why.body == entry.body) {
// If the next point in the trace is in the same block, look for an edge between them.
var next = entry.why.ppoint;
if (!entry.body.edgeTable) {
var table = {};
entry.body.edgeTable = table;
for (var line of entry.body.lines) {
if (match = /^\w+\((\d+,\d+),/.exec(line))
table[match[1]] = line; // May be multiple?
}
if (entry.body.BlockId.Kind == 'Loop') {
const [startPoint, endPoint] = entry.body.Index;
table[`${endPoint},${startPoint}`] = '(loop to next iteration)';
}
}
edgeText = entry.body.edgeTable[ppoint + "," + next];
assert(edgeText);
if (ppoint == gcPoint)
edgeText += " [[GC call]]";
} else {
// Look for any outgoing edge from the chosen point.
for (var line of entry.body.lines) {
if (match = /\((\d+),/.exec(line)) {
if (match[1] == ppoint) {
edgeText = line;
break;
}
}
}
if (ppoint == entry.body.Index[1] && entry.body.BlockId.Kind == "Function")
edgeText += " [[end of function]]";
}
print(" " + lineText + (edgeText.length ? ": " + edgeText : ""));
entry = entry.why;
}
}
function isRootedType(type)
{
return type.Kind == "CSU" && ((type.Name in typeInfo.RootedPointers) ||
(type.Name in typeInfo.RootedGCThings));
}
function typeDesc(type)
{
if (type.Kind == "CSU") {
return type.Name;
} else if ('Type' in type) {
var inner = typeDesc(type.Type);
if (type.Kind == 'Pointer')
return inner + '*';
else if (type.Kind == 'Array')
return inner + '[]';
else
return inner + '?';
} else {
return '???';
}
}
function processBodies(functionName)
{
if (!("DefineVariable" in functionBodies[0]))
return;
var suppressed = Boolean(limitedFunctions[mangled(functionName)] & LIMIT_CANNOT_GC);
// Look for the JS_EXPECT_HAZARDS annotation, and output a different
// message in that case that won't be counted as a hazard.
var annotations = new Set();
for (const variable of functionBodies[0].DefineVariable) {
if (variable.Variable.Kind == "Func" && variable.Variable.Name[0] == functionName) {
for (const { Name: [tag, value] } of (variable.Type.Annotation || [])) {
if (tag == 'annotate')
annotations.add(value);
}
}
}
var missingExpectedHazard = annotations.has("Expect Hazards");
// Awful special case, hopefully temporary:
//
// The DOM bindings code generator uses "holders" to externally root
// variables. So for example:
//
// StringObjectRecordOrLong arg0;
// StringObjectRecordOrLongArgument arg0_holder(arg0);
// arg0_holder.TrySetToStringObjectRecord(cx, args[0]);
// GC();
// self->PassUnion22(cx, arg0);
//
// This appears to be a rooting hazard on arg0, but it is rooted by
// arg0_holder if you set it to any of its union types that requires
// rooting.
//
// Additionally, the holder may be reported as a hazard because it's not
// itself a Rooted or a subclass of AutoRooter; it contains a
// Maybe<RecordRooter<T>> that will get emplaced if rooting is required.
//
// Hopefully these will be simplified at some point (see bug 1517829), but
// for now we special-case functions in the mozilla::dom namespace that
// contain locals with types ending in "Argument". Or
// Maybe<SomethingArgument>. It's a harsh world.
const ignoreVars = new Set();
if (functionName.match(/mozilla::dom::/)) {
const vars = functionBodies[0].DefineVariable.filter(
v => v.Type.Kind == 'CSU' && v.Variable.Kind == 'Local'
).map(
v => [ v.Variable.Name[0], v.Type.Name ]
);
const holders = vars.filter(([n, t]) => n.match(/^arg\d+_holder$/) && t.match(/Argument\b/));
for (const [holder,] of holders) {
ignoreVars.add(holder); // Ignore the older.
ignoreVars.add(holder.replace("_holder", "")); // Ignore the "managed" arg.
}
}
for (const variable of functionBodies[0].DefineVariable) {
var name;
if (variable.Variable.Kind == "This")
name = "this";
else if (variable.Variable.Kind == "Return")
name = "<returnvalue>";
else
name = variable.Variable.Name[0];
if (ignoreVars.has(name))
continue;
if (isRootedType(variable.Type)) {
if (!variableLiveAcrossGC(suppressed, variable.Variable)) {
// The earliest use of the variable should be its constructor.
var lineText;
for (var body of functionBodies) {
if (body.minimumUse) {
var text = findLocation(body, body.minimumUse);
if (!lineText || locationLine(lineText) > locationLine(text))
lineText = text;
}
}
print("\nFunction '" + functionName + "'" +
" has unnecessary root '" + name + "' at " + lineText);
}
} else if (isUnrootedType(variable.Type)) {
var result = variableLiveAcrossGC(suppressed, variable.Variable);
if (result) {
var lineText = findLocation(result.gcInfo.body, result.gcInfo.ppoint);
if (annotations.has('Expect Hazards')) {
print("\nThis is expected, but '" + functionName + "'" +
" has unrooted '" + name + "'" +
" of type '" + typeDesc(variable.Type) + "'" +
" live across GC call " + result.gcInfo.name +
" at " + lineText);
missingExpectedHazard = false;
} else {
print("\nFunction '" + functionName + "'" +
" has unrooted '" + name + "'" +
" of type '" + typeDesc(variable.Type) + "'" +
" live across GC call " + result.gcInfo.name +
" at " + lineText);
}
printEntryTrace(functionName, result);
}
result = unsafeVariableAddressTaken(suppressed, variable.Variable);
if (result) {
var lineText = findLocation(result.body, result.ppoint);
print("\nFunction '" + functionName + "'" +
" takes unsafe address of unrooted '" + name + "'" +
" at " + lineText);
printEntryTrace(functionName, {body:result.body, ppoint:result.ppoint});
}
}
}
if (missingExpectedHazard) {
const {
Location: [
{ CacheString: startfile, Line: startline },
{ CacheString: endfile, Line: endline }
]
} = functionBodies[0];
const loc = (startfile == endfile) ? `${startfile}:${startline}-${endline}`
: `${startfile}:${startline}`;
print("\nFunction '" + functionName + "' expected hazard(s) but none were found at " + loc);
}
}
if (batch == 1)
print("Time: " + new Date);
var xdb = xdbLibrary();
xdb.open("src_body.xdb");
var minStream = xdb.min_data_stream()|0;
var maxStream = xdb.max_data_stream()|0;
var N = (maxStream - minStream) + 1;
var start = Math.floor((batch - 1) / numBatches * N) + minStream;
var start_next = Math.floor(batch / numBatches * N) + minStream;
var end = start_next - 1;
function process(name, json) {
functionName = name;
functionBodies = JSON.parse(json);
// Annotate body with a table of all points within the body that may be in
// a limited scope (eg within the scope of a GC suppression RAII class.)
// body.limits is a plain object indexed by point, with the value being a
// bit set stored in an integer of the limit bits.
for (var body of functionBodies)
body.limits = [];
for (var body of functionBodies) {
for (var [pbody, id, limits] of allRAIIGuardedCallPoints(typeInfo, functionBodies, body, isLimitConstructor))
{
if (limits)
pbody.limits[id] = limits;
}
}
processBodies(functionName);
}
if (theFunctionNameToFind) {
var data = xdb.read_entry(theFunctionNameToFind);
var json = data.readString();
process(theFunctionNameToFind, json);
xdb.free_string(data);
quit(0);
}
for (var nameIndex = start; nameIndex <= end; nameIndex++) {
var name = xdb.read_key(nameIndex);
var functionName = name.readString();
var data = xdb.read_entry(name);
xdb.free_string(name);
var json = data.readString();
try {
process(functionName, json);
} catch (e) {
printErr("Exception caught while handling " + functionName);
throw(e);
}
xdb.free_string(data);
}
|