1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
|
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
Svc.Prefs.set("registerEngines", "");
const { Service } = ChromeUtils.import("resource://services-sync/service.js");
let scheduler;
let clientsEngine;
async function sync_httpd_setup() {
let clientsSyncID = await clientsEngine.resetLocalSyncID();
let global = new ServerWBO("global", {
syncID: Service.syncID,
storageVersion: STORAGE_VERSION,
engines: {
clients: { version: clientsEngine.version, syncID: clientsSyncID },
},
});
let clientsColl = new ServerCollection({}, true);
// Tracking info/collections.
let collectionsHelper = track_collections_helper();
let upd = collectionsHelper.with_updated_collection;
return httpd_setup({
"/1.1/johndoe/storage/meta/global": upd("meta", global.handler()),
"/1.1/johndoe/info/collections": collectionsHelper.handler,
"/1.1/johndoe/storage/crypto/keys": upd(
"crypto",
new ServerWBO("keys").handler()
),
"/1.1/johndoe/storage/clients": upd("clients", clientsColl.handler()),
});
}
async function setUp(server) {
syncTestLogging();
await configureIdentity({ username: "johndoe" }, server);
await generateNewKeys(Service.collectionKeys);
let serverKeys = Service.collectionKeys.asWBO("crypto", "keys");
await serverKeys.encrypt(Service.identity.syncKeyBundle);
await serverKeys.upload(Service.resource(Service.cryptoKeysURL));
}
add_task(async function setup() {
scheduler = Service.scheduler;
clientsEngine = Service.clientsEngine;
// Don't remove stale clients when syncing. This is a test-only workaround
// that lets us add clients directly to the store, without losing them on
// the next sync.
clientsEngine._removeRemoteClient = async id => {};
});
add_task(async function test_successful_sync_adjustSyncInterval() {
enableValidationPrefs();
_("Test successful sync calling adjustSyncInterval");
let syncSuccesses = 0;
function onSyncFinish() {
_("Sync success.");
syncSuccesses++;
}
Svc.Obs.add("weave:service:sync:finish", onSyncFinish);
let server = await sync_httpd_setup();
await setUp(server);
// Confirm defaults
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
Assert.ok(!scheduler.hasIncomingItems);
_("Test as long as numClients <= 1 our sync interval is SINGLE_USER.");
// idle == true && numClients <= 1 && hasIncomingItems == false
scheduler.idle = true;
await Service.sync();
Assert.equal(syncSuccesses, 1);
Assert.ok(scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == false && numClients <= 1 && hasIncomingItems == false
scheduler.idle = false;
await Service.sync();
Assert.equal(syncSuccesses, 2);
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == false && numClients <= 1 && hasIncomingItems == true
scheduler.hasIncomingItems = true;
await Service.sync();
Assert.equal(syncSuccesses, 3);
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == true && numClients <= 1 && hasIncomingItems == true
scheduler.idle = true;
await Service.sync();
Assert.equal(syncSuccesses, 4);
Assert.ok(scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
_(
"Test as long as idle && numClients > 1 our sync interval is idleInterval."
);
// idle == true && numClients > 1 && hasIncomingItems == true
await Service.clientsEngine._store.create({
id: "foo",
cleartext: { name: "bar", type: "mobile" },
});
await Service.sync();
Assert.equal(syncSuccesses, 5);
Assert.ok(scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.idleInterval);
// idle == true && numClients > 1 && hasIncomingItems == false
scheduler.hasIncomingItems = false;
await Service.sync();
Assert.equal(syncSuccesses, 6);
Assert.ok(scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.idleInterval);
_("Test non-idle, numClients > 1, no incoming items => activeInterval.");
// idle == false && numClients > 1 && hasIncomingItems == false
scheduler.idle = false;
await Service.sync();
Assert.equal(syncSuccesses, 7);
Assert.ok(!scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
_("Test non-idle, numClients > 1, incoming items => immediateInterval.");
// idle == false && numClients > 1 && hasIncomingItems == true
scheduler.hasIncomingItems = true;
await Service.sync();
Assert.equal(syncSuccesses, 8);
Assert.ok(!scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems); // gets reset to false
Assert.equal(scheduler.syncInterval, scheduler.immediateInterval);
Svc.Obs.remove("weave:service:sync:finish", onSyncFinish);
await Service.startOver();
await promiseStopServer(server);
});
add_task(async function test_unsuccessful_sync_adjustSyncInterval() {
enableValidationPrefs();
_("Test unsuccessful sync calling adjustSyncInterval");
let syncFailures = 0;
function onSyncError() {
_("Sync error.");
syncFailures++;
}
Svc.Obs.add("weave:service:sync:error", onSyncError);
_("Test unsuccessful sync calls adjustSyncInterval");
// Force sync to fail.
Svc.Prefs.set("firstSync", "notReady");
let server = await sync_httpd_setup();
await setUp(server);
// Confirm defaults
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
Assert.ok(!scheduler.hasIncomingItems);
_("Test as long as numClients <= 1 our sync interval is SINGLE_USER.");
// idle == true && numClients <= 1 && hasIncomingItems == false
scheduler.idle = true;
await Service.sync();
Assert.equal(syncFailures, 1);
Assert.ok(scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == false && numClients <= 1 && hasIncomingItems == false
scheduler.idle = false;
await Service.sync();
Assert.equal(syncFailures, 2);
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == false && numClients <= 1 && hasIncomingItems == true
scheduler.hasIncomingItems = true;
await Service.sync();
Assert.equal(syncFailures, 3);
Assert.ok(!scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
// idle == true && numClients <= 1 && hasIncomingItems == true
scheduler.idle = true;
await Service.sync();
Assert.equal(syncFailures, 4);
Assert.ok(scheduler.idle);
Assert.equal(false, scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
_(
"Test as long as idle && numClients > 1 our sync interval is idleInterval."
);
// idle == true && numClients > 1 && hasIncomingItems == true
Svc.Prefs.set("clients.devices.mobile", 2);
scheduler.updateClientMode();
await Service.sync();
Assert.equal(syncFailures, 5);
Assert.ok(scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.idleInterval);
// idle == true && numClients > 1 && hasIncomingItems == false
scheduler.hasIncomingItems = false;
await Service.sync();
Assert.equal(syncFailures, 6);
Assert.ok(scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.idleInterval);
_("Test non-idle, numClients > 1, no incoming items => activeInterval.");
// idle == false && numClients > 1 && hasIncomingItems == false
scheduler.idle = false;
await Service.sync();
Assert.equal(syncFailures, 7);
Assert.ok(!scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems);
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
_("Test non-idle, numClients > 1, incoming items => immediateInterval.");
// idle == false && numClients > 1 && hasIncomingItems == true
scheduler.hasIncomingItems = true;
await Service.sync();
Assert.equal(syncFailures, 8);
Assert.ok(!scheduler.idle);
Assert.ok(scheduler.numClients > 1);
Assert.ok(!scheduler.hasIncomingItems); // gets reset to false
Assert.equal(scheduler.syncInterval, scheduler.immediateInterval);
await Service.startOver();
Svc.Obs.remove("weave:service:sync:error", onSyncError);
await promiseStopServer(server);
});
add_task(async function test_back_triggers_sync() {
enableValidationPrefs();
let server = await sync_httpd_setup();
await setUp(server);
// Single device: no sync triggered.
scheduler.idle = true;
scheduler.observe(null, "active", Svc.Prefs.get("scheduler.idleTime"));
Assert.ok(!scheduler.idle);
// Multiple devices: sync is triggered.
Svc.Prefs.set("clients.devices.mobile", 2);
scheduler.updateClientMode();
let promiseDone = promiseOneObserver("weave:service:sync:finish");
scheduler.idle = true;
scheduler.observe(null, "active", Svc.Prefs.get("scheduler.idleTime"));
Assert.ok(!scheduler.idle);
await promiseDone;
Service.recordManager.clearCache();
Svc.Prefs.resetBranch("");
scheduler.setDefaults();
await clientsEngine.resetClient();
await Service.startOver();
await promiseStopServer(server);
});
add_task(async function test_adjust_interval_on_sync_error() {
enableValidationPrefs();
let server = await sync_httpd_setup();
await setUp(server);
let syncFailures = 0;
function onSyncError() {
_("Sync error.");
syncFailures++;
}
Svc.Obs.add("weave:service:sync:error", onSyncError);
_("Test unsuccessful sync updates client mode & sync intervals");
// Force a sync fail.
Svc.Prefs.set("firstSync", "notReady");
Assert.equal(syncFailures, 0);
Assert.equal(false, scheduler.numClients > 1);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
Svc.Prefs.set("clients.devices.mobile", 2);
await Service.sync();
Assert.equal(syncFailures, 1);
Assert.ok(scheduler.numClients > 1);
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
Svc.Obs.remove("weave:service:sync:error", onSyncError);
await Service.startOver();
await promiseStopServer(server);
});
add_task(async function test_bug671378_scenario() {
enableValidationPrefs();
// Test scenario similar to bug 671378. This bug appeared when a score
// update occurred that wasn't large enough to trigger a sync so
// scheduleNextSync() was called without a time interval parameter,
// setting nextSync to a non-zero value and preventing the timer from
// being adjusted in the next call to scheduleNextSync().
let server = await sync_httpd_setup();
await setUp(server);
let syncSuccesses = 0;
function onSyncFinish() {
_("Sync success.");
syncSuccesses++;
}
Svc.Obs.add("weave:service:sync:finish", onSyncFinish);
// After first sync call, syncInterval & syncTimer are singleDeviceInterval.
await Service.sync();
Assert.equal(syncSuccesses, 1);
Assert.equal(false, scheduler.numClients > 1);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
Assert.equal(scheduler.syncTimer.delay, scheduler.singleDeviceInterval);
let promiseDone = new Promise(resolve => {
// Wrap scheduleNextSync so we are notified when it is finished.
scheduler._scheduleNextSync = scheduler.scheduleNextSync;
scheduler.scheduleNextSync = function() {
scheduler._scheduleNextSync();
// Check on sync:finish scheduleNextSync sets the appropriate
// syncInterval and syncTimer values.
if (syncSuccesses == 2) {
Assert.notEqual(scheduler.nextSync, 0);
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
Assert.ok(scheduler.syncTimer.delay <= scheduler.activeInterval);
scheduler.scheduleNextSync = scheduler._scheduleNextSync;
Svc.Obs.remove("weave:service:sync:finish", onSyncFinish);
Service.startOver().then(() => {
server.stop(resolve);
});
}
};
});
// Set nextSync != 0
// syncInterval still hasn't been set by call to updateClientMode.
// Explicitly trying to invoke scheduleNextSync during a sync
// (to immitate a score update that isn't big enough to trigger a sync).
Svc.Obs.add("weave:service:sync:start", function onSyncStart() {
// Wait for other sync:start observers to be called so that
// nextSync is set to 0.
CommonUtils.nextTick(function() {
Svc.Obs.remove("weave:service:sync:start", onSyncStart);
scheduler.scheduleNextSync();
Assert.notEqual(scheduler.nextSync, 0);
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
Assert.equal(scheduler.syncTimer.delay, scheduler.singleDeviceInterval);
});
});
await Service.clientsEngine._store.create({
id: "foo",
cleartext: { name: "bar", type: "mobile" },
});
await Service.sync();
await promiseDone;
});
add_task(async function test_adjust_timer_larger_syncInterval() {
_(
"Test syncInterval > current timout period && nextSync != 0, syncInterval is NOT used."
);
Svc.Prefs.set("clients.devices.mobile", 2);
scheduler.updateClientMode();
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
scheduler.scheduleNextSync();
// Ensure we have a small interval.
Assert.notEqual(scheduler.nextSync, 0);
Assert.equal(scheduler.syncTimer.delay, scheduler.activeInterval);
// Make interval large again
await clientsEngine._wipeClient();
Svc.Prefs.reset("clients.devices.mobile");
scheduler.updateClientMode();
Assert.equal(scheduler.syncInterval, scheduler.singleDeviceInterval);
scheduler.scheduleNextSync();
// Ensure timer delay remains as the small interval.
Assert.notEqual(scheduler.nextSync, 0);
Assert.ok(scheduler.syncTimer.delay <= scheduler.activeInterval);
// SyncSchedule.
await Service.startOver();
});
add_task(async function test_adjust_timer_smaller_syncInterval() {
_(
"Test current timout > syncInterval period && nextSync != 0, syncInterval is used."
);
scheduler.scheduleNextSync();
// Ensure we have a large interval.
Assert.notEqual(scheduler.nextSync, 0);
Assert.equal(scheduler.syncTimer.delay, scheduler.singleDeviceInterval);
// Make interval smaller
Svc.Prefs.set("clients.devices.mobile", 2);
scheduler.updateClientMode();
Assert.equal(scheduler.syncInterval, scheduler.activeInterval);
scheduler.scheduleNextSync();
// Ensure smaller timer delay is used.
Assert.notEqual(scheduler.nextSync, 0);
Assert.ok(scheduler.syncTimer.delay <= scheduler.activeInterval);
// SyncSchedule.
await Service.startOver();
});
|