1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
|
/* vim:set ts=2 sw=2 sts=2 et: */
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/
*/
#include "gtest/gtest.h"
#include "js/RegExp.h"
#include "mozilla/SpinEventLoopUntil.h"
#include "mozilla/UntrustedModulesProcessor.h"
#include "mozilla/WinDllServices.h"
#include "nsContentUtils.h"
#include "nsDirectoryServiceDefs.h"
#include "TelemetryFixture.h"
#include "UntrustedModulesBackupService.h"
#include "UntrustedModulesDataSerializer.h"
class ModuleLoadCounter final {
nsDataHashtable<nsStringCaseInsensitiveHashKey, int> mCounters;
public:
template <int N>
ModuleLoadCounter(const nsString (&aNames)[N], const int (&aCounts)[N])
: mCounters(N) {
for (int i = 0; i < N; ++i) {
mCounters.Put(aNames[i], aCounts[i]);
}
}
template <int N>
bool Remains(const nsString (&aNames)[N], const int (&aCounts)[N]) {
EXPECT_EQ(mCounters.Count(), N);
if (mCounters.Count() != N) {
return false;
}
bool result = true;
for (int i = 0; i < N; ++i) {
int* entry = mCounters.GetValue(aNames[i]);
if (!entry) {
wprintf(L"%s is not registered.\n", aNames[i].get());
result = false;
} else if (*entry != aCounts[i]) {
// We can return false, but let's print out all unmet modules
// which may be helpful to investigate test failures.
wprintf(L"%s:%4d\n", aNames[i].get(), *entry);
result = false;
}
}
return result;
}
bool IsDone() const {
bool allZero = true;
for (auto iter = mCounters.ConstIter(); !iter.Done(); iter.Next()) {
if (iter.Data() < 0) {
// If any counter is negative, we know the test fails.
// No need to continue.
return true;
}
if (iter.Data() > 0) {
allZero = false;
}
}
// If all counters are zero, the test finished nicely. Otherwise, those
// counters are expected to be decremented later. Let's continue.
return allZero;
}
void Decrement(const nsString& aName) {
if (int* entry = mCounters.GetValue(aName)) {
--(*entry);
}
}
};
class UntrustedModulesCollector {
static constexpr int kMaximumPendingQueries = 200;
Vector<UntrustedModulesData> mData;
public:
Vector<UntrustedModulesData>& Data() { return mData; }
nsresult Collect(ModuleLoadCounter& aChecker) {
nsresult rv = NS_OK;
mData.clear();
int pendingQueries = 0;
EXPECT_TRUE(SpinEventLoopUntil([this, &pendingQueries, &aChecker, &rv]() {
// Some of expected loaded modules are still missing
// after kMaximumPendingQueries queries were submitted.
// Giving up here to avoid an infinite loop.
if (pendingQueries >= kMaximumPendingQueries) {
rv = NS_ERROR_ABORT;
return true;
}
++pendingQueries;
RefPtr<DllServices> dllSvc(DllServices::Get());
dllSvc->GetUntrustedModulesData()->Then(
GetMainThreadSerialEventTarget(), __func__,
[this, &pendingQueries,
&aChecker](Maybe<UntrustedModulesData>&& aResult) {
EXPECT_GT(pendingQueries, 0);
--pendingQueries;
if (aResult.isSome()) {
wprintf(L"Received data. (pendingQueries=%d)\n", pendingQueries);
for (const auto& evt : aResult.ref().mEvents) {
aChecker.Decrement(evt.mRequestedDllName);
}
EXPECT_TRUE(mData.emplaceBack(std::move(aResult.ref())));
}
},
[&pendingQueries, &rv](nsresult aReason) {
EXPECT_GT(pendingQueries, 0);
--pendingQueries;
wprintf(L"GetUntrustedModulesData() failed - %08x\n", aReason);
EXPECT_TRUE(false);
rv = aReason;
});
// Keep calling GetUntrustedModulesData() until we meet the condition.
return aChecker.IsDone();
}));
EXPECT_TRUE(SpinEventLoopUntil(
[&pendingQueries]() { return pendingQueries <= 0; }));
return rv;
}
};
static void ValidateUntrustedModules(const UntrustedModulesData& aData) {
EXPECT_EQ(aData.mProcessType, GeckoProcessType_Default);
EXPECT_EQ(aData.mPid, ::GetCurrentProcessId());
nsTHashtable<nsPtrHashKey<void>> moduleSet;
for (auto iter = aData.mModules.ConstIter(); !iter.Done(); iter.Next()) {
const RefPtr<ModuleRecord>& module = iter.Data();
moduleSet.PutEntry(module);
}
for (const auto& evt : aData.mEvents) {
EXPECT_EQ(evt.mThreadId, ::GetCurrentThreadId());
// Make sure mModule is pointing to an entry of mModules.
EXPECT_TRUE(moduleSet.Contains(evt.mModule));
EXPECT_FALSE(evt.mIsDependent);
EXPECT_EQ(evt.mLoadStatus, 0);
}
// No check for the mXULLoadDurationMS field because the field has a value
// in CCov build GTest, but it is empty in non-CCov build (bug 1681936).
EXPECT_GT(aData.mEvents.length(), 0);
EXPECT_GT(aData.mStacks.GetModuleCount(), 0);
EXPECT_EQ(aData.mSanitizationFailures, 0);
EXPECT_EQ(aData.mTrustTestFailures, 0);
}
class UntrustedModulesFixture : public TelemetryTestFixture {
static constexpr int kLoadCountBeforeDllServices = 5;
static constexpr int kLoadCountAfterDllServices = 5;
static constexpr uint32_t kMaxModulesArrayLen = 10;
// One of the important test scenarios is to load modules before DllServices
// is initialized and to make sure those loading events are forwarded when
// DllServices is initialized.
// However, GTest instantiates a Fixture class every testcase and there is
// no way to re-enable DllServices and UntrustedModulesProcessor once it's
// disabled, which means no matter how many testcases we have, only the
// first testcase exercises that scenario. That's why we implement that
// test scenario in InitialModuleLoadOnce as a static member and runs it
// in the first testcase to be executed.
static INIT_ONCE sInitLoadOnce;
static UntrustedModulesCollector sInitLoadDataCollector;
static nsString PrependWorkingDir(const nsAString& aLeaf) {
nsCOMPtr<nsIFile> file;
EXPECT_TRUE(NS_SUCCEEDED(NS_GetSpecialDirectory(NS_OS_CURRENT_WORKING_DIR,
getter_AddRefs(file))));
EXPECT_TRUE(NS_SUCCEEDED(file->Append(aLeaf)));
bool exists;
EXPECT_TRUE(NS_SUCCEEDED(file->Exists(&exists)) && exists);
nsString fullPath;
EXPECT_TRUE(NS_SUCCEEDED(file->GetPath(fullPath)));
return fullPath;
}
static BOOL CALLBACK InitialModuleLoadOnce(PINIT_ONCE, void*, void**);
protected:
static constexpr int kInitLoadCount =
kLoadCountBeforeDllServices + kLoadCountAfterDllServices;
static const nsString kTestModules[];
static void LoadAndFree(const nsAString& aLeaf) {
nsModuleHandle dll(::LoadLibraryW(PrependWorkingDir(aLeaf).get()));
EXPECT_TRUE(!!dll);
}
virtual void SetUp() override {
TelemetryTestFixture::SetUp();
::InitOnceExecuteOnce(&sInitLoadOnce, InitialModuleLoadOnce, nullptr,
nullptr);
}
static const Vector<UntrustedModulesData>& GetInitLoadData() {
return sInitLoadDataCollector.Data();
}
// This method is useful if we want a new instance of UntrustedModulesData
// which is not copyable.
static UntrustedModulesData CollectSingleData() {
// If we call LoadAndFree more than once, those loading events are
// likely to be merged into an instance of UntrustedModulesData,
// meaning the length of the collector's vector is at least one but
// the exact number is unknown.
LoadAndFree(kTestModules[0]);
UntrustedModulesCollector collector;
ModuleLoadCounter waitForOne({kTestModules[0]}, {1});
EXPECT_TRUE(NS_SUCCEEDED(collector.Collect(waitForOne)));
EXPECT_TRUE(waitForOne.Remains({kTestModules[0]}, {0}));
EXPECT_EQ(collector.Data().length(), 1);
// Cannot "return collector.Data()[0]" as copy ctor is deleted.
return UntrustedModulesData(std::move(collector.Data()[0]));
}
template <typename DataFetcherT>
void ValidateJSValue(const char16_t* aPattern, size_t aPatternLength,
DataFetcherT&& aDataFetcher) {
AutoJSContextWithGlobal cx(mCleanGlobal);
mozilla::Telemetry::UntrustedModulesDataSerializer serializer(
cx.GetJSContext(), kMaxModulesArrayLen);
EXPECT_TRUE(!!serializer);
aDataFetcher(serializer);
JS::RootedValue jsval(cx.GetJSContext());
serializer.GetObject(&jsval);
nsAutoString json;
EXPECT_TRUE(nsContentUtils::StringifyJSON(cx.GetJSContext(), &jsval, json));
JS::RootedObject re(
cx.GetJSContext(),
JS::NewUCRegExpObject(cx.GetJSContext(), aPattern, aPatternLength,
JS::RegExpFlag::Global));
EXPECT_TRUE(!!re);
JS::RootedValue matchResult(cx.GetJSContext(), JS::NullValue());
size_t idx = 0;
EXPECT_TRUE(JS::ExecuteRegExpNoStatics(cx.GetJSContext(), re, json.get(),
json.Length(), &idx, true,
&matchResult));
// On match, with aOnlyMatch = true, ExecuteRegExpNoStatics returns boolean
// true. If no match, ExecuteRegExpNoStatics returns Null.
EXPECT_TRUE(matchResult.isBoolean() && matchResult.toBoolean());
if (!matchResult.toBoolean()) {
// If match failed, print out the actual JSON kindly.
wprintf(L"JSON: %s\n", json.get());
wprintf(L"RE: %s\n", aPattern);
}
}
};
const nsString UntrustedModulesFixture::kTestModules[] = {
u"TestUntrustedModules_Dll1.dll"_ns, u"TestUntrustedModules_Dll2.dll"_ns};
INIT_ONCE UntrustedModulesFixture::sInitLoadOnce = INIT_ONCE_STATIC_INIT;
UntrustedModulesCollector UntrustedModulesFixture::sInitLoadDataCollector;
BOOL CALLBACK UntrustedModulesFixture::InitialModuleLoadOnce(PINIT_ONCE, void*,
void**) {
for (int i = 0; i < kLoadCountBeforeDllServices; ++i) {
for (const auto& mod : kTestModules) {
LoadAndFree(mod);
}
}
RefPtr<DllServices> dllSvc(DllServices::Get());
dllSvc->StartUntrustedModulesProcessor();
for (int i = 0; i < kLoadCountAfterDllServices; ++i) {
for (const auto& mod : kTestModules) {
LoadAndFree(mod);
}
}
ModuleLoadCounter waitForTwo(kTestModules, {kInitLoadCount, kInitLoadCount});
EXPECT_EQ(sInitLoadDataCollector.Collect(waitForTwo), NS_OK);
EXPECT_TRUE(waitForTwo.Remains(kTestModules, {0, 0}));
for (const auto& event : GetInitLoadData()) {
ValidateUntrustedModules(event);
}
// Data was removed when retrieved. No data is retrieved again.
UntrustedModulesCollector collector;
ModuleLoadCounter waitOnceForEach(kTestModules, {1, 1});
EXPECT_EQ(collector.Collect(waitOnceForEach), NS_ERROR_ABORT);
EXPECT_TRUE(waitOnceForEach.Remains(kTestModules, {1, 1}));
return TRUE;
}
#define PROCESS_OBJ(TYPE, PID) \
u"\"" TYPE u"\\." PID u"\":{" \
u"\"processType\":\"" TYPE u"\",\"elapsed\":\\d+\\.\\d+," \
u"\"sanitizationFailures\":0,\"trustTestFailures\":0," \
u"\"events\":\\[{" \
u"\"processUptimeMS\":\\d+,\"loadDurationMS\":\\d+\\.\\d+," \
u"\"threadID\":\\d+,\"threadName\":\"Main Thread\"," \
u"\"baseAddress\":\"0x[0-9a-f]+\",\"moduleIndex\":0," \
u"\"isDependent\":false,\"loadStatus\":0}\\]," \
u"\"combinedStacks\":{" \
u"\"memoryMap\":\\[\\[\"\\w+\\.\\w+\",\"[0-9A-Z]+\"\\]" \
u"(,\\[\"\\w+\\.\\w+\",\"[0-9A-Z]+\\\"\\])*\\]," \
u"\"stacks\":\\[\\[\\[\\d+,\\d+\\]" \
u"(,\\[\\d+,\\d+\\])*\\]\\]}}"
TEST_F(UntrustedModulesFixture, Serialize) {
// clang-format off
const char16_t kPattern[] = u"{\"structVersion\":1,"
u"\"modules\":\\[{"
u"\"resolvedDllName\":\"TestUntrustedModules_Dll1\\.dll\","
u"\"fileVersion\":\"1\\.2\\.3\\.4\","
u"\"companyName\":\"Mozilla Corporation\",\"trustFlags\":0}\\],"
u"\"processes\":{"
PROCESS_OBJ(u"browser", u"0xabc") u","
PROCESS_OBJ(u"browser", u"0x4") u","
PROCESS_OBJ(u"rdd", u"0x4")
u"}}";
// clang-format on
UntrustedModulesBackupData backup1, backup2;
{
UntrustedModulesData data1 = CollectSingleData();
UntrustedModulesData data2 = CollectSingleData();
UntrustedModulesData data3 = CollectSingleData();
data1.mPid = 0xabc;
data2.mPid = 0x4;
data2.mProcessType = GeckoProcessType_RDD;
data3.mPid = 0x4;
backup1.Add(std::move(data1));
backup2.Add(std::move(data2));
backup1.Add(std::move(data3));
}
ValidateJSValue(kPattern, ArrayLength(kPattern) - 1,
[&backup1, &backup2](
Telemetry::UntrustedModulesDataSerializer& aSerializer) {
EXPECT_TRUE(NS_SUCCEEDED(aSerializer.Add(backup1)));
EXPECT_TRUE(NS_SUCCEEDED(aSerializer.Add(backup2)));
});
}
TEST_F(UntrustedModulesFixture, Backup) {
using BackupType = UntrustedModulesBackupService::BackupType;
RefPtr<UntrustedModulesBackupService> backupSvc(
UntrustedModulesBackupService::Get());
for (int i = 0; i < 5; ++i) {
backupSvc->Backup(BackupType::Staging, CollectSingleData());
}
backupSvc->SettleAllStagingData();
EXPECT_TRUE(backupSvc->Ref(BackupType::Staging).IsEmpty());
for (auto iter = backupSvc->Ref(BackupType::Settled).ConstIter();
!iter.Done(); iter.Next()) {
const RefPtr<UntrustedModulesDataContainer>& container = iter.Data();
EXPECT_TRUE(!!container);
const UntrustedModulesData& data = container->mData;
EXPECT_EQ(iter.Key(), ProcessHashKey(data.mProcessType, data.mPid));
ValidateUntrustedModules(data);
}
}
|