1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
/**
* @fileoverview Check that there's a Services.(prefs|obs).removeObserver for
* each addObserver.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
// -----------------------------------------------------------------------------
// Rule Definition
// -----------------------------------------------------------------------------
module.exports = function(context) {
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
var addedObservers = [];
var removedObservers = [];
function getObserverAPI(node) {
const object = node.callee.object;
if (
object.type == "MemberExpression" &&
object.property.type == "Identifier"
) {
return object.property.name;
}
return null;
}
function isServicesObserver(api) {
return api == "obs" || api == "prefs";
}
function getObservableName(node, api) {
if (api === "obs") {
return node.arguments[1].value;
}
return node.arguments[0].value;
}
function addAddedObserver(node) {
const api = getObserverAPI(node);
if (!isServicesObserver(api)) {
return;
}
addedObservers.push({
functionName: node.callee.property.name,
observable: getObservableName(node, api),
node: node.callee.property,
});
}
function addRemovedObserver(node) {
const api = getObserverAPI(node);
if (!isServicesObserver(api)) {
return;
}
removedObservers.push({
functionName: node.callee.property.name,
observable: getObservableName(node, api),
});
}
function getUnbalancedObservers() {
const unbalanced = addedObservers.filter(
observer => !hasRemovedObserver(observer)
);
addedObservers = removedObservers = [];
return unbalanced;
}
function hasRemovedObserver(addedObserver) {
return removedObservers.some(
observer => addedObserver.observable === observer.observable
);
}
// ---------------------------------------------------------------------------
// Public
// ---------------------------------------------------------------------------
return {
CallExpression(node) {
if (node.arguments.length === 0) {
return;
}
if (node.callee.type === "MemberExpression") {
var methodName = node.callee.property.name;
if (methodName === "addObserver") {
addAddedObserver(node);
} else if (methodName === "removeObserver") {
addRemovedObserver(node);
}
}
},
"Program:exit": function() {
getUnbalancedObservers().forEach(function(observer) {
context.report(
observer.node,
"No corresponding 'removeObserver(\"{{observable}}\")' was found.",
{
observable: observer.observable,
}
);
});
},
};
};
|
