1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
|
#!/usr/bin/env python
# Originally modified from A. Israel's script seen at
# https://gist.github.com/aisrael/b2b78d9dfdd176a232b9
"""To run this script first install the dependencies
python3 -m venv v
source v/bin/activate
pip install githubpy GitPython requests
Generate a github access token; this is needed as the anonymous access
to Github's API will easily hit the limit even with a single invocation.
For details see:
https://help.github.com/articles/creating-an-access-token-for-command-line-use/
Next either set the github token as an env variable
`GITHUB_ACCESS_TOKEN` or alternatively invoke the script with
`--token` switch.
Example:
ceph-release-notes -r tags/v0.87..origin/giant \
$(git rev-parse --show-toplevel)
"""
from __future__ import print_function
import argparse
import github
import os
import re
import sys
import requests
import time
from git import Repo
fixes_re = re.compile(r"Fixes\:? #(\d+)")
reviewed_by_re = re.compile(r"Rev(.*)By", re.IGNORECASE)
# labels is the list of relevant labels defined for github.com/ceph/ceph
labels = {'bluestore', 'build/ops', 'cephfs', 'common', 'core', 'mgr',
'mon', 'performance', 'pybind', 'rdma', 'rgw', 'rbd', 'tests',
'tools'}
merge_re = re.compile("Merge (pull request|PR) #(\d+).*")
# prefixes is the list of commit description prefixes we recognize
prefixes = ['bluestore', 'build/ops', 'cephfs', 'cephx', 'cli', 'cmake',
'common', 'core', 'crush', 'doc', 'fs', 'librados', 'librbd',
'log', 'mds', 'mgr', 'mon', 'msg', 'objecter', 'osd', 'pybind',
'rbd', 'rbd-mirror', 'rbd-nbd', 'rgw', 'tests', 'tools']
signed_off_re = re.compile("Signed-off-by: (.+) <")
tracker_re = re.compile("http://tracker.ceph.com/issues/(\d+)")
rst_link_re = re.compile(r"([a-zA-Z0-9])_(\W)")
release_re = re.compile(r"^(nautilus|octopus|pacific|quincy):\s*")
tracker_uri = "http://tracker.ceph.com/issues/{0}.json"
def get_original_issue(issue, verbose):
r = requests.get(tracker_uri.format(issue),
params={"include": "relations"}).json()
# looking up for the original issue only makes sense
# when dealing with an issue in the Backport tracker
if r["issue"]["tracker"]["name"] != "Backport":
if verbose:
print ("http://tracker.ceph.com/issues/" + issue +
" is from the tracker " + r["issue"]["tracker"]["name"] +
", do not look for the original issue")
return issue
# if a Backport issue does not have a relation, keep it
if "relations" not in r["issue"]:
if verbose:
print ("http://tracker.ceph.com/issues/" + issue +
" has no relations, do not look for the original issue")
return issue
copied_to = [
str(i['issue_id']) for i in r["issue"]["relations"]
if i["relation_type"] == "copied_to"
]
if copied_to:
if len(copied_to) > 1:
if verbose:
print ("ERROR: http://tracker.ceph.com/issues/" + issue +
" has more than one Copied To relation")
return issue
if verbose:
print ("http://tracker.ceph.com/issues/" + issue +
" is the backport of http://tracker.ceph.com/issues/" +
copied_to[0])
return copied_to[0]
else:
if verbose:
print ("http://tracker.ceph.com/issues/" + issue +
" has no copied_to relations; do not look for the" +
" original issue")
return issue
def split_component(title, gh, number):
title_re = '(' + '|'.join(prefixes) + ')(:.*)'
match = re.match(title_re, title)
if match:
return match.group(1)+match.group(2)
else:
issue = gh.repos("ceph")("ceph").issues(number).get()
issue_labels = {it['name'] for it in issue['labels']}
if 'documentation' in issue_labels:
return 'doc: ' + title
item = set(prefixes).intersection(issue_labels)
if item:
return ",".join(sorted(item)) + ': ' + title
else:
return 'UNKNOWN: ' + title
def _title_message(commit, pr, strict):
title = pr['title']
message_lines = commit.message.split('\n')
if strict or len(message_lines) < 1:
return (title, None)
lines = []
for line in message_lines[1:]:
if reviewed_by_re.match(line):
continue
line = line.strip()
if line:
lines.append(line)
if len(lines) == 0:
return (title, None)
duplicates_pr_title = lines[0] == pr['title'].strip()
if duplicates_pr_title:
return (title, None)
assert len(lines) > 0, "missing message content"
if len(lines) == 1:
# assume that a single line means the intention is to
# re-write the PR title
return (lines[0], None)
elif len(lines) < 3 and 'refs/pull' in lines[0]:
# assume the intent was rewriting the title and something like
# ptl-tool was used to generate the merge message
return (lines[1], None)
message = " " + "\n ".join(lines)
return (title, message)
def make_release_notes(gh, repo, ref, plaintext, html, markdown, verbose, strict, use_tags, include_pr_messages):
issue2prs = {}
pr2issues = {}
pr2info = {}
for commit in repo.iter_commits(ref, merges=True):
merge = merge_re.match(commit.summary)
if not merge:
continue
number = merge.group(2)
print ("Considering PR#" + number)
# do not pick up ceph/ceph-qa-suite.git PRs
if int(number) < 1311:
print ("Ignoring low-numbered PR, probably picked up from"
" ceph/ceph-qa-suite.git")
continue
attempts = 0
retries = 30
while attempts < retries:
try:
pr = gh.repos("ceph")("ceph").pulls(number).get()
break
except Exception:
if attempts < retries:
attempts += 1
sleep_time = 2 * attempts
print(f"Failed to fetch PR {number}, sleeping for {sleep_time} seconds")
time.sleep(sleep_time)
else:
print(f"Could not fetch PR {number} in {retries} tries.")
raise
(title, message) = _title_message(commit, pr, strict)
issues = []
if pr['body']:
issues = fixes_re.findall(pr['body']) + tracker_re.findall(
pr['body']
)
authors = {}
for c in repo.iter_commits(
"{sha1}^1..{sha1}^2".format(sha1=commit.hexsha)
):
for author in re.findall(
"Signed-off-by:\s*(.*?)\s*<", c.message
):
authors[author] = 1
issues.extend(fixes_re.findall(c.message) +
tracker_re.findall(c.message))
if authors:
author = ", ".join(authors.keys())
else:
author = commit.parents[-1].author.name
if strict and not issues:
print ("ERROR: https://github.com/ceph/ceph/pull/" +
str(number) + " has no associated issue")
continue
if strict:
title_re = (
'^(?:nautilus|octopus|pacific|quincy):\s+(' +
'|'.join(prefixes) +
')(:.*)'
)
match = re.match(title_re, title)
if not match:
print ("ERROR: https://github.com/ceph/ceph/pull/" +
str(number) + " title " + title +
" does not match " + title_re)
else:
title = match.group(1) + match.group(2)
if use_tags:
title = split_component(title, gh, number)
title = title.strip(' \t\n\r\f\v\.\,\;\:\-\=')
# escape asterisks, which is used by reStructuredTextrst for inline
# emphasis
title = title.replace('*', '\*')
# and escape the underscores for noting a link
title = rst_link_re.sub(r'\1\_\2', title)
# remove release prefix for backports
title = release_re.sub('', title)
pr2info[number] = (author, title, message)
for issue in set(issues):
if strict:
issue = get_original_issue(issue, verbose)
issue2prs.setdefault(issue, set([])).add(number)
pr2issues.setdefault(number, set([])).add(issue)
sys.stdout.write('.')
print (" done collecting merges.")
if strict:
for (issue, prs) in issue2prs.items():
if len(prs) > 1:
print (">>>>>>> " + str(len(prs)) + " pr for issue " +
issue + " " + str(prs))
for (pr, (author, title, message)) in sorted(
pr2info.items(), key=lambda title: title[1][1].lower()
):
if pr in pr2issues:
if plaintext:
issues = map(lambda issue: '#' + str(issue), pr2issues[pr])
elif html:
issues = map(lambda issue: (
'<a href="http://tracker.ceph.com/issues/{issue}">issue#{issue}</a>'
).format(issue=issue), pr2issues[pr]
)
elif markdown:
issues = map(lambda issue: (
'[issue#{issue}](http://tracker.ceph.com/issues/{issue})'
).format(issue=issue), pr2issues[pr]
)
else:
issues = map(lambda issue: (
'`issue#{issue} <http://tracker.ceph.com/issues/{issue}>`_'
).format(issue=issue), pr2issues[pr]
)
issues = ", ".join(issues) + ", "
else:
issues = ''
if plaintext:
print ("* {title} ({issues}{author})".format(
title=title,
issues=issues,
author=author
)
)
elif html:
print (
(
"<li><p>{title} ({issues}<a href=\""
"https://github.com/ceph/ceph/pull/{pr}\""
">pr#{pr}</a>, {author})</p></li>"
).format(
title=title,
issues=issues,
author=author, pr=pr
)
)
elif markdown:
markdown_title = title.replace('_', '\_').replace('.', '<span></span>.')
print ("- {title} ({issues}[pr#{pr}](https://github.com/ceph/ceph/pull/{pr}), {author})\n".format(
title=markdown_title,
issues=issues,
author=author, pr=pr
)
)
else:
print (
(
"* {title} ({issues}`pr#{pr} <"
"https://github.com/ceph/ceph/pull/{pr}"
">`_, {author})"
).format(
title=title,
issues=issues,
author=author, pr=pr
)
)
if include_pr_messages and message:
print (message)
if __name__ == "__main__":
desc = '''
Make ceph release notes for a given revision. Eg usage:
$ ceph-release-notes -r tags/v0.87..origin/giant \
$(git rev-parse --show-toplevel)
It is recommended to set the github env. token in order to avoid
hitting the api rate limits.
'''
parser = argparse.ArgumentParser(
description=desc,
formatter_class=argparse.RawTextHelpFormatter
)
parser.add_argument("--rev", "-r",
help="git revision range for creating release notes")
parser.add_argument("--text", "-t",
action='store_true', default=None,
help="output plain text only, no links")
parser.add_argument("--html",
action='store_true', default=None,
help="output html format for (old wordpress) website blog")
parser.add_argument("--markdown",
action='store_true', default=None,
help="output markdown format for new ceph.io blog")
parser.add_argument("--verbose", "-v",
action='store_true', default=None,
help="verbose")
parser.add_argument("--strict",
action='store_true', default=None,
help="strict, recommended only for backport releases")
parser.add_argument("repo", metavar="repo",
help="path to ceph git repo")
parser.add_argument(
"--token",
default=os.getenv("GITHUB_ACCESS_TOKEN"),
help="Github Access Token ($GITHUB_ACCESS_TOKEN otherwise)",
)
parser.add_argument("--use-tags", default=False,
help="Use github tags to guess the component")
parser.add_argument("--include-pr-messages", default=False, action='store_true',
help="Include full PR message in addition to PR title, if available")
args = parser.parse_args()
gh = github.GitHub(
access_token=args.token)
make_release_notes(
gh,
Repo(args.repo),
args.rev,
args.text,
args.html,
args.markdown,
args.verbose,
args.strict,
args.use_tags,
args.include_pr_messages
)
|