summaryrefslogtreecommitdiffstats
path: root/src/ansiblelint/rules/command_instead_of_module.py
diff options
context:
space:
mode:
Diffstat (limited to 'src/ansiblelint/rules/command_instead_of_module.py')
-rw-r--r--src/ansiblelint/rules/command_instead_of_module.py26
1 files changed, 17 insertions, 9 deletions
diff --git a/src/ansiblelint/rules/command_instead_of_module.py b/src/ansiblelint/rules/command_instead_of_module.py
index 068e430..538141b 100644
--- a/src/ansiblelint/rules/command_instead_of_module.py
+++ b/src/ansiblelint/rules/command_instead_of_module.py
@@ -1,4 +1,5 @@
"""Implementation of command-instead-of-module rule."""
+
# Copyright (c) 2013-2014 Will Thames <will@thames.id.au>
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -25,7 +26,7 @@ from pathlib import Path
from typing import TYPE_CHECKING
from ansiblelint.rules import AnsibleLintRule
-from ansiblelint.utils import convert_to_boolean, get_first_cmd_arg, get_second_cmd_arg
+from ansiblelint.utils import get_first_cmd_arg, get_second_cmd_arg
if TYPE_CHECKING:
from ansiblelint.file_utils import Lintable
@@ -68,9 +69,17 @@ class CommandsInsteadOfModulesRule(AnsibleLintRule):
}
_executable_options = {
- "git": ["branch", "log", "lfs"],
- "systemctl": ["--version", "kill", "set-default", "show-environment", "status"],
- "yum": ["clean"],
+ "git": ["branch", "log", "lfs", "rev-parse"],
+ "systemctl": [
+ "--version",
+ "get-default",
+ "kill",
+ "set-default",
+ "set-property",
+ "show-environment",
+ "status",
+ ],
+ "yum": ["clean", "history", "info"],
"rpm": ["--nodeps"],
}
@@ -97,9 +106,7 @@ class CommandsInsteadOfModulesRule(AnsibleLintRule):
):
return False
- if executable in self._modules and convert_to_boolean(
- task["action"].get("warn", True),
- ):
+ if executable in self._modules:
message = "{0} used in place of {1} module"
return message.format(executable, self._modules[executable])
return False
@@ -108,8 +115,9 @@ class CommandsInsteadOfModulesRule(AnsibleLintRule):
if "pytest" in sys.modules:
import pytest
- from ansiblelint.rules import RulesCollection # pylint: disable=ungrouped-imports
- from ansiblelint.runner import Runner # pylint: disable=ungrouped-imports
+ # pylint: disable=ungrouped-imports
+ from ansiblelint.rules import RulesCollection
+ from ansiblelint.runner import Runner
@pytest.mark.parametrize(
("file", "expected"),