summaryrefslogtreecommitdiffstats
path: root/src/ansiblelint/rules/inline_env_var.py
diff options
context:
space:
mode:
Diffstat (limited to 'src/ansiblelint/rules/inline_env_var.py')
-rw-r--r--src/ansiblelint/rules/inline_env_var.py76
1 files changed, 76 insertions, 0 deletions
diff --git a/src/ansiblelint/rules/inline_env_var.py b/src/ansiblelint/rules/inline_env_var.py
new file mode 100644
index 0000000..f578fb7
--- /dev/null
+++ b/src/ansiblelint/rules/inline_env_var.py
@@ -0,0 +1,76 @@
+"""Implementation of inside-env-var rule."""
+# Copyright (c) 2016 Will Thames <will@thames.id.au>
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
+from ansiblelint.constants import FILENAME_KEY, LINE_NUMBER_KEY
+from ansiblelint.rules import AnsibleLintRule
+from ansiblelint.utils import Task, get_first_cmd_arg
+
+if TYPE_CHECKING:
+ from ansiblelint.file_utils import Lintable
+
+
+class EnvVarsInCommandRule(AnsibleLintRule):
+ """Command module does not accept setting environment variables inline."""
+
+ id = "inline-env-var"
+ description = (
+ "Use ``environment:`` to set environment variables "
+ "or use ``shell`` module which accepts both"
+ )
+ severity = "VERY_HIGH"
+ tags = ["command-shell", "idiom"]
+ version_added = "historic"
+
+ expected_args = [
+ "chdir",
+ "creates",
+ "executable",
+ "removes",
+ "stdin",
+ "warn",
+ "stdin_add_newline",
+ "strip_empty_ends",
+ "cmd",
+ "__ansible_module__",
+ "__ansible_module_original__",
+ "_raw_params",
+ LINE_NUMBER_KEY,
+ FILENAME_KEY,
+ ]
+
+ def matchtask(
+ self,
+ task: Task,
+ file: Lintable | None = None,
+ ) -> bool | str:
+ if task["action"]["__ansible_module__"] in ["command"]:
+ first_cmd_arg = get_first_cmd_arg(task)
+ if not first_cmd_arg:
+ return False
+
+ return any(
+ [arg not in self.expected_args for arg in task["action"]]
+ + ["=" in first_cmd_arg],
+ )
+ return False