1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
|
import json
import os.path
from typing import List, Tuple, Type, cast
import pytest
from debputy.exceptions import DebputyFSIsROError
from debputy.plugin.api import (
DebputyPluginInitializer,
BinaryCtrlAccessor,
PackageProcessingContext,
VirtualPath,
virtual_path_def,
)
from debputy.exceptions import PluginConflictError, PluginAPIViolationError
from debputy.plugin.api.impl import DebputyPluginInitializerProvider
from debputy.plugin.api.impl_types import automatic_discard_rule_example
from debputy.plugin.api.test_api import (
build_virtual_file_system,
package_metadata_context,
initialize_plugin_under_test,
)
from debputy.plugin.api.test_api.test_impl import (
initialize_plugin_under_test_preloaded,
initialize_plugin_under_test_from_inline_json,
)
CUSTOM_PLUGIN_JSON_FILE = os.path.join(
os.path.dirname(__file__), "data", "custom-plugin.json.in"
)
def bad_metadata_detector_fs_rw(
path: VirtualPath,
_ctrl: BinaryCtrlAccessor,
_context: PackageProcessingContext,
) -> None:
del path["foo"]
def conflicting_plugin(api: DebputyPluginInitializer) -> None:
api.packager_provided_file(
"logrotate",
"/some/where/that/is/not/etc/logrotate.d/{name}",
)
def bad_plugin(api: DebputyPluginInitializer) -> None:
api.metadata_or_maintscript_detector("fs_rw", bad_metadata_detector_fs_rw)
def adr_inconsistent_example_plugin(api: DebputyPluginInitializerProvider) -> None:
api.automatic_discard_rule(
"adr-example-test",
lambda p: p.name == "discard-me",
examples=automatic_discard_rule_example(
"foo/discard-me",
("bar/discard-me", False),
"baz/something",
("discard-me/foo", False),
),
)
def test_conflict_with_debputy():
with pytest.raises(PluginConflictError) as e_info:
initialize_plugin_under_test_preloaded(
1,
conflicting_plugin,
plugin_name="conflicting-plugin",
)
message = (
'The stem "logrotate" is registered twice for packager provided files.'
" Once by debputy and once by conflicting-plugin"
)
assert message == e_info.value.args[0]
def test_metadata_read_only():
plugin = initialize_plugin_under_test_preloaded(
1,
bad_plugin,
plugin_name="bad-plugin",
)
fs = build_virtual_file_system(["./foo"])
with pytest.raises(PluginAPIViolationError) as e_info:
plugin.run_metadata_detector("fs_rw", fs)
assert isinstance(e_info.value.__cause__, DebputyFSIsROError)
def test_packager_provided_files():
plugin = initialize_plugin_under_test(plugin_desc_file=CUSTOM_PLUGIN_JSON_FILE)
assert plugin.packager_provided_files_by_stem().keys() == {
"my-file",
"test-file-from-json",
}
my_file = [p for p in plugin.packager_provided_files() if p.stem == "my-file"][0]
assert my_file.stem == "my-file"
assert my_file.compute_dest("g++-3.1")[1] == "g__-3.1.conf"
def test_path_checks():
symlink_path = "./foo"
with pytest.raises(ValueError) as e_info:
virtual_path_def(symlink_path, link_target="/bar", mode=0o0755)
assert (
e_info.value.args[0]
== f'Please do not provide mode for symlinks. Triggered by "{symlink_path}"'
)
with pytest.raises(ValueError) as e_info:
virtual_path_def(symlink_path + "/", link_target="/bar")
msg = (
"Path name looks like a directory, but a symlink target was also provided."
f' Please remove the trailing slash OR the symlink_target. Triggered by "{symlink_path}/"'
)
assert e_info.value.args[0] == msg
def test_metadata_detector_applies_to_check():
plugin_name = "custom-plugin"
metadata_detector_id = "udeb-only"
plugin = initialize_plugin_under_test(plugin_desc_file=CUSTOM_PLUGIN_JSON_FILE)
with pytest.raises(ValueError) as e_info:
plugin.run_metadata_detector(
metadata_detector_id,
build_virtual_file_system(["./usr/share/doc/foo/copyright"]),
)
msg = f'The detector "{metadata_detector_id}" from {plugin_name} does not apply to the given package.'
assert e_info.value.args[0].startswith(msg)
metadata = plugin.run_metadata_detector(
metadata_detector_id,
build_virtual_file_system(["./usr/share/doc/foo/copyright"]),
context=package_metadata_context(package_fields={"Package-Type": "udeb"}),
)
assert metadata.substvars["Test:Udeb-Metadata-Detector"] == "was-run"
@pytest.mark.parametrize(
"variables,exec_type",
[
(
[("DEBPUTY_VAR", "RESERVED")],
ValueError,
),
(
[("_DEBPUTY_VAR", "RESERVED")],
ValueError,
),
(
[("_FOO", "RESERVED")],
ValueError,
),
(
[("path:_var", "RESERVED")],
ValueError,
),
(
[("path:DEBPUTY_VAR", "RESERVED")],
ValueError,
),
(
[("DEB_VAR", "RESERVED")],
ValueError,
),
(
[("DPKG_VAR", "RESERVED")],
ValueError,
),
(
[("PACKAGE", "RESERVED")],
ValueError,
),
(
[("foo:var", "RESERVED")],
ValueError,
),
(
[("env:var", "RESERVED")],
ValueError,
),
(
[("SOURCE_DATE_EPOCH", "RESERVED")],
ValueError,
),
(
[("!MY_VAR", "INVALID_NAME")],
ValueError,
),
(
[("VALUE_DEPENDS_ON_VAR", "{{UNKNOWN_VAR}}")],
ValueError,
),
(
[("VALUE_DEPENDS_ON_VAR", "{{DEB_HOST_ARCH}}")],
ValueError,
),
(
[("DEFINED_TWICE", "ONCE"), ("DEFINED_TWICE", "TWICE")],
PluginConflictError,
),
],
)
def test_invalid_manifest_variables(
variables: List[Tuple[str, str]],
exec_type: Type[Exception],
) -> None:
def _initializer(api: DebputyPluginInitializer):
with pytest.raises(exec_type):
for varname, value in variables:
api.manifest_variable(varname, value)
initialize_plugin_under_test_preloaded(
1,
_initializer,
plugin_name="test-plugin",
load_debputy_plugin=False,
)
def test_valid_manifest_variables() -> None:
variables = {
"PLUGIN_VAR": "TEST VALUE",
"ANOTHER_PLUGIN_VAR": "ANOTHER VALUE",
"path:SOMEWHERE_DIR": "/usr/share/some-where",
}
def _initializer(api: DebputyPluginInitializer):
for k, v in variables.items():
api.manifest_variable(k, v)
plugin = initialize_plugin_under_test_preloaded(
1,
_initializer,
plugin_name="test-plugin",
load_debputy_plugin=False,
)
assert plugin.declared_manifest_variables == variables.keys()
def test_valid_manifest_variables_json() -> None:
variables = {
"PLUGIN_VAR": "TEST VALUE",
"ANOTHER_PLUGIN_VAR": "ANOTHER VALUE",
"path:SOMEWHERE_DIR": "/usr/share/some-where",
}
content = {
"api-compat-version": 1,
"manifest-variables": [
{
"name": k,
"value": v,
}
for k, v in variables.items()
],
}
plugin = initialize_plugin_under_test_from_inline_json(
"test-plugin",
json.dumps(content),
)
assert plugin.declared_manifest_variables == variables.keys()
def test_automatic_discard_rules_example() -> None:
plugin = initialize_plugin_under_test_preloaded(
1,
# Internal API used
cast("PluginInitializationEntryPoint", adr_inconsistent_example_plugin),
# API is restricted
plugin_name="debputy",
load_debputy_plugin=False,
)
issues = plugin.automatic_discard_rules_examples_with_issues()
assert len(issues) == 1
issue = issues[0]
assert issue.name == "adr-example-test"
assert issue.example_index == 0
assert set(issue.inconsistent_paths) == {
"/discard-me/foo",
"/bar/discard-me",
"/baz/something",
}
|