1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
|
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "gtest/gtest.h"
#include "mozmemory.h"
#include "replace_malloc_bridge.h"
#include "mozilla/Assertions.h"
#include "mozilla/mozalloc.h"
#include "../../PHC.h"
using namespace mozilla;
bool PHCInfoEq(phc::AddrInfo& aInfo, phc::AddrInfo::Kind aKind, void* aBaseAddr,
size_t aUsableSize, bool aHasAllocStack, bool aHasFreeStack) {
return aInfo.mKind == aKind && aInfo.mBaseAddr == aBaseAddr &&
aInfo.mUsableSize == aUsableSize &&
// Proper stack traces will have at least 3 elements.
(aHasAllocStack ? (aInfo.mAllocStack->mLength > 2)
: (aInfo.mAllocStack.isNothing())) &&
(aHasFreeStack ? (aInfo.mFreeStack->mLength > 2)
: (aInfo.mFreeStack.isNothing()));
}
bool JeInfoEq(jemalloc_ptr_info_t& aInfo, PtrInfoTag aTag, void* aAddr,
size_t aSize, arena_id_t arenaId) {
return aInfo.tag == aTag && aInfo.addr == aAddr && aInfo.size == aSize
#ifdef MOZ_DEBUG
&& aInfo.arenaId == arenaId
#endif
;
}
uint8_t* GetPHCAllocation(size_t aSize, size_t aAlignment = 1) {
// A crude but effective way to get a PHC allocation.
for (int i = 0; i < 2000000; i++) {
void* p = (aAlignment == 1) ? moz_xmalloc(aSize)
: moz_xmemalign(aAlignment, aSize);
if (ReplaceMalloc::IsPHCAllocation(p, nullptr)) {
return (uint8_t*)p;
}
free(p);
}
return nullptr;
}
static const size_t kPageSize = 4096;
TEST(PHC, TestPHCAllocations)
{
// First, check that allocations of various sizes all get put at the end of
// their page as expected. Also, check their sizes are as expected.
#define ASSERT_POS(n1, n2) \
p = (uint8_t*)moz_xrealloc(p, (n1)); \
ASSERT_EQ((reinterpret_cast<uintptr_t>(p) & (kPageSize - 1)), \
kPageSize - (n2)); \
ASSERT_EQ(moz_malloc_usable_size(p), (n2));
uint8_t* p = GetPHCAllocation(1);
if (!p) {
MOZ_CRASH("failed to get a PHC allocation");
}
// On Win64 the smallest possible allocation is 16 bytes. On other platforms
// it is 8 bytes.
#if defined(XP_WIN) && defined(HAVE_64BIT_BUILD)
ASSERT_POS(8U, 16U);
#else
ASSERT_POS(8U, 8U);
#endif
ASSERT_POS(16U, 16U);
ASSERT_POS(32U, 32U);
ASSERT_POS(64U, 64U);
ASSERT_POS(128U, 128U);
ASSERT_POS(256U, 256U);
ASSERT_POS(512U, 512U);
ASSERT_POS(1024U, 1024U);
ASSERT_POS(2048U, 2048U);
ASSERT_POS(4096U, 4096U);
free(p);
#undef ASSERT_POS
// Second, do similar checking with allocations of various alignments. Also
// check that their sizes (which are different to allocations with normal
// alignment) are the same as the sizes of equivalent non-PHC allocations.
#define ASSERT_ALIGN(a1, a2) \
p = (uint8_t*)GetPHCAllocation(8, (a1)); \
ASSERT_EQ((reinterpret_cast<uintptr_t>(p) & (kPageSize - 1)), \
kPageSize - (a2)); \
ASSERT_EQ(moz_malloc_usable_size(p), (a2)); \
free(p); \
p = (uint8_t*)moz_xmemalign((a1), 8); \
ASSERT_EQ(moz_malloc_usable_size(p), (a2)); \
free(p);
// On Win64 the smallest possible allocation is 16 bytes. On other platforms
// it is 8 bytes.
#if defined(XP_WIN) && defined(HAVE_64BIT_BUILD)
ASSERT_ALIGN(8U, 16U);
#else
ASSERT_ALIGN(8U, 8U);
#endif
ASSERT_ALIGN(16U, 16U);
ASSERT_ALIGN(32U, 32U);
ASSERT_ALIGN(64U, 64U);
ASSERT_ALIGN(128U, 128U);
ASSERT_ALIGN(256U, 256U);
ASSERT_ALIGN(512U, 512U);
ASSERT_ALIGN(1024U, 1024U);
ASSERT_ALIGN(2048U, 2048U);
ASSERT_ALIGN(4096U, 4096U);
#undef ASSERT_ALIGN
}
TEST(PHC, TestPHCInfo)
{
int stackVar;
phc::AddrInfo phcInfo;
jemalloc_ptr_info_t jeInfo;
// Test a default AddrInfo.
ASSERT_TRUE(PHCInfoEq(phcInfo, phc::AddrInfo::Kind::Unknown, nullptr, 0ul,
false, false));
// Test some non-PHC allocation addresses.
ASSERT_FALSE(ReplaceMalloc::IsPHCAllocation(nullptr, &phcInfo));
ASSERT_TRUE(PHCInfoEq(phcInfo, phc::AddrInfo::Kind::Unknown, nullptr, 0,
false, false));
ASSERT_FALSE(ReplaceMalloc::IsPHCAllocation(&stackVar, &phcInfo));
ASSERT_TRUE(PHCInfoEq(phcInfo, phc::AddrInfo::Kind::Unknown, nullptr, 0,
false, false));
uint8_t* p = GetPHCAllocation(32);
if (!p) {
MOZ_CRASH("failed to get a PHC allocation");
}
// Test an in-use PHC allocation: first byte within it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::InUsePage, p, 32ul, true, false));
ASSERT_EQ(moz_malloc_usable_size(p), 32ul);
jemalloc_ptr_info(p, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagLiveAlloc, p, 32, 0));
// Test an in-use PHC allocation: last byte within it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 31, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::InUsePage, p, 32ul, true, false));
ASSERT_EQ(moz_malloc_usable_size(p + 31), 32ul);
jemalloc_ptr_info(p + 31, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagLiveAlloc, p, 32, 0));
// Test an in-use PHC allocation: last byte before it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p - 1, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::InUsePage, p, 32ul, true, false));
ASSERT_EQ(moz_malloc_usable_size(p - 1), 0ul);
jemalloc_ptr_info(p - 1, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test an in-use PHC allocation: first byte on its allocation page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 32 - kPageSize, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::InUsePage, p, 32ul, true, false));
jemalloc_ptr_info(p + 32 - kPageSize, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test an in-use PHC allocation: first byte in the following guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 32, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, false));
jemalloc_ptr_info(p + 32, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test an in-use PHC allocation: last byte in the lower half of the
// following guard page.
ASSERT_TRUE(
ReplaceMalloc::IsPHCAllocation(p + 32 + (kPageSize / 2 - 1), &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, false));
jemalloc_ptr_info(p + 32 + (kPageSize / 2 - 1), &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test an in-use PHC allocation: last byte in the preceding guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 31 - kPageSize, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, false));
jemalloc_ptr_info(p + 31 - kPageSize, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test an in-use PHC allocation: first byte in the upper half of the
// preceding guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(
p + 31 - kPageSize - (kPageSize / 2 - 1), &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, false));
jemalloc_ptr_info(p + 31 - kPageSize - (kPageSize / 2 - 1), &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
free(p);
// Test a freed PHC allocation: first byte within it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::FreedPage, p, 32ul, true, true));
jemalloc_ptr_info(p, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagFreedAlloc, p, 32, 0));
// Test a freed PHC allocation: last byte within it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 31, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::FreedPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 31, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagFreedAlloc, p, 32, 0));
// Test a freed PHC allocation: last byte before it.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p - 1, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::FreedPage, p, 32ul, true, true));
jemalloc_ptr_info(p - 1, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test a freed PHC allocation: first byte on its allocation page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 32 - kPageSize, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::FreedPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 32 - kPageSize, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test a freed PHC allocation: first byte in the following guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 32, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 32, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test a freed PHC allocation: last byte in the lower half of the following
// guard page.
ASSERT_TRUE(
ReplaceMalloc::IsPHCAllocation(p + 32 + (kPageSize / 2 - 1), &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 32 + (kPageSize / 2 - 1), &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test a freed PHC allocation: last byte in the preceding guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p + 31 - kPageSize, &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 31 - kPageSize, &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// Test a freed PHC allocation: first byte in the upper half of the preceding
// guard page.
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(
p + 31 - kPageSize - (kPageSize / 2 - 1), &phcInfo));
ASSERT_TRUE(
PHCInfoEq(phcInfo, phc::AddrInfo::Kind::GuardPage, p, 32ul, true, true));
jemalloc_ptr_info(p + 31 - kPageSize - (kPageSize / 2 - 1), &jeInfo);
ASSERT_TRUE(JeInfoEq(jeInfo, TagUnknown, nullptr, 0, 0));
// There are no tests for `mKind == NeverAllocatedPage` because it's not
// possible to reliably get ahold of such a page.
}
TEST(PHC, TestPHCDisabling)
{
uint8_t* p = GetPHCAllocation(32);
uint8_t* q = GetPHCAllocation(32);
if (!p || !q) {
MOZ_CRASH("failed to get a PHC allocation");
}
ASSERT_TRUE(ReplaceMalloc::IsPHCEnabledOnCurrentThread());
ReplaceMalloc::DisablePHCOnCurrentThread();
ASSERT_FALSE(ReplaceMalloc::IsPHCEnabledOnCurrentThread());
// Test realloc() on a PHC allocation while PHC is disabled on the thread.
uint8_t* p2 = (uint8_t*)realloc(p, 128);
// The small realloc is fulfilled within the same page, but it does move.
ASSERT_TRUE(p2 == p - 96);
ASSERT_TRUE(ReplaceMalloc::IsPHCAllocation(p2, nullptr));
uint8_t* p3 = (uint8_t*)realloc(p2, 8192);
// The big realloc is not in-place, and the result is not a PHC allocation.
ASSERT_TRUE(p3 != p2);
ASSERT_FALSE(ReplaceMalloc::IsPHCAllocation(p3, nullptr));
free(p3);
// Test free() on a PHC allocation while PHC is disabled on the thread.
free(q);
// These must not be PHC allocations.
uint8_t* r = GetPHCAllocation(32); // This will fail.
ASSERT_FALSE(!!r);
ReplaceMalloc::ReenablePHCOnCurrentThread();
ASSERT_TRUE(ReplaceMalloc::IsPHCEnabledOnCurrentThread());
}
|
