1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
|
/**
* @fileoverview Reject using element.parentNode.removeChild(element) when
* element.remove() can be used instead.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
var helpers = require("../helpers");
module.exports = {
meta: {
docs: {
url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/avoid-removeChild.html",
},
messages: {
useRemove:
"use element.remove() instead of element.parentNode.removeChild(element)",
useFirstChildRemove:
"use element.firstChild.remove() instead of element.removeChild(element.firstChild)",
},
schema: [],
type: "suggestion",
},
create(context) {
return {
CallExpression(node) {
let callee = node.callee;
if (
callee.type !== "MemberExpression" ||
callee.property.type !== "Identifier" ||
callee.property.name != "removeChild" ||
node.arguments.length != 1
) {
return;
}
if (
callee.object.type == "MemberExpression" &&
callee.object.property.type == "Identifier" &&
callee.object.property.name == "parentNode" &&
helpers.getASTSource(callee.object.object, context) ==
helpers.getASTSource(node.arguments[0])
) {
context.report({
node,
messageId: "useRemove",
});
}
if (
node.arguments[0].type == "MemberExpression" &&
node.arguments[0].property.type == "Identifier" &&
node.arguments[0].property.name == "firstChild" &&
helpers.getASTSource(callee.object, context) ==
helpers.getASTSource(node.arguments[0].object)
) {
context.report({
node,
messageId: "useFirstChildRemove",
});
}
},
};
},
};
|
