1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
|
/**
* @fileoverview Reject use of non-zero values in setTimeout
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
var helpers = require("../helpers");
var testTypes = new Set(["browser", "xpcshell"]);
module.exports = {
meta: {
docs: {
url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/no-arbitrary-setTimeout.html",
},
messages: {
listenForEvents:
"listen for events instead of setTimeout() with arbitrary delay",
},
schema: [],
type: "problem",
},
create(context) {
// We don't want to run this on mochitest plain as it already
// prevents flaky setTimeout at runtime. This check is built-in
// to the rule itself as sometimes other tests can live alongside
// plain mochitests and so it can't be configured via eslintrc.
if (!testTypes.has(helpers.getTestType(context))) {
return {};
}
return {
CallExpression(node) {
let callee = node.callee;
if (callee.type === "MemberExpression") {
if (
callee.property.name !== "setTimeout" ||
callee.object.name !== "window" ||
node.arguments.length < 2
) {
return;
}
} else if (callee.type === "Identifier") {
if (callee.name !== "setTimeout" || node.arguments.length < 2) {
return;
}
} else {
return;
}
let timeout = node.arguments[1];
if (timeout.type !== "Literal" || timeout.value > 0) {
context.report({
node,
messageId: "listenForEvents",
});
}
},
};
},
};
|
