1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
|
/**
* @fileoverview Ensures that Services uses have valid property names.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
const helpers = require("../helpers");
module.exports = {
meta: {
docs: {
url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/valid-services.html",
},
schema: [],
type: "problem",
},
create(context) {
let servicesInterfaceMap = helpers.servicesData;
let serviceAliases = new Set([
...Object.values(servicesInterfaceMap),
// This is defined only for Android, so most builds won't pick it up.
"androidBridge",
// These are defined without interfaces and hence are not in the services map.
"cpmm",
"crashmanager",
"mm",
"ppmm",
// The new xulStore also does not have an interface.
"xulStore",
]);
return {
MemberExpression(node) {
if (node.computed || node.object.type !== "Identifier") {
return;
}
let alias;
if (node.object.name == "Services") {
alias = node.property.name;
} else if (
node.property.name == "Services" &&
node.parent.type == "MemberExpression"
) {
alias = node.parent.property.name;
} else {
return;
}
if (!serviceAliases.has(alias)) {
context.report({
node,
message: `Unknown Services member property ${alias}`,
});
}
},
};
},
};
|
