Merging upstream version 127.0.

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

10 files changed, 43 insertions, 128 deletions

diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_groups.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_groups.js
index ce69d30517..f930b28f59 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_groups.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_groups.js
@@ -59,9 +59,9 @@ add_task(async function recent_search() {
     assert: () =>
       assertAbandonmentTelemetry([
         {
-          groups: "recent_search,suggested_index",
-          results: "recent_search,action",
-          n_results: 2,
+          groups: "recent_search",
+          results: "recent_search",
+          n_results: 1,
         },
       ]),
   });
@@ -114,9 +114,9 @@ add_task(async function top_site() {
     assert: () =>
       assertAbandonmentTelemetry([
         {
-          groups: "top_site,suggested_index",
-          results: "top_site,action",
-          n_results: 2,
+          groups: "top_site",
+          results: "top_site",
+          n_results: 1,
         },
       ]),
   });
@@ -128,9 +128,9 @@ add_task(async function clipboard() {
     assert: () =>
       assertAbandonmentTelemetry([
         {
-          groups: "general,suggested_index",
-          results: "clipboard,action",
-          n_results: 2,
+          groups: "general",
+          results: "clipboard",
+          n_results: 1,
         },
       ]),
   });
@@ -170,9 +170,9 @@ add_task(async function general() {
     assert: () =>
       assertAbandonmentTelemetry([
         {
-          groups: "heuristic,suggested_index,general",
-          results: "search_engine,action,bookmark",
-          n_results: 3,
+          groups: "heuristic,general",
+          results: "search_engine,bookmark",
+          n_results: 2,
         },
       ]),
   });
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_search_mode.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_search_mode.js
index 7edcc47a30..45f4b79e7c 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_search_mode.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_abandonment_search_mode.js
@@ -45,10 +45,3 @@ add_task(async function tabs() {
     assert: () => assertAbandonmentTelemetry([{ search_mode: "tabs" }]),
   });
 });
-
-add_task(async function actions() {
-  await doActionsTest({
-    trigger: () => doBlur(),
-    assert: () => assertAbandonmentTelemetry([{ search_mode: "actions" }]),
-  });
-});
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js
index 04ef7e9757..1668470714 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_edge_cases.js
@@ -196,7 +196,6 @@ add_task(async function enter_to_reload_current_url() {
     await BrowserTestUtils.waitForCondition(
       () => window.document.activeElement === gURLBar.inputField
     );
-    await UrlbarTestUtils.promiseSearchComplete(window);
 
     // Press Enter key to reload the page without selecting any suggestions.
     await doEnter();
@@ -213,8 +212,8 @@ add_task(async function enter_to_reload_current_url() {
         selected_result: "input_field",
         selected_result_subtype: "",
         provider: undefined,
-        results: "action",
-        groups: "suggested_index",
+        results: "",
+        groups: "",
       },
     ]);
   });
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_groups.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_groups.js
index d46c874403..a0ef61dd19 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_groups.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_groups.js
@@ -59,9 +59,9 @@ add_task(async function recent_search() {
     assert: () =>
       assertEngagementTelemetry([
         {
-          groups: "recent_search,suggested_index",
-          results: "recent_search,action",
-          n_results: 2,
+          groups: "recent_search",
+          results: "recent_search",
+          n_results: 1,
         },
       ]),
   });
@@ -114,9 +114,9 @@ add_task(async function top_site() {
     assert: () =>
       assertEngagementTelemetry([
         {
-          groups: "top_site,suggested_index",
-          results: "top_site,action",
-          n_results: 2,
+          groups: "top_site",
+          results: "top_site",
+          n_results: 1,
         },
       ]),
   });
@@ -128,9 +128,9 @@ add_task(async function clipboard() {
     assert: () =>
       assertEngagementTelemetry([
         {
-          groups: "general,suggested_index",
-          results: "clipboard,action",
-          n_results: 2,
+          groups: "general",
+          results: "clipboard",
+          n_results: 1,
         },
       ]),
   });
@@ -170,9 +170,9 @@ add_task(async function general() {
     assert: () =>
       assertEngagementTelemetry([
         {
-          groups: "heuristic,suggested_index,general",
-          results: "search_engine,action,bookmark",
-          n_results: 3,
+          groups: "heuristic,general",
+          results: "search_engine,bookmark",
+          n_results: 2,
         },
       ]),
   });
@@ -255,6 +255,7 @@ add_task(async function always_empty_if_drop_go() {
 
   await doTest(async () => {
     // Open the results view once.
+    await addTopSites("https://example.com/");
     await showResultByArrowDown();
     await UrlbarTestUtils.promisePopupClose(window);
 
@@ -282,6 +283,7 @@ add_task(async function always_empty_if_paste_go() {
 
   await doTest(async () => {
     // Open the results view once.
+    await addTopSites("https://example.com/");
     await showResultByArrowDown();
     await UrlbarTestUtils.promisePopupClose(window);
 
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_interaction.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_interaction.js
index 2866186c30..d2deacf597 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_interaction.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_interaction.js
@@ -42,6 +42,7 @@ add_task(async function dropped() {
   });
 
   await doTest(async () => {
+    await addTopSites("https://example.com/");
     await showResultByArrowDown();
     await doDropAndGo("example.com");
 
@@ -67,6 +68,7 @@ add_task(async function pasted() {
   });
 
   await doTest(async () => {
+    await addTopSites("https://example.com/");
     await showResultByArrowDown();
     await doPasteAndGo("www.example.com");
 
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_search_mode.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_search_mode.js
index 013bef1904..9227b81fd0 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_search_mode.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_search_mode.js
@@ -42,6 +42,7 @@ add_task(async function tabs() {
   await doTabTest({
     trigger: async () => {
       const currentTab = gBrowser.selectedTab;
+      EventUtils.synthesizeKey("KEY_Tab");
       EventUtils.synthesizeKey("KEY_Enter");
       await BrowserTestUtils.waitForCondition(
         () => gBrowser.selectedTab !== currentTab
@@ -50,14 +51,3 @@ add_task(async function tabs() {
     assert: () => assertEngagementTelemetry([{ search_mode: "tabs" }]),
   });
 });
-
-add_task(async function actions() {
-  await doActionsTest({
-    trigger: async () => {
-      const onLoad = BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
-      doClickSubButton(".urlbarView-quickaction-button[data-key=addons]");
-      await onLoad;
-    },
-    assert: () => assertEngagementTelemetry([{ search_mode: "actions" }]),
-  });
-});
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js
index bea266dbf4..34083e4369 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js
@@ -119,9 +119,9 @@ add_task(async function selected_result_bookmark() {
       {
         selected_result: "bookmark",
         selected_result_subtype: "",
-        selected_position: 3,
+        selected_position: 2,
         provider: "Places",
-        results: "search_engine,action,bookmark",
+        results: "search_engine,bookmark",
       },
     ]);
   });
@@ -267,27 +267,11 @@ add_task(async function selected_result_url() {
   });
 });
 
-add_task(async function selected_result_action() {
-  await doTest(async () => {
-    await showResultByArrowDown();
-    await selectRowByProvider("quickactions");
-    const onLoad = BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
-    doClickSubButton(".urlbarView-quickaction-button[data-key=addons]");
-    await onLoad;
-
-    assertEngagementTelemetry([
-      {
-        selected_result: "action",
-        selected_result_subtype: "addons",
-        selected_position: 1,
-        provider: "quickactions",
-        results: "action",
-      },
-    ]);
+add_task(async function selected_result_tab() {
+  await SpecialPowers.pushPrefEnv({
+    set: [["browser.urlbar.secondaryActions.featureGate", false]],
   });
-});
 
-add_task(async function selected_result_tab() {
   const tab = BrowserTestUtils.addTab(gBrowser, "https://example.com/");
 
   await doTest(async () => {
@@ -307,6 +291,7 @@ add_task(async function selected_result_tab() {
     ]);
   });
 
+  await SpecialPowers.popPrefEnv();
   BrowserTestUtils.removeTab(tab);
 });
 
@@ -402,7 +387,7 @@ add_task(async function selected_result_top_site() {
         selected_result_subtype: "",
         selected_position: 1,
         provider: "UrlbarProviderTopSites",
-        results: "top_site,action",
+        results: "top_site",
       },
     ]);
   });
@@ -456,7 +441,7 @@ add_task(async function selected_result_clipboard() {
         selected_result_subtype: "",
         selected_position: 1,
         provider: "UrlbarProviderClipboard",
-        results: "clipboard,action",
+        results: "clipboard",
       },
     ]);
   });
@@ -492,50 +477,6 @@ add_task(async function selected_result_unit() {
   await SpecialPowers.popPrefEnv();
 });
 
-add_task(async function selected_result_site_specific_contextual_search() {
-  await SpecialPowers.pushPrefEnv({
-    set: [["browser.urlbar.contextualSearch.enabled", true]],
-  });
-
-  await doTest(async () => {
-    const extension = await SearchTestUtils.installSearchExtension(
-      {
-        name: "Contextual",
-        search_url: "https://example.com/browser",
-      },
-      { skipUnload: true }
-    );
-    const onLoaded = BrowserTestUtils.browserLoaded(
-      gBrowser.selectedBrowser,
-      false,
-      "https://example.com/"
-    );
-    BrowserTestUtils.startLoadingURIString(
-      gBrowser.selectedBrowser,
-      "https://example.com/"
-    );
-    await onLoaded;
-
-    await openPopup("search");
-    await selectRowByProvider("UrlbarProviderContextualSearch");
-    await doEnter();
-
-    assertEngagementTelemetry([
-      {
-        selected_result: "site_specific_contextual_search",
-        selected_result_subtype: "",
-        selected_position: 2,
-        provider: "UrlbarProviderContextualSearch",
-        results: "search_engine,site_specific_contextual_search",
-      },
-    ]);
-
-    await extension.unload();
-  });
-
-  await SpecialPowers.popPrefEnv();
-});
-
 add_task(async function selected_result_rs_adm_sponsored() {
   const cleanupQuickSuggest = await ensureQuickSuggestInit({
     prefs: [["quicksuggest.rustEnabled", false]],
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/head-interaction.js b/browser/components/urlbar/tests/engagementTelemetry/browser/head-interaction.js
index 58c55b416f..dffdebad97 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/head-interaction.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/head-interaction.js
@@ -130,6 +130,7 @@ async function doTypedTest({ trigger, assert }) {
 
 async function doTypedWithResultsPopupTest({ trigger, assert }) {
   await doTest(async () => {
+    await addTopSites("https://example.org/");
     await showResultByArrowDown();
     EventUtils.synthesizeKey("x");
     await UrlbarTestUtils.promiseSearchComplete(window);
@@ -150,6 +151,7 @@ async function doPastedTest({ trigger, assert }) {
 
 async function doPastedWithResultsPopupTest({ trigger, assert }) {
   await doTest(async () => {
+    await addTopSites("https://example.org/");
     await showResultByArrowDown();
     await doPaste("x");
 
@@ -257,6 +259,7 @@ async function doPersistedSearchTermsRestartedRefinedTest({
 
   for (const { firstInput, secondInput, expected } of testData) {
     await doTest(async () => {
+      await addTopSites("https://example.com/");
       await openPopup(firstInput);
       await doEnter();
 
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/head-search_mode.js b/browser/components/urlbar/tests/engagementTelemetry/browser/head-search_mode.js
index 86151e1ba3..25a6504109 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/head-search_mode.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/head-search_mode.js
@@ -78,16 +78,3 @@ async function doTabTest({ trigger, assert }) {
 
   BrowserTestUtils.removeTab(tab);
 }
-
-async function doActionsTest({ trigger, assert }) {
-  await doTest(async () => {
-    await openPopup("add");
-    await UrlbarTestUtils.enterSearchMode(window, {
-      source: UrlbarUtils.RESULT_SOURCE.ACTIONS,
-    });
-    await selectRowByProvider("quickactions");
-
-    await trigger();
-    await assert();
-  });
-}
diff --git a/browser/components/urlbar/tests/engagementTelemetry/browser/head.js b/browser/components/urlbar/tests/engagementTelemetry/browser/head.js
index 1373cc7e27..a3b2b020c0 100644
--- a/browser/components/urlbar/tests/engagementTelemetry/browser/head.js
+++ b/browser/components/urlbar/tests/engagementTelemetry/browser/head.js
@@ -406,9 +406,7 @@ async function setup() {
     set: [
       ["browser.urlbar.searchEngagementTelemetry.enabled", true],
       ["browser.urlbar.quickactions.enabled", true],
-      ["browser.urlbar.quickactions.minimumSearchString", 0],
-      ["browser.urlbar.suggest.quickactions", true],
-      ["browser.urlbar.shortcuts.quickactions", true],
+      ["browser.urlbar.secondaryActions.featureGate", true],
     ],
   });