diff options
author | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-19 01:13:33 +0000 |
---|---|---|
committer | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-19 01:13:33 +0000 |
commit | 086c044dc34dfc0f74fbe41f4ecb402b2cd34884 (patch) | |
tree | a4f824bd33cb075dd5aa3eb5a0a94af221bbe83a /tools/tryselect/selectors | |
parent | Adding debian version 124.0.1-1. (diff) | |
download | firefox-086c044dc34dfc0f74fbe41f4ecb402b2cd34884.tar.xz firefox-086c044dc34dfc0f74fbe41f4ecb402b2cd34884.zip |
Merging upstream version 125.0.1.
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to 'tools/tryselect/selectors')
-rw-r--r-- | tools/tryselect/selectors/chooser/templates/chooser.html | 11 | ||||
-rw-r--r-- | tools/tryselect/selectors/fuzzy.py | 7 | ||||
-rw-r--r-- | tools/tryselect/selectors/perf.py | 23 |
3 files changed, 38 insertions, 3 deletions
diff --git a/tools/tryselect/selectors/chooser/templates/chooser.html b/tools/tryselect/selectors/chooser/templates/chooser.html index 4e009d94ac..1c3df39327 100644 --- a/tools/tryselect/selectors/chooser/templates/chooser.html +++ b/tools/tryselect/selectors/chooser/templates/chooser.html @@ -40,6 +40,17 @@ {% else %} <div class="tab-pane" id="{{ section.name }}" role="tabpanel" aria-labelledby="{{ section.name }}-tab"> {% endif %} + {% if section.name == "perf" %} + <div> + <p style="color:red"> + WARNING: The try chooser is no longer supported for selecting performance tests. + Please use + <a href="https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html"> + ./mach try perf + </a>. + </p> + </div> + {% endif %} {% for label, meta in section.labels|dictsort %} <label class="multiselect filter-label" for={{ label }}> <span> diff --git a/tools/tryselect/selectors/fuzzy.py b/tools/tryselect/selectors/fuzzy.py index 7a9bccc4b7..a9b139fa6f 100644 --- a/tools/tryselect/selectors/fuzzy.py +++ b/tools/tryselect/selectors/fuzzy.py @@ -12,7 +12,7 @@ from mach.util import get_state_dir from ..cli import BaseTryParser from ..push import check_working_directory, generate_try_task_config, push_to_try -from ..tasks import filter_tasks_by_paths, generate_tasks +from ..tasks import filter_tasks_by_paths, filter_tasks_by_worker_type, generate_tasks from ..util.fzf import ( FZF_NOT_FOUND, PREVIEW_SCRIPT, @@ -182,6 +182,11 @@ def run( if filter_by_uncommon_try_tasks(task_name) } + if try_config_params.get("try_task_config", {}).get("worker-types", []): + all_tasks = filter_tasks_by_worker_type(all_tasks, try_config_params) + if not all_tasks: + return 1 + if test_paths: all_tasks = filter_tasks_by_paths(all_tasks, test_paths) if not all_tasks: diff --git a/tools/tryselect/selectors/perf.py b/tools/tryselect/selectors/perf.py index 3c59e5949c..261905d5a3 100644 --- a/tools/tryselect/selectors/perf.py +++ b/tools/tryselect/selectors/perf.py @@ -336,6 +336,15 @@ class PerfParser(CompareParser): "help": "Use PerfCompare Beta instead of CompareView.", }, ], + [ + ["--non-pgo"], + { + "action": "store_true", + "default": False, + "help": "Use opt/non-pgo builds instead of shippable/pgo builds. " + "Setting this flag will result in faster try runs.", + }, + ], ] def get_tasks(base_cmd, queries, query_arg=None, candidate_tasks=None): @@ -715,7 +724,7 @@ class PerfParser(CompareParser): PerfParser.variants[variant.value]["query"] ) - def _build_categories(category, category_info, category_matrix): + def _build_categories(category, category_info, category_matrix, **kwargs): """Builds the categories to display.""" categories = {} @@ -745,6 +754,16 @@ class PerfParser(CompareParser): for suite in category_info["suites"] } + if kwargs.get("non_pgo"): + for key, query_list in platform_queries.items(): + updated_query_list = [] + for query in query_list: + updated_query = query.replace( + "'shippable", "!shippable !nightlyasrelease" + ) + updated_query_list.append(updated_query) + platform_queries[key] = updated_query_list + platform_category_name = f"{category} {platform.value}" platform_category_info = { "queries": platform_queries, @@ -931,7 +950,7 @@ class PerfParser(CompareParser): for category, category_matrix in category_decision_matrix.items(): categories.update( PerfParser._build_categories( - category, PerfParser.categories[category], category_matrix + category, PerfParser.categories[category], category_matrix, **kwargs ) ) |