diff options
Diffstat (limited to 'docs/contributing/how_to_submit_a_patch.rst')
| -rw-r--r-- | docs/contributing/how_to_submit_a_patch.rst | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/docs/contributing/how_to_submit_a_patch.rst b/docs/contributing/how_to_submit_a_patch.rst index d8ef62f742..7c5b56a7e1 100644 --- a/docs/contributing/how_to_submit_a_patch.rst +++ b/docs/contributing/how_to_submit_a_patch.rst @@ -105,11 +105,6 @@ simple commit message should look like this: Bug 123456 - Change this thing to work better by doing something. r=reviewers -The ``r=reviewers`` part is optional; if you are using Phabricator, -Lando will add it automatically based on who actually granted review, -and in any case the person who does the final check-in of the patch will -make sure it's added. - The text of the message should be what you did to fix the bug, not a description of what the bug was. If it is not obvious why this change is appropriate, then `explain why in the commit @@ -117,6 +112,11 @@ message <https://mozilla-version-control-tools.readthedocs.io/en/latest/mozrevie If this does not fit on one line, then leave a blank line and add further lines for more detail and/or reasoning. +The ``r=reviewers`` part specifies that ``reviewers`` should review the patch +and provide feedback before it is integrated into the Firefox codebase. For +choosing reviewers, and the full reviewer syntax, please see +:ref:`Getting reviews`. + You can edit the message of the current commit at any time using ``hg commit --amend`` or ``hg histedit``. |