diff options
Diffstat (limited to 'js/src/doc')
| -rw-r--r-- | js/src/doc/Debugger/Debugger.md | 7 | ||||
| -rw-r--r-- | js/src/doc/feature_checklist.md | 19 |
2 files changed, 19 insertions, 7 deletions
diff --git a/js/src/doc/Debugger/Debugger.md b/js/src/doc/Debugger/Debugger.md index ad7d57e22d..d3b01832a9 100644 --- a/js/src/doc/Debugger/Debugger.md +++ b/js/src/doc/Debugger/Debugger.md @@ -87,6 +87,13 @@ access to browser-level features like the `alert` function, which this API's implementation does not, making it possible to present debugger errors to the developer in a way suited to the context.) +### `shouldAvoidSideEffects` +A boolean value used to ask a side-effectful native code to abort. + +If set to true, `JS::dbg::ShouldAvoidSideEffects(cx)` returns true. +Native code can opt into this to support debugger who wants to perform +side-effect-free evaluation. + ## Debugger Handler Functions diff --git a/js/src/doc/feature_checklist.md b/js/src/doc/feature_checklist.md index 7cf847f725..e08821deda 100644 --- a/js/src/doc/feature_checklist.md +++ b/js/src/doc/feature_checklist.md @@ -9,12 +9,12 @@ work directly top-down) [Exposure Guidelines](https://wiki.mozilla.org/ExposureGuidelines) process. We historically haven't been amazing at sending intent-to-prototype emails, but we can always get better. -- ☐ Create a shell option for the feature. - ☐ Stage 2 or earlier proposals should be developed under compile time guards, disabled by default. -- ☐ Create a browser preference for the feature. +- ☐ Create a preference for the feature in `modules/libpref/init/StaticPrefList.yaml` + and a command line option in `js/src/shell/js.cpp`. - ☐ Implement the Feature. -- ☐ Land feature disabled by pref and shell-option. +- ☐ Land feature disabled by pref. - ☐ Import the test262 test cases for the feature, or enable them if they're already imported. (See `js/src/test/Readme.txt` for guidance) - ☐ Contact `fuzzing@mozilla.org` to arrange fuzzing for the feature. @@ -22,10 +22,15 @@ work directly top-down) fuzzers as well that the feature is ready for fuzzing. - ☐ Send an Intent to Ship Email to `dev-platform`. This is also part of the [Exposure Guidelines](https://wiki.mozilla.org/ExposureGuidelines) process. -- ☐ Ship the feature; default the preference to true and the command-line - option to true. -- ☐ Open a followup bug to later remove the preference and the command line - option. +- ☐ Ship the feature: + - ☐ default the preference to true. + - ☐ Double check for any code that is currently `NIGHTLY_BUILD` that should now be built unconditionally, e.g. in `js/src/vm/JSObject.cpp`. + You may want to run a [central as beta simulation](https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA) + to make sure you've caught any lingering `NIGHTLY_BUILD` parts. + - ☐ Update ` js/xpconnect/tests/chrome/test_xrayToJS.xhtml` for any changes to existing global objects. + - ☐ For new globals, the following tests also need updates: + `dom/serviceworkers/test/test_serviceworker_interfaces.js`, `tests/mochitest/general/test_interfaces.js`, and `dom/workers/test/test_worker_interfaces.js` +- ☐ Open a followup bug to later remove the preference. ## Supplemental Checklists |