diff options
Diffstat (limited to 'third_party/libwebrtc/g3doc/style-guide.md')
| -rw-r--r-- | third_party/libwebrtc/g3doc/style-guide.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/third_party/libwebrtc/g3doc/style-guide.md b/third_party/libwebrtc/g3doc/style-guide.md index b32163f906..57cb85c466 100644 --- a/third_party/libwebrtc/g3doc/style-guide.md +++ b/third_party/libwebrtc/g3doc/style-guide.md @@ -65,7 +65,7 @@ Follow the [Google styleguide for `TODO` comments][goog-style-todo]. When referencing a WebRTC bug, prefer using the URL form (excluding the scheme part): ```cpp -// TODO(bugs.webrtc.org/12345): Delete the hack when blocking bugs are resolved. +// TODO: bugs.webrtc.org/12345 - Delete the hack when blocking bugs are resolved. ``` The short form used in commit messages, e.g. `webrtc:12345`, is discouraged. @@ -132,7 +132,8 @@ docs. WebRTC uses std::string, with content assumed to be UTF-8. Note that this has to be verified whenever accepting external input. -For concatenation of strings, use rtc::SimpleStringBuilder. +For concatenation of strings, use webrtc::StrJoin or rtc::SimpleStringBuilder +directly. The following string building tools are NOT recommended: * The + operator. See https://abseil.io/tips/3 for why not. |