1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
|
export const description = `
Tests that, in compat mode, the dimension of a view is compatible with a texture's textureBindingViewDimension.
`;
import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { kTextureDimensions, kTextureViewDimensions } from '../../../capability_info.js';
import {
effectiveViewDimensionForTexture,
getTextureDimensionFromView,
} from '../../../util/texture/base.js';
import { CompatibilityTest } from '../../compatibility_test.js';
export const g = makeTestGroup(CompatibilityTest);
function isTextureBindingViewDimensionCompatibleWithDimension(
dimension: GPUTextureDimension = '2d',
textureBindingViewDimension: GPUTextureViewDimension = '2d'
) {
return getTextureDimensionFromView(textureBindingViewDimension) === dimension;
}
function isValidViewDimensionForDimension(
dimension: GPUTextureDimension | undefined,
depthOrArrayLayers: number,
viewDimension: GPUTextureViewDimension | undefined
) {
if (viewDimension === undefined) {
return true;
}
switch (dimension) {
case '1d':
return viewDimension === '1d';
case '2d':
case undefined:
switch (viewDimension) {
case undefined:
case '2d':
case '2d-array':
return true;
case 'cube':
return depthOrArrayLayers === 6;
case 'cube-array':
return depthOrArrayLayers % 6 === 0;
default:
return false;
}
break;
case '3d':
return viewDimension === '3d';
}
}
function isValidDimensionForDepthOrArrayLayers(
dimension: GPUTextureDimension | undefined,
depthOrArrayLayers: number
) {
switch (dimension) {
case '1d':
return depthOrArrayLayers === 1;
default:
return true;
}
}
function isValidViewDimensionForDepthOrArrayLayers(
viewDimension: GPUTextureViewDimension | undefined,
depthOrArrayLayers: number
) {
switch (viewDimension) {
case '2d':
return depthOrArrayLayers === 1;
case 'cube':
return depthOrArrayLayers === 6;
case 'cube-array':
return depthOrArrayLayers % 6 === 0;
default:
return true;
}
return viewDimension === 'cube';
}
function getEffectiveTextureBindingViewDimension(
dimension: GPUTextureDimension | undefined,
depthOrArrayLayers: number,
textureBindingViewDimension: GPUTextureViewDimension | undefined
) {
if (textureBindingViewDimension) {
return textureBindingViewDimension;
}
switch (dimension) {
case '1d':
return '1d';
case '2d':
case undefined:
return depthOrArrayLayers > 1 ? '2d-array' : '2d';
break;
case '3d':
return '3d';
}
}
g.test('viewDimension_matches_textureBindingViewDimension')
.desc(
`
Tests that, in compat mode, the dimension of a view is compatible with a texture's textureBindingViewDimension
when used as a TEXTURE_BINDING.
`
)
.params(u =>
u //
.combine('dimension', [...kTextureDimensions, undefined])
.combine('textureBindingViewDimension', [...kTextureViewDimensions, undefined])
.combine('viewDimension', [...kTextureViewDimensions, undefined])
.combine('depthOrArrayLayers', [1, 2, 6])
.filter(
({ dimension, textureBindingViewDimension, depthOrArrayLayers, viewDimension }) =>
textureBindingViewDimension !== 'cube-array' &&
viewDimension !== 'cube-array' &&
isTextureBindingViewDimensionCompatibleWithDimension(
dimension,
textureBindingViewDimension
) &&
isValidViewDimensionForDimension(dimension, depthOrArrayLayers, viewDimension) &&
isValidViewDimensionForDepthOrArrayLayers(
textureBindingViewDimension,
depthOrArrayLayers
) &&
isValidDimensionForDepthOrArrayLayers(dimension, depthOrArrayLayers)
)
)
.fn(t => {
const { dimension, textureBindingViewDimension, viewDimension, depthOrArrayLayers } = t.params;
const texture = t.device.createTexture({
size: [1, 1, depthOrArrayLayers],
format: 'rgba8unorm',
usage: GPUTextureUsage.TEXTURE_BINDING,
...(dimension && { dimension }),
...(textureBindingViewDimension && { textureBindingViewDimension }),
} as GPUTextureDescriptor); // MAINTENANCE_TODO: remove cast once textureBindingViewDimension is added to IDL
t.trackForCleanup(texture);
const effectiveTextureBindingViewDimension = getEffectiveTextureBindingViewDimension(
dimension,
texture.depthOrArrayLayers,
textureBindingViewDimension
);
const effectiveViewDimension = getEffectiveTextureBindingViewDimension(
dimension,
texture.depthOrArrayLayers,
viewDimension
);
const layout = t.device.createBindGroupLayout({
entries: [
{
binding: 0,
visibility: GPUShaderStage.COMPUTE,
texture: {
viewDimension: effectiveViewDimensionForTexture(texture, viewDimension),
},
},
],
});
const resource = texture.createView({ dimension: viewDimension });
const shouldError = effectiveTextureBindingViewDimension !== effectiveViewDimension;
t.expectValidationError(() => {
t.device.createBindGroup({
layout,
entries: [{ binding: 0, resource }],
});
}, shouldError);
});
|
