1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
const builtin = 'textureStore';
export const description = `
Validation tests for the ${builtin}() builtin.
* test textureStore coords parameter must be correct type
* test textureStore array_index parameter must be correct type
* test textureStore value parameter must be correct type
`;
import { makeTestGroup } from '../../../../../../common/framework/test_group.js';
import { keysOf, objectsToRecord } from '../../../../../../common/util/data_tables.js';
import { kAllTextureFormats, kTextureFormatInfo } from '../../../../../format_info.js';
import {
Type,
kAllScalarsAndVectors,
isConvertible,
ScalarType,
VectorType,
isUnsignedType,
} from '../../../../../util/conversion.js';
import { ShaderValidationTest } from '../../../shader_validation_test.js';
const kTextureColorTypeToType = {
sint: Type.vec4i,
uint: Type.vec4u,
float: Type.vec4f,
'unfilterable-float': Type.vec4f,
};
type TextureStoreArguments = {
coordsArgTypes: readonly [ScalarType | VectorType, ScalarType | VectorType];
hasArrayIndexArg?: boolean;
};
const kValidTextureStoreParameterTypes: { [n: string]: TextureStoreArguments } = {
texture_storage_1d: { coordsArgTypes: [Type.i32, Type.u32] },
texture_storage_2d: { coordsArgTypes: [Type.vec2i, Type.vec2u] },
texture_storage_2d_array: {
coordsArgTypes: [Type.vec2i, Type.vec2u],
hasArrayIndexArg: true,
},
texture_storage_3d: { coordsArgTypes: [Type.vec3i, Type.vec3u] },
} as const;
const kTextureTypes = keysOf(kValidTextureStoreParameterTypes);
const kValuesTypes = objectsToRecord(kAllScalarsAndVectors);
export const g = makeTestGroup(ShaderValidationTest);
g.test('coords_argument')
.specURL('https://gpuweb.github.io/gpuweb/wgsl/#texturestore')
.desc(
`
Validates that only incorrect coords arguments are rejected by ${builtin}
`
)
.params(u =>
u
.combine('textureType', keysOf(kValidTextureStoreParameterTypes))
.combine('coordType', keysOf(kValuesTypes))
.beginSubcases()
.combine('value', [-1, 0, 1] as const)
// filter out unsigned types with negative values
.filter(t => !isUnsignedType(kValuesTypes[t.coordType]) || t.value >= 0)
)
.fn(t => {
const { textureType, coordType, value } = t.params;
const coordArgType = kValuesTypes[coordType];
const { coordsArgTypes, hasArrayIndexArg } = kValidTextureStoreParameterTypes[textureType];
const coordWGSL = coordArgType.create(value).wgsl();
const arrayWGSL = hasArrayIndexArg ? ', 0' : '';
const format = 'rgba8unorm';
const valueWGSL = 'vec4f(0)';
const code = `
@group(0) @binding(0) var t: ${textureType}<${format},write>;
@fragment fn fs() -> @location(0) vec4f {
textureStore(t, ${coordWGSL}${arrayWGSL}, ${valueWGSL});
return vec4f(0);
}
`;
const expectSuccess =
isConvertible(coordArgType, coordsArgTypes[0]) ||
isConvertible(coordArgType, coordsArgTypes[1]);
t.expectCompileResult(expectSuccess, code);
});
g.test('array_index_argument')
.specURL('https://gpuweb.github.io/gpuweb/wgsl/#texturestore')
.desc(
`
Validates that only incorrect array_index arguments are rejected by ${builtin}
`
)
.params(u =>
u
.combine('textureType', kTextureTypes)
// filter out types with no array_index
.filter(t => !!kValidTextureStoreParameterTypes[t.textureType].hasArrayIndexArg)
.combine('arrayIndexType', keysOf(kValuesTypes))
.beginSubcases()
.combine('value', [-9, -8, 0, 7, 8])
// filter out unsigned types with negative values
.filter(t => !isUnsignedType(kValuesTypes[t.arrayIndexType]) || t.value >= 0)
)
.fn(t => {
const { textureType, arrayIndexType, value } = t.params;
const arrayIndexArgType = kValuesTypes[arrayIndexType];
const args = [arrayIndexArgType.create(value)];
const { coordsArgTypes } = kValidTextureStoreParameterTypes[textureType];
const coordWGSL = coordsArgTypes[0].create(0).wgsl();
const arrayWGSL = args.map(arg => arg.wgsl()).join(', ');
const format = 'rgba8unorm';
const valueWGSL = 'vec4f(0)';
const code = `
@group(0) @binding(0) var t: ${textureType}<${format}, write>;
@fragment fn fs() -> @location(0) vec4f {
textureStore(t, ${coordWGSL}, ${arrayWGSL}, ${valueWGSL});
return vec4f(0);
}
`;
const expectSuccess =
isConvertible(arrayIndexArgType, Type.i32) || isConvertible(arrayIndexArgType, Type.u32);
t.expectCompileResult(expectSuccess, code);
});
g.test('value_argument')
.specURL('https://gpuweb.github.io/gpuweb/wgsl/#texturestore')
.desc(
`
Validates that only incorrect value arguments are rejected by ${builtin}
`
)
.params(u =>
u
.combine('textureType', kTextureTypes)
.combine('valueType', keysOf(kValuesTypes))
.beginSubcases()
.combine('format', kAllTextureFormats)
// filter to only storage texture formats.
.filter(t => !!kTextureFormatInfo[t.format].color?.storage)
.combine('value', [0, 1, 2])
)
.fn(t => {
const { textureType, valueType, format, value } = t.params;
const valueArgType = kValuesTypes[valueType];
const args = [valueArgType.create(value)];
const { coordsArgTypes, hasArrayIndexArg } = kValidTextureStoreParameterTypes[textureType];
const coordWGSL = coordsArgTypes[0].create(0).wgsl();
const arrayWGSL = hasArrayIndexArg ? ', 0' : '';
const valueWGSL = args.map(arg => arg.wgsl()).join(', ');
const code = `
@group(0) @binding(0) var t: ${textureType}<${format}, write>;
@fragment fn fs() -> @location(0) vec4f {
textureStore(t, ${coordWGSL}${arrayWGSL}, ${valueWGSL});
return vec4f(0);
}
`;
const colorType = kTextureFormatInfo[format].color?.type;
const requiredValueType = kTextureColorTypeToType[colorType!];
const expectSuccess = isConvertible(valueArgType, requiredValueType);
t.expectCompileResult(expectSuccess, code);
});
|
