1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
|
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "compiler/translator/ValidateTypeSizeLimitations.h"
#include "angle_gl.h"
#include "compiler/translator/Diagnostics.h"
#include "compiler/translator/Symbol.h"
#include "compiler/translator/SymbolTable.h"
#include "compiler/translator/blocklayout.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
#include "compiler/translator/util.h"
namespace sh
{
namespace
{
// Arbitrarily enforce that all types declared with a size in bytes of over 2 GB will cause
// compilation failure.
//
// For local and global variables, the limit is much lower (1MB) as that much memory won't fit in
// the GPU registers anyway.
constexpr size_t kMaxVariableSizeInBytes = static_cast<size_t>(2) * 1024 * 1024 * 1024;
constexpr size_t kMaxPrivateVariableSizeInBytes = static_cast<size_t>(1) * 1024 * 1024;
// Traverses intermediate tree to ensure that the shader does not
// exceed certain implementation-defined limits on the sizes of types.
// Some code was copied from the CollectVariables pass.
class ValidateTypeSizeLimitationsTraverser : public TIntermTraverser
{
public:
ValidateTypeSizeLimitationsTraverser(TSymbolTable *symbolTable, TDiagnostics *diagnostics)
: TIntermTraverser(true, false, false, symbolTable), mDiagnostics(diagnostics)
{
ASSERT(diagnostics);
}
bool visitDeclaration(Visit visit, TIntermDeclaration *node) override
{
const TIntermSequence &sequence = *(node->getSequence());
for (TIntermNode *variableNode : sequence)
{
// See CollectVariablesTraverser::visitDeclaration for a
// deeper analysis of the AST structures that might be
// encountered.
TIntermSymbol *asSymbol = variableNode->getAsSymbolNode();
TIntermBinary *asBinary = variableNode->getAsBinaryNode();
if (asBinary != nullptr)
{
ASSERT(asBinary->getOp() == EOpInitialize);
asSymbol = asBinary->getLeft()->getAsSymbolNode();
}
ASSERT(asSymbol);
const TVariable &variable = asSymbol->variable();
if (variable.symbolType() == SymbolType::AngleInternal)
{
// Ignore internal variables.
continue;
}
const TType &variableType = asSymbol->getType();
// Create a ShaderVariable from which to compute
// (conservative) sizing information.
ShaderVariable shaderVar;
setCommonVariableProperties(variableType, variable, &shaderVar);
// Compute the std140 layout of this variable, assuming
// it's a member of a block (which it might not be).
Std140BlockEncoder layoutEncoder;
BlockEncoderVisitor visitor("", "", &layoutEncoder);
// Since the size limit's arbitrary, it doesn't matter
// whether the row-major layout is correctly determined.
bool isRowMajorLayout = false;
TraverseShaderVariable(shaderVar, isRowMajorLayout, &visitor);
if (layoutEncoder.getCurrentOffset() > kMaxVariableSizeInBytes)
{
error(asSymbol->getLine(),
"Size of declared variable exceeds implementation-defined limit",
asSymbol->getName());
return false;
}
const bool isPrivate = variableType.getQualifier() == EvqTemporary ||
variableType.getQualifier() == EvqGlobal ||
variableType.getQualifier() == EvqConst;
if (layoutEncoder.getCurrentOffset() > kMaxPrivateVariableSizeInBytes && isPrivate)
{
error(asSymbol->getLine(),
"Size of declared private variable exceeds implementation-defined limit",
asSymbol->getName());
return false;
}
}
return true;
}
private:
void error(TSourceLoc loc, const char *reason, const ImmutableString &token)
{
mDiagnostics->error(loc, reason, token.data());
}
void setFieldOrVariableProperties(const TType &type,
bool staticUse,
bool isShaderIOBlock,
bool isPatch,
ShaderVariable *variableOut) const
{
ASSERT(variableOut);
variableOut->staticUse = staticUse;
variableOut->isShaderIOBlock = isShaderIOBlock;
variableOut->isPatch = isPatch;
const TStructure *structure = type.getStruct();
const TInterfaceBlock *interfaceBlock = type.getInterfaceBlock();
if (structure)
{
// Structures use a NONE type that isn't exposed outside ANGLE.
variableOut->type = GL_NONE;
if (structure->symbolType() != SymbolType::Empty)
{
variableOut->structOrBlockName = structure->name().data();
}
const TFieldList &fields = structure->fields();
for (const TField *field : fields)
{
// Regardless of the variable type (uniform, in/out etc.) its fields are always
// plain ShaderVariable objects.
ShaderVariable fieldVariable;
setFieldProperties(*field->type(), field->name(), staticUse, isShaderIOBlock,
isPatch, &fieldVariable);
variableOut->fields.push_back(fieldVariable);
}
}
else if (interfaceBlock && isShaderIOBlock)
{
variableOut->type = GL_NONE;
if (interfaceBlock->symbolType() != SymbolType::Empty)
{
variableOut->structOrBlockName = interfaceBlock->name().data();
}
const TFieldList &fields = interfaceBlock->fields();
for (const TField *field : fields)
{
ShaderVariable fieldVariable;
setFieldProperties(*field->type(), field->name(), staticUse, true, isPatch,
&fieldVariable);
fieldVariable.isShaderIOBlock = true;
variableOut->fields.push_back(fieldVariable);
}
}
else
{
variableOut->type = GLVariableType(type);
variableOut->precision = GLVariablePrecision(type);
}
const TSpan<const unsigned int> &arraySizes = type.getArraySizes();
if (!arraySizes.empty())
{
variableOut->arraySizes.assign(arraySizes.begin(), arraySizes.end());
// WebGL does not support tessellation shaders; removed
// code specific to that shader type.
}
}
void setFieldProperties(const TType &type,
const ImmutableString &name,
bool staticUse,
bool isShaderIOBlock,
bool isPatch,
ShaderVariable *variableOut) const
{
ASSERT(variableOut);
setFieldOrVariableProperties(type, staticUse, isShaderIOBlock, isPatch, variableOut);
variableOut->name.assign(name.data(), name.length());
}
void setCommonVariableProperties(const TType &type,
const TVariable &variable,
ShaderVariable *variableOut) const
{
ASSERT(variableOut);
// Shortcut some processing that's unnecessary for this analysis.
const bool staticUse = true;
const bool isShaderIOBlock = type.getInterfaceBlock() != nullptr;
const bool isPatch = false;
setFieldOrVariableProperties(type, staticUse, isShaderIOBlock, isPatch, variableOut);
const bool isNamed = variable.symbolType() != SymbolType::Empty;
if (isNamed)
{
variableOut->name.assign(variable.name().data(), variable.name().length());
}
}
TDiagnostics *mDiagnostics;
std::vector<int> mLoopSymbolIds;
};
} // namespace
bool ValidateTypeSizeLimitations(TIntermNode *root,
TSymbolTable *symbolTable,
TDiagnostics *diagnostics)
{
ValidateTypeSizeLimitationsTraverser validate(symbolTable, diagnostics);
root->traverse(&validate);
return diagnostics->numErrors() == 0;
}
} // namespace sh
|
