1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
|
/**
* @fileoverview Require use of Services.* rather than getService.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
const helpers = require("../helpers");
let servicesInterfaceMap = helpers.servicesData;
module.exports = {
meta: {
docs: {
url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/rules/use-services.html",
},
// fixable: "code",
messages: {
useServices:
"Use Services.{{ serviceName }} rather than {{ getterName }}.",
},
schema: [],
type: "suggestion",
},
create(context) {
return {
CallExpression(node) {
if (!node.callee || !node.callee.property) {
return;
}
if (
node.callee.property.type == "Identifier" &&
node.callee.property.name == "defineLazyServiceGetter" &&
node.arguments.length == 4 &&
node.arguments[3].type == "Literal" &&
node.arguments[3].value in servicesInterfaceMap
) {
let serviceName = servicesInterfaceMap[node.arguments[3].value];
context.report({
node,
messageId: "useServices",
data: {
serviceName,
getterName: "defineLazyServiceGetter",
},
});
return;
}
if (
node.callee.property.type == "Identifier" &&
node.callee.property.name == "defineLazyServiceGetters" &&
node.arguments.length == 2 &&
node.arguments[1].type == "ObjectExpression"
) {
for (let property of node.arguments[1].properties) {
if (
property.value.type == "ArrayExpression" &&
property.value.elements.length == 2 &&
property.value.elements[1].value in servicesInterfaceMap
) {
let serviceName =
servicesInterfaceMap[property.value.elements[1].value];
context.report({
node: property.value,
messageId: "useServices",
data: {
serviceName,
getterName: "defineLazyServiceGetters",
},
});
}
}
return;
}
if (
node.callee.property.type != "Identifier" ||
node.callee.property.name != "getService" ||
node.arguments.length != 1 ||
!node.arguments[0].property ||
node.arguments[0].property.type != "Identifier" ||
!node.arguments[0].property.name ||
!(node.arguments[0].property.name in servicesInterfaceMap)
) {
return;
}
let serviceName = servicesInterfaceMap[node.arguments[0].property.name];
context.report({
node,
messageId: "useServices",
data: {
serviceName,
getterName: "getService()",
},
// This is not enabled by default as for mochitest plain tests we
// would need to replace with `SpecialPowers.Services.${serviceName}`.
// At the moment we do not have an easy way to detect that.
// fix(fixer) {
// let sourceCode = context.getSourceCode();
// return fixer.replaceTextRange(
// [
// sourceCode.getFirstToken(node.callee).range[0],
// sourceCode.getLastToken(node).range[1],
// ],
// `Services.${serviceName}`
// );
// },
});
},
};
},
};
|
