1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
|
# -*- coding: utf-8 eval: (blacken-mode 1) -*-
# SPDX-License-Identifier: ISC
#
# June 10 2023, Christian Hopps <chopps@labn.net>
#
# Copyright (c) 2023, LabN Consulting, L.L.C.
#
"""
Test mgmtd parsing of configs.
So:
MGMTD matches zebra:
one exit file: ONE: vty -f file
one exit redir: ONE: vty < file
early exit file: ONE: vty -f file
early exit redir: ONE: vty < file
early end file: ALL: vty -f file
early end redir: ONE: vty < file
Raw tests:
FAILED mgmt_config/test_config.py::test_mgmtd_one_exit_file - AssertionError: vtysh < didn't work after exit
FAILED mgmt_config/test_config.py::test_mgmtd_one_exit_redir - AssertionError: vtysh < didn't work after exit
FAILED mgmt_config/test_config.py::test_mgmtd_early_exit_file - AssertionError: vtysh -f didn't work after 1 exit
FAILED mgmt_config/test_config.py::test_mgmtd_early_exit_redir - AssertionError: vtysh < didn't work after 1 exits
FAILED mgmt_config/test_config.py::test_mgmtd_early_end_redir - AssertionError: vtysh < didn't work after 1 end
FAILED mgmt_config/test_config.py::test_zebra_one_exit_file - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_one_exit_redir - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_exit_file - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_exit_redir - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_end_redir - AssertionError: zebra second conf missing
Before fixed:
one exit file: NONE: vty -f file
early exit file: NONE: vty -f file
FAILED mgmt_config/test_config.py::test_mgmtd_one_exit_file - AssertionError: vtysh -f didn't work before exit
FAILED mgmt_config/test_config.py::test_mgmtd_one_exit_redir - AssertionError: vtysh < didn't work after exit
FAILED mgmt_config/test_config.py::test_mgmtd_early_exit_file - AssertionError: vtysh -f didn't work before exit
FAILED mgmt_config/test_config.py::test_mgmtd_early_exit_redir - AssertionError: vtysh < didn't work after 1 exits
FAILED mgmt_config/test_config.py::test_mgmtd_early_end_redir - AssertionError: vtysh < didn't work after 1 end
FAILED mgmt_config/test_config.py::test_zebra_one_exit_file - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_one_exit_redir - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_exit_file - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_exit_redir - AssertionError: zebra second conf missing
FAILED mgmt_config/test_config.py::test_zebra_early_end_redir - AssertionError: zebra second conf missing
"""
import ipaddress
import logging
import os
import re
from pathlib import Path
import pytest
from lib.common_config import retry, step
from lib.topogen import Topogen, TopoRouter
# pytestmark = [pytest.mark.staticd, pytest.mark.mgmtd]
pytestmark = [pytest.mark.staticd]
@retry(retry_timeout=1, initial_wait=0.1)
def check_kernel(r1, prefix, expected=True):
net = ipaddress.ip_network(prefix)
if net.version == 6:
kernel = r1.cmd_nostatus("ip -6 route show", warn=not expected)
else:
kernel = r1.cmd_nostatus("ip -4 route show", warn=not expected)
logging.debug("checking kernel routing table:\n%0.1920s", kernel)
route = f"{str(net)}(?: nhid [0-9]+)?.*proto (static|196)"
m = re.search(route, kernel)
if expected and not m:
return f"Failed to find \n'{route}'\n in \n'{kernel:.1920}'"
elif not expected and m:
return f"Failed found \n'{route}'\n in \n'{kernel:.1920}'"
return None
@pytest.fixture(scope="module")
def tgen(request):
"Setup/Teardown the environment and provide tgen argument to tests"
topodef = {"s1": ("r1",)}
tgen = Topogen(topodef, request.module.__name__)
tgen.start_topology()
# configure mgmtd using current mgmtd config file
tgen.gears["r1"].load_config(TopoRouter.RD_ZEBRA, "zebra.conf")
tgen.gears["r1"].load_config(TopoRouter.RD_MGMTD)
tgen.start_router()
yield tgen
tgen.stop_topology()
def save_log_snippet(logfile, content, savepath=None):
os.sync()
os.sync()
os.sync()
with open(logfile, encoding="utf-8") as f:
buf = f.read()
assert content == buf[: len(content)]
newcontent = buf[len(content) :]
if savepath:
with open(savepath, "w", encoding="utf-8") as f:
f.write(newcontent)
return buf
def mapname(lname):
return lname.replace(".conf", "") + "-log.txt"
logbuf = ""
@pytest.fixture(scope="module")
def r1(tgen):
return tgen.gears["r1"].net
@pytest.fixture(scope="module")
def confdir():
return Path(os.environ["PYTEST_TOPOTEST_SCRIPTDIR"]) / "r1"
@pytest.fixture(scope="module")
def tempdir(r1):
return Path(r1.rundir)
@pytest.fixture(scope="module")
def logpath(tempdir):
return tempdir / "mgmtd.log"
@pytest.fixture(autouse=True, scope="function")
def cleanup_config(r1, tempdir, logpath):
global logbuf
logbuf = save_log_snippet(logpath, logbuf, "/dev/null")
yield
r1.cmd_nostatus("vtysh -c 'conf t' -c 'no allow-external-route-update'")
r1.cmd_nostatus("vtysh -c 'conf t' -c 'no ip multicast rpf-lookup-mode urib-only'")
r1.cmd_nostatus("vtysh -c 'conf t' -c 'no ip table range 2 3'")
logbuf = save_log_snippet(logpath, logbuf, "/dev/null")
def test_staticd_startup(r1):
r1.cmd_nostatus(
"vtysh -c 'debug mgmt client frontend' "
"-c 'debug mgmt client backend' "
"-c 'debug mgmt backend frontend datastore transaction'"
)
step("Verifying routes are present on r1")
result = check_kernel(r1, "12.0.0.0/24", retry_timeout=3.0)
assert result is None
def test_mgmtd_one_exit_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "one-exit.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "20.1.0.0/24")
result2 = check_kernel(r1, "20.2.0.0/24")
assert result1 is None, "vtysh -f didn't work before exit"
assert result2 is not None, "vtysh < worked after exit, unexpected"
def test_mgmtd_one_exit_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "one-exit2.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "21.1.0.0/24")
result2 = check_kernel(r1, "21.2.0.0/24")
assert result1 is None, "vtysh < didn't work before exit"
assert result2 is not None, "vtysh < worked after exit, unexpected"
def test_mgmtd_early_exit_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-exit.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "13.1.0.0/24")
result2 = check_kernel(r1, "13.2.0.0/24")
result3 = check_kernel(r1, "13.3.0.0/24")
assert result1 is None, "vtysh -f didn't work before exit"
assert result2 is not None, "vtysh -f worked after 1 exit, unexpected"
assert result3 is not None, "vtysh -f worked after 2 exit, unexpected"
def test_mgmtd_early_exit_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-exit2.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "14.1.0.0/24")
result2 = check_kernel(r1, "14.2.0.0/24")
result3 = check_kernel(r1, "14.3.0.0/24")
assert result1 is None, "vtysh < didn't work before exit"
assert result2 is not None, "vtysh < worked after 1 exits, unexpected"
assert result3 is not None, "vtysh < worked after 2 exits, unexpected"
def test_mgmtd_early_end_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-end.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "15.1.0.0/24")
result2 = check_kernel(r1, "15.2.0.0/24")
result3 = check_kernel(r1, "15.3.0.0/24")
assert result1 is None, "vtysh -f didn't work before end"
assert result2 is None, "vtysh -f didn't work after 1 end"
assert result3 is None, "vtysh -f didn't work after 2 ends"
def test_mgmtd_early_end_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-end2.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
result1 = check_kernel(r1, "16.1.0.0/24")
result2 = check_kernel(r1, "16.2.0.0/24")
result3 = check_kernel(r1, "16.3.0.0/24")
assert result1 is None, "vtysh < didn't work before end"
assert result2 is not None, "vtysh < worked after 1 end, unexpected"
assert result3 is not None, "vtysh < worked after 2 end, unexpected"
#
# Zebra
#
def test_zebra_one_exit_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "one-exit-zebra.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" not in showrun
), "zebra second conf present, unexpected"
def test_zebra_one_exit_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "one-exit2-zebra.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" not in showrun
), "zebra second conf present, unexpected"
def test_zebra_early_exit_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-exit-zebra.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" not in showrun
), "zebra second conf present, unexpected"
assert "ip table range 2 3" not in showrun, "zebra third conf present, unexpected"
def test_zebra_early_exit_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-exit2-zebra.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" not in showrun
), "zebra second conf present, unexpected"
assert "ip table range 2 3" not in showrun, "zebra third conf present, unexpected"
def test_zebra_early_end_file(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-end-zebra.conf"
step(f"load {conf} file with vtysh -f ")
output = r1.cmd_nostatus(f"vtysh -f {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" in showrun
), "zebra second conf missing"
assert "ip table range 2 3" in showrun, "zebra third missing"
def test_zebra_early_end_redir(r1, confdir, tempdir, logpath):
global logbuf
conf = "early-end2-zebra.conf"
step(f"Redirect {conf} file into vtysh")
output = r1.cmd_nostatus(f"vtysh < {confdir / conf}")
logbuf = save_log_snippet(logpath, logbuf, tempdir / mapname(conf))
print(output)
showrun = r1.cmd_nostatus("vtysh -c 'show running'")
assert "allow-external-route-update" in showrun, "zebra conf missing"
assert (
"ip multicast rpf-lookup-mode urib-only" not in showrun
), "zebra second conf present, unexpected"
assert "ip table range 2 3" not in showrun, "zebra third conf present, unexpected"
|