summaryrefslogtreecommitdiffstats
path: root/ChangeLog
diff options
context:
space:
mode:
authorDaniel Baumann <daniel.baumann@progress-linux.org>2024-06-07 11:48:25 +0000
committerDaniel Baumann <daniel.baumann@progress-linux.org>2024-06-07 11:48:25 +0000
commit9c0049cfae49c8e4ddef9125a69db2ad134c10c6 (patch)
tree812a86c0eee63dfc5ace12f2622ed3ce9cd3d680 /ChangeLog
parentReleasing progress-linux version 4:24.2.3-2~progress7.99u1. (diff)
downloadlibreoffice-9c0049cfae49c8e4ddef9125a69db2ad134c10c6.tar.xz
libreoffice-9c0049cfae49c8e4ddef9125a69db2ad134c10c6.zip
Merging upstream version 4:24.2.4.
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog3495
1 files changed, 3325 insertions, 170 deletions
diff --git a/ChangeLog b/ChangeLog
index d745cd5be8..843b5c3e0d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,22 +1,2564 @@
-2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba]
+2024-06-04 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2]
- Version 24.2.3.2, tag libreoffice-24.2.3.2
+ Version 24.2.4.2, tag libreoffice-24.2.4.2
-2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [890ac6263b2f3348ddfe11075c921d8454bc2826]
+2024-06-04 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [69c2282cfeb53fd81e98b50fd2ca17249a13169b]
- bump product version to 24.2.3.2
+ bump product version to 24.2.4.2
- Change-Id: Ie10184cc8b4b860b20a270f8845d1059ce93a6d8
+ Change-Id: If08c87acc1f5bcc55a05f015806bf50bc99acd2d
-2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [ab4fd05c26289147ac1cab686a93a84fda85be5f]
+2024-06-04 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [e3ce5d358dcf7cac002bee7b0c885a3d19859f57]
+
+ Update git submodules
+
+ * Update translations from branch 'libreoffice-24-2-4'
+ to 3357c0b88c8b0d218ccc7c40558a9ee8cd4612ea
+ - update translations for 24.2.4 rc2
+
+ and force-fix errors using pocheck
+
+ Change-Id: Iecf863e23df6934c7fc9125f9eda4ec05c26739f
+ (cherry picked from commit 8bde22939d49fb6cebb30841b269b1625c07eb5a)
+
+2024-06-04 Justin Luth <jluth@mail.com> [df737dc40e47322f1d6f2a3a3fbd08373125eafd]
+
+ Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"
+
+ This reverts my 24.2 commit e58e251756ecb0312cb6891d4df23e17ef8f6fcb.
+
+ Unintended side affect in Draw (not Writer) sidebar.
+
+ Change-Id: I948263c1e8be1202e0504f109d84ce4469ddf45d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167970
+ Reviewed-by: Justin Luth <jluth@mail.com>
+ Tested-by: Jenkins
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167973
+ (cherry picked from commit 5777b30375df6b34568cf88cc3701513635eace1)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168325
+ Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-06-04 Xisco Fauli <xiscofauli@libreoffice.org> [982cf82f52935057ac94334a608f6dde99e6c1da]
+
+ sc: check GetActiveViewShell()
+
+ See the recently introduced
+ https://crashreport.libreoffice.org/stats/crash_details/3da2dcd1-ca3e-409a-a665-dcb09d2a3ba0
+
+ Change-Id: If6ddc71bc2946232d57d5fd8fd6029b45b19495f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167903
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167923
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 768823934200096c4bd736526aa9765b1bceb0bb)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167935
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+
+2024-06-04 Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> [1f6b6fb6d8eeacfc5cfe2334d390c9e3fd2815e5]
+
+ tdf#160589: compare the correct OutDev with PageWindows
+
+ Change-Id: I29d9c60cac04536bb2d5ad2ed1c086c8e67a9f20
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166151
+ Tested-by: Jenkins
+ Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
+ (cherry picked from commit 1e1a3825d76ed8071424e8e21bbda23464c10fff)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168317
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit c8d067868792e6de49bde70507bd30261d3fbd3d)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168318
+ Reviewed-by: Hossein <hossein@libreoffice.org>
+ Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-06-04 Xisco Fauli <xiscofauli@libreoffice.org> [23c9e1acf88f772024e930dd2cf3a9e10435a8c3]
+
+ sfx2: warning C6011: Dereferencing NULL pointer
+
+ Change-Id: Ie65284c3ded0c5789f0be5bbd770d190a92fecec
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167922
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167981
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 63870676cda0f36c3763869dfb0fed49da0a2104)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167937
+ Reviewed-by: Hossein <hossein@libreoffice.org>
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+
+2024-06-03 Stephan Bergmann <stephan.bergmann@allotropia.de> [5c9c8a230d9e98c6d54c2ada2d4824e2c20b42c8]
+
+ Consolidate on a single Updater::log overload
+
+ Change-Id: Id812788f30ac4a327d450255cfe19181c69ae81e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168257
+ Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 253bd05e95ae5093e61a4685a9d28f31edc6f585)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168296
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ (cherry picked from commit aff07e946a08608a96fcc853152d0e57b7a00e8e)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168381
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-06-03 Stephan Bergmann <stephan.bergmann@allotropia.de> [b01f7e8f4b931f56a55d5bfc661f7bb7416afa58]
+
+ Make sure updates dir exists when writing updating.log
+
+ Change-Id: Ib652fedde970d01b701ad4b61e75028cd43974f6
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168258
+ Tested-by: Jenkins
+ Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
+ (cherry picked from commit 48190a8f3783135c65538977cd38f34ba733f071)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168297
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ (cherry picked from commit 44d8490f615cd6c56a1336d6d4da10219f572ccb)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168382
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-06-03 Stephan Bergmann <stephan.bergmann@allotropia.de> [ada4296497bae971c3cb293f934f5e6240f23185]
+
+ tdf#161292: Fix create-partial-info for newly added files
+
+ 084c64982ef6187292fd73e6deaa4448e0b6f3de "Create MAR updates from msi rather
+ than from archive" had patched make_add_instruction (in
+ workdir/UnpackedTarball/onlineupdate/tools/update-packagin/common.sh) to
+ unconditionally use add-if (with the file itself as test file) rather than plain
+ add (because we can't reuse Mozilla's extension logic there to determine
+ optional installation parts), and it noted in its commit message that "addition
+ of files will cause a MAR update to miss them".
+
+ Which turned out to be a problem with
+ <https://update-mar.libreoffice.org/24.2.2.2/LibreOffice_24.2.2.2_Windows_X86_64_d56cc158d8a96260b836f100ef4b4ef25d6f1a01_from_bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882_partial.mar>,
+ updating from 24.2.2.1 with instdir/program/python-core-3.8.18/ to 24.2.2.2 with
+ instdir/program/python-core-3.8.19/: All the files in python-core-3.8.19 were
+ recorded as add-if testing on themselves, so were never added.
+
+ So a better approach is, for newly added files to make them add (so they get
+ added unconditionally, even if they are part of some optional component that
+ happens to not be installed; this hopefully won't cause further issues) instead
+ of add-if. (Existing files that are added instead of patched still use add-if,
+ though.) This does not address the create-update-info target for full mar
+ updates (which is not used currently?), just the create-partial-info target.
+
+ (The existing calls to make_add_instruction in the upstream Mozilla code already
+ have a seemingly rotten mix of two-argument calls and calls with three arguments
+ where the third argument is ignored, and would check for a fourth "forced"
+ argument but which is never passed in. So avoid extending that mess further,
+ and just replace this never-use-add-if call to make_add_instruction directly
+ with that function's (accordingly tweaked) body.)
+
+ Change-Id: Ib596f3aa72c3ab9f896b20f7d623bc574eb15fd8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168285
+ Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit c00014019e6d33bfb4729c563062db1645c48e9d)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168310
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ (cherry picked from commit f7bd624cf1f2ad51a5f7d0edf23a1f19a9063823)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168319
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-31 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [cb1ee2011436c6aa45c5a678f41c2f77fc925b63]
+
+ update credits
+
+ Change-Id: I8f3b3bbed98c026302400be448d621ce530d5e79
+ (cherry picked from commit 64bf123ebae9873758c30cb41aaf3a1098c5e678)
+ (cherry picked from commit 6d02039027b245ddcdb72638fd25d5a470d3dc51)
+
+2024-05-31 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [9ceeb2e476d2921fc174280ede09a7b97eb4b1c2]
+
+ Update git submodules
+
+ * Update translations from branch 'libreoffice-24-2-4'
+ to f07002ad3f6f59f2808369beec84ace71b5af5fc
+ - update translations for 24.2.4 rc2
+
+ and force-fix errors using pocheck
+
+ Change-Id: I72d7d0cfe6d2cf73e9d77b235e568607dc2e64ac
+ (cherry picked from commit 70127e22568ed8e3993d85ab681f8e23b2bf1e0b)
+
+2024-05-31 Mike Kaganski <mike.kaganski@collabora.com> [2b4de0e1b2119c82b906c9f4025b7a1ce525aca5]
+
+ Simplify a bit
+
+ And avoid a second call of pObj->GetUserCall.
+
+ Change-Id: I4487ad33df594a8a96b517c5b4671512dea7116d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162042
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ (cherry picked from commit 5703d3af04b8fe78fdd4dbef14b08d8446402779)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167940
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit 660443e38c2d059d557298e1131cf42b96436e30)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168065
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-31 Patrick Luby <guibmacdev@gmail.com> [5949c600f7ca023edeb652677426c7d3e21ad06d]
+
+ Fix some macOS memory leaks due to overretaining Objective-C objects
+
+ Change-Id: If826476ad6c6692d22519f4eb0fb45621240fdbf
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168203
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-27 Patrick Luby <guibmacdev@gmail.com> [92ed1c31467db58d4feca4cf5dc556bac32fcc5e]
+
+ Related tdf#158914: fix memory leaks by calling (auto)release selectors
+
+ Found the following memory leaks using Xcode's Instruments application:
+
+ 1. Posting an NSAccessibilityUIElementDestroyedNotification
+ notification causes [ AquaA11yWrapper isAccessibilityElement ]
+ to be called on the object so mark the object as disposed
+ before posting the destroyed notification and test for disposed
+ in all of the standard NSAccessibility selectors to prevent
+ any calls to likely disposed C++ accessibility objects.
+
+ 2. In [ AquaA11yWrapper accessibilityHitTest: ],
+ [ AquaA11yFactory wrapperForAccessibleContext: ] already retains
+ the returned object so retaining it until the next call to this
+ selector can lead to a memory leak when dragging selected cells
+ in Calc to a new location. So autorelease the object so that
+ transient objects stay alive but not past the next clearing of
+ the autorelease pool.
+
+ 3. [ AquaA11ySelectionWrapper selectedChildrenAttributeForElement: ] is
+ expected to return an autoreleased object.
+
+ 4. [ AquaA11yFactory wrapperForAccessible: ] is not a getter. It
+ expects the caller to release the returned object.
+
+ 5. CreateNSString() is not a getter. It expects the caller to
+ release the returned string.
+
+ Change-Id: I824740d7e3851b0c3e31e2c009860aa822c94222
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168034
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Tested-by: Jenkins
+ (cherry picked from commit 0735a4306da86c6fa0390b85f1f391ec404b2699)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168058
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+
+2024-05-26 Michael Weghorn <m.weghorn@posteo.de> [661eed7b8e5412a0c6f952dc30a529683a2f5986]
+
+ related tdf#158914 sc a11y: Release references when disposing sheet
+
+ Clear all `ScAccessibleCell` references that are owned by
+ `ScAccessibleSpreadsheet` when disposing the sheet instead
+ of when the sheet is deleted.
+
+ While `ScAccessibleSpreadsheet::disposing` is always called,
+ `ScAccessibleSpreadsheet::~ScAccessibleSpreadsheet` is not called
+ until all of the sheet's `ScAccessibleCell` instances have been
+ deleted. So make sure that `ScAccessibleSpreadsheet::disposing`
+ releases all `ScAccessibleCell` references.
+
+ This might possibly reduce some of the leaks mentioned in [1].
+
+ [1] https://gerrit.libreoffice.org/c/core/+/167961/comments/15a6a4e4_91a77291
+
+ Change-Id: Iaf14338945c1899d54c8e7f8a16f38a48316ac98
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167985
+ Tested-by: Jenkins
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ (cherry picked from commit 4d2c41e8171139e210d94b0c3c2b6b3d6392665a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168051
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+
+2024-05-21 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a7fbc89b67189455afaf5681f33db07daf06c28f]
+
+ bump product version to 24.2.4.1.0+
+
+ Change-Id: If9eeaf1eda12619f68d468927a6ba275a05e60e9
+
+2024-05-21 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [44988e22d7e035f4d6c32edf068512bb06e52f4a]
+
+ Branch libreoffice-24-2-4
+
+ This is 'libreoffice-24-2-4' - the stable branch for the 24.2.4 release.
+ Only very safe changes, reviewed by three people are allowed.
+
+ If you want to commit more complicated fix for the next 24.2.x release,
+ please use the 'libreoffice-24-2' branch.
+
+ If you want to build something cool, unstable, and risky, use master.
+
+2024-05-21 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [df5c3afef80d99213e48f5d78228b684e69216ee]
+
+ Update git submodules
+
+ * Update translations from branch 'libreoffice-24-2'
+ to 5569d097c4619640613e373a9d494e380ecf564e
+ - update translations for 24.2.4 rc1
+
+ and force-fix errors using pocheck
+
+ Change-Id: I33b8c9512615cb5d058159e40785d20255b645df
+
+2024-05-21 Xisco Fauli <xiscofauli@libreoffice.org> [75daf23752587c4d4d6ee2dfa697596762ed2321]
+
+ update language-subtag-registry to 2024-05-16
+
+ How the file was created:
+ mkdir data
+ cd data
+ wget
+ https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
+ cd ..
+ tar cvjf language-subtag-registry-2024-05-16.tar.bz data/language-subtag-registry
+
+ Change-Id: I1070881fac9d88508e58715c9a87d547ddf86a50
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167860
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit 02c01942328bd40183a61c054c00d8b292f9dfd0)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167822
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-21 Mike Kaganski <mike.kaganski@collabora.com> [e9e27cc9a8914e97f5ea28de863e580062e030de]
+
+ tdf#161172: Also record history for !bChangeOfListStyleAtParagraph
+
+ Change-Id: I6443d7ef76a27ac3ab75f88edd271a8b36e06c14
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167839
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167818
+
+2024-05-21 Jaume Pujantell <jaume.pujantell@collabora.com> [594f0cfa7f1b7b87e95f1e07af9bc54e36dbfbdf]
+
+ writerfilter: avoid infinit loop when resolving embeddings on docx
+
+ If a docx file contains a loop on the .rels files for headers and/or footers
+ the code would enter an infinite recursion while looking for embeddings.
+
+ Change-Id: I2122fd6b1677812f561e96a9511a61b0e938e94a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167784
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167827
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-20 Thorsten Behrens <thorsten.behrens@allotropia.de> [2cb47c0acae68bb1b7f7aa5ffa9e63fd39b748be]
+
+ backport curl_easy_setopt changes
+
+ This reverts commit d95ac1c608caba9cabaa503f1a5589285547aed5.
+
+ Change-Id: I4bc104272d4c41efab1a7e5eae78267675c1b32b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167753
+ Tested-by: Jenkins
+ Reviewed-by: Andras Timar <andras.timar@collabora.com>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167805
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-20 Eike Rathke <erack@redhat.com> [a710956f628418a8a74f5ad3636a046eaa69fd15]
+
+ Resolves: tdf#160804 sc: ResizeMatrix: Use document grammar
+
+ API grammar (old GRAM_PODF_A1) here was always wrong and could
+ never had matched the formula string obtained from the document,
+ but in earlier days array separators weren't configurable so this
+ may have worked accidentally.. Likely GRAM_PODF_A1 was introduced
+ being confused by existance of older bApi parameter that never was
+ true though and got eliminated later.
+
+ Change-Id: Ie77ad4047c21d999bea1ff97c7c2b451f01121eb
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167844
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+ Tested-by: Jenkins
+ (cherry picked from commit d4ae5abb4d00cc8adb3c45a9410fc71e56211c46)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167817
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-20 László Németh <nemeth@numbertext.org> [2f51031f05dec2f21b8f587eafa7c399d6e4b19e]
+
+ Update git submodules
+
+ * Update dictionaries from branch 'libreoffice-24-2'
+ to 7081a63e0740588f7454bdd8c9d5bb3d64c69e2b
+ - Updated Hungarian hyphenation dictionary to version v20240321
+
+ source: https://sourceforge.net/projects/magyarispell/files/OOo%20Huhyphn/v20240321-0.1/
+ Change-Id: If470f5854511cac6f0a355e4d006abf9e3976f90
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/165166
+ Tested-by: László Németh <nemeth@numbertext.org>
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ (cherry picked from commit 491736b0e775f7d4a0bfd9ed9ce94ec296e3e988)
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/167821
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-20 László Németh <nemeth@numbertext.org> [f4cc60aae383fc560060f1d261d71ce05bad862d]
+
+ Update git submodules
+
+ * Update dictionaries from branch 'libreoffice-24-2'
+ to 597f89a149f2c442df2bc68037e42b6caa4abdb3
+ - Hungarian dictionary v1.8.1
+
+ Added new words, fixes, and decomposition data of ~6500 compound words
+ for better hyphenation. See tdf#158885 for COMPOUNDLEFTHYPHENMIN
+ implementation in LibreOffice, where Hunspell filters out compound word
+ boundaries from libhyphen-based hyphenation breaks, restricting hyphenation
+ near the compound boundary according to spelling and typography rules.
+
+ Change-Id: I22a7b70513d0a59d7a31462fcb46efd53cfe8ad7
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/165439
+ Tested-by: László Németh <nemeth@numbertext.org>
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ (cherry picked from commit c5b2a36bde02841590b8ccc490ca88bfdb69f153)
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/167820
+ Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-20 Marco A.G.Pinto <marcoagpinto@sapo.pt> [87c284c6b9fdaee7dff6978da8069f5c1055f2e9]
+
+ Update git submodules
+
+ * Update dictionaries from branch 'libreoffice-24-2'
+ to 682575dfd5d336b1d42bbecbe46dddcec2c0e183
+ - Updated the English dictionaries: GB+ZA (2024.05.01)
+
+ Change-Id: Ie9586a0ff5a823893e059c0190f9239548448173
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/167028
+ Reviewed-by: Aron Budea <aron.budea@collabora.com>
+ Tested-by: Aron Budea <aron.budea@collabora.com>
+ (cherry picked from commit 7272a82714ca91947b4573c09bce4938861a9877)
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/167819
+ Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-20 Khaled Hosny <khaled@libreoffice.org> [af319f4122aab98d44e88e8d582c109096c57049]
+
+ tdf#160884: Apply scale to position of embedded images in Type 3 fonts
+
+ Regression from:
+
+ commit bc3f6c3a47411a3b5dafadca4e5c55cd24e30662
+ Author: Khaled Hosny <khaled@libreoffice.org>
+ Date: Tue Aug 22 10:47:33 2023 +0300
+
+ tdf#155610: Workaround Acrobat bug with Type 3 fonts and unusual UPEM
+
+ Change-Id: I5e352292268d19fb8348a038d251f2d395a0be46
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167830
+ Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
+ Reviewed-by: خالد حسني <khaled@libreoffice.org>
+ Tested-by: Jenkins
+ (cherry picked from commit 44f2bc12779645bce1000289caf9c66804ecb14e)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167815
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-19 Caolán McNamara <caolan.mcnamara@collabora.com> [bf877f3e10c3a2ce7267335a0c9c7cd828c373ca]
+
+ Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state
+
+ and not if it is implied to be toggled on by SwFormatFrameSize::SYNCED
+ in which case on "ok" FN_KEEP_ASPECT_RATIO is set from the ui state
+
+ so both tdf#151382 and tdf132591 work
+
+ Change-Id: I039de0e8f0f9adcc3c02f0e07c12d83cd807887b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167816
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-19 Caolán McNamara <caolan.mcnamara@collabora.com> [7472bf01dee87a45aa3345397ae6f072f5d57058]
+
+ Resolves: tdf#161133 read-only widget should have deactivated calendar
+
+ a problem since:
+
+ commit 6e7e19d9c300dbdd279789b09f94781e946fad52
+ Date: Wed Jul 15 12:10:32 2020 +0100
+
+ weld DateControl
+
+ Change-Id: I367c4237903655ad02c0c4af70ae0383b8a89f25
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167811
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-19 Caolán McNamara <caolan.mcnamara@collabora.com> [07e6ed881032d1df3ec96c93f5e6c502e021eeb6]
+
+ Resolves: tdf#157453 support FM_PROP_LINECOUNT for combobox dropdow rows
+
+ Change-Id: I3d18ed505c2eea7305903f9a476c332db0148113
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167814
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-18 Michael Stahl <michael.stahl@allotropia.de> [b01d89eaf473870281f6ecbdeb12aa3fcd79f9bb]
+
+ tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists
+
+ The first commit made the start and end node of the paste look like the
+ list it was inserted into, but the middle nodes may have different
+ paragraph styles and may have different left margin / first line indent.
+
+ In addition to the SwNumRule, also copy any left margin or first line
+ indent if it is effective on the node that the SwNumRule was taken from.
+
+ Now all the list labels should be in the same place.
+
+ Change-Id: Ia5794687ea0ff542f23289b1ca63ea99dae85bc3
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167777
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 2bcaa374ea418cd81f9dbf62cd7e896f5977992a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167810
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-18 Michael Stahl <michael.stahl@allotropia.de> [2e2ea78e585d469373c038aa12c5b99909a018c8]
+
+ tdf#161137 sw: fix AutoText or Paste overriding paragraph indents
+
+ The problem is that when a paragraph style specifies a SwNumRule, then
+ this style's indents override the indents of the SwNumRule, but if the
+ same SwNumRule is also added to the SwTextNode's mpAttrSet, then the
+ style's indents no longer take effect.
+
+ This happens both when inserting an AutoText, and when Pasting, into a
+ list item, because DocumentContentOperationsManager::CopyImplImpl()
+ sets the pNumRuleToPropagate as direct formatting on every pasted node.
+
+ Add another flag to SwDoc::SetNumRule() to check if pNumRuleToPropagate
+ was already in effect due to the paragraph style.
+
+ Change-Id: Id98ad2a21eab4f8636fb36f9298a054cfe4f7784
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167766
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 7698f386413e514a4478a1af69a8a3be93dfecab)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167689
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-18 Xisco Fauli <xiscofauli@libreoffice.org> [e9cec488461b1610091f43b4a837e2338fd1cf91]
+
+ tdf#155651: Add support for "context-fill"
+
+ Change-Id: I6f96cc7c059ece5f9401fc0ae552cf279e53109c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167230
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Tested-by: Jenkins
+ (cherry picked from commit 3b0f96a0773f19f7d5bdb5725ff9667eb4809215)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167218
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-18 Michael Stahl <michael.stahl@allotropia.de> [99ad44515c45e98635d382ebfec82b0a09217f9e]
+
+ sw: make testTdf131963 less strict
+
+ Asserting number of pages is rather questionable because any number of
+ things can change that and you will spend days debugging that.
+
+ For some reason this test has 12 pages on my libreoffice-24-2 branch
+ build and 11 pages on my master build, either of which are clearly
+ better than the 2 pages result of the bug that was fixed there.
+
+ Change-Id: Ie1e97d5cc973f317a2d6ca8a7d13822385b134f4
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167627
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 9aa22abcbdfe42e516ecc791605e3a1b7ef80327)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167465
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-18 Michael Stahl <michael.stahl@allotropia.de> [d632d86579467941ce8b3dda1dbd46c83a92877a]
+
+ writerfilter: fix parsing of invalid STYLEREF field
+
+ forum-mso-en-3309.docx contains a funny field that doesn't follow
+ the grammar in the OOXML spec:
+
+ STYLEREF \t "Heading 1" \* MERGEFORMAT
+
+ Word can evaluate it and find the paragraph, so make the parser a bit
+ more flexible, by adding known switches that don't have arguments, so
+ that any argument following these becomes a field argument,
+ for now only for STYLEREF.
+
+ (regression from commit d4fdafa103bfea94a279d7069ddc50ba92f67d01)
+
+ Change-Id: Ic42cd2be58fd65a817946e21a9661d357b02a99a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167697
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 5ae1379fcdd00228e683ae90991e275f570cd92d)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167733
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-18 Michael Weghorn <m.weghorn@posteo.de> [9497be2e668c19aedc588588bf9dfed9338afe54]
+
+ tdf#160565 tdf#145735 qt: Avoid native window handles for Qt 6
+
+ Similar to the tdf#122293 scenario with Qt 5 on Wayland,
+ using native windows causes unresponsive UI even with
+ the xcb Qt QPA plugin when using Qt 6.
+
+ Therefore, don't call `QWidget::winId()` at all when
+ using Qt 6, but just refuse to resolve a native window
+ handle, the same way that is already done here for the
+ wayland Qt QPA plugin with qt5.
+
+ Add a comment based on the one originally added with
+
+ commit 0e3c3b842e14b9646d3697cf1266be21359e0f13
+ Author: Michael Weghorn <m.weghorn@posteo.de>
+ Date: Sat May 11 21:31:33 2019 +0200
+
+ tdf#122293 qt5: Use "alien widgets" by default on Wayland
+
+ that was later dropped during a refactoring.
+
+ This code path is triggered when trying to resolve the
+ parent window for a file picker (s. `QtFilePicker::initialize`).
+ In a quick test in a KDE Plasma 5 Wayland session on Debian testing,
+ the modality behavior was unchanged with or without this change in
+ place:
+
+ * With qt6 xcb, the main window nicely gets grayed out and is
+ unresponsive while the file dialog gets shown when using
+ e.g. "File" -> "Open" in Writer.
+
+ * With qt6 wayland, the main window is not grayed out and looks
+ more "active" still, but doesn't actually accept keyboard
+ or mouse input.
+
+ This is basically the same in other Qt/KDE applications, e.g.
+ a self-compiled Kate from git master, so not LO-specific.
+
+ If resolving the parent for the file picker turns out to be necessary,
+ maybe something similar to what commit
+
+ commit 3ff4800fe400de916c97f587322104af06cc0879
+ Author: Caolán McNamara <caolanm@redhat.com>
+ Date: Wed Apr 4 10:22:34 2018 +0100
+
+ weld SvInsertOleDlg
+
+ and
+
+ weld SfxInsertFloatingFrameDialog
+
+ and smuggle in the parent widget for the Gtk File dialog via
+ an XWindow interface
+
+ did for gtk3 might be worth looking into.
+
+ However, I can at least not reproduce issues like the one described
+ for gtk3 in
+
+ commit 203d96787969f707c78101be18d51b44ace98f93
+ Author: Caolán McNamara <caolanm@redhat.com>
+ Date: Mon Jun 21 13:01:52 2021 +0100
+
+ give folderpicker an optional parent
+
+ so, like a file picker, it can make its parent modal while its
+ operating. Otherwise its possible to interact with the parent dialog in
+ undesirable ways, e.g. file, export as, export as epub, the folder
+ picker of 'media directory'
+
+ with the qt6 VCL plugin even with this commit in place.
+
+ Another scenario relying on a native window handle is video
+ playback with GStreamer's x11 video sink.
+
+ That still works for qt5 with the xcb plugin as the handle is
+ still returned for that one.
+
+ For qt6 with the xcb plugin, that didn't work properly
+ without this commit either (at least not in my tests with
+ current qtbase dev as of commit
+ 70a2e7f32b9f9ce19d1538f14fbde7b0d1e77ffd), s.
+ tdf#145735 comment 7.
+ It's now broken a different way than before
+ (extra windows show up instead of no video being shown).
+ This will be further tracked together with a solution for
+ Wayland in tdf#125219.
+
+ As a side note, forcing native windows for everything
+ using `QT_USE_NATIVE_WINDOWS=1` as described at [1]
+ causes more sever brokenness with the qt6 xcb plugin
+ (mostly black window in Writer instead of showing the
+ actual content).
+
+ [1] https://doc.qt.io/qt-6/qwidget.html#native-widgets-vs-alien-widgets
+
+ Change-Id: I9718c680bd8bc4ff0574f171403d965c1beac781
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167783
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 2f4103da5625a9b90eb41d5c767a248a8d0b4255)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167813
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-17 Noel Grandin <noel.grandin@collabora.co.uk> [ab69de0e0aa0c9e48355c9db36c8aa9b93f235d4]
+
+ tdf#161019 tdf#159846 spreadsheet border rendering
+
+ regression from
+ commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a
+ Author: Noel Grandin <noel.grandin@collabora.co.uk>
+ Date: Mon Jun 19 12:23:55 2023 +0200
+ tdf#150534 reduce the memory consumption of cells when calculating
+
+ Change-Id: Id8b52a3a0880bbb6a7aff28f55bcd57cb1cae048
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167617
+ Tested-by: Jenkins
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit 6f8a73a379d97829080367b21d54f9b5fab781c9)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167682
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-17 Miklos Vajna <vmiklos@collabora.com> [9b508c45a7c30a5c1847b7d93f2a26a653102588]
+
+ tdf#160952 sw: ignore top margin only at page top, not in fly
+
+ See
+ <https://gerrit.libreoffice.org/c/core/+/167671/2#message-8603b129dd8bd72608259571056ded950182ca96>,
+ multi-column shape text can't appear in DOCX files, so collapsing upper
+ spacing in that case is not correct, avoid it.
+
+ Change-Id: Icf69c8d84fdd15d6e3289ff614b2f6ba7cee1e0e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167758
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit b969e692000f50aafacc2eb577f545b8836dcc26)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167683
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-16 Mike Kaganski <mike.kaganski@collabora.com> [324c1a72961ccc1af1c496689c558aa127ef3d81]
+
+ tdf#161035: The previous bookmarks can legitimately be not processed
+
+ The enumeration may be called for a partial paragraph selection, and
+ then the bookmarks prior to the selection are not processed.
+
+ Change-Id: Ib725ffb320ec5a81b39ce77f06392a82bd6d8ee0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167720
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Tested-by: Jenkins
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167754
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-16 Michael Weghorn <m.weghorn@posteo.de> [6460b76852b69f428ed26aba3877e9853ec22555]
+
+ tdf#157009 android: Add icon symlink for F-Droid
+
+ Add a symlink to the app icon at the expected
+ location when using the Triple-T data structure
+ that can be used to provide metadata for F-Droid. [1]
+
+ As Android Viewer currently uses a non-default directory layout,
+ this currently needs to be placed in a different subdirectory than
+ the actual source code in order for F-Droid to find it, see the
+ discussion in [2] for more details.
+
+ This should cause the app icon to show up in F-Droid
+ after the next update.
+
+ [1] https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#triple-t-structure
+ [2] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643#note_1538888683
+
+ Change-Id: Ic1a987e430b6e92134ac19d7f1c264953cd3cf0c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167732
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 69189de8fa9a9d4973a4304a82780d32e79fbe6f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167679
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-16 Xisco Fauli <xiscofauli@libreoffice.org> [79be57a37c5db33dc25f22d90e5fe54cca1e0bd8]
+
+ Fix UBSan failure (part 2)
+
+ Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e
+ "sw: check GetUserCall"
+
+ https: //gerrit.libreoffice.org/c/core/+/166824/comments/8db24a41_2f4e7e4e
+ Change-Id: Ib6f981aa3055f0d37d0b83e3284842d310fe6ef0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166913
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167002
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-16 Xisco Fauli <xiscofauli@libreoffice.org> [118bde319d10c54a3a6ee53077740406fb07fc13]
+
+ Fix UBSan failure
+
+ Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e
+ "sw: check GetUserCall"
+
+ https://ci.libreoffice.org/job/lo_ubsan/3154/consoleFull#-1571115798d893063f-7f3d-4b7e-b56f-4e0f225817cd
+ Change-Id: Ifc80312890f2e6b82dcc9419b5b7e8bfcd5340a5
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166824
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167001
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-16 Xisco Fauli <xiscofauli@libreoffice.org> [67af2cc487450a274ae7ba988249c9c362eaa95d]
+
+ sw: check GetUserCall
+
+ It might return nullptr
+ See https://crashreport.libreoffice.org/stats/signature/SwFEShell::ShouldObjectBeSelected(Point%20const%20&)
+
+ Change-Id: Ia0ed355a7eb9084b9f57163ffbfe6b549c8bdb3f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166642
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit 495b5db74f0db59395ff68bacc8d8ca67595b66e)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166710
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-16 Patrick Luby <guibmacdev@gmail.com> [d5ffb72e00e528796c07d51b3ed9d7a28ad12668]
+
+ tdf#153306 prevent subpixel shifting of X coordinate
+
+ HACK: for some unknown reason, if the X coordinate of the
+ path's bounds is more than 1024, SkBlendMode::kExclusion will
+ shift by about a half a pixel to the right with Skia/Metal on
+ a Retina display. Weirdly, if the same polygon is repeatedly
+ drawn, the total shift is cumulative so if the drawn polygon
+ is more than a few pixels wide, the blinking cursor in Writer
+ will exhibit this bug but only for one thin vertical slice at
+ a time. Apparently, shifting drawing a very tiny amount to
+ the left seems to be enough to quell this runaway cumulative
+ X coordinate shift.
+
+ Change-Id: Ic1ac8a390df51c4aa1cc3183590dce72059af6b6
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166766
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 05d3a99aa687ee4e1706f9403651379b7ebdad89)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166722
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-16 Miklos Vajna <vmiklos@collabora.com> [ed4316d109841c31de49493092d82b40259e818a]
+
+ tdf#160952 sw: ignore top margin only at page top, not e.g. table top
+
+ The bugdoc has a table at the top of the 2nd page and we ignored the top
+ margin inside the table cell (for the first paragraph), while this
+ doesn't happen in Word.
+
+ As mentioned at
+ <https://gerrit.libreoffice.org/c/core/+/167221/3#message-c03abf8e8e3cd20d49006058e6b3eb130585ff8f>,
+ the old code assumed "top of the page" for all frames not having a
+ previous frame, while that code was only tested with text frames
+ directly in the body frame of a page frame.
+
+ Fix the problem by limiting this "collapse upper spacing" behavior to
+ frames directly in body frames. This keeps the old bugdoc working, but
+ is meant to restore the old, wanted behavior in other cases like e.g. in
+ table cells.
+
+ If later it's discovered that upper spacing collapsing is wanted in
+ other contexts, those are best added on a case by case basis.
+
+ Change-Id: Ieb93facd8b2e7f6412fd20873c10ce6c8b775619
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167631
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 6025ac371bd5cd07c0af550d78db323ad394173b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167671
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-16 Weblate <noreply@documentfoundation.org> [71d5a67fa448ed83d4c5ca577ca99f5dd85f331b]
+
+ android-viewer translated using Weblate
+
+ Japanese currently translated at 34.8% (46 of 132 strings)
+
+ Change-Id: Ie6b66ae3c2c878463f7c413fd77397e698b6c3bc
+ Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/ja/
+ Translation: android-viewer/android-strings-24-2
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167629
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-16 Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> [01bdb97829d103d06175fb50746ddeefddbaa3b3]
+
+ tdf#160906 use SfxPoolItemHolder
+
+ to avoid handling already deleted SfxPoolItems.
+
+ Change-Id: I1f1f8f93cae8db7f7c8df66c2c7f3c02b59a39c3
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167274
+ Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167376
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-15 Caolán McNamara <caolan.mcnamara@collabora.com> [e16c06e4d069216d65bf43bcb9e12c85d5505ba0]
+
+ tdf#161073 handle is supposed to be freed automatically on failure
+
+ and is since:
+ https://gitlab.gnome.org/GNOME/glib/-/commit/747e3af9987b37847d7d5acbf882d1ee4a6bd91b
+
+ Change-Id: Ibb648ccf69ff892fc1e2a3c3dc4da1fffd577c92
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167468
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-15 Eike Rathke <erack@redhat.com> [49a69504963812d8e2bd7d9a7de6c011a5749dda]
+
+ Resolves: tdf#160985 Max integer representation for rtl_math_StringFormat_G
+
+ Same as for rtl_math_StringFormat_Automatic we want to preserve
+ the highest accuracy of integer values also with
+ rtl_math_StringFormat_G if nDecPlaces is large enough, instead of
+ possibly rounding into 15 digits. This occurred with
+ FastSaxSerializer::write(double) but rtl::OString::number(double)
+ and rtl::OUString::number(double) and rtl_math_doubleToString()
+ and rtl::str::valueOfFP() and rtl_str_valueOfDouble() and all
+ places calling with rtl_math_StringFormat_G are similar affected.
+
+ Question might remain why those places use
+ rtl_math_StringFormat_G with fixed nDecimalPlaces calculated from
+ RTL_STR_MAX_VALUEOFDOUBLE - SAL_N_ELEMENTS("-x.E-xxx") + 1
+ instead of rtl_math_StringFormat_Automatic with
+ rtl_math_DecimalPlaces_Max.
+
+ Change-Id: Ib388b119faed441c9020dca803649a4089da5b07
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167647
+ Tested-by: Jenkins
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+ (cherry picked from commit 1ea85e8f2d815e6c0834215714ed3dad1101b971)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167673
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-15 Patrick Luby <guibmacdev@gmail.com> [73b552139906e10f004bd56e53684cceed071bd6]
+
+ tdf#160690 set an opaque alpha mask for non-transparent frames
+
+ Due to the switch from transparency to alpha in commit
+ 81994cb2b8b32453a92bcb011830fcb884f22ff3, an empty alpha mask
+ is treated as a completely transparent bitmap. So revert all
+ of the previous commits for tdf#157576, tdf#157635, and tdf#157793
+ and create a completely opaque bitmap instead.
+
+ Note: this fix also fixes tdf#157576, tdf#157635, and tdf#157793.
+
+ Change-Id: Ic2ccad6ab94e4d43b1b66013f85955d474dc0151
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167563
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 2a9eb581f0edfae8123018006df5cc9de1e1fd45)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167674
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+
+2024-05-14 Miklos Vajna <vmiklos@collabora.com> [abd90828cf101581a07b9d1c371a8c3156521e9f]
+
+ tdf#160952 sw: ignore top margin of para on non-first pages with newer DOCX
+
+ The 2nd page of the bugdoc has a single paragraph, with a non-zero top
+ margin. This is ignored in Word, but wasn't ignored in Writer.
+
+ Experimenting with the document, it looks like old Word files also don't
+ ignore this top margin: it started when the compat mode is upgraded
+ (from binary DOC or Word 2010) to Word 2023 or newer. Also the top
+ margin is only ignored for the first paragraph on the page, and only in
+ case it's not on the first page.
+
+ Fix the problem by introducing a new SwFrame::IsCollapseUpper() function
+ to decide if the upper margin should be collapsed or not, and then by
+ using it in SwFlowFrame::CalcUpperSpace() at one place where we read the
+ top margin from the doc model. Take advantage of the fact that we have
+ related, existing compat flags that tell us if we're in "Word >= 2013"
+ compat mode: see e.g. GetFlyAnchorBottom(), which explains
+ DocumentSettingId::TAB_OVER_MARGIN is a good indicator that this is a
+ "Word <= 2010" document. Also, DocumentSettingId::TAB_OVER_SPACING is an
+ indicator that this is a Word document, so we want the "TabOverSpacing
+ && !TabOverMargin" case.
+
+ This doesn't change all reads of the upper spacing of a text node, but
+ is enough to avoid the unwanted top spacing, as demonstrated by the
+ bugdoc.
+
+ Change-Id: Ibdebdf5f0555256a0b6ed85d07079f14ef69a576
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167252
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 6200d89b905d51776ff4f3c8a84f338655ffaa7f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167221
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-14 László Németh <nemeth@numbertext.org> [95fdda2f027f2bcdd135b3f55c549d6f2339e086]
+
+ tdf#160836 sw: fix narrow selection area of cell border
+
+ Remove ShouldObjectBeSelected() condition to fix the
+ selection area around the horizontal border. (Its purpose
+ was to avoid of selection of the border, when covered by
+ an image: but that would be !ShouldObjectBeSelected(), with
+ the same problem: halved selection area.)
+
+ Clean-up commit commit 30de13743f144aced83bc43d310592f82788c910
+ "tdf#160836 sw: resize rows at images cropped by row height".
+
+ Change-Id: I6c812a150b67431c7ea3131f29489bda919c1724
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166877
+ Tested-by: Jenkins
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ (cherry picked from commit 38b6e89c9483fdfe3d26bef3b25f890528aef84e)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167211
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-14 László Németh <nemeth@numbertext.org> [03d40ad9dea1629f55a1270d425a5995ed229ddb]
+
+ tdf#160836 sw: resize rows at images cropped by row height
+
+ Fixed row height can crop cell content, including images
+ anchored as character. Resizing the row height with mouse
+ was not possible there, because selection of the cropped
+ image avoided to drag & drop the horizontal cell border.
+
+ Change-Id: I6dde79e77563468059794548b6c058cad61586a0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166795
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ Tested-by: Jenkins
+ (cherry picked from commit 30de13743f144aced83bc43d310592f82788c910)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167210
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-14 Xisco Fauli <xiscofauli@libreoffice.org> [2041013fd9759fdd7fc242ee4ae870175bab4801]
+
+ Update language-subtag-registry to 2024-03-07
+
+ How the file was created:
+ mkdir data
+ cd data
+ wget
+ https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
+ cd ..
+ tar -cvjSf language-subtag-registry-2024-03-07.tar.bz2 data
+
+ Change-Id: If1bdeab0ee5853855949dcbbfb00170e897c80e1
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167341
+ Tested-by: Jenkins
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+ (cherry picked from commit 96698d3a72d8496358786ffedc7b6eb22af3648c)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167461
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-14 Patrick Luby <guibmacdev@gmail.com> [812c3cf069b068b75d01662c241b52bec2dd2928]
+
+ tdf#160767 skip fix for tdf#155266 when the event hasn't changed
+
+ When scrolling in Writer with automatic spellchecking enabled,
+ the current event never changes because the fix for tdf#155266
+ causes Writer to get stuck in a loop. So, if the current event
+ has not changed since the last pass through this code, skip
+ the fix for tdf#155266.
+
+ Change-Id: I97265a7698756c5fb65b6686f6bb77c1caa08862
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167229
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ Tested-by: Jenkins
+
+2024-05-13 Xisco Fauli <xiscofauli@libreoffice.org> [a4c2c23cbb77a2d821e71e6a51f8e6d1779f1e3e]
+
+ libxml2: upgrade to 2.12.7
+
+ * Fixes CVE-2024-34459
+
+ Downloaded from https://download.gnome.org/sources/libxml2/2.12/libxml2-2.12.7.tar.xz
+
+ Change-Id: Ie45ad54b3f781a54a278e2542fccafb8d06542bb
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167585
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit 02dc762466c655e9ca6fb7cef92b1495915b34ed)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167460
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-13 László Németh <nemeth@numbertext.org> [5ad48954250b9235f4381a756445c318d2d69f6c]
+
+ tdf#160842 sw: select cell content instead of cropped part of image
+
+ It was not possible to select and edit the content of the bottom
+ cell, if an image cropped by the fixed row height "covered" it,
+ i.e. the image was in the previous row, anchored as character.
+
+ Note: table cells with fixed row height are usable to crop images
+ easily, with a single drag & drop, according to the requirement of
+ the text layout, while the cell above or bottom of the cell with
+ image is for the caption of the image. This is very useful to
+ adjust a book layout with sections with multiple columns and
+ illustrations.
+
+ Change-Id: I8683b4066db6ce43549ec3aa69b0e639a59e3681
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166794
+ Tested-by: Jenkins
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ (cherry picked from commit f3b899655018397e71300dbb32cdf4f82940a68b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167089
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-13 László Németh <nemeth@numbertext.org> [5b3037e2caa5dc857f51dd0dd7f38646535ee232]
+
+ tdf#44773 sw: allow resizing table rows, if cursor outside the table
+
+ If the cursor wasn't in the table, only column width of text
+ tables was resizeable by dragging the horizontal cell borders:
+ It was possible to drag the horizontal border, showing its
+ preview, but the drop cancelled the operation instead of
+ resizing the table row according to the selected position.
+
+ Now it's possible to resize the height of the table rows
+ without moving the text cursor inside the table.
+
+ Note: This is important for floating tables containing images:
+ here it's not possible to put the cursor inside the table, if
+ the image is cropped only by the cell borders: so it was not
+ possible to resize the row height.
+
+ Change-Id: I181d79a28cdeefabb796b7b978ee1368a9378888
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166793
+ Tested-by: Jenkins
+ Reviewed-by: László Németh <nemeth@numbertext.org>
+ (cherry picked from commit 6c00a73348511b688be214439941e128fc430a34)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167088
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-10 Michael Stahl <michael.stahl@allotropia.de> [9f5757c3cbd1f9252f2ea82bc8bacab24d26822c]
+
+ sw: Navigator: don't show virtual drawing objects
+
+ These can return a non-empty name now, so exclude them explicitly.
+
+ (regression from commit ae132145ff42a95dc24fb124847c04af4b8c8dab)
+
+ Change-Id: Ia7f7b9fd7abe67f3302e95b38e3b9fa30b769b5b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167349
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 609d1e353cfd7a9b138fcbe656a2faae9f84c36a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167451
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+
+2024-05-10 Michael Stahl <michael.stahl@allotropia.de> [c1198a8c0594308a06b29cc887850f8d50216d43]
+
+ gbuild: don't create empty services.rdb on "make postprocess"
+
+ Since commit db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3 "make
+ postprocess.clea; make postprocess" will result in an empty
+ services.rdb, because the components are added in makefiles in other
+ modules. Detect the problem and tell the user to run top-level make.
+
+ Change-Id: Iab1a15efa5a4c9bb3e90e44f82a9510dff724c80
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167354
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit baaeca870f5c8ae40d33eff2b530bd4b3670ee45)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167453
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+
+2024-05-10 Michael Stahl <michael.stahl@allotropia.de> [da7e1d686a586fa93b1e96adb3d837ea3ae59b98]
+
+ tdf#156484 svx,sw: fix visibility of shapes in header/footer
+
+ Similar to commit ae132145ff42a95dc24fb124847c04af4b8c8dab, also forward
+ IsVisible() and IsPrintable() from SdrVirtObj to its real object;
+ evidently the properties aren't copied when creating SdrVirtObj but
+ there is no reason for that to have these properties independent.
+
+ This triggers an assert in VOCOfDrawVirtObj::createPrimitive2DSequence()
+ because that is called during layout from getObjectRange(); the assert
+ was added in commit ae3ec0d53a22ae5d2b7fb244a6056d0627b71873 and
+ intended for painting, but this isn't painting, and it's not easily
+ possible to detect if the function is called during painting, so remove
+ the assert.
+
+ Change-Id: Id2a04a5d07f43b86eb9c524b30ba74ecaf6a95c8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167350
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 9fb9bd54a82ee20f5916aa68e428e0fb67f02ed6)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167452
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+
+2024-05-10 Caolán McNamara <caolan.mcnamara@collabora.com> [323f7ee7344e3d039693c80144cc7034ca634d53]
+
+ cool#7015 fix rgba emojis
+
+ We initially added this for android so we could match the OpenGL GL_RGBA
+ layout available there. Later we made it available for all platforms via
+ --enable-cairo-rgba which is useful for the kit case.
+
+ But along the line color emoji support was added to cairo which wasn't
+ present at the time of the original patch, so now capture those uses
+ as well.
+
+ https: //github.com/CollaboraOnline/online/issues/7015
+ Change-Id: I6039607a46a58a7e9cbf5c052e6fb34234fd19b0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167225
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 06a2805d88244adb7276327bc4539fd9bf651539)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167312
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-09 Noel Grandin <noel.grandin@collabora.co.uk> [d6bdcff5f739179efdd060083dc7feef14e5ba4d]
+
+ tdf#160706 speed up loading conditional formatting rule in XLS (II)
+
+ Reduce the work we do in IndexedStyleSheets::Reindex
+
+ takes my test document from 117s to 48s
+
+ Change-Id: I2e23b05684d0f2e3a9dc05c0a0fc4e9bbea7008d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166180
+ Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit 5060893f0b69c094beae73ab1a0926e3feb249b2)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167078
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-05-08 Michael Stahl <michael.stahl@allotropia.de> [5d996d2bcfcd16affffe411c68be070967f4feae]
+
+ framework: MenuBarManager: fix WNT crash if queryDispatch() throws
+
+ a Java extension throws RuntimeException from queryDispatch(), which is
+ translated to a C++ exception and thrown by the mscx_uno bridge, and this
+ is apparently not handled anywhere (Visual Studio says "Unhandled
+ Exception"), and what happens then apparently is the exception goes poof
+ and vanishes, and normal return from the mscx_uno bridge code happens,
+ but the out parameter used for the return value is never initialised, and
+ then the uno::Reference move assignment operator crashes.
+
+ Change-Id: I21535fcf0ab4ec30a712d01b5039b7e2fb7b09d7
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165081
+ Tested-by: Michael Stahl <michael.stahl@allotropia.de>
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 447a15f4772bcbc9366cfa43b92c55ae644e9b03)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165113
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+ Tested-by: Jenkins
+
+2024-05-08 Caolán McNamara <caolan.mcnamara@collabora.com> [3079e0c1ff781c77b0b279dea9ec97a5a24e5b92]
+
+ return early on empty ORelationTableConnectionData*
+
+ we test for pData existing, but it it doesn't then we continue and
+ will typically dereference it, so test looks inverted
+
+ Change-Id: Iddcab25d5620942bb617bd1e9985322f5e497839
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167331
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 0b97bfa88ffebf31778f0f68e883e046822cd264)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167313
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-08 Bayram Çiçek <bayram.cicek@collabora.com> [0aef29521b824e61b81bb6be1079b8ddd77e39a9]
+
+ tdf#159375: remove initialization on Tools>Options
+
+ - Initializing some dialogs at the startup of Options
+ makes it opening very slow on some low-power systems.
+
+ - This patch removes this initialization. This means,
+ all dialogs will be initialized at the time of search.
+ Therefore, we should wait a bit longer when typing
+ on the search bar to get the results...
+
+ - remove the default parameter "nNumberOfNode" from
+ initializeFirstNDialog()
+
+ - rename initializeFirstNDialog() to initializeAllDialogs()
+
+ Change-Id: I4fd9c5673f7edecfe6a6621b6018d5d405f112a6
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167023
+ Tested-by: Jenkins
+ Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
+ Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
+ (cherry picked from commit dd3953f705cc19aad4b0fcec7fd2961246b659e3)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167222
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+
+2024-05-08 Miklos Vajna <vmiklos@collabora.com> [32616609c788aa1cf0837af0f387390a23de1766]
+
+ tdf#159683 sw content controls, plain text: fix crash with the clipboard doc
+
+ Regression from commit c804c5354855188b5a37219cfe11dc079dc235f4 (sw
+ content control: fix lost properties on copy&paste, 2023-03-10), select
+ a plain text content control, copy it to the clipboard, quit: assertion
+ fails during shutdown because the doc's "placeholder text" char style is
+ still referenced by a client.
+
+ What happens here is that the SwContentControl copy ctor copies the
+ plain text flag, and that flag is only read in SwTextNode::InsertHint(),
+ so that causes the problem. Note how that code is inconsistent: we avoid
+ the creation of dummy characters in the copy case, but we still try to
+ adjust the start/end of the content control attribute in the copy case,
+ which makes not much sense.
+
+ Fix the problem by not adjusting the content control attribute
+ boundaries in the copy case, since the original intention was to do
+ thees corrections only at a UI level, during interactive edit.
+
+ It's not clear why this inconsistency had an influence on the clients of
+ the char style, though.
+
+ Change-Id: I86b0516464f24fc453dcd97588dafb8afd010a9e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166882
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 06aeb9c61d50bba7edafe17f9d3513af26b0782f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167311
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-08 Miklos Vajna <vmiklos@collabora.com> [fe9395164bc4130c83ab75e0c471516f9da61bee]
+
+ Related: tdf#160833 teach DOC export about DoNotMirrorRtlDrawObjs
+
+ See
+ <https://gerrit.libreoffice.org/c/core/+/167033/1#message-e1df9bf60b7b8b2acdf0c062484ddc572939a3d9>,
+ no need to undo the import-time mapping in case we know that the
+ mirroring is avoided at a layout level.
+
+ Change-Id: Idbdc10ad327540dc5045e9b19dd42160b5139470
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167049
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 9d95eb980ef12678f6fb978badcbe1cacbe0c4dc)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167084
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-08 Miklos Vajna <vmiklos@collabora.com> [e74f2f3f259125434f7fb9f8d7c338123a0137ed]
+
+ tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/
+
+ The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that
+ SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the
+ anchor paragraph is RTL, so swapped the "from left" label to a "from
+ right" label.
+
+ Don't do this when the compat option is enabled, so not only we render
+ correctly but the UI now correctly explains why we came up with the
+ correct position.
+
+ Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167031
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 0f410680461d7ba5f70dd65b2a8263dec15ac357)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167083
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-07 Thorsten Behrens <thorsten.behrens@allotropia.de> [b1c4dc433fd377dca87cb29189fe00310ccb25c9]
+
+ fix linker error for PCH build
+
+ Error was:
+
+ ld.lld: error: undefined symbol: LanguageTag::~LanguageTag()
+ >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
+ >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&))
+ >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
+ >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&))
+ >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
+ >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<CharClass, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&>(CharClass*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&))
+ >>> referenced 5 more times
+
+ Change-Id: Ie84d062d1815aa8e8118171862e0f8f64331d769
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166346
+ Tested-by: Jenkins
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+ (cherry picked from commit b4be47efb848bd5209cb1f2d915c22814b516d32)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166896
+ Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
+
+2024-05-07 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [54586d9de58d4b971ef976bcce0df957141b0a50]
+
+ update credits
+
+ Change-Id: Ibdf64d7605c81e9006c1637a85a4a539993dffa6
+ (cherry picked from commit 6b62ff0eaf499eb8c2ed4af3413757f38bc97dcb)
+
+2024-05-07 Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> [81bc6152fecfb9220ec1a36b8a7edc8634467e19]
+
+ tdf#160153 Restore Storage config item
+
+ Revert "[API CHANGE] Remove deprecated Storage config item"
+
+ This reverts commit 3cee7edeb31ac64e078159c7a63ebf4f54793da7.
+
+ As documented in the bug report, the config item is still used.
+ Thus, remove the deprecation notice, too.
+
+ Change-Id: Ia9beefe8e98bce8d70c546d27999d81c5cc9fd62
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166904
+ Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 80fcd2290dfc9748bb7f4e322b22b773b61daa67)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167219
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-07 Michael Stahl <michael.stahl@allotropia.de> [331da18872d8dd526b0e91854450223ee8c0bf0c]
+
+ tdf#160402 writerfilter: extend StyleMap with all Word styles
+
+ There doesn't appear to be an accurate and complete documentation of all
+ the Word built-in style names, but fortunately Word writes them all into
+ styles.xml in a w:latentStyles element anyway.
+
+ It turned out that a lot of the Writer built-in style names here were
+ obsoleted by renaming and did not match any more.
+
+ Change-Id: Ic69785a34524f667b83a06a267715b2c8b0165d0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167242
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 72ea1005b987159a6a59f9379e63321e0b0dd44f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167261
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-07 Michael Stahl <michael.stahl@allotropia.de> [fdd44d9e7c6066aac8572d6d78dedef339b6058e]
+
+ tdf#40142 sw: only check level for table of contents
+
+ Only Table of Contents has level settings, the level is always 0 for the
+ other ToX types, which erroneously excludes nodes (as can be seen with
+ testFDO77715 failing with upcoming tdf#160402 bugfix).
+
+ (regression from commit 5c04c4474236cc50009aea6d89f7c443c861af19)
+
+ Change-Id: Iec1c2b8eaba0ad20b2ad7d8c6b20603315a7a83d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167096
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 7178d6197b892e456a8db8a3d085a24bfd52cf32)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167212
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-07 Weblate <noreply@documentfoundation.org> [19304724d3e7fdf19cbaf0c71c44ac742d444c96]
+
+ android-viewer translated using Weblate
+
+ Chinese (Traditional) currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: Iadede33683d02d01c5c0781af18b41328fc2f01a
+
+ android-viewer translated using Weblate
+
+ Portuguese (Brazil) currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: Ide5e2c3964faad4656cb8b7d5302604d87074ea5
+
+ android-viewer translated using Weblate
+
+ Dutch currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: Ia4659494c08701dd9939596321bcb5955bfe830f
+
+ android-viewer translated using Weblate
+
+ Czech currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: If43f5f750e95e9eb93f9051e6370c9a0f27a7f06
+ Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org>
+ Co-authored-by: Po-Yen Huang <jeff.huang@ossii.com.tw>
+ Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
+ Co-authored-by: kees538 <kees538@gmail.com>
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/cs/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/nl/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/pt_BR/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/zh_Hant/
+ Translation: android-viewer/android-strings-24-2
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167251
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-07 Michael Stahl <michael.stahl@allotropia.de> [74f859b5525da0760a70ab660bd912dabfd608ca]
+
+ tdf#160402 writerfilter,sw: STYLEREF field can refer to character style
+
+ Adapt SwGetRefFieldType::FindAnchor() to search for SwTextCharFormat,
+ and ApplyClonedTOCStylesToXText() to replace "CharStyleName".
+
+ Works for the "Intensive Hervorhebung" field in bugdoc.
+
+ Change-Id: Iee126eeb4cc2ff1c570941e3beefd93527c56fee
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167098
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit d4fdafa103bfea94a279d7069ddc50ba92f67d01)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167244
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-07 Michael Stahl <michael.stahl@allotropia.de> [e33f2b3d550d5d26a5eca135d88e0c16b2db11d8]
+
+ tdf#160402 filter,writerfilter: import locale-dependent STYLEREF names
+
+ * Handle STYLEREF style the same way as TOC style on import.
+
+ * Word 2013 does not uppercase the first letter
+ ("Überschrift 1" -> "berschrift1") and there doesn't
+ appear to be any justification why the code does that.
+
+ * The style that's applied is actually the display style name
+ so convert from source's m_sConvertedStyleName.
+
+ * Change the logic in DomainMapper_Impl::ConvertTOCStyleName() to
+ explicitly check and clone only known built-in Word styles, which are
+ the ones that are translated.
+
+ * This requires some refactoring, and to add the built-in styles in the
+ bugdoc to the "StyleNameMap", which is probably still incomplete...
+
+ * Exporting to DOCX appears to work without changes.
+
+ * Somehow this causes the testFDO77715 to have an outlinelevel of 1 on
+ the TOC paragraphs now, but that turns out to be a bugfix.
+
+ Change-Id: I73bc1d1819e5cecbba2fef9cd6d290682a02a638
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167097
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167243
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-07 Patrick Luby <guibmacdev@gmail.com> [b11c9b5f205907390ef210ae3c1f9f54fee84820]
+
+ tdf#160855 fix crash due to Skia's internal maximum pixel limit
+
+ Somewhere in the tens of thousands of selected fill cells,
+ the size of the VirtualDevice exceeds 1 GB of pixels. But
+ Skia, at least on macOS, will fail to create a surface.
+ Even if there is ample free memory, Skia/Raster will fail.
+
+ The second problem is that even if you disable Skia, the
+ crash is just delayed when a BitmapEx is created from the
+ VirtualDevice and malloc() fails.
+
+ Since this data flavor really triggers one or more system
+ memory limits, lower the resolution of the bitmap by keeping
+ the VirtualDevice pixel size within an arbitrary number of
+ pixels.
+
+ Note: the artibrary "maximum number of pixels" limit that
+ that Skia can handle may need to be raised or lowered for
+ platforms other than macOS.
+
+ Change-Id: Ie087f2db152470aa70521fbe5fe6c7cedd8504af
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167145
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Tested-by: Jenkins
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ (cherry picked from commit 8d9f54165d28d83092667b7bfcd0ee48ade54c87)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167215
+
+2024-05-07 Xisco Fauli <xiscofauli@libreoffice.org> [35c0afcf0a0428670e3e1998f222440b504ae0c8]
+
+ svx: Avoid divide by 0
+
+ See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs()
+
+ Change-Id: Ie08c54d1a1b40bcc42da9f81c893f496fff433a8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166626
+ Tested-by: Jenkins
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 90548039f09d4bc773bf6879a62d544adfa175db)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166674
+ Reviewed-by: Aron Budea <aron.budea@collabora.com>
+
+2024-05-06 Xisco Fauli <xiscofauli@libreoffice.org> [2165fa986408a2ee53c56ee18936f69ed97d40e3]
+
+ Update git submodules
+
+ * Update dictionaries from branch 'libreoffice-24-2'
+ to 43715e23e6ff1f153689950db0ea1273b6a7bf3f
+ - upgrade Ukrainian dictionaries to 6.4.4
+
+ Change-Id: Idf246940bdf58844212420975ab52c19b08327ec
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872
+ Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Andriy Rysin <arysin@gmail.com>
+ (cherry picked from commit 0ca7301c3c00d6e7936fd912ba775d0008f7fee4)
+ Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166906
+ Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [fb7e3ebf22a120fa0055d556616aeb69abe49bec]
+
+ wrong ScContentTree::SelectEntryByName early return condition
+
+ Change-Id: I974f5aea545a80b0e48b50e2a2eae0729ff59691
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167174
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 18b70ec7d9c4a0288f206cb64708f87a83789c00)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167085
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-06 Xisco Fauli <xiscofauli@libreoffice.org> [b2dc48571714a84b1eeff127e86c07b29b579e43]
+
+ tdf#159661, tdf#160773: svgio: Add unittest
+
+ Change-Id: I2d0b96f13e02ac81b97ea347889c76770c22a989
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166509
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167053
+
+2024-05-06 Mike Kaganski <mike.kaganski@collabora.com> [9f5664f4d34e8f04cc18dc252cad4b3b853db882]
+
+ tdf#152906: use correct Y offset
+
+ GetEditCursor now returns the position relative to the line, not
+ to the whole text. In ImpEditEngine::CreateLines, its use wasn't
+ fixed, and so the Y position of all lines in the calculation was
+ the same, thus adjusting to the same contour's horizontal stripe.
+
+ Change-Id: I16362bab47f3064281eefb45a12834d836a8ada3
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167042
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167188
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [46bd13a55492adef4bf95133d7123494a62f549a]
+
+ Related: tdf#160056 1 entry is more common than no entries
+
+ Change-Id: I78fe8969120f894cf5c0a71fb61611af2d203d18
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166065
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 7f2283c2986ff94766cc1d2c076fb34a2c88a31a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166302
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [34126d6fceb054b7ba05ceeae76e32c89fac580f]
+
+ Related: tdf#160056 don't call GetParamCount twice
+
+ GetParamCount: 290ms -> 175ms
+ Change-Id: Ic3a26b1e8035744dcab2da69a8ebd3b29dd2160a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166031
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 030b655963c182693c7b657dc6aa4d2fe85c17c6)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166301
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [9757290668b50827ab22597a73a4850ebf3f6521]
+
+ Related: tdf#160056 don't set nVal twice
+
+ Change-Id: I0da3e0c7f18271f6104d52b50d65e96564650b8b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166054
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 63b237e1e8147f54e6d4db4671f612a656200e2f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166300
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [bc7198d47b4d1aef7a346c3f939122c9c764eeda]
+
+ Related: tdf#160056 all maTokens are FormulaTypedDoubleToken*
+
+ Change-Id: I6eacaf58c25ef9c5cb930a79177471c79a6a26c0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166047
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit adbbe732e7ed7f3a749e04f1d9023989c972ec22)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166299
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [e3e9d51c2d4bed475f9848c62c7b0e5c72d5e125]
+
+ Related: tdf#160056 various functions and objects that can be const
+
+ this formatter can be const
+
+ Change-Id: I2cd83140585e0b7027bb1c165a8d59e51cbbaad0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164728
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ SvNumberformat::ImpGetFractionOfSecondString can be const
+
+ Change-Id: If7a31f8b3667d9a6b8719553567211071bd2d631
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164774
+ Tested-by: Jenkins
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ ImpIsEntry can be const
+
+ Change-Id: Id229344a68925a1bde84f2b4aad46cfc5f01b797
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164769
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ SvNumberformat::ImpGetLogicalOutput can be const
+
+ Change-Id: I847e5de84f0636b5a169f383e319a6b8707cc31f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164773
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ SvNumberFormatter::GetUserDefColor can be const
+
+ Change-Id: If499e28e5ac69018b35b475a73ecb2dc4b78dad6
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164786
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ These methods can be const too
+
+ Change-Id: Iaef46216dac6584f57b7933d658384f54d0a4544
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164772
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166125
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-05-06 Caolán McNamara <caolan.mcnamara@collabora.com> [a7587def8792dc811d9aa66a462d752130f575d5]
+
+ cid#1596833 Uninitialized pointer field
+
+ Change-Id: I1f05ef494e7e28bd105b7658072c33b2d274a803
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167159
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 66916b20818e4fc4a25d711b3860b4096e575a5c)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167080
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-06 Noel Grandin <noel.grandin@collabora.co.uk> [f99b8fc6ef3cd311b8bab52b3674d2637cb547e2]
+
+ tdf#160706 speed up loading conditional formatting rule in XLS
+
+ we only need to finalizeImport on the last ExtDxf we loaded, otherwise
+ we end up with an O(n^2) performance problem
+
+ Change-Id: I566ef43189a1bb7ac7c55e1bccf9445c9cea19b9
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166179
+ Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit dac30c44c606232ce23d52a423d0bf8010f25d4f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167077
+ Tested-by: Jenkins
+
+2024-05-06 Miklos Vajna <vmiklos@collabora.com> [7d75210808f8d8be7ee226031ae27b724cfcfbcc]
+
+ tdf#160833 DOCX import: use the DoNotMirrorRtlDrawObjs compat flag
+
+ The bugdoc has a shape which should be on the right page margin, but it
+ was on the left page margin.
+
+ Use the new compat flag to have a layout that matches Word.
+
+ This way we don't need to unmap the tweaked position at export time (a
+ limitation that the DOC filter has).
+
+ Change-Id: I38dfae370f275d9f0897198e7b0569f2d91dd352
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166993
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167044
+
+2024-05-06 Miklos Vajna <vmiklos@collabora.com> [3fd55489b73fc8fd03a5271567153c9852986e39]
+
+ tdf#160833 sw DoNotMirrorRtlDrawObjs: add layout
+
+ In case this flag is active (intended for DOCX files), then don't
+ automatically mirror the position of drawing objects, just because they
+ are anchored in an RTL text node.
+
+ Change-Id: Ie743d94ecb511d7de89e8e1e8303896370ce58c8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166883
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167043
+
+2024-05-06 Pierre <prrvchr@gmail.com> [eb045cc529f0e7b17e7e3bc913f2ab1748247966]
+
+ tdf#160375 Base displays and gives the full name of the table
+
+ Change-Id: Icc8c6d85cc5a88461b7bd02487513e0e864bacef
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166093
+ Reviewed-by: Pierre Vacher <prrvchr@gmail.com>
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-05 Julien Nabet <serval2412@yahoo.fr> [ee9f7d31348e917eb8ba5b007a6679e01ecdb37f]
+
+ tdf#160924: SDK: typo SDK_HOME instead of OO_SDK_HOME for linux
+
+ Change-Id: I8ec2bc31b19cc6b724a6f7ea3238dda8cf60d4b7
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167111
+ Tested-by: Jenkins
+ Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
+ (cherry picked from commit 6aa2e8fe2b0b59e2fe20191decb9bd6202dabcc9)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167073
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+
+2024-05-05 Weblate <noreply@documentfoundation.org> [19491e5c1bd9d41b76dae92864d103ed3c42876e]
+
+ android-viewer translated using Weblate
+
+ Polish currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I803a8b0f3608066df8864e44451eb3dfc9b06c32
+
+ android-viewer translated using Weblate
+
+ Italian currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I52367b9e9d91c4e4bd50914861100cdf7f440e78
+
+ android-viewer translated using Weblate
+
+ Armenian currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: Ice049f5f95394783ba8b214c9bf069c67aff7317
+
+ android-viewer translated using Weblate
+
+ Upper Sorbian currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: If58610f0e164867babefb7c2eeaadeac0b87a5a6
+
+ android-viewer translated using Weblate
+
+ French currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I460e0276b6c98ec33ceefde14d5878f51127ed93
+
+ android-viewer translated using Weblate
+
+ Spanish currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I96ea9a573188a68937500563f0100e999554b1a0
+
+ android-viewer translated using Weblate
+
+ Lower Sorbian currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I61a5e85484ee942c1ec49a4a98b302739a01e864
+
+ android-viewer translated using Weblate
+
+ Catalan currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: Iebb2ed1a53aef3bc46790bbaf43527837d77e1b6
+
+ android-viewer translated using Weblate
+
+ Asturian currently translated at 99.2% (131 of 132 strings)
+
+ Change-Id: I3a93bbccc61931662cbecb4466c49589e026b37a
+
+ android-viewer translated using Weblate
+
+ Turkish currently translated at 100.0% (132 of 132 strings)
+
+ Change-Id: I3b39853d9be20c69c1b7a95a87dcdd204f7f58b0
+ Co-authored-by: Adam Rak <kitynska@gmail.com>
+ Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
+ Co-authored-by: Michael Wolf <milupo@sorbzilla.de>
+ Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com>
+ Co-authored-by: Valter Mura <valtermura@gmail.com>
+ Co-authored-by: gokhan <ggurbet@gmail.com>
+ Co-authored-by: sophie <gautier.sophie@gmail.com>
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/ast/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/ca/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/dsb/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/es/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/fr/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/hsb/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/hy/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/it/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/pl/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/tr/
+ Translation: android-viewer/android-strings-24-2
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167133
+ Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-05-03 Mike Kaganski <mike.kaganski@collabora.com> [d1c31e3857b7f0c6b3fb72da0c967bfa2bdef015]
+
+ Fix a thinko in 8a97f1ba8d9ccb65b2c89106de20666311d90c30
+
+ Change-Id: I07bb67e9384470269d1fd3df087acee377cce729
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166490
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167052
+
+2024-05-03 Mike Kaganski <mike.kaganski@collabora.com> [14c7b4249e822c218f912fcd3707226081363f7a]
+
+ tdf#160773: handle 0-size font height
+
+ Regression from commit cc3663bbaed4f65d64154e5f9abb51a5f622f710
+ (tdf#160702: improve text positioning, 2024-04-20), where I didn't
+ know yet that this was possible :-)
+
+ Change-Id: I1316db48b8acbacd077eeb4a8989c3dbf7e4a7b5
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166425
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167051
+
+2024-05-03 Xisco Fauli <xiscofauli@libreoffice.org> [f4a868ce3b7e5fe6e708f2c795402d646e0746d5]
+
+ tdf#155651: Add support for "context-stroke"
+
+ Change-Id: Ib4f4a7b644d0d6c6b36e31b80fd7adc18999110d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166908
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Tested-by: Jenkins
+
+2024-05-03 Mike Kaganski <mike.kaganski@collabora.com> [44b6b90080e7585e46250fb4076b210619e10bb3]
+
+ tdf#157103: fix SVG whitespace handling
+
+ Previous code tried to hack some tricks to restore whitespaces after
+ trimming them according to the xml:space attribute value. But it was
+ wrong in multiple ways.
+
+ 1. The collapsed space must stay in the block where its start was.
+ When a block ended with a space, then trimming the space from it,
+ and adding to a next block, can change the size of the space.
+ 2. The shift of a line (e.g., specifying x and y values) doesn't end
+ the logical line. A space before such a shift must be kept by the
+ same rules, as if there weren't a shift.
+ 3. A block with xml:space="preserve" is treated as if it consists of
+ all non-whitespace characters, even if its leading or trailing
+ characters are spaces. I.e., a trailing space in a block before,
+ or a leading space in a block after, should be collapsed into a
+ single space, not removed - even when the space-preserving block
+ itself is made invisible.
+
+ Change-Id: Ic778d1e9d6b9d0c342ea74ad78d44bb47bc8d708
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166239
+ Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167050
+ Tested-by: Jenkins
+
+2024-05-03 Julien Nabet <serval2412@yahoo.fr> [f1b1e61ef56b85fd56f39854d2edb52f3c2d8b82]
+
+ tdf#160916: typo "Checbox"
+
+ Change-Id: Ia06bc947cd1788850251b1386977ef0229dddd8a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167030
+ Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
+ Tested-by: Jenkins
+ (cherry picked from commit 68008d9f0176c43ecc768af8e3539227640d1519)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166905
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
+ Tested-by: Julien Nabet <serval2412@yahoo.fr>
+
+2024-05-03 Mike Kaganski <mike.kaganski@collabora.com> [5a25899a9c5c0c4e6fb92ca355ea1e24cec3a747]
+
+ tdf#160702: improve text positioning
+
+ Opening an SVG with text in different elements (e.g., tspans) in the
+ same text element performs calculations to position the parts properly
+ (i.e., the next part will start where the previous part ended, unless
+ the position in overridden explicitly). These calculations require to
+ know the text widths. The first problem leas here: the text width was
+ calculated for a typically small text size (numerically equal to the
+ pixel size defined in the SVG), but these calculations aren't truly
+ linear, because font rendering may change depending on font height.
+ Additionally, the rounding gives much higher error in smaller sizes
+ than in larger. There was already a workaround for a similar problem
+ in ViewRedirector::createRedirectedPrimitive2DSequence, where a large
+ font (with 100 times greater height) was used to increase correctness.
+ This was also used here, with the same large height (50000) used as a
+ reference.
+
+ Then, at the time of wrawing the text at different zoom levels, the
+ code in VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D
+ creates a font of a calculated size, and uses it to output the text.
+ But the font is always created with an integral height, which means,
+ that for a wanted height of 2.5 (in a zoomed out view), the really
+ used height will be 3, which is 20% larger; or for wanted height of
+ 2.4, the actual height will be 2 (20% smaller). This resulted in odd
+ jumps of the text widths, when the text may overlap the following
+ part, or conversely, create a big gap before the next gap. To try to
+ mitigate that, the function now takes the difference between the
+ wanted and the actual font size into account, and adjusts the MapMode
+ accordingly. This doesn't fix the jumping completely (e.g., because
+ of the mentioned special handling of small font sizes in the fonts
+ thenselves, like hinting), but still makes the calculations much more
+ stable, decreasing the amount of jumping. Similar changes are made in
+ TextLayouterDevice.
+
+ Use of the functions that return text size as a double, not rounded
+ value, should additionally help improving stability.
+
+ Change-Id: I455845d8ca43ee9c06a0fc980947f35d8a25797a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166238
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166468
+
+2024-05-03 Mike Kaganski <mike.kaganski@collabora.com> [aa2df54f37926cf95261eefade1b87da3229cfd7]
+
+ tdf#160622: Let SalLayout::GetBoundRect return basegfx::B2DRectangle
+
+ This avoids premature rounding in TextLayouterDevice::getTextBoundRect.
+ The box in D2DWriteTextOutRenderer::performRender needs to be expanded
+ to allow room for the line width (which now will be guaranteed on all
+ sides; previously, the rounding could happen to give no room on some
+ side, even prior to commit 8962141a12c966b2d891829925e6203bf8d51852).
+ Fixes some lines partially cut off in smaller text (or zoomed out).
+
+ Change-Id: I07335136021f894cf045363b4d736bfab06c64d4
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166236
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167014
+
+2024-05-03 Miklos Vajna <vmiklos@collabora.com> [799767d5670efc7f996892de5dd7d1afdb4a6cce]
+
+ tdf#160833 sw: add a DoNotMirrorRtlDrawObjs compat flag
+
+ The DOCX bugdoc has a circle shape anchored inside an RTL paragraph:
+ this shows up on the right hand side in Word, but on the left hand side
+ in Writer.
+
+ What happens is that Writer implicitly mirrors draw objects anchored in
+ RTL paragraphs, while Word doesn't do this.
+
+ Start fixing the problem by adding a new layout compatibility flag that
+ can be used by the DOCX import in the future, to leave the behavior
+ unchanged for new & existing ODT documents.
+
+ An alternative would be to do something similar to the DOC import's
+ SwWW8ImplReader::MiserableRTLGraphicsHack(), but 1) we don't have the
+ page margins by the time we import the shape and 2) as its name says, it
+ doesn't feel like a clean solution, it's better to handle this
+ difference at a layout level.
+
+ Change-Id: I2ec067d86c7fbdbe57e4cd9547015fe25a9a56b9
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166820
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit c675eaf923cf579670b8ba2f7794b47be7fad39e)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166845
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-02 Weblate <noreply@documentfoundation.org> [88afcb6589e613e01d003fa9afdea495574d3de3]
+
+ android-viewer translated using Weblate
+
+ Turkish currently translated at 98.4% (130 of 132 strings)
+
+ android-viewer translated using Weblate
+
+ German currently translated at 100.0% (132 of 132 strings)
+
+ Co-authored-by: Christian Lohmaier <cloph@documentfoundation.org>
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/de/
+ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/tr/
+ Translation: android-viewer/android-strings-24-2
+ Change-Id: I211f181c9e02dbb9c0ba1347bf9f584470e58d1b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167015
+ Tested-by: Jenkins
+ Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+
+2024-05-02 Regina Henschel <rb.henschel@t-online.de> [1347274fc1cb780db4c7c9b8c0272e1730b95c04]
+
+ tdf#160329 update objects after row sort is finished
+
+ The problem was that when the object position was updated to the anchor
+ values by recalcPos() method, the document did not yet have the new
+ state of the hidden rows. As a result, incorrect positions were
+ calculated. Therefore, the update of the position is moved to a place
+ after the update of the visibility of the rows.
+
+ Sorting rows must not change the visibility of objects. However, updating
+ the visibility of rows sets all objects to visible. Now the visibility
+ state of an object is saved and restored later so that the recalcPos()
+ method receives the correct state for the object.
+
+ Change-Id: Ia32698c1d45cd81702e6d00c5dfc100f6f6f399c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166799
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit f0a2969d15e3101d7f96a7fe77bca06a5d70f57a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166903
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-05-02 Mike Kaganski <mike.kaganski@collabora.com> [e7803234b5609d6ff66ebe79b7409d0fc822b067]
+
+ tdf#160898: check for nullptr
+
+ Regression after commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda
+ (tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09)
+
+ Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Tested-by: Jenkins
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166997
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-02 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [8b80b3daf5db792d86c0caf379ca010750cebba6]
+
+ seed 24-2 branch with android translations
+
+ Change-Id: Ib5f9e545d4dbef998ed8b7a3ffbea5e7e4c0a9d3
+
+2024-05-02 Caolán McNamara <caolan.mcnamara@collabora.com> [cd7ee2410a42da4b702cb32f57e038ba7d9f0854]
+
+ always check return of SfxViewFrame::Current()
+
+ Change-Id: If35fe03c775aec12ec534d02d58596aebcec764f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166985
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit caf719c59c6dc8db2b6a0eab8d47760277f112a3)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166902
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-02 Thorsten Behrens <thorsten.behrens@allotropia.de> [d83a475a8a1b409fc7634ba522a0f0801758b568]
+
+ Only run solver uitest if either lpsolve or coinbase is in
+
+ Change-Id: Ic03a6df33344b92dccc9bc393d718b4011aa1613
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162034
+ Tested-by: Jenkins
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+ (cherry picked from commit 580b2ecf88f7418374dff2d937c9e18f93d50381)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166897
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-05-02 Heiko Tietze <tietze.heiko@gmail.com> [77be21b5bd0bd339b2e629f5ec5ee00887033781]
+
+ Resolves tdf#141778 - Size issues on view options UI
+
+ Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166894
+ Tested-by: Jenkins
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-30 Caolán McNamara <caolan.mcnamara@collabora.com> [1ddc294779d81ce2a00b75d283f183890074e650]
+
+ Unchecked HeapAlloc
+
+ Change-Id: Icd49d0b5f996d57d8e9518cb08fd3c3fc54fa779
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166732
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit a70a8f55973ec3e71f65335be75699f1d2a73d62)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166833
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-30 Michael Weghorn <m.weghorn@posteo.de> [8fbff7fa22cc50132f09442e338fc71434c4a77a]
+
+ qt: Guard clipboard mime data with SolarMutex
+
+ Most of the access to the QtClipboardTransferable
+ mime data happens exclusively on the main thread,
+ with the solar mutex held.
+
+ However, `mimeData()`, called from `QtClipboard::getContents`
+ didn't ensure that yet, so as Michael Stahl pointed out in [1],
+
+ commit 1db5b87fe69c2375f1d66974dafcd563303c76db
+ Author: Michael Weghorn <m.weghorn@posteo.de>
+ Date: Tue Feb 13 13:23:17 2024 +0100
+
+ tdf#156562 qt: Sync with system clipboard content if necessary
+
+ introduced a data race by allowing to set new mime data.
+
+ Introduce a new
+ `QtClipboardTransferable::hasMimeData(const QMimeData* pMimeData)`
+ that guards access to the mime data with the solar mutext as well
+ and use that instead, so all access to the `QtClipboardTransferable`
+ mime data is now guarded by the solar mutex.
+
+ Also add an explicit note for the mime data getter/setter in the
+ `QtTransferable` base class that subclasses allowing to update
+ mime data are responsible for preventing data races.
+
+ [1] https://gerrit.libreoffice.org/c/core/+/166141/comment/fe75f418_40c1b622
+
+ Change-Id: I01dbbb0b37a4c6ad06b4d3001ecce8b0260eb32e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166750
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 621cfc0e4120ab2b381b54268fe39bd19257df9b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166892
+
+2024-04-30 Michael Weghorn <m.weghorn@posteo.de> [28b2020f276f12561252ea3a42555bfe88a0c1b6]
+
+ qt: Avoid race on QtTransferable member
+
+ As Michael Stahl pointed out in [1], there is a data
+ race on `QtTransferable::m_bProvideUTF16FromOtherEncoding`.
+
+ Adjust the code a bit to no longer make use of the
+ member and drop it.
+
+ The QtClipboard case was fine because both methods making
+ use of the member always run in the main thread with the
+ SolarMutex held.
+
+ For anything else, the `m_pMimeData` doesn't change
+ don't change, so access to that member doesn't need
+ to be guarded by a mutex and thus dropping
+ `QtTransferable::m_bProvideUTF16FromOtherEncoding`
+ should be sufficient to address that race at least.
+ (Another one will be addressed separately.)
+
+ [1] https://gerrit.libreoffice.org/c/core/+/166140/comment/bc1c9f11_6ad630b7
+
+ Change-Id: Iaf2fb460b129493f5627c95b6968aa57da368b4c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166749
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 8939999deef4f77f19d7b2d31df09260a34affe1)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166891
+
+2024-04-30 Michael Weghorn <m.weghorn@posteo.de> [2e4a593abc2fb82f7d26f73db71bb7fdd68add35]
+
+ tdf#156562 qt: Sync with system clipboard content if necessary
+
+ If the `QtClipboardTransferable`'s mime data gets out of sync
+ with the system clipboard's one, no longer cease operation
+ and stop reporting any transfer data, but sync with the
+ clipboard data, i.e. update the mime data with those
+ currently in the system clipboard.
+
+ For the "Paste Special" dialog with qt6 on Wayland
+ (see tdf#156562), an external clipboard update gets
+ triggered between the point in time when the
+
+ std::shared_ptr<const TransferableDataHelper> aDataHelper
+
+ in the `SID_PASTE_SPECIAL` case in `SwBaseShell::ExecClpbrd`
+ gets assigned and when the callback set via
+ `pDlg->StartExecuteAsync` gets called, even if there
+ was no user interaction with the system clipboard at all.
+
+ This however meant that the `aDataHelper` used in the
+ callback would no longer return any transfer/mime data,
+ so pasting wouldn't work.
+
+ Handle that case by updating the `QtClipboardTransferable`
+ mime data with the current system clipboard's data, but
+ keep emitting a warning at least.
+
+ As a consequence, opening the "Paste Special" dialog, then
+ copying something else to the clipboard, then confirming
+ the dialog will copy the newly copied data rather than
+ what was in the clipboard when the dialog was initially
+ started. That's the same for gtk3 already, but on Windows,
+ the original clipboard content would still be pasted.
+
+ (Retrieving the clipboard content anew in the callback using
+ `TransferableDataHelper::CreateFromSystemClipboard` instead
+ of passing the original `aDataHelper` into the callback
+ would have a similar effect. However, on other platforms,
+ reusing the previously copied data from the clipboard when
+ the actual system clipboard was changed in between may
+ be what's desired.)
+
+ The observed extra/unexpected clipboard change event may be
+ related/similar to what the following commit was addressing for
+ the case of LO itself being the clipboard owner:
+
+ commit 71471a36b125f6bdc915d5dbcae92ebcaa7ff5a4
+ Date: Tue Apr 6 01:41:08 2021 +0200
+
+ tdf#140404 Qt ignore "unchanged" clipboard events
+
+ LO gets a Qt signal on all clipboard changes. For X11 you get one
+ signal when you set the clipboard. Anything else normally signals
+ lost of clipboard ownership.
+
+ But on Wayland LO somehow gets a second notification without any
+ actual change. AFAIK it's not triggered by any LO actions and
+ isOwner still indicates, that LO has the ownership. This breaks
+ the single notification assumption, the code was relying on.
+
+ (...)
+
+ Backtrace showing how the clipboard update gets triggered
+ (with mode `QClipboardMode::Clipboard`, not just
+ `QClipboardMode::Selection`; qtbase dev as of
+ 0d0810e2dcc8a9ee28935af5daadc2ef36ed25a2):
+
+ 1 QtClipboard::handleChanged QtClipboard.cxx 156 0x7f6284c7a7a8
+ 2 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 153 0x7f6284c8450f
+ 3 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 72 0x7f6284c8500b
+ 4 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call qobjectdefs_impl.h 152 0x7f6284c8457f
+ 5 QtPrivate::FunctionPointer<void (QtClipboard:: *)(QClipboard::Mode)>::call<QtPrivate::List<QClipboard::Mode>, void> qobjectdefs_impl.h 200 0x7f6284c833ee
+ 6 QtPrivate::QCallableObject<void (QtClipboard:: *)(QClipboard::Mode), QtPrivate::List<QClipboard::Mode>, void>::impl qobjectdefs_impl.h 571 0x7f6284c81f81
+ 7 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 487 0x7f62841b863f
+ 8 doActivate<false> qobject.cpp 4116 0x7f628425772e
+ 9 QMetaObject::activate qobject.cpp 4176 0x7f628424cdef
+ 10 QClipboard::changed moc_qclipboard.cpp 182 0x7f62831e9fcc
+ 11 QClipboard::emitChanged qclipboard.cpp 558 0x7f62831e9bc1
+ 12 QPlatformClipboard::emitChanged qplatformclipboard.cpp 89 0x7f628324ed69
+ 13 QtWaylandClient::QWaylandDataDevice::data_device_selection qwaylanddatadevice.cpp 295 0x7f6281b8eaf1
+ 14 QtWayland::wl_data_device::handle_selection qwayland-wayland.cpp 985 0x7f6281b7389a
+ 15 ?? 0x7f629681a40e
+ 16 ?? 0x7f629681971d
+ 17 ffi_call 0x7f6296819ef3
+ 18 ?? 0x7f629955c921
+ 19 ?? 0x7f6299558c09
+ 20 wl_display_dispatch_queue_pending 0x7f629955a5ac
+ 21 QtWaylandClient::EventThread::dispatchQueuePending qwaylanddisplay.cpp 227 0x7f6281afd5f4
+ 22 QtWaylandClient::EventThread::readAndDispatchEvents qwaylanddisplay.cpp 109 0x7f6281afd124
+ 23 QtWaylandClient::QWaylandDisplay::flushRequests qwaylanddisplay.cpp 508 0x7f6281af5b98
+ 24 QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 153 0x7f6281b13ebb
+ 25 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 72 0x7f6281b151f0
+ 26 QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 152 0x7f6281b13f1c
+ 27 QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay:: *)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 200 0x7f6281b11250
+ 28 QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 571 0x7f6281b0d5e3
+ 29 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 487 0x7f62841b863f
+ 30 QMetaCallEvent::placeMetaCall qobject.cpp 650 0x7f6284243bf9
+ 31 QObject::event qobject.cpp 1447 0x7f6284245095
+ 32 QApplicationPrivate::notify_helper qapplication.cpp 3298 0x7f62823a696c
+ 33 QApplication::notify qapplication.cpp 3249 0x7f62823a677d
+ 34 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1138 0x7f62841b1162
+ 35 QCoreApplication::sendEvent qcoreapplication.cpp 1581 0x7f62841b1d0b
+ 36 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1936 0x7f62841b33c4
+ 37 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1770 0x7f62841b255e
+ 38 postEventSourceDispatch qeventdispatcher_glib.cpp 244 0x7f62846384ac
+ 39 ?? 0x7f628b9111f4
+ 40 ?? 0x7f628b914317
+ 41 g_main_context_iteration 0x7f628b914930
+ 42 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 394 0x7f6284638d41
+ 43 QPAEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 87 0x7f628395c418
+ 44 QtInstance::ImplYield QtInstance.cxx 453 0x7f6284cd9a40
+ 45 QtInstance::DoYield QtInstance.cxx 464 0x7f6284cd9b69
+ 46 ImplYield svapp.cxx 390 0x7f628f739c32
+ 47 Application::Yield svapp.cxx 474 0x7f628f73a9d0
+ 48 Application::Execute svapp.cxx 368 0x7f628f739925
+ 49 desktop::Desktop::Main app.cxx 1614 0x7f6299037216
+ 50 ImplSVMain svmain.cxx 229 0x7f628f758df4
+ 51 SVMain svmain.cxx 261 0x7f628f759109
+ 52 soffice_main sofficemain.cxx 94 0x7f62990a4367
+ 53 sal_main main.c 51 0x56508cf899d4
+ 54 main main.c 49 0x56508cf899ba
+
+ -------------------------------------------------------------------------------------
+
+ NOTE: This libreoffice-24-2 backport also includes a cherry-pick
+ of the follow-up commit
+
+ commit 8d98f231fa2d3f4386a842d0f45a9ceeea4ab8e1
+ Author: Michael Weghorn <m.weghorn@posteo.de>
+ Date: Thu Feb 15 08:52:25 2024 +0100
+
+ tdf#156562 qt: Don't crash on null clipboard content
+
+ squashed into this commit.
+
+ Change-Id: I1720d8acd72dca4ef6bc32935b920b2c1ff4d8f1
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163304
+ Tested-by: Jenkins
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ (cherry picked from commit 1db5b87fe69c2375f1d66974dafcd563303c76db)
+ (cherry picked from commit 8d98f231fa2d3f4386a842d0f45a9ceeea4ab8e1)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166141
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-30 Michael Weghorn <m.weghorn@posteo.de> [fedd7587477ae7c2b3f3cb350db3aeedbbb20f1c]
+
+ tdf#156562 qt: Don't cache supported mime types/data flavors
+
+ Drop the optimization to remember the supported
+ data flavors in `QtTransferable::m_aMimeTypeSeq`
+ and evaluate them each time instead.
+
+ This is in preparation of allowing to change
+ the mime data in an upcoming commit.
+
+ Another alternative would be to (re-)calculate
+ `QtTransferable::m_aMimeTypeSeq` only at the point
+ in time that the mime data are set. Keep that
+ in mind for further consideration in case this should
+ ever become relevant from a performance perspective.
+
+ Change-Id: Ic1792f6c2a19bf4c8f642a6288e9f3413fe7c893
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163303
+ Tested-by: Jenkins
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ (cherry picked from commit ee03b3a7e85c7bb293e161cc6ea7fe7bb3bc9240)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166140
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-29 Michael Stahl <michael.stahl@allotropia.de> [d45a0651990a58b8eb1306205cb2209d1012398f]
+
+ tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override
+
+ This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287
+ xmloff: ODF import: fix text:list override of list style" and subsequent
+ commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and
+ 1b2a6b98291cf8b7022951be19b915fe2a9e18e6.
+
+ It turns out that there is actually a paragraph in ODF 1.2 and later
+ that gives paragraph's indent priority over the list style's, which i
+ unfortunately missed when investigating the above issues:
+
+ 17.20 <style:list-level-label-alignment>
+ ...
+
+ The fo:text-indent and fo:margin-left attributes are evaluated only
+ for paragraphs inside list items whose paragraph styles do not specify
+ them. If one of the two properties, or both, are specified by the
+ paragraph style, the text indent and/or left margin are taken from the
+ paragraph style. In this case the paragraph style's properties are
+ used to determine the indent and margin for the text lines and thus
+ also the alignment position.
+
+ This is usually interpreted as "on the same level", so applying a
+ list-style at a paragraph style overrides the indents inherited from a
+ parent paragraph style, but if the style then specifies its own indents
+ that overrides the list style's indents.
+
+ Furthermore it turns out that Google Docs now imports this bugdoc the
+ same way as LO 7.5 does; unclear if that changed recently (it shows
+ it like Word does in the preview, but like LO 7.5 does after opening it).
+
+ This means the way MS Word imports the bugdoc, which remains unchanged,
+ now looks like a bug and we should not change LO to be compatible with
+ it (when the same structure is created in Word, storing to ODF and
+ loading again, it looks different too).
+
+ Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 546741148863ae0b2a25cc994a7323c8113cb573)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166716
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Andreas Heinisch <andreas.heinisch@yahoo.de> [30524d5998d38b7e216b721859c72fbfc56a5b5a]
+
+ tdf#160765 - Paste Special Dialog: Remember comments checkbox
+
+ After the change of tdf#139858 the comments checkbox was not remembered anymore after closing the dialog. In order to fix this issue, additionally check not only the NOTE flag but also for the ADDNOTES one.
+
+ Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762
+ Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
+ Tested-by: Jenkins
+ (cherry picked from commit 7e30434655754277bfa7ce7d8ec37b07181d2c92)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166838
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Miklos Vajna <vmiklos@collabora.com> [008b1c3a8652b33b9b42ca0794a21ce9754e96f2]
+
+ tdf#159379 sw: fix crash on dropping multiple as-char images
+
+ Have an empty Writer document, set preferences so images created via
+ drag&drop are anchored as-char, drop 2 images from a file manager,
+ crash.
+
+ The root of the problem is that the first image gets dropped fine, but
+ the second one would be anchored to the currently selected graphic node,
+ since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix
+ double-click opening frame dialog, not graphic dialog on images,
+ 2022-04-26).
+
+ The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic
+ node for a point inside the image looks correct, so fix the problem by
+ extending SwFEShell::Insert() to take the anchor position as the anchor
+ for the new image, in case a graphic node is selected.
+
+ The original use-case would use SwEditWin::ExecuteDrop(), but keep the
+ test simple and invoke the underlying SwFEShell::Insert() instead, that
+ also triggers the problem.
+
+ Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499
+ Tested-by: Jenkins
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ (cherry picked from commit f9f2b7590bb7b3334d499b6884cc7f3e80843b8c)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166511
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [6b20b3abc70c210ae52ecde24076ad08c4594fe0]
update credits
Change-Id: I92481956d041c4a5077aa7a56af2df3ab72fd9bf
(cherry picked from commit e729fec8a9e73e9d013cb634d4bcbd8c43be4200)
- (cherry picked from commit 6b20b3abc70c210ae52ecde24076ad08c4594fe0)
-2024-04-29 Julien Nabet <serval2412@yahoo.fr> [467b70a96820c70916015bb3386f219432e9c915]
+2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [32921f8ae0aea6d724a80974f2b213c799175ab5]
+
+ Update git submodules
+
+ * Update translations from branch 'libreoffice-24-2'
+ to 64792214d2d89afc019f94ca29ff7a2c2a17ab39
+ - update translations for 24.2.3 rc2
+
+ and force-fix errors using pocheck
+
+ Change-Id: Ia1b6ca2a6abad23632aafb021c8bba19a20e1a7b
+
+2024-04-29 Julien Nabet <serval2412@yahoo.fr> [cf370be03dfc6eb2cd4643548f2f25ad3bfc6612]
tdf#159625: fix "allow to split paragraph"
@@ -42,12 +2584,58 @@
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166725
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- (cherry picked from commit cf370be03dfc6eb2cd4643548f2f25ad3bfc6612)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166843
- Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-2024-04-29 Caolán McNamara <caolan.mcnamara@collabora.com> [cc4225317a5da0a883e1a58150f92802e16ac7aa]
+2024-04-29 Michael Stahl <michael.stahl@allotropia.de> [d33d3bbd9fb021c9ef15689f4e8e5b9898541e70]
+
+ tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuse
+
+ This is obviously wrong, as ALG just pointed out: the aIter is at the
+ end after the 1st loop, so the 2nd loop does nothing.
+ Thx Gabor for checking all the reported bugs.
+
+ (regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
+
+ Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90
+ Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ Tested-by: Jenkins
+ (cherry picked from commit ac05822b8957d80018d3ce1cbf97cd9faa0dfe99)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166712
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Miklos Vajna <vmiklos@collabora.com> [e49f965e6e0ae7f643ecc012c0fffce02a9cef29]
+
+ sc: fix crash in ScColumn::SetEditText()
+
+ Crashreport:
+
+ > SIG Fatal signal received: SIGSEGV code: 128 for address: 0x0
+ > program/libsclo.so
+ > ScColumn::SetEditText(int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
+ > sc/source/core/data/column3.cxx:2362
+ > program/libsclo.so
+ > ScTable::SetEditText(short, int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
+ > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
+ > program/libsclo.so
+ > ScDocument::SetEditText(ScAddress const&, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
+ > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
+ > program/libsclo.so
+ > ScDocFunc::SetEditCell(ScAddress const&, EditTextObject const&, bool)
+ > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
+ > program/libsclo.so
+ > (anonymous namespace)::finalizeFormulaProcessing(std::shared_ptr<(anonymous namespace)::FormulaProcessingContext>)
+ > sc/source/ui/view/viewfunc.cxx:565
+
+ Change-Id: I331ca8784702fdcb0ebad6a0a73390dbe2615ece
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166612
+ Tested-by: Jenkins
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ (cherry picked from commit e3ce4aad47c052dcd67107f7c91336f4ecc949be)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166525
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Caolán McNamara <caolan.mcnamara@collabora.com> [b18b3b51a7d397a16e85bf8ba83b27193c7cc8c5]
SfxViewFrame::Current() dereferenced without null check
@@ -60,12 +2648,20 @@
(cherry picked from commit 95d3e0d478686c7fa84f0bb8c466a1082333a47b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166830
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- (cherry picked from commit b18b3b51a7d397a16e85bf8ba83b27193c7cc8c5)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166841
- Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-2024-04-29 Julien Nabet <serval2412@yahoo.fr> [bb71d3949bbccc6c731933e2cd1e32b9b1080ddc]
+2024-04-29 Caolán McNamara <caolan.mcnamara@collabora.com> [5582ea36163d060887ff319baaf817f8581fe0db]
+
+ WaE: C6011 Derefencing NULL pointer 'pMF'
+
+ Change-Id: I76e85e8671623f7cdf994dce779c3944b8761acf
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166731
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit e5c988821db31f285cdd207e2a2ac849c0f1c099)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166832
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-29 Julien Nabet <serval2412@yahoo.fr> [2ed402dada3b8b64c6f23cf5afc068848ab1a528]
tdf#160827: fix crash when retrieving _MarkAsFinal value (docx) (take 2)
@@ -77,73 +2673,79 @@
(cherry picked from commit 45d2d90d2354a6a32297cde52c0041915499b19b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166726
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- (cherry picked from commit 2ed402dada3b8b64c6f23cf5afc068848ab1a528)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166839
- Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-2024-04-29 Patrick Luby <guibmacdev@gmail.com> [77c26dae7c984f5c60206091f87897079c8a5d93]
+2024-04-29 Alex Henrie <alexhenrie24@gmail.com> [a3d78ae9c38338ba186be97061a4086c54d7bbeb]
- tdf#153306 prevent subpixel shifting of X coordinate
+ Add missing file types to desktop files and alphabetize the lists
- HACK: for some unknown reason, if the X coordinate of the
- path's bounds is more than 1024, SkBlendMode::kExclusion will
- shift by about a half a pixel to the right with Skia/Metal on
- a Retina display. Weirdly, if the same polygon is repeatedly
- drawn, the total shift is cumulative so if the drawn polygon
- is more than a few pixels wide, the blinking cursor in Writer
- will exhibit this bug but only for one thin vertical slice at
- a time. Apparently, shifting drawing a very tiny amount to
- the left seems to be enough to quell this runaway cumulative
- X coordinate shift.
+ The missing MIME types were:
- Change-Id: Ic1ac8a390df51c4aa1cc3183590dce72059af6b6
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166766
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ * application/docbook+xml
+ * application/x-gnumeric
+ * application/x-pocket-word
+ * application/x-starchart
+ * application/x-starimpress
+ * application/x-starmath
+ * application/x-starwriter-global
+ * application/vnd.apache.parquet
+ * application/vnd.quark.quarkxpress
+ * application/vnd.stardivision.calc
+ * application/vnd.stardivision.chart
+ * application/vnd.stardivision.draw
+ * application/vnd.stardivision.impress
+ * application/vnd.stardivision.math
+ * application/vnd.stardivision.writer-global
+
+ Having the lists in alphabetical order will make it much easier to spot
+ missing types in the future.
+
+ Change-Id: Iae25bb074e8d22c6c6efeaf1101a1a07429accda
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166545
Tested-by: Jenkins
- (cherry picked from commit 05d3a99aa687ee4e1706f9403651379b7ebdad89)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166723
- Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+ (cherry picked from commit 5d7d94d5239c4ad7d8dc997ccbb0060ba2391280)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166729
-2024-04-29 Michael Stahl <michael.stahl@allotropia.de> [0d37975ae718e1baa312616dfbbd71496e077a49]
+2024-04-29 Patrick Luby <guibmacdev@gmail.com> [e1a5213427a876ae609635671f6fd6186aea1e67]
- sw: workaround crash in IsAllHiddenRow()
+ tdf#160831 only set outside color to black for alpha masks
- Not sure why but somehow still crashes in the code added in commit
- ab7893544dc6be6dc192dffefd57cd5ddd421c35
+ The outside color still needs to be white for the content
+ so only apply the fix for tdf#157795 to the alpha mask.
- https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33
+ Change-Id: I7486b2c9062ca96bf127f2bce6b1bd5e65d00ff6
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166806
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 5425103fb5a09c7e5e56d077260523438c593e21)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166727
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-26 Xisco Fauli <xiscofauli@libreoffice.org> [2dd760424554d597eb93fb6bc96ffddc9c5f1b18]
+
+ NotoSansHebrew: upgrade to v2.004
- Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010
- Tested-by: Michael Stahl <michael.stahl@allotropia.de>
- Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
- (cherry picked from commit 44ff9907eb1f2851b3b9087e7ec5e5dfae5a00c6)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165940
+ Change-Id: I5f58bc02b35c5995ba8af3f24f448f45dbb378bc
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166522
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
- Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
- (cherry picked from commit 13e517aa5baa1ce9afefd84ff41496c1adeb5367)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166092
- Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
-2024-04-29 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [f185f1fb1ce949f0ebe16eb23f7b76e90020e8cb]
+2024-04-26 Patrick Luby <guibmacdev@gmail.com> [ca574d5eef68af970cb49f90c7fc4fe813c9009c]
- Update git submodules
+ tdf#160714 use crop box for bounds of embedded PDF object
- * Update translations from branch 'libreoffice-24-2-3'
- to abc5b4da9d1c382d8f76eec58b3c6b0ba17f92bd
- - update translations for 24.2.3 rc2
-
- and force-fix errors using pocheck
-
- Change-Id: Ia1b6ca2a6abad23632aafb021c8bba19a20e1a7b
- (cherry picked from commit 64792214d2d89afc019f94ca29ff7a2c2a17ab39)
-
-2024-04-29 Andreas Heinisch <andreas.heinisch@yahoo.de> [985a85437c1352079ff1812b6039874b5226882b]
+ If there is no crop box, fallback to the media box just to be safe.
+
+ Change-Id: I29f99a43e550cf09a1534c0aa01ffd6a55536fb7
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166544
+ Tested-by: Jenkins
+ Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ (cherry picked from commit 4b31f87e918c38a7eb30ceb85563a5c98b426da5)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166670
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-25 Andreas Heinisch <andreas.heinisch@yahoo.de> [7e2e1d7fd4531f57bbc30a0a8e1cb8c40519a349]
tdf#160765 - Save content for undo when pasting notes
@@ -157,13 +2759,151 @@
(cherry picked from commit a1694b194c2b3e89250c5b79a69e7dd184b69976)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166523
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- (cherry picked from commit 7e2e1d7fd4531f57bbc30a0a8e1cb8c40519a349)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166527
- Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
-2024-04-29 Michael Stahl <michael.stahl@allotropia.de> [8c5b6aca5e3928dd89ecdd78ff0959bd6eccb6f1]
+2024-04-25 Xisco Fauli <xiscofauli@libreoffice.org> [644450951361025398cc8a4aeaab670eb33b0131]
+
+ NotoSerifHebrew: upgrade to v2.004
+
+ Change-Id: I857889598ad68902635e2dd349118c503a4fa70f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166590
+ Tested-by: Jenkins
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ (cherry picked from commit e835642a93b6e63f168333dea1b4bc8c26275218)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166521
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-24 Heiko Tietze <tietze.heiko@gmail.com> [32f7ef29615b25e91a73fe33632bb3b7ca506d04]
+
+ Resolves tdf#159569 - Conditional Formatting dialog jumps with message string
+
+ Some defined width solves the issue
+
+ Change-Id: I1f92815e690828e283c275a58a71dd07613642fc
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579
+ Tested-by: Jenkins
+ Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
+ (cherry picked from commit 9d29a2a6aad679129218ab4c5020c92bb3ce9cb3)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166520
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-24 Caolán McNamara <caolan.mcnamara@collabora.com> [78b62dadcc119359e9fd5ceb670e2585d18d4c3a]
+
+ Related: tdf#160056 various methods that don't need to be exported
+
+ IsSpecialStandardFormat can be private, only used internally
+
+ and rename to ImpIsSpecialStandardFormat
+
+ Change-Id: Ie20c83906559f94e545f384807396ec8acf970f9
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164537
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ ResetDefaultSystemCurrency can be private
+
+ only called by a friend from the same .so
+
+ Change-Id: I5f63e83325b291b95b0132089dc331f3b7e79362
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164538
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ GetNonEndOfPathToken can be private
+
+ Change-Id: Iebf8b84c205eee083ecf8b436520911ba132fe5c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164703
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ Related: tdf#160056 can be private and not exported
+
+ Change-Id: I3da15340809603b991d3a41beb2af7a0ba375acc
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165137
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+ Related: tdf#160056 ImpSubstituteEntry can be private and not exported
+
+ Change-Id: I895db1f02338b6c2a1fec8bdfc15c2857fbee38f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165138
+ Tested-by: Jenkins
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166124
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-23 Noel Grandin <noel.grandin@collabora.co.uk> [6b9cd13f502363c1784cdcb4538b6409a3a14c83]
+
+ tdf#160469 Ctrl+Alt+F4 is marked reserved, but doesn't do anything
+
+ this used to be SV_SHORTCUT_DOCKUNDOCK, which was introduced in
+
+ commit b342b183aaea042ef0e6e1c75304072cb4e1375a
+ Author: Rüdiger Timm <rt@openoffice.org>
+ Date: Tue Jul 24 09:03:18 2007 +0000
+ INTEGRATION: CWS mergesvp (1.1.2); FILE ADDED
+
+ I assume this was a solaris or something similar system hotkey, so
+ remove it as no longer being relevant.
+
+ Certainly nothing inside the vcl code is handling it specially.
+
+ Change-Id: I80b9d293e7db42e1ff523319862d44b93d3231c8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166502
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Tested-by: Jenkins
+ (cherry picked from commit bced98442d5e9c4b55ec6d4e5da3d549f8141359)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166513
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-22 Noel Grandin <noel.grandin@collabora.co.uk> [414d58e8fe8ecf545549dc960e1599b1035b7564]
+
+ tdf#160431 Inverts webp file image when inserted
+
+ regression from
+ commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
+ Author: Noel Grandin <noelgrandin@gmail.com>
+ Date: Fri Apr 16 20:33:10 2021 +0200
+ Convert internal vcl bitmap formats transparency->alpha (II)
+
+ Change-Id: I3b2959c99a2e18c3972920f8ca86072566d54225
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166450
+ Tested-by: Jenkins
+ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit c503b6eef32055f75dc9cf761bd20eda4f161dd4)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166434
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-22 Vasily Melenchuk <vasily.melenchuk@cib.de> [bed3fa30f442c9045264f34fd6abf940215c637b]
+
+ configure: cygwin issue with date fixed
+
+ previous variant was causing: "bash: /dev/null: ambiguous redirect"
+ and value was written
+
+ Change-Id: Ic8762a98f11ef2fee669478b5694ae1c5fb0b8ce
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166294
+ Tested-by: Jenkins
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+ (cherry picked from commit 5d3e3790e15cd05bea463bc4ff14d523163832fc)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166431
+
+2024-04-22 Michael Stahl <michael.stahl@allotropia.de> [bd3519a67250550e8b793ca11b1b620feb988dfe]
+
+ tdf#156146 tdf#159903 sw: add unit tests
+
+ Unfortunately the actual computed margins are not stored in text
+ formatting data structures so are only available directly from
+ SwTextMargin.
+
+ Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166221
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-22 Michael Stahl <michael.stahl@allotropia.de> [3df05ad4ec73e160f8c29af94ab3a34ee403b90d]
tdf#159903 xmloff: ODF import: fix bug in margin compatibility override
@@ -182,36 +2922,66 @@
(cherry picked from commit 1b2a6b98291cf8b7022951be19b915fe2a9e18e6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166217
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
- (cherry picked from commit 3df05ad4ec73e160f8c29af94ab3a34ee403b90d)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166512
- Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
-2024-04-29 Michael Stahl <michael.stahl@allotropia.de> [9b5b007df580eaeff2bab2fda9a6cb45e3a3bd24]
+2024-04-22 Justin Luth <justin.luth@collabora.com> [c3bbc3b5c06b743a206a33111c061d4d7d011f21]
- tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuse
+ xlsx export: fix corrupt file for Excel: protectedRange must have sqref
- This is obviously wrong, as ALG just pointed out: the aIter is at the
- end after the 1st loop, so the 2nd loop does nothing.
- Thx Gabor for checking all the reported bugs.
+ Excel refuses to open a file if there is no sqref specified
+ <protectedRanges>
+ <protectedRange name="corruptFile"/>
+ </protectedRanges>
- (regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
+ In this case, import failed to import sqref="10:131".
+ A follow-up commit avoids exporting these shorthand ranges.
- Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90
- Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643
- Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ I don't see much point in trying to create a unit test for this.
+ (I assume protectedRange is simply round-tripped
+ because I doubt LO has working support for protectedRanges.)
+
+ commit 9cee6a45632623d3d7e5a574128940f96d8c926b
+ Author: Eike Rathke on Thu Mar 20 10:16:50 2014 +0100
+ added ScEnhancedProtection to ScTableProtection
+
+ Change-Id: I97ef1ee801898bdcace067d62890c4ce0e7cf1d8
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166265
+ Reviewed-by: Justin Luth <jluth@mail.com>
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Justin Luth <jluth@mail.com>
+ (cherry picked from commit 78bd5e2523d077a67468b752d4788a2c3b43fb5f)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166220
+ Tested-by: Jenkins
+
+2024-04-20 Leonid Ryzhov <leoryzhov@gmail.com> [e611b94a9afc0a9b7d60dbaca364615c1a5b2813]
+
+ tdf#159395-LanguageTool use correct default URL when username/APIkey set
+
+ Change-Id: I31e1c2f1dfd96d87f60b6be1e5abce4837827a76
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165079
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ (cherry picked from commit 155a6af93a8ac90cab15968f5dd499ab77ad9f72)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166097
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-19 Mike Kaganski <mike.kaganski@collabora.com> [0324cb1c85b6daab8abaf139ac6b372127b76f06]
+
+ tdf#160717: fix ex handling
+
+ Same as in commit e27572686130df43d1d65c574b0c34f39fc0d1a9
+ (tdf#160593: make sure to use current element's font size for em unit,
+ 2024-04-18) for em.
+
+ Change-Id: Id9003c0426a6b373456da1aa1550f7ff07f766a3
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166235
+ Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ (cherry picked from commit edef46e82e7e54a27004f9ee6e99108390736d12)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166216
Tested-by: Jenkins
- (cherry picked from commit ac05822b8957d80018d3ce1cbf97cd9faa0dfe99)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166714
- Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
- Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
-2024-04-29 Mike Kaganski <mike.kaganski@collabora.com> [fa83f96bd8d987a7e9abce73d7b4ace1ff389ce7]
+2024-04-19 Mike Kaganski <mike.kaganski@collabora.com> [028feacd6a459d613e7a0d12788bf05b0e4c778c]
tdf#160700: Avoid both bookmark-start and bookmark-end at the same index
@@ -238,29 +3008,245 @@
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166280
- (cherry picked from commit 63ebbc33e8b1194f1e0ef7b58a98c6e4236476a9)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166219
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
-2024-04-29 Patrick Luby <guibmacdev@gmail.com> [24bf5dd70e721fd68df0e2bd06adb85ebaf4ea24]
+2024-04-19 Mike Kaganski <mike.kaganski@collabora.com> [97586e0b4712e44e360e6572af8483d81ac2346a]
- tdf#160831 only set outside color to black for alpha masks
+ tdf#160594: Use the recommended fallback of 0.5em for ex in font-size
- The outside color still needs to be white for the content
- so only apply the fix for tdf#157795 to the alpha mask.
+ This fixes the error of identical treatment of em and ex in font-size,
+ which violated https://drafts.csswg.org/css-values-4/#font-relative-length.
+ The fix uses the fallback of 0.5em for ex, similar to the code used in
+ SvgNumber::solveNonPercentage. A follow-up should implement the correct
+ use of "x-height of the first available font".
- Change-Id: I7486b2c9062ca96bf127f2bce6b1bd5e65d00ff6
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166806
- Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
+ Change-Id: Id9d581994e158d629d9752299ad93ac7e9fe4cad
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166234
Tested-by: Jenkins
- (cherry picked from commit 5425103fb5a09c7e5e56d077260523438c593e21)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166728
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166261
+
+2024-04-19 Mike Kaganski <mike.kaganski@collabora.com> [334446935b194ebdadb10004c01bff550f09838e]
+
+ tdf#160593: make sure to use current element's font size for em unit
+
+ According to https://drafts.csswg.org/css-values-4/#font-relative-length
+ em is "equal to the computed value of the font-size property of the element
+ on which it is used". This means, that for an element that defines its own
+ font-size, attributes like 'dy' using em refer to the new font-size, not to
+ inherited font-size.
+
+ Change-Id: Ie5a013df99a68edddf466e4c0ee5311f6219fcb2
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166233
+ Tested-by: Jenkins
+ Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
+ Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166260
+
+2024-04-18 Laurent Balland <laurent.balland@mailo.fr> [637312e2aa682ca11543a421a8de0bbbe72bf86b]
+
+ tdf#129701 Follow-up of previous change
+
+ According to comments in https://gerrit.libreoffice.org/c/core/+/163536
+ Follow-up of previous change
+
+ Change-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133
+ Tested-by: Jenkins
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+ (cherry picked from commit 47187acee758680cda8086b6e295ef7beea3491b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166178
+
+2024-04-18 Juan José González <juanjosegzl@libreoffice.org> [ed3cc2dde9a036b12508de5978a1ca47e0df790f]
+
+ Update git submodules
+
+ * Update helpcontent2 from branch 'libreoffice-24-2'
+ to 83b1b76cb72845dd5d605337cb8253b914086911
+ - Move z-index rule to CSS stylesheet we control
+
+ Previously a fix was pushed to prism css file, which can
+ be changed by the upstream project. Instead overwrite the
+ rule in our files.
+
+ Change-Id: I549b05d4a359343ae0fe09831644a2eed8fb0474
+ Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166076
+ Tested-by: Jenkins
+ Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
+ (cherry picked from commit 2b438594148c4ee94cb632e7a3d3b64b547706d5)
+ Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166211
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-17 Caolán McNamara <caolan.mcnamara@collabora.com> [257ba94f52c36d42ae05272dc9d42a35828ef993]
+
+ ofz#68081 keep within bounds
+
+ Change-Id: Ib7f11f2447d5a2cc6b9b559727f2a0127c15913e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166154
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit c09c61f5e3f7207006c3a26f5a79fabc29600350)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166098
+ Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+
+2024-04-17 Caolán McNamara <caolan.mcnamara@collabora.com> [3a3ab826e73cc98988f2044e497ca55461b40c4e]
+
+ Related: tdf#160056 use member init list
+
+ Change-Id: I09dea90e3e3f3fd0a4047b989329a027f788f695
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164148
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166123
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-15 Miklos Vajna <vmiklos@collabora.com> [f9a08c15e3a8fb078c1707d67a998f8c4d670e5a]
+
+ tdf#160067 sw floattable: fix missing move bwd of paras in split section frame
+
+ The last (5th) paragraph in the index was on page 2, even if page 1
+ still had space for it.
+
+ This is a regression from commit
+ 397d72e582c725d162c7e0b819dc6c0bb62e42b0 (Related: tdf#158986 sw
+ floattable: fix unexpected page break with sections, 2024-02-23), in
+ case SwLayAction::FormatLayout() doesn't calc its lower content frames
+ then this bugdoc is good, but the old bugdoc moves its floating table to
+ the next page, which would be bad.
+
+ Fix the problem by making the condition for this "calc lower in
+ FormatLayout()" action more strict: only do this for content frames
+ which are in sections, followed by sections.
+
+ Note that probably a cleaner way would be to completely stop calculating
+ content frames in SwLayAction::FormatLayout() and only do that in
+ FormatContent(), but then it's not clear how to re-fix tdf#158986, and
+ at least this resolves the regression.
+
+ Change-Id: Id671b3b68d8af8ad1cca3399a9aa028de58df3a0
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165878
+ Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
+ Tested-by: Jenkins
+ (cherry picked from commit 607fcac441c7f3a7d3c169c19039e581d707f2bb)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165841
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-15 Caolán McNamara <caolan.mcnamara@collabora.com> [24fa67d72fbc4aa0474ffc243938c5dcb10349ae]
+
+ ofz#67906 Integer-overflow
+
+ Change-Id: I459bdeef6bb7577c5388202374c981c7b01fa137
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165899
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166026
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+
+2024-04-15 Caolán McNamara <caolan.mcnamara@collabora.com> [af9fc39a7531bf4267895f99368ac075b79c759e]
+
+ reserve a TaskPriority for testtool IdleTask
+
+ Change-Id: I1fbd77cdeb643123afbb8bbdbd1ca38949e1b547
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162671
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 0f9847270c8dc606f70e59ec4a4b512283014078)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162626
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
- Tested-by: Patrick Luby <guibomacdev@gmail.com>
-2024-04-26 Patrick Luby <guibmacdev@gmail.com> [f7579474089bfc67f7d83680d562efa17783e4b4]
+2024-04-15 Caolán McNamara <caolan.mcnamara@collabora.com> [e310c8714cba16f592d59596caadf39bd01b61d0]
+
+ avoid SvNumberFormatter lock in formula-group-threading
+
+ keep a per-interpret-thread cache of the SvNumberFormatter
+ mapping while formula-group-threading, this is similar to:
+
+ commit c2d8341ee392949274b901abfd44d9645d2e4e36
+ Date: Tue Oct 15 08:32:22 2019 +0530
+
+ Cache last used number-format-type in interpreter-context
+
+ Change-Id: Ie99807eaf2f3260cec357f9d66307df0a69826e9
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164227
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 2c3605405225de4b850064cf25b15cd64be1409b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165748
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-15 Caolán McNamara <caolan.mcnamara@collabora.com> [992ec11cf73003d326ce7610a481c6bd19564588]
+
+ Related: tdf#160056 this can be be a local function
+
+ Change-Id: I0ffebd5a1f871b86507d0c1b3946b32993d76365
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165106
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit e8d01d2447b3350f1bd24e07580402c4c699756c)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165747
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-15 Caolán McNamara <caolan.mcnamara@collabora.com> [ba5cbbccefb5d55e19ed928cf900f8afb8337e9d]
+
+ Related: tdf#160056 this can be static
+
+ Change-Id: I1172854a1bf00e74adbe350c54e4e98ea38b0b35
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165072
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 49189bb8823adc6a76d3f33b34c02d6a640df96a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165746
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-14 Michael Stahl <michael.stahl@allotropia.de> [13e517aa5baa1ce9afefd84ff41496c1adeb5367]
+
+ sw: workaround crash in IsAllHiddenRow()
+
+ Not sure why but somehow still crashes in the code added in commit
+ ab7893544dc6be6dc192dffefd57cd5ddd421c35
+
+ https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33
+
+ Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010
+ Tested-by: Michael Stahl <michael.stahl@allotropia.de>
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 44ff9907eb1f2851b3b9087e7ec5e5dfae5a00c6)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165940
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-04-14 Eike Rathke <erack@redhat.com> [ae35c7770169a7ab8721ac26adf55e22491494ec]
+
+ Correct {bg-BG} formats with group separator
+
+ The leading # digit before the separator was omitted. This never
+ worked as intended.
+
+ Change-Id: Idf8a6cf246b8db4e6d5361bc1c5f66c1c0c057c5
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166072
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+ Tested-by: Jenkins
+ (cherry picked from commit afa957aeb9f0afd8179f02a4b4281c77b737300b)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165949
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-14 Caolán McNamara <caolan.mcnamara@collabora.com> [cce100f72dda8f5d4ae0c75c69a81603dc62e247]
+
+ tdf#160056 don't need to create a boost::intrusive_ptr to do search
+
+ with more recent c++ versions we can elide that construction for the
+ purposes of this comparison
+
+ Change-Id: I6a88219ef4451d2775b3b7ab1d9cf8adfb53e04d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164713
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit e5548dceb9086a6f0c8fa70bce8de6da0be72e40)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165713
+ Reviewed-by: Eike Rathke <erack@redhat.com>
+
+2024-04-13 Patrick Luby <guibmacdev@gmail.com> [acb6430800fccd120765110a3822c422fbc9a19d]
tdf#160590 Disable Metal with Intel HD Graphics 6000
@@ -272,87 +3258,256 @@
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
(cherry picked from commit fe3a4bdf48f7b2d4f6da31b4392ac5979653cf9c)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165946
- Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165945
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
- Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
- Tested-by: Patrick Luby <guibomacdev@gmail.com>
-2024-04-26 Noel Grandin <noel.grandin@collabora.co.uk> [1e8ac8b7c865d63014c6655e2e7e77979927c4f7]
+2024-04-13 Laurent Balland <laurent.balland@mailo.fr> [4e983181e038a539c3d9834c585037d4808c5d90]
- tdf#160431 Inverts webp file image when inserted
+ tdf#160567 Replace duplicate style A4 with A0
- regression from
- commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
- Author: Noel Grandin <noelgrandin@gmail.com>
- Date: Fri Apr 16 20:33:10 2021 +0200
- Convert internal vcl bitmap formats transparency->alpha (II)
+ Style A4 was defined twice and A0 was missing. Rename second A4 with A0
+ and change size to 48pt
- Change-Id: I3b2959c99a2e18c3972920f8ca86072566d54225
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166450
+ Change-Id: I529b4fab5223269908867531873d36d3e878e7e7
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166045
Tested-by: Jenkins
- Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
- (cherry picked from commit c503b6eef32055f75dc9cf761bd20eda4f161dd4)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166434
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
- (cherry picked from commit 414d58e8fe8ecf545549dc960e1599b1035b7564)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166510
- Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ (cherry picked from commit 838d2666e85fc27cdcfc66198b6d7a983eec1ea6)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165944
-2024-04-26 Patrick Luby <guibmacdev@gmail.com> [f15ac9bb71266a9c1c058a782e6752129aa4d0b3]
+2024-04-13 Jim Raykowski <raykowj@gmail.com> [419fc9947bdcef8d5ef4e6305be62c07d0d0854a]
- tdf#160714 use crop box for bounds of embedded PDF object
+ Resolves tdf#157403 sidebar SdNavigator does not show new slide/page
- If there is no crop box, fallback to the media box just to be safe.
+ after file reload
- Change-Id: I29f99a43e550cf09a1534c0aa01ffd6a55536fb7
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166544
+ Change-Id: I8ba7ffac3c098cf388a67e3454c5986b5a8b1f3f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165767
Tested-by: Jenkins
- Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
- (cherry picked from commit 4b31f87e918c38a7eb30ceb85563a5c98b426da5)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166671
- Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
- Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
+ Reviewed-by: Jim Raykowski <raykowj@gmail.com>
+ (cherry picked from commit 1dbe90cb078bddaf8bbd333823762744158c92bb)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165934
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-2024-04-23 Laurent Balland <laurent.balland@mailo.fr> [1d00b945c25c5b9df6553c0c89ef63749ac0a419]
+2024-04-12 Caolán McNamara <caolan.mcnamara@collabora.com> [aa225b41352f22c60f41fb9fa03c23b4e9359266]
- tdf#129701 Follow-up of previous change
+ IniLnge is set during ctor and never changes subsequently
- According to comments in https://gerrit.libreoffice.org/c/core/+/163536
- Follow-up of previous change
+ so no lock is needed for it
- Change-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133
+ squashed commits of:
+
+ there is only the one ctor, so drop misleading "preferred" comment
+
+ that suggests there are alternatives to choose from
+
+ Change-Id: Ica3367fae93f57f339bdc39b1cd91d47a2c9618e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164146
+ Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 023e59d0283614a568362b794bb94a9254401d7e)
+
+ SvNumberFormatter::ImpConstruct is only used once by the single ctor
+
+ so fold it into the ctor
+
+ Change-Id: If063143ef47a8ab293edf3896fb51079d0e0284f
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164144
Tested-by: Jenkins
- Reviewed-by: Eike Rathke <erack@redhat.com>
- (cherry picked from commit 47187acee758680cda8086b6e295ef7beea3491b)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166178
- (cherry picked from commit 637312e2aa682ca11543a421a8de0bbbe72bf86b)
- Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166215
- Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
- Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
- Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
- Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 657631791421eae2c88a89da27bd2c0dc1822175)
+
+ if we rearrange, we don't need to create maLanguageTag twice
+
+ Change-Id: I2c8ad9999adc406dc850c59b48e49681099dc054
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164147
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 9fcee419dd368823d842b9c9a032b2213ee24d34)
+
+ IniLnge is set during ctor and never changes subsequently
+
+ Change-Id: Ie052e32976d9810555c8f1892dab47a7472cdc71
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164149
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit 1245614991654b9d3ddb15f644a689585fd4c9de)
+
+ Related: tdf#160056 IniLnge is immutable
+
+ no lock needed here
+
+ Change-Id: I00461d44f78e9776568492fccb7dee0e9869944e
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164848
+ Tested-by: Jenkins
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+ (cherry picked from commit ee5b9597605176af0c80f9ea28caac9ba7980254)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165749
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
-2024-04-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [87e8d8037cafce6e7eca7cd05eb1fc763639c851]
+2024-04-12 Michael Stahl <michael.stahl@allotropia.de> [51dda113fd893fb879c0e8a345bc2b6b99e00771]
- bump product version to 24.2.3.1.0+
+ sw: layout: use page style set on hidden paragraph
+
+ SwPageFrame::FindPageDesc() now ignores paragraphs hidden for any
+ reason, but to maintain layout compatibility it should only ignore
+ paragraphs in a hidden section, not paragraphs hidden by fields.
+
+ (regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1)
- Change-Id: Ic9c7238409a969815c58aa3b1d7bb723bbf20b69
+ Change-Id: Iad5e76f5cc437d35b4ae9bde6bc9b73dbe32bf3d
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164761
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 7335babda93974104a39202c434e9499b8086f3a)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164742
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
-2024-04-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a6daec12469d25b14bdecf2698a24221b5d62a5d]
+2024-04-12 Michael Stahl <michael.stahl@allotropia.de> [6d3b6db240a826113a40df8cb6168816aef3441c]
- Branch libreoffice-24-2-3
+ sw: SelectAll of section with RES_PAGEDESC corner-case
- This is 'libreoffice-24-2-3' - the stable branch for the 24.2.3 release.
- Only very safe changes, reviewed by three people are allowed.
+ The main problem here is that if a document has a RES_PAGEDESC on its
+ first body text node, and you paste a section whose first text node also
+ has a RES_PAGEDESC, the result inevitably has a page break that wasn't
+ there before, and which is unwanted.
- If you want to commit more complicated fix for the next 24.2.x release,
- please use the 'libreoffice-24-2' branch.
+ SwEditShell::CopySelToDoc() needs a change to include the end node of a
+ section at the start, so it is copied.
- If you want to build something cool, unstable, and risky, use master.
+ Change CopyImplImpl() to insert a non-textnode *before* a text node at
+ the insert position, instead of after it. This simplifies the
+ implementation: only SwFEShell::Paste() needs to care about removing an
+ empty trailing paragraph, but SwEditShell::CopySelToDoc() needs no
+ changes; both functions would need to delete the empty paragraph when
+ inserting after.
+
+ Several tests such as CppunitTest_sw_ooxmlexport3 testCrashWhileSave
+ fail because of this, which can be solved by removing the DelFullPara()
+ call in SwXText::copyText() that is now unnecessary.
+
+ Generalise and simplify the "bAfterTable" code in CopyImplImpl(): it
+ doesn't really matter what is before the insert position, what matters
+ is if the pasted text starts with a table or section.
+
+ Also, the fly-anchor-correction code (both here and in
+ SwUndoInserts::RedoImpl()) needs to move to the first text node also in
+ case a section was inserted (but the equal-looking code *before*
+ inserting remains as is!), in the situation where the last node will be
+ deleted.
+
+ Now there are some test failures:
+
+ unowriter.cxx:430:Assertion
+ Test name: (anonymous namespace)::testSectionAnchorCopyTableAtStart::TestBody
+ equality assertion failed
+ - Expected: quux
+ foo
+ bar
+ - Actual : quux
+ foo
+
+ This is because the end position was created from SwNodeIndex aInsPos
+ only, it needs to take also the aDestIdx from the "if (pEndTextNd)"
+ branch.
+
+ testTdf134250::TestBody finished in: 867ms
+ uiwriter2.cxx:462:Assertion
+ Test name: testTdf134250::TestBody
+ equality assertion failed
+ - Expected: 1
+ - Actual : 2
+
+ The section is pasted now, so there are 2.
+
+ uiwriter3.cxx:1519:Assertion
+ Test name: testTdf135733::TestBody
+ equality assertion failed
+ - Expected: 1
+ - Actual : 2
+
+ Table is now inserted before the first paragraph, which has a
+ RES_PAGEDESC.
+
+ (presumably regression from commit 9667e5ffd18d6167344e102b89a393bc981644ec)
+
+ Change-Id: I820e381113fee90a81249afbc2280bfc3ddb7647
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164401
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit fcd4222d36e1864452163e5c94976eea353bbaf0)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164741
+ Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
+
+2024-04-12 Michael Weghorn <m.weghorn@posteo.de> [d1c29054449b00a16da6ee7ecaef0a94fe3964bf]
+
+ tdf#160176 svx: Reset help text when form control has none
+
+ In `FmFormPage::RequestHelp`, also call
+ `Help::ShowQuickHelp`/`Help::ShowBalloon` when
+ the help text is empty, as that is the way to
+ unset the help text/remove the tooltip again,
+ see `ImplShowHelpWindow` in `vcl/source/app/help.cxx`:
+
+ For the case of non-native tooltips (e.g. the
+ gen VCL plugin on Linux), the `bRemoveHelp = true`
+ code path is relevant.
+ For qt5/qt6/kf5/kf6 which use native tooltips,
+ the call to
+
+ pParent->ImplGetFrame()->ShowTooltip(rHelpText, rHelpArea)
+
+ further up sets the `QtFrame`'s `m_aTooltipText` member
+ to an empty string, which prevents showing the outdated
+ help text for the `QEvent::ToolTip` event in
+ `QtWidget::handleEvent`.
+
+ Change-Id: Iceb2424d9c72ae46333a718c677629122e517f11
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166006
+ Tested-by: Jenkins
+ Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
+ (cherry picked from commit 6347c89711903834cc9188abda5d5a253053b789)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165933
+ Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
+
+2024-04-11 Michael Stahl <michael.stahl@allotropia.de> [570a36ad5f76ea28e0653d1a7a43250432bf1afa]
+
+ tdf#88214 sw: text formatting: adapt empty line at end of para to Word
+
+ For an empty line at the end of an empty paragraph, Writer already uses
+ any existing text attribute in the paragraph, see for example
+ testEmptyTrailingSpans.
+
+ For an empty line at the end of a non-empty paragraph, Writer text
+ formatting uses only paragraph attributes, ignoring any text attributes,
+ whereas the UI will display the attributes from the text attributes
+ (such as font height) if you move the cursor there.
+
+ Word uses text attributes also in this case, so adapt the inconsistent
+ Writer behaviour: text formatting now uses text attributes too.
+
+ Apparently this can be achieved by calling SeekAndChgBefore() instead of
+ SeekAndChg().
+
+ Add another compat flag "ApplyTextAttrToEmptyLineAtEndOfParagraph" to
+ preserve the formatting of existing ODF documents.
+
+ Adapt test document fdo74110.docx, it has a line break with "Angsana
+ New" font.
+
+ Change-Id: I0863d3077e419404194b47110e4ad2bdda3d11c4
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165887
+ Tested-by: Jenkins
+ Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
+ (cherry picked from commit 2b47fae7e3e23ee7c733708500cb0482ad7f8af1)
+ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165906
+ Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
+
+2024-04-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [bdb455b6c62a1cfeb7e759fa7314d8653c453f84]
+
+ bump product version to 24.2.4.0.0+
+
+ Change-Id: Ie305c2fa2e92e34e5d8c450428a169fa014817f3
2024-04-11 Patrick Luby <guibmacdev@gmail.com> [dd769dd028dad7b67709e6c4268c595d1916a9e7]