diff options
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 4349 |
1 files changed, 4056 insertions, 293 deletions
@@ -1,72 +1,2431 @@ -2024-01-26 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1] +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [db4def46b0453cc22e2d0305797cf981b68ef5ac] - Version 24.2.0.3, tag libreoffice-24.2.0.3 + Version 24.2.1.2, tag libreoffice-24.2.1.2 -2024-01-26 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [4f5addb2843a6dc97c94bb15ba2a267c747ffd2e] +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [b39375c15f7b160378ec9e160307646a7a9544d4] - bump product version to 24.2.0.3 + bump product version to 24.2.1.2 - Change-Id: I6df3410fda715bf71330f96d90888fcefdc03a5b + Change-Id: Ie23a07309fd7206ff34c718329d6f7921dfd1578 -2024-01-26 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [11957f2e8def67f7505b0a57c97c2cb349047eec] +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [9cfb2071ab4c3bc5e12de06cbd75b9dd52768638] + + update credits + + Change-Id: Ie2fc3de7861b870d5a4b2aa9943af7401f21a1b7 + (cherry picked from commit fe47872aa8380567af7f453b9d3466cf7acd0d12) + (cherry picked from commit 2a18ca440961210b8f71cbabc2cf205d194169ef) + +2024-02-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a9320e6b296855d06bbba5d8181c3a79d9001a3a] Update git submodules - * Update translations from branch 'libreoffice-24-2-0' - to 192448749b74f8a3291eba3cf92bb2d6bd0b6729 - - update translations for 24.2.0 rc3 + * Update translations from branch 'libreoffice-24-2-1' + to cf2a5781160bbbd4c98d5cfbcac2a9b256f71cf4 + - update translations for 24.2.1 rc2 and force-fix errors using pocheck - Change-Id: I93e387c681acb9d7d3ae6b69cd57cafd4556e552 - (cherry picked from commit c53381e37074987d7baa37c72ede218c619bdb4f) - (cherry picked from commit 1884f687861c029ca3359fad879b1b261d07a718) + Change-Id: I529205bfbe25f3e4a843743d37ba26c23b626a84 + (cherry picked from commit e674dbc9fb3e9fbbeefa4d4db7e5f98f0c057bbe) -2024-01-26 Michael Stahl <michael.stahl@allotropia.de> [117fa5a2199a06e11eddf8d007704bdae68ea02d] +2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [9b82cdec8ea09e56f2b2189b73fbdd1c803f8210] - sw: fix crash in SwTextCursor::GetModelPositionForViewPoint() + libxml2: upgrade to release 2.12.5 - With a field that spans 3 SwTextFrames, it happens that - rText[sal_Int32(nCurrStart + nLength) - 1] - results in rText[-1]; it looks like both nCurrStart and nLength are - correct (nCurrStart was decremented in line 1531 after "if (bFieldInfo)") - so there is a missing check here. + Fixes CVE-2024-25062 - Change-Id: I0d5be617e8e54c20dc8633efd3a7d82510f4acd7 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162522 + Change-Id: I0e98fd919328e9633a602c4872de0b06eb972cc0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163734 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit 42a315b4a777dc371297752b6233e437d36c456b) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162546 + (cherry picked from commit 4c3ee61e3eda0cbfd812443f80af89aa3a24ac73) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163754 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163790 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Caolán McNamara <caolan.mcnamara@collabora.com> [cd074fc3d883b148418235009ef721b35b24deb9] + + upgrade libxml2, libxslt & liblangtag + + what I'm really after is some vexating not-reproducible oss-fuzz msan + warnings when using libxml2 in the fodt2pdf fuzzer. So lets upgrade + libxml2 to the latest, which requires bumping libxslt, and then requires + a newer liblangtag because of no longer implicit includes that it + depended on. + + xmlKeepBlanksDefaultValue and xmlSubstituteEntitiesDefault are + deprecated, we should get around to updating those uses + + Change-Id: I8fda0dffda0a7ea65407d246a3121875cb8ad4a4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161598 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 6875c975f80d8b813b1829a530162869a1e2d92e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163752 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163789 + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Xisco Fauli <xiscofauli@libreoffice.org> [2967b5776b26644de416253da2fdbc8fcfb18c71] + + tdf#159743: Revert all Shortcut modifications in German UI + + These changes have to be done exponentially and with the german + speaking community involved in the discussion + + This commit reverts: + + - 2d37ac2ca3a93cd7f05867ba7256c9e232192983 "Added & modified some + shortcuts for general compatibility." + - f5ae03b235766070b1c1e5bf46d0cb86a8196b10 "Writer German shortcuts + compatibility improvements." + - e651d9e657f9b61fb45777d6e7edeb5cb95f8d27 "German shortcut improvements + for Calc:" + - 691604d9037e72a94207d643cba29c64260b1cb9 "German shortcut changes for + Impress:" + - c0c8cffd3541e3cd616c96791b04e7ebf2b2ed03 "Writer: German language + shortcuts." + - 3bd3c41bc930406ec3d995a45a7f7060d572bbd0 "German keybindings:" + - 4b81692f8f3236082f9ac989e4e21c8119ff6e64 "Writer: Update German + language shortcuts" + + Change-Id: I233aa4cdd292cc21bfc28b628b822e9179eab415 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163759 + Tested-by: Jenkins + Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163809 + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [96861294836862f8a051a9d6dd390ab15c0460e4] + + tdf#159519 comphelper,package: do not store document without SHA256 + + The problem is that on Windows 7 the password-encrypted documents are + stored unencrypted, without any error message. + + This is due to defensive programming in + OStorageHelper::CreatePackageEncryptionData(), which happily continues + if creating the SHA256 hash fails, which is the one required for storing + anything newer than ODF 1.1. + + Also, the poorly named ZipPackage::GetEncryptionKey() should check for + consistency, the expectation is that either there's no encryption key + (empty sequence), or the expected one is in the sequence. + + Creating the SHA256 uses the crypto::NSSInitializer component, which is + in xsec_xmlsec.dll, which is linked to libxmlsec-mscng.dll, which is + linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on + Windows 7; to reproduce elsewhere, rm instdir/program/libxsec_xmlsec.so + + (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b + and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b) + + Change-Id: I0b22e20f6d4d0b1a12ed7d99fac7b5243910f9ba + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163708 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 58c31ded0264103769595a1b25739b0e8df571cd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163750 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 003f2ac9fcac9be5156adf280beaf4e2aa499ea5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163762 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Hossein <hossein@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Mike Kaganski <mike.kaganski@collabora.com> [a224f85c9bb9ab0a2e5a833dcb5ebb3eab4d7ea3] + + tdf#159302: Another UNO property "BaseLine" needs to use mm/100s + + Change-Id: I6688577a41590624f1e1f08112f1308e810a7e37 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163333 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit b6ef30d1b049977beb23d28a07d77012fa1daf47) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163339 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit df41d922ef7e6c99f72d65dad04b56c82a79ae30) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163340 + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Julien Nabet <serval2412@yahoo.fr> [6d69bfd42eb5ecb06a0a2b4dec8819fb6d1561f2] + + tdf#159707: fix crash when changing to edit mode (calc) + + bt: + 0x00007f9eb4b902f2 in com::sun::star::uno::Reference<com::sun::star::frame::XModel>::operator->() const (this=0x55b8c2b54888) at include/com/sun/star/uno/Reference.h:387 + 0x00007f9eb4c03584 in ScVbaEventsHelper::notifyEvent(com::sun::star::document::EventObject const&) (this=0x55b8c2b54840, rEvent=...) at /home/julien/lo/libreoffice/sc/source/ui/vba/vbaeventshelper.cxx:605 + 0x00007f9ef464bd3c in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XEventListener> const&) const (this=0x7ffc5044dfc0, listener=uno::Reference to (ScVbaEventsHelper *) 0x55b8c2b54870) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3293 + 0x00007f9ef463b8aa in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XEventListener>::forEach<(anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> >((anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> const&) + (this=0x55b8c2735c18, func=...) at include/comphelper/interfacecontainer3.hxx:279 + 0x00007f9ef463b010 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Any const&) + (this=0x55b8c2308ae0, aName="OnUnload", xController=empty uno::Reference, supplement=uno::Any(void)) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3338 + 0x00007f9ef463a089 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55b8c2308ae0, rBC=..., rHint=...) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2960 + + See full bt here: + https://bugs.documentfoundation.org/attachment.cgi?id=192546 + + Regression from: + https://git.libreoffice.org/core/+/d2fccf0117a37f8aab8bb50ece419987f06af6b9%5E%21 + "cool#6893 improve listeners in SfxBaseModel" + + Change-Id: I372808dade20c47275ab599054d8e9572dc3da4d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163356 + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Tested-by: Jenkins + (cherry picked from commit 6c6b580428bc527da9af82da743616787617b39b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163345 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-25 Michael Stahl <michael.stahl@allotropia.de> [016b75f8289276468cde320067ae3519fdeb94f4] + + tdf#159519 libxmlsec: avoid linking function not existent in Windows 7 + + xsec_xmlsec.dll is linked to libxmlsec-mscng.dll, which is + linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on + Windows 7. + + Use GetProcAddress() to retrieve BCryptKeyDerivation at runtime; the + function is not used by LibreOffice. + + (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b + and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b) + + Change-Id: I0c0c94ee0cdfd48ae7506d9dfb51fcaf8289d460 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163709 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 0690f3b7b981417a7b1f2fffd87c593a2a2a15d5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163740 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit aacb4fce006b537dade0417c0637fd584f7f2c2a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163761 + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-23 Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> [8d52be7d87c3be4a4792a0fab36835a8a2680e59] + + Fix typo: I10N -> L10N + + Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Tested-by: Jenkins + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163481 + Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163808 + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-22 Regina Henschel <rb.henschel@t-online.de> [f09fbbd8ae57d59c6ca264b042927330249ce163] + + tdf#156993 use correct count for ViewContactOfSdrPage + + The count is used as upper limit in a for-loop in + ViewObjectContact::getPrimitive2DSequenceSubHierarchy(). + That calls ViewContactOfSdrPage::GetViewContact(). + With the wrong count the case 10 was not reached and thus the helplines + were not drawn. + + Change-Id: If606bbb718b1f78a874862217d1e03b02287e848 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163192 + Tested-by: Jenkins + Reviewed-by: Regina Henschel <rb.henschel@t-online.de> + (cherry picked from commit 56517d8a38459f5a9e67327c1ac0dc8bcd07bcb8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163180 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 0f6e36496a1b398c5df1c8eb0570d5945d024e78) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163183 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Tested-by: Hossein <hossein@libreoffice.org> + Reviewed-by: Hossein <hossein@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Miklos Vajna <vmiklos@collabora.com> [5572a3fe4f567f9167efe2d291af5d7d1c414d9e] + + sw: fix crash in SwSpellDialogChildWindow::LockFocusNotification() + + Crashreport signature: + + Fatal signal received: SIGSEGV code: 128 for address: 0x0 + program/libswlo.so + SwSpellDialogChildWindow::GetNextWrongSentence(bool) + sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx:824 + program/libcuilo.so + svx::SpellDialog::GetNextSentence_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) + /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:919 + program/libcuilo.so + svx::SpellDialog::SpellContinue_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool) + cui/source/dialogs/SpellDialog.cxx:370 + /opt/collaboraoffice/program/libcuilo.so + svx::SpellDialog::InitHdl(void*) + /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173 + + Change-Id: I0ecae218beb30e5136f7a6f468e3eb9f6e6e5009 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163637 + Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> - Tested-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit d505b8d2730b93cea8d2dcf2656af37c6c8cc580) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163615 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit f6aa72589e0f20694c58af7a098558adb5c02abc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163627 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Noel Grandin <noel.grandin@collabora.co.uk> [5bd591dc06f174486a75991e785ae95fd99382c8] + + tdf#159666 Crash when table and line object are selected at the same time + + before + commit e3077168072452fb8f1c0a8afb2992877cb96d1c + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Thu Jun 17 09:49:37 2021 +0200 + loplugin:finalclasses + the cast in + const SdrEdgeObj* pEdge = static_cast<SdrEdgeObj*>(m_pObj); + would incorrectly cast a SdrTableObj, but it happened to do nothing + problematic. + + After the above commit, the vtable layout changed and it started + crashing. + + Work around it by use dynamic_cast and ignoring objects that are not + SdrEdgeObj. + + Change-Id: Ibe03d4935b8eeb182e037b1648d841e26fa23ed4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163242 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit bac09f76fd903c109b591a7bc15883e5653715ee) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163187 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 12b25cb35eb9cbb08363f4bd45e9190d3ef674b5) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163270 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Taichi Haradaguchi <20001722@ymail.ne.jp> [d8b1133a8fb9ddee010a9a38a25453f3b245ea9f] + + Expat: upgrade to release 2.6.0 + + Fixes CVE-2023-52425 and CVE-2023-52426. + + Change-Id: Id135bbaea893a83129bdbee44948c09322a64c07 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163146 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + (cherry picked from commit b7e4078033b064bfc3847db0916a4df389117817) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163392 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 66022adfa09662a082272f42bf0c34582abf38b1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163397 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Noel Grandin <noelgrandin@gmail.com> [7564f8651012ed0cbfbe6d37cd4effba308a2cd4] + + tdf#101313 Copy-paste table from writer to calc + + With Merged Cells from Writer to Calc, + Cells Placed in Wrong Position (Wrong cell offsets). + + regression from + commit ed24564ce11683731b820c29d5a46e073ab7a2a7 + Author: Noel Grandin <noel@peralex.com> + Date: Thu Jul 19 15:22:31 2012 +0200 + SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector + + Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 4df426e429e1aed92f074d8acd3ba3a5ec335ba9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163532 + (cherry picked from commit b5a5cae0e78e989c421a376bb55a724981c74d87) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163545 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-22 Patrick Luby <guibmacdev@gmail.com> [e0fd2489d5dd4b8b2bd41f6e42cfe64817a578da] + + tdf#159529 clear hb_ot_face_t data after fetching 'sbix' and 'glyf' tables + + The 'sbix' and 'glyf' tables can be very large for color emoji fonts + so clear any cached data in hb_ot_face_t after fetching that table's + extents. + + Change-Id: Id5deda9114b7199a4194ff16879e5791acd1cd82 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163674 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit af47a78e11d4819bb4b1ae1a1277babd10d815b7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163622 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Tested-by: Patrick Luby <guibomacdev@gmail.com> + +2024-02-22 Balazs Varga <balazs.varga.extern@allotropia.de> [0a300e60ed73f76eeb61035086df6cf857a2fa85] + + tdf#158360 - sw, ooxml import - fix insertTextPortion crash + + Before this patch da8dead8e9282010893cbd12519e107baf03cd1a + SvxUnoTextBase::insertTextPortion returned an empty XTextRange + in case of texts in comment. (SwTextAPIObject) Lets use + finishParagraphInsert which also give back an empty XTextRange. + + regression from commit: da8dead8e9282010893cbd12519e107baf03cd1a + (tdf#73537 - sc: show author and creation date in calc comments) + + Change-Id: I0b33e5b3cae32718a62a7be04b9a88562f85652c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163670 + Tested-by: Jenkins + Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> + (cherry picked from commit 7cf3d5e3073dc5cffc64b6d9b32513e90087a3d4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163626 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit 64248c5d42bbf46eeb4c41e79dd0b5e4a360e280) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163629 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-21 Baole Fang <baole.fang@gmail.com> [613135cef0b6b2cc9d01d9a7126fb6707fd473f0] + + tdf#159678: Fix heading dropdown list + + Change-Id: I65b6e6e5484f26b27e7851a6615550f527fcfb06 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163416 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 694b9b6422ee27da13ad455174cde50b1a673ac7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163406 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit 9d48831793cdbf93975b71083fbcc9577c17fceb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163617 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-20 Mike Kaganski <mike.kaganski@collabora.com> [adc2e086e7cbba4bb256a03df189a2e8ce273393] + + OpenSSL: upgrade to 3.0.13 + + Change-Id: Ib03c99a2dbf0f7c932b8a6b953ac9eb9c43f978f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163475 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 4897792975453024db8369c3d8c5f2e65c956d73) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163497 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 391d04f9f7b879dd4dfb4c770881196cbd73cb54) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163531 + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + Tested-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-17 Michael Stahl <michael.stahl@allotropia.de> [1742ce27ded54cc541356ae0a7b429a120341b70] + + nss: upgrade to release 3.98 + + Fixes CVE-2023-5388 + + Also update README, and remove obsolete documentation of Debian's + mangled SONAME; relevant Debian changelog: + + nss (2:3.13.4-2) unstable; urgency=low + + * debian/control, debian/libnss3*, debian/rules, + mozilla/security/coreconf/*, mozilla/security/nss/lib/*/manifest.mn: + Move to unversioned library. ABI compatibility is ensured upstream, and + the SO version, if it needed a change at any time, would be a change in + the library name. There is no reason to keep making compatibility more + difficult with other distros and upstream binary releases. While previous + versions were one-way compatible (binaries built against other distros or + upstream nspr could work on Debian), this approach works both ways. + + -- Mike Hommey <glandium@debian.org> Thu, 17 May 2012 09:45:36 +0200 + + Change-Id: Ifc1eae68827fa88ae001a3903c8555af67b488ac + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163482 + Tested-by: Michael Stahl <michael.stahl@allotropia.de> + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit c5e7af92ebcde59cb72fda2a88d08dc6656dc2e2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163504 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163520 + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> -2024-01-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [5212d0d520d3375b4a790ea456d1b4201d3e0ba0] +2024-02-17 Andras Timar <andras.timar@collabora.com> [743c626c7ebd04d06a4c8e71c21a7589dfa8ddd9] + + nss: upgrade to release 3.97 + + Change-Id: If0eaf6a93f57239d81491c635922745bf3f38fd5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163410 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit f25b7efba56757b085f7a836f57d9c2fc8fd14b8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163407 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 74486211adfb81a8b4d23c51457ff62acd804956) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163498 + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-15 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [675ca3a30cb414d702a1023ec0b583522c20caf2] + + update credits + + Change-Id: I8c189f3708898087560255fbf353ac88e1dad432 + (cherry picked from commit a21fb5bd8896ee8b82adf21f3e00cecaa521052f) + (cherry picked from commit 17f1d7c3705a40a5b982ee213c6d95762c546751) + +2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [4ac28ff6b015da09c3b8ba8ffc91179666836147] + + bump product version to 24.2.1.1.0+ + + Change-Id: I644fcefec24622bd690b0af6712a467ef506a1c3 + +2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [0376ed9695b18d925e3af1dfb4fd76068a6e01ec] + + Branch libreoffice-24-2-1 + + This is 'libreoffice-24-2-1' - the stable branch for the 24.2.1 release. + Only very safe changes, reviewed by three people are allowed. + + If you want to commit more complicated fix for the next 24.2.x release, + please use the 'libreoffice-24-2' branch. + + If you want to build something cool, unstable, and risky, use master. + +2024-02-09 Noel Grandin <noel.grandin@collabora.co.uk> [6b7a23022a4d2471df7b458f3ac61c8b768ea896] + + tdf#159641 TreeView repaint problem with PgUp in kf5/gen + + regression from + commit be53f32655973c7a18824d5145eed992be788d2f + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Thu Mar 12 13:55:55 2020 +0200 + rename vcl::Window::Update to PaintImmediately + + Change-Id: I74fc87e984e1f085d2351cbae033e51920608e3d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163154 + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Jenkins + (cherry picked from commit 30fb8cde7579fb5da15c1d8da9611198f2f5ce78) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163149 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-09 Michael Stahl <michael.stahl@allotropia.de> [59aca5a45b1bd5a3f9261ae12b9723ef89edde58] + + tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtf + + warn:legacy.osl:::writerfilter/source/dmapper/DomainMapper_Impl.cxx:1278: section stack already empty + DomainMapper_Impl.cxx:9817: void writerfilter::dmapper::DomainMapper_Impl::substream(): Assertion `m_aContextStack.size() == contextSize' failed. + + Before substream(), there is one CONTEXT_SECTION, after there is an + additional CONTEXT_PARAGRPAH. + + The first OSL_ENSURE is because RTFDocumentImpl::tableBreak() calls + endParagraphGroup() but in the substream, startParagraphGroup() hadn't + been called; fixing this also makes the assert failure go away. + + This worked previously because sectBreak() called endParagraphGroup() + after reading the header substreams, but it seems dubious that a + paragraph group started in the body should be used in the substream. + + (regression from commit 57abad5cf990111fd7de011809d4421dc0550193) + + Change-Id: I98864bca03b59099c17080c0a7582de2b77d41e1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163096 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 6446d3e12440be39e6b55f8749038061a1b240da) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163137 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-09 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [7c476ef48c0b475f117a23ca2290c9b43b2a566e] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to a90a713acbaa675695628c7553fbfc65d3847c30 + - update translations for 24.2.1 rc1 + + and force-fix errors using pocheck + + Change-Id: I433166ed6b62867bae2999cd5c7130dd386b3cec + +2024-02-09 Caolán McNamara <caolan.mcnamara@collabora.com> [788f2f0bea3d9feb83e9ffcded046c41bc41a0fa] + + crashtesting: still seeing occasional impl_notifyEvent_nothrow failures + + e.g.: + + #0 0x00007f5a3a5d45fc in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (this=this@entry=0x7f5a38ffd680, listener=empty uno::Reference) at include/comphelper/interfacecontainer3.hxx:253 + #1 0x00007f5a3a5d9427 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> const&) (this=this@entry=0x7f5a3035ea08, func=...) at include/comphelper/interfacecontainer3.hxx:275 + xListener = empty uno::Reference + iter = {rCont = @0x7f5a3035ea08, maData = {m_pimpl = 0x7f5a30132260}, nRemain = 1} + #2 0x00007f5a3a5d950e in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::notifyEach<com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035ea08, NotificationMethod=<optimized out>, Event=...) at include/comphelper/interfacecontainer3.hxx:290 + #3 0x00007f5a3a5d39f9 in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:200 + __func__ = "impl_notifyEvent_nothrow" + #4 0x00007f5a3a5d3b83 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:233 + rEventHolder = <optimized out> + #5 0x00007f5a57cd95ba in comphelper::AsyncEventNotifierBase::execute() (this=this@entry=0x7f5a3010f670) at comphelper/source/misc/asyncnotification.cxx:139 + + so lets guard the OInterfaceIteratorHelper3 ctor. + + might as well use empty() to return early then, and align + the OInterfaceIteratorHelper4 case with that. + + Change-Id: I138841840e032e6524792fb75168ccabc666b34c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162127 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit dd8dad09097225726cbcd878d95d5bd0aacdf042) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163101 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-09 Caolán McNamara <caolan.mcnamara@collabora.com> [ba81230114cfcd7b61ccfb7cb522d2d2630e375c] + + calc null-deref + + probably seen after a sheet was deleted + + /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f259a642520] + /opt/collaboraoffice/program/../program/libsclo.so(+0x5b3db8)[0x7f25873b3db8] + /opt/collaboraoffice/program/../program/libsclo.so(+0x4964a1)[0x7f25872964a1] + + this looks most likely: + + 00000000005b3db0 ScTable::ContainsNotesInRange(ScRange const&) const + 0000000000496440 ScDocument::ContainsNotesInRange(ScRangeList const&) const + + Change-Id: Ib019fe8abc18538eee7096e1fe5589e83e4849da + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163136 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 1fd89488d282cad8386af12064876f8ba0ac2956) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163145 + +2024-02-09 Noel Grandin <noel.grandin@collabora.co.uk> [9de81ad9460e3fdf7733d5ba740f08894ce4b1a7] + + tdf#158279 TOC links lost when converting .doc to HTML + + regression from + commit 8ce36e943f0e50970925b2dd77729ef6036b4a49 + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Sun May 26 15:15:41 2019 +0200 + move some searching inside IDocumentMarkAccess + + where I called the wrong method from inside Writer::FindPos_Bkmk + + The code was then removed in + commit 7bad1516c5f2a85b5bae3f49261ac2494cbb7162 + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Wed Jul 17 05:41:08 2019 +0200 + loplugin:unusedmethods + + Change-Id: I3f1e14a1e3ae2dd134738363e6b2679d2a2f418a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163095 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 0a32def8b519461b35b1e249d71ae9961b04400a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163029 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-09 Oliver Specht <oliver.specht@cib.de> [d37be1f9581a8a02c10c7bd88e83c74e2b46bc75] + + tdf#159478 read field comment in default encoding + + If a symbol font is applied inside a field the command string + was wrongly converted as symbol text. This is fixed by using a + default RTL_TEXTENCODING_MS_1252 encoding. + + Change-Id: I11326ef3c79d6d74c720a2b4ac4987ee6716d912 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162844 + Tested-by: Jenkins + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163120 + +2024-02-09 Oliver Specht <oliver.specht@cib.de> [e4ef509f3fea0c99708c111d731365b3225575d2] + + tdf#159572 select font according to recent settings + + selection of a recently inserted special character applies the + stored font to make sure the character is not inserted wit a + font that doesn't contain the symbol + + Change-Id: Id61bfac3a2ff22dbdae8a5b83f000d3f0c3e992b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163004 + Tested-by: Jenkins + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163128 + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-02-09 Oliver Specht <oliver.specht@cib.de> [49f63872d7149778efdd1add6f9eb0b7ca254089] + + tdf#159560 paragraph break should be shown as pilcrow sign + + When non-printing characters are switched on at the end of the paragraph + a pilcrow sign is shown. This is displayed using the font at the end of + the character. If a symbol font is used that would result in a random symbol + instead of the pilcrow sign (0x00b6). This is fixed here. + + Change-Id: I0d4ae9f439d2e34ca774d4e2cb188e94290808a8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162983 + Tested-by: Jenkins + Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + (cherry picked from commit 297b47a7e0c191be22f90ab799b4b8bb8bdbaf59) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163142 + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-02-09 Oliver Specht <oliver.specht@cib.de> [0b4032eedf5db37201c9ef9c007f4669fb204d6d] + + tdf#43848 fix selection in table with split/merged cells + + extends the selection of table cells to reach a more + rectangular selection area + Additionally tdf#155670 is taken care of by not showing the + row selection cursor if row selection is not supported + + Change-Id: If31aa1030c91d81bc889d8aaa668e96c5328f03f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162508 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + (cherry picked from commit aacf6f0e6059a3b24451da2782e0a0a420e89679) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163143 + +2024-02-08 Miklos Vajna <vmiklos@collabora.com> [80c5fe83bcbc7d7f6721890b3a42316b199f55a1] + + tdf#159483 sc HTML import: handle data-sheets-value attribute for the bool case + + Copy a cell with boolean TRUE and FALSE from google docs to Calc, the + paste result is a TRUE and a FALSE string. + + The problem is that boolean is meant to be a float 0 or 1 with custom + cell format, but we don't build this doc model. + + Fix the problem by ParseDataSheetsValue() to write the properties of the + cell similar to what the normal HTML import would extract from our own + markup, like: + + <td height="17" align="right" sdval="1" sdnum="1033;0;BOOLEAN">TRUE</td> + + This requires passing around both the value and the numbering + properties, since the cell format just decides it's a boolean, but the + cell value will decide if it's TRUE or FALSE. + + Change-Id: Id558ced56e02bbe24330d82c3998b047dc8febdb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163108 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit f8c95cf93ce9ab8b9b78f3af03411d0cc2e195ba) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163144 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Julien Nabet <serval2412@yahoo.fr> [b7a1ff456629549f66c93a5258073f1394598174] + + tdf#159595: Data validation without error check allows to enter wrong data + + Change-Id: If5660f462a07ca571e05a44abcb0e378b6de613e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163064 + Tested-by: Jenkins + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + (cherry picked from commit 9925937bb6b9be70befb8886ccc5665eff4ef227) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163020 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Oliver Specht <oliver.specht@cib.de> [c40fc3bc88f92baed2bc14a7667383078c77915d] + + tdf#159254 import paper bin/paper source from rtf/docx files + + Imports \binfsxn and \binsxn from RTF and + w:paperSrc from docx files and applies paper tray to the page style + if the printer supports the imported tray value. + Works only on Windows. + + Change-Id: Ie1170c58f7114f0dbf6bdd2721d4e077886cbe16 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162236 + Tested-by: Jenkins + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163119 + +2024-02-08 Xisco Fauli <xiscofauli@libreoffice.org> [71deb4bcc4e54b807c3a885652bebd8ee3f73cc0] + + tdf#159601, tdf#159594: reuse target for symbols' children + + Regression from e7186b49a9a0b24ddc3b1c5384b5d9facb03518c + "tdf#158445: support viewBox in symbol elements" + + Change-Id: Ie2198c47149def17fa3cb612046b61bf32e873bf + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163046 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 8b7dbf40a06bc900562887889c17606ae5ef0587) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163015 + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Noel Grandin <noel.grandin@collabora.co.uk> [74c66dfda671e01746f226758769689937f24388] + + improve loplugin:cow_wrapper + + some stuff was hiding inside templates + + Change-Id: I89fd1a926dd6bf96e35a74e5028165acae51c60c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162159 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163100 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-08 Miklos Vajna <vmiklos@collabora.com> [f5f6db55a5938f37a1c136be904ad7f10a3438ef] + + tdf#159483 sc HTML paste: handle data-sheets-value here, too + + HTML import into Calc could already create text cells, but HTML paste + with the same content remained auto-converted to numbers + unconditionally. + + Turns out HTML paste goes via ScHTMLLayoutParser instead of the HTML + import's ScHTMLQueryParser, so the data-sheets-value was ignored for + paste. + + Fix the problem by extracting the old data-sheets-value handler from + ScHTMLQueryParser to a separate ParseDataSheetsValue(), and use it also + in ScHTMLLayoutParser. + + For the actual handling, still only text is handled, no other formats + yet. + + Change-Id: I0b2bf4665af331d07624ed42e30a24e31bfca331 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163068 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 543e52481e764b8e0eea6cf0123a77cf492bdf8e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163130 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Xisco Fauli <xiscofauli@libreoffice.org> [968e815ec7fb2ff11bfae2c027fe26c45d4bcee0] + + CppunitTest_sw_a11y: disable test on Win ( 24.2 only ) + + This test fails in tb88-win when compiling libreoffice-24-2 + branch but not with master branch, so disabling it just in the + affected branch. Why it fails in one branch and not in + the other is a mistery + + Change-Id: Iec37ffe5f90689012f4fc3041075cbe0b6dbd002 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163118 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Xisco Fauli <xiscofauli@libreoffice.org> [977b8cf668a486cc8781cbfeebd4f9bdff3edc5f] + + tdf#159637: fix position of 'Windows Share' entry + + Started to happen after + + commit b91daea3c1a38883c06cdd63c6eababe1df9e61d + Author: Michael Stahl <michael.stahl@allotropia.de> + Date: Tue Nov 7 13:20:21 2023 +0100 + + tdf#146386 fpicker,svtools: remove FTP from Remote Files dialog + + Change-Id: I6ae78f96c1a1271de8cb2f0f114b92c3c213a068 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163115 + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit a381e87d16496d9fee98d9ff49fa2a38cc5c8fb2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163140 + Tested-by: Jenkins + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Henry Castro <hcastro@collabora.com> [d2ba2fa1123a07a9853124218342cc83c5176491] + + tdf#158440: do not extend transparent color + + Avoid to extend the area of transparent colors. + + Signed-off-by: Henry Castro <hcastro@collabora.com> + Change-Id: Ie492e6fea2c3d8b785cfbb96fe7cfc31d87b9996 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163030 + Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit c44e12ddb952c78dd08aba1774863554d7ecc7fa) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163024 + Tested-by: Jenkins + +2024-02-08 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [c654b5eeea3243c436b513cbfdd7b2b7894d8004] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 38966f0e280afefd34fa9ea29ee32af932450be0 + - update translations for 24.2.1 rc1 + + and force-fix errors using pocheck + + Change-Id: I1f5249691eb8653b1c7437b927b9a0d8df5d2d31 + +2024-02-08 Taichi Haradaguchi <20001722@ymail.ne.jp> [24d0bcea8085a6e7675cda1ac736dd7f1081a30e] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 1eed95f9a3d99dc12aa83fecbf7767630dfb79bd + - Fix link to graphic_size_check page + + Fix a bug that the "Help Page Not Found" page is displayed + when the Help button in the "Graphic Size Check" dialog is clicked. + + Change-Id: I6bf7c568b5f0dafc5d21de49d950b074cc09f442 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162645 + Tested-by: Jenkins + Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> + (cherry picked from commit 10c11a706ac08e4324a9439e42c748417c0e7f47) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162898 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-08 Mike Kaganski <mike.kaganski@collabora.com> [e137799397a36c481e92cdc00d6a3a4dbda296df] + + tdf#159458: make sure to update unexpanded URL when renaming library + + 1. If passed new source URL is expanded (i.e., trying to expand it in + SfxLibraryContainer::checkStorageURL didn't change it), previously + aUnexpandedStorageURL was unchanged. It should be cleared - then it + will be set automatically to the URL to lib info file. + + 2. Try to create the "variable" path (starting with "$(USER)/basic/") + because this avoids absolute paths to the libraries, which make it + harder to move the profile. + + Change-Id: Ie83ea9a32cfddf37727d238547663aeb72487ee3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162777 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 907d4107896234b2e7ebfd42f40cee3bd5b1d01e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162728 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-08 Andreas Heinisch <andreas.heinisch@yahoo.de> [bacf30464c601663c7c58020e7bf230cd3661768] + + tdf#158326 - Auto Filter: separate sorting and removing of duplicates + + Change-Id: Ide74895508af280f4b0c129689d852635e62dbff + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160052 + Tested-by: Jenkins + Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> + (cherry picked from commit 6d0fddb697fd619d11da3469f4dd72782334f3bb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162891 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Andras Timar <andras.timar@collabora.com> [3eb73e8bca02d2f0b16bc38c880dc529c83e23bc] + + LOK: disable popup bubble for hyperlinks + + Change-Id: I0ca21a90561affa453bd249c86e58793618f809e + (cherry picked from commit 88fea772610a4feef018ba03fd19749841772225) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162287 + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-08 Patrick Luby <plubius@libreoffice.org> [e1c125f6027970710eaa27bfe3d39476060878ca] + + tdf#158740 fix crash by checking the end node's index + + I don't know why m_nEndNode is larger than the size of the node + array, but adjusting m_nEndNode to the last element in the node + array stops the crashing. + + Change-Id: I425589457c6729b6689a7046f063154a2496e811 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162035 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 9bfd8e69385930d8f558c767f7b29149324d1b70) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162211 + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-02-08 Xisco Fauli <xiscofauli@libreoffice.org> [7e2cd9522fc7f465310f9cd73a37c08861e8f0b8] + + missing dependency in CppunitTest_sw_a11y + + Similar to 41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07 + "missing dependency in CppunitTest_test_a11y" + + Change-Id: I4dc9d0a5c59dc95e68fd489b3e672ef6ed14355a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163112 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-08 Justin Luth <justin.luth@collabora.com> [c723758d0540bdb4846eefb4b50b4bde212f1985] + + tdf#159581 sc: fix multi-sheet ScDocRowHeightUpdater + + Apparently it was caching the first sheet's + row height, and applying it to every other sheet. + + AFAICS, the only time this ever ran against multiple sheets + was during import time, so that is why it wasn't easily noticed + before 24.2 when XLSX started using it on import. + + make CppunitTest_sc_subsequent_filters_test2 \ + CPPUNIT_TEST_NAME=testTdf159581_optimalRowHeight + + Change-Id: Ic4e4dd335fa48d02acbc85cfad35feb8eca7597b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163066 + Tested-by: Jenkins + Reviewed-by: Justin Luth <jluth@mail.com> + (cherry picked from commit 9778d499df3d081314295ae099463870146b7a9c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163027 + +2024-02-08 Noel Grandin <noel.grandin@collabora.co.uk> [e4cc4aefc6715a54b140b6c962bff5af9f39dc37] + + missing dependency in CppunitTest_test_a11y + + found while doing other builds - if the build ordering is very unlucky, + acc is not built when this runs, the dynamic load fails in the + accessibility factory fails, and we fall back to using the + DummyAccessibilityFactory instead of the real one and the test will + crash. + + Change-Id: Ic16fdbe17d50c6be26b5627a4f515c91e1f7f609 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163091 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163026 + +2024-02-07 Caolán McNamara <caolan.mcnamara@collabora.com> [c7e9e3a35c00cae8cea13cbef1de9c696a881cdb] + + ofz: Use-of-uninitialized-value + + keep a high water mark of the highest initialized level + + Change-Id: Ib799331c523209c4f165dc4c40317e25b6b0cc7c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162624 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-07 Patrick Luby <plubius@libreoffice.org> [32e4f2d4d6e93f9bd9f17bd847300727017ef092] + + Don't reuse CertificateChooser instances + + Reusing the same instance will, in the following case, lead to a + crash. It appears that the CertificateChooser is getting disposed + somewhere as mpDialogImpl in its base class ends up being null: + + 1. Create an empty Writer document and add a digital signature + in the Digital Signatures dialog + 2. File > Save As the document, check the "Encrypt with GPG key" + checkbox, press Encrypt, and crash in Dialog::ImplStartExecute() + + Change-Id: I9aaa1bd449622e018b502d68c53d397255a1b61a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163065 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + (cherry picked from commit f0a5cb1f77496d212a90b5303a9f4be8b8c0e283) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163025 + +2024-02-07 Xisco Fauli <xiscofauli@libreoffice.org> [dd7a69068b8f92052b45a60014e6f6ed689c2947] + + tdf#157042: Revert "re-apply "optimize ConfigurationProperty::get()"" + + This reverts commit 3a4a00a51acca8f9b5e775547abff0c4dc9144d7. + + it's causing https://crashreport.libreoffice.org/stats/signature/%3Cname%20omitted%3E + in libreoffice-24-2 branch ( See + https://bugs.documentfoundation.org/show_bug.cgi?id=157042#c36 ) + In previous branches, it was reported as + https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*) + See comment in 7b46c77366fb3effd2de9bf5ba11ebd3c064974a + "tdf#157042: Revert "re-apply "optimize ConfigurationProperty::get()"" + + Change-Id: I3481c05b12b422404a38f0be1fea1ea69ffd0e46 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163061 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + +2024-02-06 Caolán McNamara <caolan.mcnamara@collabora.com> [17ac927774d5f1c66bffdd7854a344e37baadc77] + + LanguageTag ctor can canonicalize against various known tags + + so can optimize skipping the _lt_tag_canonicalize path which ends up + using a fairly expensive xmlXPathEval + + Change-Id: Ie96f16482d247f3731c1c8eac6d613736b8b289a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162596 + Tested-by: Jenkins + Reviewed-by: Eike Rathke <erack@redhat.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 313836d19f46d0e046d1c2b8c593727b0b0192ea) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162814 + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [6f14c818ad25e7fb1feb65ab8072e2a9918398d6] + + tdf#159015 sw: layout: fix infinite loop in ::CalcContent() + + SwObjectFormatter::FormatObj() will just return if IsAgain() is set, so + the while loop here won't make any progress. + + (regression from commit 191babee4f0ec643b80e96b0cd98c2d04ff96e4e) + + Change-Id: I1c194b148760ae05cf4dee1d5729be28e87d6ba0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162880 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 13865c4da30a3a2a5ab8efbd568c47952d3ffcee) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162894 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [a2a85724b3260713b1938a934fd73211d6e1d99d] + + tdf#123968 sw: fix assert on importing ooo62823-1.sxw + + svl/source/items/itemset.cxx:662: const SfxPoolItem* implCreateItemEntry(SfxItemPool&, const SfxPoolItem*, bool): Assertion `pSource->Which() == nWhich && "ITEM: Clone of Item did NOT copy/set WhichID (!)"' failed. + + XMLVariableInputFieldImportContext::PrepareField() first sets "Input" + and then "SubType" property. + + Apparently i missed that *both* of these are mutable in the API, and + both together determine whether the field is a RES_TXTATR_INPUTFIELD or + RES_TXTATR_FIELD. + + So call SwXTextField::TransmuteLeadToInputField() also when the + "SubType" is set, and adapt it to toggling 2 different things. + + Hmm... actually this will change these fields to be inline editable + after ODF import, which was the intention all along. + + It turns out that there is even a unit test testTdf123968 for this; it + works in the usual case, but in this case the input field is in a + header, so in styles.xml, and the styles.xml is imported before + content.xml and does not contain the variable-decls element, so the + variable field type has the GSE_EXPR subtype (default?), and setting the + "Input" property doesn't transmute it. + + (regression from commit 742baabbe4d077e1ba913a7989300908f4637ac7) + + Change-Id: Ib5757cda32287e51651f05f5b19e82d7be0431e3 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162941 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 99055ae98ef1fe67b8db4a8c3167a8acaeaac02f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163012 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Miklos Vajna <vmiklos@collabora.com> [536096309f78de9eabac38ffb9c04bff95ea7d91] + + tdf#159507 editeng: support pasting HTML fragments + + Commit ce53519f025158f8f64a4e8603c8c6e0dc35473a (cool#8023 editeng: + support HTML paste, 2024-01-24) added support for pasting HTML files + into Calc cells while editing, but this doesn't work when only a HTML + fragment is provided, without headers and footers. + + The HTML code in ImpEditEngine::PasteText() was modeled after the + HTML_SIMPLE case, which is some custom format from MSIE and that + rejected the data in case the header didn't match, so the HTML case also + required a HTML header in the above commit, but this doesn't work for + HTML fragments. + + Fix the problem by just dropping the header check in + ImpEditEngine::PasteText(), because that data already comes from the + text/html slot of the clipboard, so there is already indication about + the file format, even without the header. And without headers, it's + almost impossible to recognize if the HTML fragment is a HTML one or + not. + + Note that this is the HTML paste when a cell edit is active, the normal + Calc HTML paste is a different codepath, in sc/. + + Change-Id: I4d37d80f947880fe22051c5fe84dc6bbc257e108 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162927 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 0503f6718f7686f3e2c93fc13af23e9fbfdace42) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162903 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [b828a5e1acbeb1cd2dbf9da3d5cbcbaeca9096b5] + + check that rtl_random_getBytes() was successful + + ... everywhere it is used to generate material for encryption. + + Change-Id: Id3390376bb2f3a5fa1bbfd735850fce886ef7db2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162873 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit b85c2459ced6a41915dbaf567613fb5e244a0ada) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162890 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [b5a31c9cd0b53957a716a487e203f13919bac64c] + + writerfilter: fix missing paragraph break on tdf136445-1.rtf + + This causes an assert: + crossrefbookmark.cxx:44: sw::mark::CrossRefBookmark::CrossRefBookmark(): Assertion `IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark(rPaM) && "<CrossRefBookmark::CrossRefBookmark(..)>" "- creation of cross-reference bookmark with an illegal PaM that does not expand over exactly one whole paragraph."' failed. + + The problem is that there is an annotation at the end of a paragraph, + and reading the annotation changes various members of DomainMapper_Impl, + in particular m_bParaSectpr and m_bParaChanged, causing "bRemove" in + DomainMapper::lcl_utext() to be erroneously true, removing the just + inserted paragraph break again. + + Move all flags that are evaluated for bRemove to SubstreamContext. + + This causes one test failure, but it turns out that the new result is + the same as in Word 2013. + + Test name: (anonymous namespace)::testTdf108947::TestBody + equality assertion failed + - Expected: Header Page 2 ? + - Actual : + Header Page 2 ? + + (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b) + + Change-Id: I44a7a8928ab04c600d4d3c43bc4e4deeafe57d89 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162932 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 86ad08f9d25110e91e92a0badf6de75e785b3644) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162936 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [23d9c8ea006ad62b757f2610df1ad1c73c53b624] + + writerfilter: move members to SubstreamContext + + writerfilter: move m_bParaHadField to SubstreamContext + + Change-Id: Ie15e35d304a423bfa3d7b7ead71015d5ec1228d4 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162839 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 4913812baeabd44b46302e54b73a227e760c688a) + + writerfilter: use SubstreamContext for all substreams + + <vmiklos> possibly just nobody needed that so far. could be some more + general SubstreamContext, i don't see an obvious problem reusing that at + more places. + + Change-Id: If0749155452f65f8dfc4ac2b10f91bb8e48a6b2b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162840 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 95b01848b18283fd2f903c982108ccdb8efee022) + + writerfilter: move m_bFirstParagraphInCell to SubstreamContext + + This is a change to set it for all substreams. + + Change-Id: I44ed9a5485000f40f8ccfe3ec885ef8f05f5aab2 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162841 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 30323c813977eb0127251848fecd2532dce75749) + + writerfilter: replace members w/ SubstreamContext::eSubstreamType + + This should not change any behaviour. + + Change-Id: Ic970f0e1b6401119d875c9e811589b9c210e0c34 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162842 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 992f7114ab8645fb5b7a22b5f974a95fe7be7712) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162933 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [0a53b7f64dddc31b705080bb21230aae99212062] + + tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ header + + The problem was not fixed yet for the less-minimized bugzilla attachment + where the sections contain headers and footers. + + What happened there is that first \page caused a deferred page break, + then \sect and sectBreak() delayed-read the header substream and the + \par in the header resets all the deferred break flags. + + Add the deferred break to an already existing Context class, and remove + the direct members in DomainMapper_Impl in favor of always using the + m_StreamStateStack. + + Probably this problem cannot occur for DOCX import, because it imports + header/footer eagerly where the reference element is, and sectPr is + before any runs that contain breaks in the same paragraph element. + + Change-Id: Iba971955e9cf0c398d416518e72d99307d3e1cfd + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162833 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 17e2c7226a73675d69febf0915aaeae61ad8e9f1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162823 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [d5e2e66f8eb7cb89863ee0096f0569d2358fa1b7] + + tdf#158586 writerfilter: RTF import: handle \sect in frame as \par + + This fixes the test testTdf158586_0 and testTdf158586_0B to look like in + Word; the case appears a bit esoteric, hopefully Word won't actually + create such documents? But Word will round-trip such bugdoc to a DOCX + where the first w:p contains all of w:framePr and w:sectPr and w:br... + + Change-Id: I6ec09478a774e1e9c785e9482618c1afc388df0e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162778 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit dbe78489e98d565b72a703524308523135ffdd67) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162822 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Michael Stahl <michael.stahl@allotropia.de> [6dde3695c27b28165b5aa27de5a6e309b860e02f] + + tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone + + The problem is that \page is actually completely ignored in the bugdoc + testTdf158586_1. + + If you delete the \sbknone then there is a page break but it's caused by + \sect; the \page is still ignored. + + It is ignored because, first, the \page results in a deferred break in + DomainMapper, then for \sect, the synthetic \par is dispatched and that + moves the break from deferred to the top paragraph properties context, + then sectBreak() calls endParagraphGroup() which just removes the top + paragraph properties context. + + Remove the dispatchSymbol(RTFKeyword::PAR) for \sect, instead set a flag + so that RTFDocumentImpl::sectBreak() does it. + + Add a new flag m_bParAtEndOfSection so that RTFDocumentImpl::parBreak() + can suppress the startParagraphGroup(), so the deferred break remains + present. + + This also fixes testTdf158586_lostFrame. + + (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b) + + Change-Id: I82a00899a9448069832a0b2f98a96df00da75518 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162770 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 57abad5cf990111fd7de011809d4421dc0550193) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162821 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-06 Vasily Melenchuk <vasily.melenchuk@cib.de> [e52d61431b43336eca338d4afe061433fb7c97a2] + + tdf#158409: RTF import: use current run props for fields + + Fields import was not using current run properties causing + fallback to used style or default style what is wrong for RTF. + + Change-Id: I0189c6122b703a23ff910ee38da78aa05ac4d9f8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160387 + Tested-by: Jenkins + Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163057 + +2024-02-06 Gabor Kelemen <kelemeng@gnome.hu> [ca1db558aa4081b8ab0f8351252f7e16fa635fe7] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to f2ee21b4f0df120c737d7357e7d6dd2df92b4e9c + - tdf#159568 Fix link to extensions page -> Dictionaries category + + Change-Id: I729264913b54c797193bb6b9c238c8d72a94608c + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163045 + Tested-by: Jenkins + Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + (cherry picked from commit 3323d51dec401d59a5b0163294922d2487ba91a8) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163014 + +2024-02-06 Noel Grandin <noel.grandin@collabora.co.uk> [9c5500973bd99ef1323c85c6eefad86c86983f56] + + tdf#159461 deadlock in Dialog "XML Filter Settings" + + revert + commit 15405dc68b2e88b53585578567da13e3e99962db + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Mon Feb 20 15:43:41 2023 +0200 + osl::Mutex->std::mutex in FilterCache + + There is much recursive behaviour going on here, + via the configmgr and the listeners that FilterCache + has. + + Change-Id: Ice003404dffad9e5e63bcff30c2ceede4f52cab8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162930 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit b23aec2266da4cc2b3f4a34037d3a073a36d3d83) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162905 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-06 Xisco Fauli <xiscofauli@libreoffice.org> [96cc4fa5c4ba0794ea8febb19c3a6b5b010a8528] + + tdf#159566: match 'central' dominant-baseline to 'middle' + + Inkscape also does it the same way + + Change-Id: I3e1cea091e7314886bbc9135c55698892239bec7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163006 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit 358061b4a480ea763ea541094cef2112f917eb93) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163013 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + +2024-02-05 Patrick Luby <plubius@libreoffice.org> [aebea827555c29b30eded9a4e158b58c063613dc] + + tdf#147291 add more default certificate manager application for macOS + + Add the following applications to the macOS GUI servers list: + + - Trusted Key Manager - CertEurope + - SCInterface Manager and SmartCard tools + + Change-Id: Iec78171c6e82f0a072f5f06b79606560a8cc03cc + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162942 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 538f7b45c0c2c08124e9ea51a0947504f142a4f1) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162909 + +2024-02-05 Caolán McNamara <caolan.mcnamara@collabora.com> [326246599fa9488caf1ffb33daa75042ab782cb8] + + Resolves: tdf#156352 disable sorting while adding rows + + looks like the new row gets sorted immediately when added as an empty + row into the first row, so accessing it by index later to set it text/id + get an unexpected result. + + pause sorting while inserting the entries and enable it again when + finished for the easiest fix. + + Change-Id: Ib028b193afbf2b9026841b19419e012b70448e39 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162906 + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-02-05 Miklos Vajna <vmiklos@collabora.com> [af302ee34f74b4d71b1721d23f62225b7e66ff2e] + + tdf#158814 DOCX import: fix unwanted header with type="first" & no titlePg + + The bugdoc had no header in Word, but had one in Writer, since commit + 17e51f427b3f0cec74ac8e0a1b3f51189006ae6f (DOCX import: first page header + should always set default headers as well, 2014-11-21). + + The code has changed a log in the meantime, today we import first page + headers and left/right page headers as a single page style, but still + code was missing to detect the case when <w:headerReference + w:type="first"> was not followed by <w:titlePg>, which is an indicator + that the first page header/footer should be used. + + Fix the problem by new flags to SectionPropertyMap to track if we ever + seen a first/left/right header. This allows making an informed decision + in SectionPropertyMap::setHeaderFooterProperties(): if the header is on, + but we effectively don't have none of a first, left or right header, + then it's time to turn it off, similar to what the DOC import does. + + Note that this only changes behavior for headers, but if there is a + practical need, then the same could be also done for footers as well. + Instead of adding a new test, notice that testTdf112694 in + CppunitTest_sw_core_header_footer explicitly tests this case: a first + header which is not a title page. So change that testcase to assert the + behavior now matches Word and drop the FIXME. + + Change-Id: Ib604e786d7a5a197d4b562533326206697de882a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162992 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit d918beda2ab42668014b0dd42996b6ccc97e8c3a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162907 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-05 Patrick Luby <plubius@libreoffice.org> [ad8033e3beb9eeb44ecfb008f0caa2c5312fc951] + + tdf#159307 add default macOS certificate manager applications + + Most, if not all, of the Linux certificate manager applications are + not available on macOS so create a separate list for macOS. + + Also, fix uncloseable windows due to uncaught exceptions thrown by + XSystemShellExecute::execute(). Failure to catch such exceptions + would cause the document window to be uncloseable and the application + to be unquittable. + + Change-Id: I9bc6dc9c6c9d054252b634874045cb066023214a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162887 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 29bf86f7cb367705b13049e5f0b3faa8bb93638a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162900 + Reviewed-by: Patrick Luby <guibomacdev@gmail.com> + +2024-02-05 Vladislav Tarakanov <vladislav.tarakanov@bk.ru> [f0164f2755be1e759894601d6097ef70e0411f3d] + + tdf#158924 Handle multi-clicks for navigation bar + + Added handling for navigation bar buttons when many quick + clicks have been made. To do this, after processing the first click, + the number of clicks in the series is stored in a new variable. + Until the entire series of clicks has been processed, the slide + switch will not occur. + + Change-Id: I8f4416a0c7928bb78609be8ff52252782c37f5a0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161625 + Tested-by: Jenkins + Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> + (cherry picked from commit ab320f4e11c70b50e5beddf12ad925f192941d9a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162904 + +2024-02-02 Mike Kaganski <mike.kaganski@collabora.com> [9a6ec69ac28f36e6c637267bd71a7527162318eb] + + Avoid infinite loop (24-2-specific) + + The 'continue' didn't increment nPos. + In master, this is fixed by commit a53f0dc811a115cd68a5c297a68eeb5a9d3bb5ef + (Extract Local file header and Data descriptor handling into own functions, + 2024-02-02) + + Change-Id: Id20a1a543250efe0d359ec6d0f05fc23cff1c5ac + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162902 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Tested-by: Jenkins + +2024-02-02 Mike Kaganski <mike.kaganski@collabora.com> [c07f2a047e9201bbc0c2d55a2dada264b2094846] + + tdf#159496: clear mxObjectContainer in PrepareSecondTryLoad_Impl + + The problem here is that the object container has own reference to the + storage object. In SfxBaseModel::load, when preparing for a second try, + the storage gets disposed, and a cleanup is performed; but previously, + the reference to the disposed storage was used in the object container, + and thus generated a failure when it was used to import the OLE. + + Clearing it allows to re-create it properly, with the updated storage. + + Change-Id: I08b7503d79240ccc51b253fe1f4e99a0232995b1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162866 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 6bddbe51cee5c4aea023cc68771800f46a4aad2f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162828 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-02 Miklos Vajna <vmiklos@collabora.com> [0bb20afe3590838ba8aef204033ac95a047ba710] + + cool#8023 editeng: support HTML paste + + editeng text (e.g. Writer shape text or Calc cell text edit) had working + plain text and RTF paste, but HTML paste was not working. + + This is typically not noticed because desktop paste usually goes via + RTF, but it can be visible when a LOK client just puts the best format + on the clipboard, i.e. HTML is provided, but RTF is unavailable in the + browser and plain text is also not written to the LOK clipboard. + + Fix the problem by connecting the existing ImpEditEngine::ReadHTML() to + the generic ImpEditEngine::PasteText(): this already worked for plain + text and RTF, but not for HTML. + + Note that "SIMPLE_HTML" was already supported, but that's not really + HTML but some custom format that contains HTML, and it's claimed that MS + IE 4.0 produced this. + + (cherry picked from commit ce53519f025158f8f64a4e8603c8c6e0dc35473a) + + Change-Id: Ib41529c66d9bda30cc4ed5faca4a99274ae594d7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162547 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-02 Miklos Vajna <vmiklos@collabora.com> [0156a797ff62172354f95cb104be2d4893c89875] + + tdf#159483 sc HTML import: handle data-sheets-value attribute for the text case + + The A2 cell in the bugdoc has 01 in it, which was auto-converted to 1 + (float) value on import, even if it was text originally. + + This is hard to solve for HTML in general, which is not typed, but this + input is coming from google sheets, which has an additional + data-sheets-value attribute on <td> that does tell us about the type of + the cell. + + Fix the problem by handling that attribute, and in case it explicitly + says it's text, then apply the matching number format. + + Other types are not yet handled. + + Change-Id: I2986ef864e97d9c46d191aba25ca5740a1151a71 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162869 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit e6e5660b726ecf3b0c39b277568568973b43c9f0) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162893 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-02 Mike Kaganski <mike.kaganski@collabora.com> [d6c47949fc57d0fd115dc0f2f99ad8da89eab8bc] + + tdf#154587: allow directory entries in ZIP packages + + The problem in the bugdoc was the directory entries. These entries + are valid in ZIP packages (even if not common); they may be useful + to e.g. define per-directory permissions (ACLs). + + In normal mode, ZipFile reads central directory; there we can read + if the entry has FAT file attributes; and then, if the entry is a + directory. Then it is OK to skip it. + + In repair mode, central directory is not used, local file headers + don't contain a "directory" flag. A workaround is used, checking + if there are entries that represent directories of other entries. + + Also this change fixes some places that didn't pass the recovery + flag correctly. + + Change-Id: I324671841a2c4d0f279b03801d95c8f2eeb99b46 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162888 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 747463809e50c132557a95dcee6709a1fa82d760) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162897 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-02 Michael Stahl <michael.stahl@allotropia.de> [6d739a60bb4014f5b42e75ef909a2f5f7a1fb081] + + curl: upgrade to release 8.6.0 + + Fixes CVE-2024-0853 + + Change-Id: Iabba0748f7c48ee03a8223aef9ca81bf379738e9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162793 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 9667ea7e274c4e29cf7c35d9e124a8fbcb2af3da) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162812 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-02-02 Marco A.G.Pinto <marcoagpinto@sapo.pt> [564276033aef0031ca2ef0ba488a8d06c3db7f39] + + Update git submodules + + * Update dictionaries from branch 'libreoffice-24-2' + to d7bb4585419ce4496498ae5291947a3bf06ea1ec + - tdf#159164 Update the English dictionaries: GB+ZA+AU+CA+US + + Change-Id: I1ad3cb7a283f85cd8260d2d12f3abd78dfcf6206 + Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/162881 + Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> + (cherry picked from commit 208a9fd80b2a182fe20f224cd615119c6323ae2e) + Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/162899 + +2024-02-01 Noel Grandin <noel.grandin@collabora.co.uk> [61371bf3b19441d2c30a51153fcc675eafdd49b8] + + tdf#158695 convert-to bogusly needs libcui (--disable-gui build) + + Change-Id: I8e13902c4ee9b4b17e921b68b0626f7728cb0c18 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162749 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 8d26ca7f9ac37b5ada0a2c463b37181bcc8301a8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162810 + Tested-by: René Engelhard <rene@debian.org> + Reviewed-by: René Engelhard <rene@debian.org> + +2024-02-01 Olivier Hallot <olivier.hallot@libreoffice.org> [0d5d4974d3b6a493a8e52ca11a2318ca7e55749d] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 05baaa8a523645e77639e811a5296935f17e75e7 + - Update link to teasing video for master + + Change-Id: Iaa1d4a1729945d9a6cbf658bfac8071db6f02bfb + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162723 + Tested-by: Jenkins + Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> + (cherry picked from commit 549f8c25c3d2da1038ade4768a08ebb6ffb832f7) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162724 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-02-01 Mike Kaganski <mike.kaganski@collabora.com> [cffe6b2d7925d92424f1d6e02dafd32c1c9679cf] + + tdf#159474: fix handling of pre-set RepairPackage property + + StorageFilterDetect::detect had a wrong logic here, only honoring + repair request in case it haappened interactively inside it. The + pre-existing RepairPackage set to true was treated as "do not try + to repair". + + Change-Id: I3fb63a5d72097a79977e8ed734f8e69dd2ea999a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162858 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162867 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-01 Jim Raykowski <raykowj@gmail.com> [2212b3d09bbd09a7a70095c18e8f43cd4b2019d5] + + tdf#158101 Make non-gtk backends context popup menu item + + visibility behavior like gtk + + For context popup menus, gtk's native popup menu hides disabled menu + items. This patch makes this the behavior for non-gtk backends while + preserving the intent of commit + a0955317900075371d6adb7f924af24c22f02d09 to make VCL PopupMenu respect + the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting. + + Change-Id: Ice59f2b5ec20dac9d1b0891ccbd83dbbcd308078 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159192 + Tested-by: Jenkins + Reviewed-by: Jim Raykowski <raykowj@gmail.com> + (cherry picked from commit 1ac7350a7032a760be22cce845eab7efe435827d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162825 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-01 Noel Grandin <noel.grandin@collabora.co.uk> [b573e50839c8671abc94ac53905b1b027a3807d7] + + tdf#159350 Hiding Options dialog tabpages stopped working + + regression from + commit 3ed7511eca99819012fc1baa490ef85963a9472e + Author: Noel Grandin <noel.grandin@collabora.co.uk> + Date: Mon Jul 26 15:21:35 2021 +0200 + simplify SvtOptionsDialogOptions + + Change-Id: If300aefd3b249e64c15bc664ed16c00e743c2b80 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162836 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 8d9fba2ece350f82f307493b184447dbb44a971d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162826 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-02-01 Balazs Varga <balazs.varga.extern@allotropia.de> [3bbcae765e58bb02ca422edbb27d69388fdba4eb] + + tdf#159128 UI: Open Security settings option directly + + Open Security Option Setting page directly from Security pop up + warning infobar. + + Follow up of 1f440348eb0892fd2c9597806d87b5fe9d60d49a + (tdf#157482 UI: Turn Security Warnings popup windows into infobars) + + cherry-pick from commit: 2c16ea16b305dc546164e28cf6b212ebccc44ec4 + + Change-Id: Iac116677801bdb13a9680bcfdf532ec3d874ce0e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162393 + Tested-by: Jenkins + Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162491 + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-02-01 Stephan Bergmann <stephan.bergmann@allotropia.de> [89046b35d825220014adee558450e0caf5c6027e] + + tdf#159307 Let non-URIS_ONLY execute() handle .app directories on macOS + + Change-Id: I873daed9347b5e5bee4a630474438fce2cc73fec + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162768 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162801 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-01 Stephan Bergmann <stephan.bergmann@allotropia.de> [3712014bc7635187ee994126b505e58e2b3c7786] + + tdf#159307 Fix GetCertificateManager + + ...which had always cut off an existing path ever since + 92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f "Allow selecting a custom certificate + manager", for reasons that are unclear to me. + + So if an existing setting contains at least one slash (or backslash, on + Windows), try to use it as-is; otherwise, keep searching for it in aPath. (And, + in any case, make sure to report back the given value in sExecutable.) + + Change-Id: I8b2b6ac7a449d7afd02e029ff46d4c79e6b824e1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162703 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162800 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-02-01 Miklos Vajna <vmiklos@collabora.com> [d19f051dd4244bdfb58458d4287305b59c2915c6] + + tdf#159107 sw floattable: prefer inline table in footnote with change tracking + + Writer doesn't really support tables in footnotes, see the warning at + the top of SwFlowFrame::MoveFwd(). Still, there is some initial support + for them, since commit 11c51eefe8c3210cef2b5850f401ba67a401d01 + (tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes, + 2021-03-28). Similarly, redlines really just track insertion and + deletion, but some initial support for table operations were added in + commit eebe4747d2d13545004937bb0267ccfc8ab9d63f (tdf#144270 sw: manage + tracked table (row) deletion/insertion, 2022-01-12). + + The combination of these is a bit fragile, but the bugdoc happened to be + imported as an inline table (in a footnote, with recording changes) + before commit d477fa8ac1b0d3ee81427217bbb5950278ab16db (sw floattable: + unconditionally map <w:tblpPr> to SwFormatFlySplit, 2023-03-17). + + Fix the problem by explicitly importing floating tables as inline in the + footnote + redline case to restore the working use-case. + + DOCX import of this combination can be enabled again once Writer layout + works for the produced model. + + Change-Id: I9cd0a1fabb9807f5117cb5a36ec8597d6646eece + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162733 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit af15f8b7f346898677f1eee6521a6be1ff63eb56) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162716 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-31 Heiko Tietze <tietze.heiko@gmail.com> [2920c56159320965e81de99b11fb1ca5dd42c8d5] + + Resolves tdf#159328 - Fix field shading regression + + Introduced by 4d7a98b582dc70bbffc78e6622969e218f108433 + + Change-Id: Ibcc057e47c62d53dfa9e6410230c4b231df8551c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162799 + Tested-by: Jenkins + Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + (cherry picked from commit 788ebd183b095ffb7369c4d518acd14bad72ae82) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162820 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-31 Noel Grandin <noelgrandin@collabora.co.uk> [d891af6d9b876b172a77df5315c0a176f8dbdc6f] + + tdf#159131 Calc is laggy when moving a line (row) + + revert 69910b540ae5140123fd2d4d67a9d338f980db53 and + add a couple of pre-emptive reserve calls, to prevent repeated + resizing. + + I'm not sure why the above commit causes trouble on Windows, but + not Linux, something in the std::vector::reserve implementation + no doubt. + + Change-Id: I858303a0a1e12d204fd3bbccc6c6c7ce57564e5b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162746 + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 21dd07f95d7dcb95f243753306108c18d9ba115a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162726 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-31 Mike Kaganski <mike.kaganski@collabora.com> [e4b66492cebe6cad3afa77e81db4d60eb9b7eba1] + + Make sure to only dynamic_cast once + + Commit 3078020b07e41a6533ba71755d8cc8095bc3c3a7 (sw34bf04: #i109272#: + SwXTextPortionEnumeration: fix CrossRefBookmark handling 2011-03-01) + moved the dynamic_cast to the general case in lcl_FillBookmark. Later, + commit 9b01059f6e2143c5b5b481f3d321309648fc7dd4 (SwXTextPortionEnumeration + ctor: avoid dynamic_cast in the common case, 2014-10-28) split it into + two: for bookmark start, and for bookmark end. Both will happen, when + the bookmark is fully inside the node. + + This makes sure to only dynamic_cast once, and only when necessary. + + Change-Id: I3b88504b0cd21a644cf9933143312a4fb570b27a + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162732 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162803 + +2024-01-31 Mike Kaganski <mike.kaganski@collabora.com> [bf158e76815e0bca92441e2c3bbefc12193cba0e] + + Acquire solar mutex in SkiaZone, instead of asserting + + The assertion is there since commit 7c1dc527837a65b77f7624e18a575271cb46afba + (ensure SolarMutex is held for SkiaZone, 2020-09-29). For unclear reason, + it now started to fail locally in JunitTest_toolkit_unoapi_3: + + vcllo.dll!SkiaZone::SkiaZone() Line 23 C++ + vcllo.dll!SkiaSalBitmap::ResetAllData() Line 1412 C++ + vcllo.dll!SkiaSalBitmap::Create(const Size & rSize, vcl::PixelFormat ePixelFormat, const BitmapPalette & rPal) Line 85 C++ + vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, vcl::PixelFormat ePixelFormat, const BitmapPalette * pPal) Line 132 C++ + vcllo.dll!`anonymous namespace'::GIFReader::CreateBitmaps(__int64 nWidth, __int64 nHeight, BitmapPalette * pPal, bool bWatchForBackgroundColor) Line 224 C++ + vcllo.dll!`anonymous namespace'::GIFReader::ReadLocalHeader() Line 513 C++ + vcllo.dll!`anonymous namespace'::GIFReader::ProcessGIF() Line 807 C++ + vcllo.dll!`anonymous namespace'::GIFReader::ReadGIF(Graphic & rGraphic) Line 946 C++ + vcllo.dll!ImportGIF(SvStream & rStm, Graphic & rGraphic) Line 1005 C++ + vcllo.dll!GraphicFilter::readGIF(SvStream & rStream, Graphic & rGraphic, GfxLinkType & rLinkType) Line 920 C++ + vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, std::basic_string_view<char16_t,std::char_traits<char16_t>> rPath, SvStream & rIStream, unsigned short nFormat, unsigned short * pDeterminedFormat, GraphicFilterImportFlags nImportFlags) Line 1328 C++ + vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 1861 C++ + vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance, ConvertData & data) Line 1832 C++ + sofficeapp.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 111 C++ + sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop * __formal, ConvertData & rData) Line 1722 C++ + sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void * instance, ConvertData & data) Line 1719 C++ + vcllo.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 111 C++ + vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic, ConvertDataFormat nFormat) Line 39 C++ + frmlo.dll!ImageProducer::ImplImportGraphic(Graphic & rGraphic) Line 187 C++ + frmlo.dll!ImageProducer::startProduction() Line 147 C++ + frmlo.dll!frm::OImageControlModel::doSetControlValue(const com::sun::star::uno::Any & _rValue) Line 610 C++ + frmlo.dll!frm::OBoundControlModel::setControlValue(const com::sun::star::uno::Any & _rValue, frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 2127 C++ + frmlo.dll!frm::OImageControlModel::impl_updateStreamForURL_lck(const rtl::OUString & _rURL, frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 423 C++ + frmlo.dll!frm::OImageControlModel::impl_handleNewImageURL_lck(frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 437 C++ + frmlo.dll!frm::OImageControlModel::setFastPropertyValue_NoBroadcast(long nHandle, const com::sun::star::uno::Any & rValue) Line 259 C++ + cppuhelper3MSC.dll!cppu::OPropertySetHelper::setFastPropertyValue(long nHandle, const com::sun::star::uno::Any & rValue) Line 523 C++ + comphelper.dll!comphelper::OPropertySetAggregationHelper::setFastPropertyValue(long _nHandle, const com::sun::star::uno::Any & _rValue) Line 534 C++ + cppuhelper3MSC.dll!cppu::OPropertySetHelper::setPropertyValue(const rtl::OUString & rPropertyName, const com::sun::star::uno::Any & rValue) Line 266 C++ + mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214 C++ + mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430 C++ + binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239 C++ + binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79 C++ + binaryurplo.dll!request(void * pThreadSpecificData) Line 84 C++ + cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101 C++ + cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169 C++ + cppu3.dll!threadFunc(void * param) Line 190 C++ + sal3.dll!oslWorkerWrapperFunction(void * pData) Line 69 C++ + ucrtbased.dll!00007ff9dfee3010() Unknown + kernel32.dll!00007ffaab01257d() Unknown + ntdll.dll!00007ffaac28aa58() Unknown + + No idea what caused the problem only now. But since solar mutex is + expected to be hold here, let's just do it. + + Change-Id: Id848f5f43759ef37faa0d18ed3133a7292b3463f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161504 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 75c89e5603b5fbe4fa2b307f565c071f3b36216b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161426 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-31 Miklos Vajna <vmiklos@collabora.com> [e5f43ead6411e656f01e22b8e60b3e093cc391b0] + + tdf#159452 sw content control, PDF export: fix checked checkboxes + + Regression from commit 9bad5be0ffdcdee92d40162b598ed2ab2815e5d5 (sw + content controls, checkbox: add PDF export, 2022-09-13), we used to + export checkbox content controls as plain text, but once checkbox + content controls are exported as forms, the state of the checkboxes are + lost. + + Writer content control checkboxes support custom values for the checked + and unchecked states, but the PDF export does not. On one hand, + PDFWriterImpl::createDefaultCheckBoxAppearance() assumes that the + checked state should be a checkmark, not the Writer default 'BALLOT BOX + WITH X' (U+2612). On the other hand, the PDF spec section 12.7.4.2.3 + "Check Boxes" says that the checked state should be "Yes", which + explains why our checked state is not recognized by PDF readers. + + Fix the problem by making the export of checked/unchecked states + conditional in SwContentControlPortion::DescribePDFControl(): the + checked state then shows up as expected. + + Leave the unchecked case unchanged, the current markup there doesn't + cause problems. + + Change-Id: I9063d8607c8cccfa080921af38b3cbfe40905115 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162765 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 256e2c679bcbb3ea446884d0ff4e3f8687b82ede) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162729 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-31 Julien Nabet <serval2412@yahoo.fr> [dea542e3b4216b41b3593485caa7d21cd2195041] + + tdf#159288: Assertion on insert trend line + + 5 0x00007fd6780533a2 in __assert_fail + (assertion=0x7fd66de41177 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7fd66df2c58b "/home/julien/lo/libreoffice/vcl/source/app/dbggui.cxx", line=35, function=0x7fd66de5d0c6 "void ImplDbgTestSolarMutex()") at ./assert/assert.c:101 + 6 0x00007fd66f0dd6a2 in ImplDbgTestSolarMutex() () at /home/julien/lo/libreoffice/vcl/source/app/dbggui.cxx:35 + 7 0x00007fd677522f10 in DbgTestSolarMutex() () at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:54 + 8 0x00007fd66f3aea88 in ImplFontCache::GetFontInstance(vcl::font::PhysicalFontCollection const*, vcl::font::FontSelectPattern&) (this=0x564a8f77e0c0, pFontList=0x564a8f7783d0, aFontSelData=...) + at /home/julien/lo/libreoffice/vcl/source/font/fontcache.cxx:117 + 9 0x00007fd66f3ae987 in ImplFontCache::GetFontInstance(vcl::font::PhysicalFontCollection const*, vcl::Font const&, Size const&, float, bool) + (this=0x564a8f77e0c0, pFontList=0x564a8f7783d0, rFont=..., rSize=Size = {...}, fExactHeight=12, bNonAntialias=false) at /home/julien/lo/libreoffice/vcl/source/font/fontcache.cxx:111 + 10 0x00007fd66eb905f6 in OutputDevice::GetDefaultFont(DefaultFontType, o3tl::strong_int<unsigned short, LanguageTypeTag>, GetDefaultFontFlags, OutputDevice const*) + (nType=DefaultFontType::CJK_SPREADSHEET, eLang=..., nFlags=GetDefaultFontFlags::OnlyOne, pOutDev=0x564a8f6bfca0) at /home/julien/lo/libreoffice/vcl/source/outdev/font.cxx:573 + 11 0x00007fd62e86669d in chart::CharacterProperties::AddDefaultsToMap(std::__debug::unordered_map<int, com::sun::star::uno::Any, std::hash<int>, std::equal_to<int>, std::allocator<std::pair<int const, com::sun::star::uno::Any> > >&) (rOutMap=std::__debug::unordered_map with 19 elements = {...}) at /home/julien/lo/libreoffice/chart2/source/tools/CharacterProperties.cxx:358 + 12 0x00007fd62e951686 in (anonymous namespace)::GetStaticRegressionEquationDefaults()::$_0::operator()() const (this=0x7ffe3f9b6b80) + at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:121 + 13 0x00007fd62e9500e7 in (anonymous namespace)::GetStaticRegressionEquationDefaults() () at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:117 + 14 0x00007fd62e94ff98 in chart::RegressionEquation::GetDefaultValue(int, com::sun::star::uno::Any&) const (this=0x564a90aa2870, nHandle=4, rAny=uno::Any(void)) + at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:196 + + See full bt here: + https://bugs.documentfoundation.org/attachment.cgi?id=192072 + + Change-Id: I8048b9a69761dba618ef556335c2cadab6647627 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162737 + Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + Tested-by: Jenkins + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit dd5e179f0fd7c9bf37872acf53301be28bb71cfc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162722 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-31 Caolán McNamara <caolan.mcnamara@collabora.com> [6c24cdd5098c5021da53ee96b07bd90bada0f049] + + tdf#151352 keep a reference to the parent + + and use that in the dtor instead of a pointer. + + FWIW the XWindow isn't actually a vcl::Window in the Gtk case, so + VCLUnoHelper::GetWindow doesn't do anything there. But using an + XWindow gives a safe view wrt life cycle. + + Change-Id: I4d0fd707ea931a76d6f87f434f7ece8df066785c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162720 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-30 Michael Stahl <michael.stahl@allotropia.de> [93444f3aaeb2c082abe52f3842674ddc7654426c] + + tdf#105844 unotest,xmlsecurity: fix tests on MacOSX + + The new tests fail with: + + > core/xmlsecurity/qa/unit/signing/signing2.cxx: + > 252: Assertion + > Test name: testPasswordPreserveMacroSignatureODFWholesomeLO242::TestBody + > equality assertion failed + > - Expected: 1 + > - Actual : 4 + + This is because only the first test that runs sees the testing CA + certificates that are copied in MacrosTest::setUpNssGpg(); when the + second test runs, they have somehow vanished. + + This is because apparently SQLite on MacOSX, unlike on Linux, monitors + the file descriptors of its database files, and then invalidates itself + when setUpNssGpg() via osl::File::copy() renames and unlinks the + existing database files: + + > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode renamed while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp + > cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x20) + > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode unlinked while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp + > cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x11) + > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode renamed while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp + > cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x20) + > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode unlinked while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp + > cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x11) + + Split MacrosTest::setUpNssGpg()/tearDownNssGpg() into functions + setUpX509() which only does something on the 1st invocation, and + setUpGpg()/tearDownGpg() which may be invoked per-test (they could also + be run once for the whole test suite, but not obvious how to do that); + PDF related tests don't need GPG. + + Presumably this is (along with the WNT-specific problem fixed in commit + 3e9a700091872480dd085f0928d1d30b7d74cfd7) the reason why most of the + tests not only accept the expected result of SignatureState::OK but also + SignatureState::NOTVALIDATED. + + Change-Id: I59b85ca651cecaccfdea729ed1e645c53079c8bf + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162693 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 8d65e55fa02014d156b7e569466aceb8836837fa) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162715 + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + +2024-01-30 Caolán McNamara <caolan.mcnamara@collabora.com> [0690f0cc3683dbe47ae237b3a00d02ba4db6966c] + + cool#7769 Reduce unnecessary invalidations on calc save + + https://github.com/CollaboraOnline/online/issues/7769 + + Reduce unnecessary invalidations. Don't invalidate windows + if layer visibility didn't really change. + + Change-Id: Ic2abd78d60aea2e8676c8e56608cf51e941f5918 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162301 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-30 Balazs Varga <balazs.varga.extern@allotropia.de> [5f6542e77a3ae8313199ca6704ef050be336a2f0] + + tdf#159384 - A11y: fix simulated numbering warning in TOC + + Do not complane about simulated numbering warning in TOC + if its contains a list with numbering. + + Change-Id: Ib6a10d18d19cc9cb44ffd5b79e2106af457985d1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162707 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 24a3f8269e427875fbe8013f88e83fc41b90b33a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162717 + +2024-01-30 Xisco Fauli <xiscofauli@libreoffice.org> [38dd3c75d40bd5ebbc63b192e38d581bed9b9092] + + tdf#158445: support viewBox in symbol elements + + Change-Id: Ie45b1e1dd4a4dcfc3cf3ce3d30f8dd9e040e37fb + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162605 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + (cherry picked from commit d1bffce7314d334e9da330169b3d259c044de161) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162612 + Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> + +2024-01-30 Mike Kaganski <mike.kaganski@collabora.com> [411a567b7eb0693a98143f9cdf74ac3b5f8ef56e] + + tdf#159412: make sure to keep the value while changing the type + + SbxValue::SetType clears the original value. We need to use the Get/Put + cycle, asking for a specific type in Get, and then making sure that the + variable is not fixed on Put. + + Change-Id: I0a6c106d511e8491c89a5a2153f47a708f83ee1e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162664 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 4541614e5f88604b4b1e17b0223d11c2e330d451) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162622 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-30 Mike Kaganski <mike.kaganski@collabora.com> [dbb8a9c01fd6693df32f0a9c023b7be2c623cf7a] + + Related: tdf#159382 Naming is hard: make initial monster shorter + + Rename "NoSpaceAfterHangingFootnoteNumbering" and friends to + "NoGapAfterNoteNumber". This is cleaner, no less descriprive. + + Change-Id: I87d3103e4ddfc05e5604eaa4fe707b1fd5711aae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162654 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162660 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-30 Mike Kaganski <mike.kaganski@collabora.com> [87f11c2961cd4bb8be6bc8f62442a706da0420b7] + + tdf#159382: introduce a Word compat flag for hanging footnote number spacing + + The new 'NoSpaceAfterHangingFootnoteNumbering' compatibility option is false + for ODF documents by default. Word file format filters set it to true. Its + purpose is to avoid extra spacing between the footnote number and its text, + when the paragraph has hanging first line, as in MS Word. + + Change-Id: I42d9353865498137ab99e1d2c031f5b207cbc220 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162603 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162636 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-29 Rene Engelhard <rene@rene-engelhard.de> [be1a96a9090f7b71598882f6f9a2ac5bf1ce6e58] + + add hy to bin/lo-xlate-lang + + Change-Id: I1205da81fc179affa58478860928e74a501d4c0c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162618 + Tested-by: René Engelhard <rene@debian.org> + Tested-by: Jenkins + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-01-29 Rafael Lima <rafael.palma.lima@gmail.com> [d60520f8aabefd8f2893b8656c555c25be93c16c] + + tdf#159329 Fix AutoFilter arrow color in dark mode + + When using dark mode, the arrow is black over a dark background. This patch makes it use the dialog text color for better contrast. + + Change-Id: Icf07d50599191417dee294e1f4c925fe1a8a7655 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162460 + Tested-by: Jenkins + Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> + (cherry picked from commit b0f678ca59a65a3c302c3c3a499230fbc52ed5bd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162615 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-28 Oliver Specht <oliver.specht@cib.de> [118e6cc0921849216e1fc3eb8d2f7dbb53463b26] + + tdf#158652 notify navigator on insert/edit/delete comment + + links changes of the drawing engine to comments as it was + done before with pictures, shapes and OLE objects + ui unit test included + + Change-Id: I4fde3a82b80e73758fb3da94ed2553453d09e9ef + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160624 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + (cherry picked from commit 0097f8595791f4bbf499ebd423f4f80ec8e38dbe) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162381 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-28 Caolán McNamara <caolan.mcnamara@collabora.com> [c664e7a5ce4001b677e67e4b40780d1babf683c3] + + invalid cast from 'GtkImage' to 'GtkLabel' + + since: + + commit fe946f86ad6586fa810cae5c0f246389a285e172 + Date: Wed Nov 29 15:25:06 2023 +0100 + + Bump Glade version + + Change-Id: Ide86220f260dac40395389530e7221ea8de8f092 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162611 + Tested-by: Jenkins + Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> + +2024-01-27 Noel Grandin <noel.grandin@collabora.co.uk> [42e06fb686d4c02fc6efaf0a792319147e3d62bf] + + tdf#159381 TimeStamp(RFC3161) create problem by asn1 format error. + + DER rules say that BOOLEAN values are either FALSE (0x00) + or TRUE (0xff) + + Change-Id: I59f57557fbc4d6447e0d8e994b04adda1ee8c1a9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162597 + Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit d2d8f8bf82558d9aa548fb9f13bed410e0baf79b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162614 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-01-26 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [d9a3985fc01f516df6ffd5e2acb93b35a87d97f8] + + Update git submodules + + * Update translations from branch 'libreoffice-24-2' + to 1884f687861c029ca3359fad879b1b261d07a718 + - update translations for 24.2.0 rc3 + + and force-fix errors using pocheck + + Change-Id: I93e387c681acb9d7d3ae6b69cd57cafd4556e552 + (cherry picked from commit c53381e37074987d7baa37c72ede218c619bdb4f) + +2024-01-26 Michael Stahl <michael.stahl@allotropia.de> [83d68d6ff1d19abf18bac8bfa35b200f45d91b5c] + + tdf#142806 sw: PDF export: fix multi-frame links/fields + + * SwRootFrame::CalcFrameRects() assumption that there is only 1 frame is + wrong, add a loop; also remove dead eMode check in else branch + * GetCursorRectsContainingText() cannot call GetCurrFrame() because that + returns always the same frame, but it can be split across several + * fix GetFrameOfModify() to return the correct frame in case of a field + (where it returned always the frame containing the start of the field, + but pViewPosAndCalcFrame could be in a follow frame) + + (regression from commit 5726be1314517d47dd733aabe64a3d85cce094c5) + + Change-Id: I63a94080ee120f178580e0339db4541691165780 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162523 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 9ba8d68c2b2fd06340bbdcb61dc3d57f6e3eb974) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162565 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-26 Michael Stahl <michael.stahl@allotropia.de> [6155fe977b0462136fcccbc6f052518041b5e66f] + + tdf#142806 sw: slowness if Style Inspector visible during PDF export + + There are loads of bookmarks in this bugdoc, WriterInspectorTextPanel + update functions somehow iterate them all, and it's entirely pointless + because the view doesn't repaint during store anyway. + + PDF export does a lot of cursor moves at the shell to get selection + rectangles, and each one triggers the slow update in AttrChangedNotify. + + Also simplify, the m_pShell is already there. + + Change-Id: I2177db1a2ab712e8984772843bd5f995e6989a4f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162525 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 5314947eea119a1ed4960e23c61530669b97468e) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162544 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [8304814a587fa1bdafe2541a1a4c252ec3bc72ae] update credits Change-Id: Ifb0ea3df4b544706527081f0ff21694c4dd2cad6 (cherry picked from commit 038476af694ef28f01aedb168273c3ba8709c209) - (cherry picked from commit 8304814a587fa1bdafe2541a1a4c252ec3bc72ae) -2024-01-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [b6bcc3bbfb84f2a4712107d569d7ad6ba556a584] +2024-01-25 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [361f6599761869351b3e5512a8e6b61d7ed7f0dc] Update git submodules - * Update translations from branch 'libreoffice-24-2-0' - to 5fa84a6a6193ae4a433b3d238eef053a43ca36c5 + * Update translations from branch 'libreoffice-24-2' + to 53b120579195265f189df2d70b13fbf70abe2525 - update translations for 24.2.0 rc3 and force-fix errors using pocheck Change-Id: I016d4038f8ba31d6ad0427eefc057d6d90bb4560 (cherry picked from commit 7b42317e75937684f4e45303945c8ce490d7fc5c) - (cherry picked from commit 53b120579195265f189df2d70b13fbf70abe2525) -2024-01-25 Xisco Fauli <xiscofauli@libreoffice.org> [be3f53ce62fcf02114afb0727c4a4ab6eccc23a5] +2024-01-25 Michael Stahl <michael.stahl@allotropia.de> [4f8aee3ae8a792bb78bf89a0d9c5fa9c58114913] + + sw: fix crash in SwTextCursor::GetModelPositionForViewPoint() + + With a field that spans 3 SwTextFrames, it happens that + rText[sal_Int32(nCurrStart + nLength) - 1] + results in rText[-1]; it looks like both nCurrStart and nLength are + correct (nCurrStart was decremented in line 1531 after "if (bFieldInfo)") + so there is a missing check here. + + Change-Id: I0d5be617e8e54c20dc8633efd3a7d82510f4acd7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162522 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 42a315b4a777dc371297752b6233e437d36c456b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162543 + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-01-25 Xisco Fauli <xiscofauli@libreoffice.org> [c2032ed42ea8a44bd3a5f8e8a778e05005366099] + + tdf#159336: export EditWidget with multiline enabled + + How to reproduce it from scratch: + 1. Open writer + 2. Form - Content Controls - Rich Text/Plain Text + 3. Split the control intro different lines + 4. Export to PDF + + -> The content control is displayed in one line + + Change-Id: Ia8666c8a6520e94ae06693ea8767c1d79aa5d3a0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162446 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Jenkins + (cherry picked from commit 8a6c9e246c746792fa0ab9d47a0fd5928b77d91d) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162532 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-25 Caolán McNamara <caolan.mcnamara@collabora.com> [be464eaa4e443e81ee236044b37cd8a861fa4d17] + + Resolves: tdf#159368 crash on tools, macros, edit + + when launched from startcenter + + Change-Id: I362bfe27914445c3027b6e8a125a75cc31679678 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162542 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-25 Mike Kaganski <mike.kaganski@collabora.com> [0d88061459c0d5200d7f87acc63babdac30e4d43] + + tdf#140912, tdf#159219: fix import of graphic placeholder with custom prompt + + Importing the text marks the object as not empty. Then, the object would + behave as an outliner object. This includes showing in slide show; allowing + text esiting; stretching the placeholder image, which required a workaround + implemented in commit 7b3be7f6f3d800e2ad86f5a043e6e9b21ed4409f (tdf#140912 + Better handling of the picture placeholders, 2021-12-01). + + Instead, drop the custom prompt. More correct solution would be making sure + to mark the object as empty after setting the text; but this doesn't round- + trip to ODF; and it crashes export to PPTX. Proper support for the sustom + placeholder prompt feature should be done separately. + + The new workaround (dropping the text) makes previous workaround (special + handling of the placeholder graphic) unnecessary. The unit test is updated. + + Change-Id: Ic7f42493af8d1d725ffa39ffab58f1ff033351cc + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162202 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162239 + +2024-01-25 Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> [ae17868cb81f593913982454bfd07c863e569941] + + sd: remove condition to only show ThemeDialog in master view + + Change-Id: I09ce07f7b520688aa54dd30107b5ab2218b12894 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156277 + Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit 62804da3c0ab9443cf36f2e02387a2e9c272d5dc) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162463 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 77070aedb602729c523ea166aa92d7c227a88312) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162466 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-25 Caolán McNamara <caolan.mcnamara@collabora.com> [4bf6405eaa864a3566085117d0fdf28f429c99bf] + + crashtesting: crash seen on import of forum-mso-en4-278652.xlsx + + probably an issue since: + + commit 135ce256ce9e879663d828ec6e699de521fad867 + Date: Mon Aug 14 15:59:18 2023 +0200 + + tdf#146487 Don't show generic diagram title when there is an empty title given + + Change-Id: I12d8d6e78a8435b998084221402b6bdfc4a1a433 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162539 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-24 Xisco Fauli <xiscofauli@libreoffice.org> [c36bb3f22a55af0066b0d81a966ef8932d20bf7b] sfx2: check SfxViewShell::Current() @@ -78,35 +2437,306 @@ Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 1a4a215bc59e50958b2c04ac405c5200f5811970) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162469 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162468 + +2024-01-24 Michael Weghorn <m.weghorn@posteo.de> [df266f613bc12c18ec8d1c9cdc250fda1bc6c45b] + + svx a11y: Notify listeners when disposing shape + + In `AccessibleShape::disposing`, call the same method + of the base class, i.e. `AccessibleContextBase::disposing`, + not `AccessibleContextBase::dispose`. + + The code was moved from `AccessibleShape::dispose` to + `AccessibleShape::disposing` in + + commit f11b151dc08ccfcb7e78bfd9a24c77670942ea63 + Date: Tue Apr 30 13:30:10 2002 +0000 + + #95585# Moved code from dispose to disposing(). + + and it seems likely that adjusting the base class method to call + was just forgotten/missed. + + This resulted in the accessible getting disposed without listeners + getting notified (since `AccessibleContextBase::disposing` takes + care of that). + + This resulted in a crash for the following scenario with the qt6 + VCL plugin when the Orca screen reader is running: + + 1) start LO Writer + 2) click on the "Basic shapes" toolbar button + 3) click + drag to insert a shape into the document + 4) click somewhere else + + Backtrace is below. + `AtSpiAdaptor::handleMessage` (frame #12 in the bt) checks + whether the accessible is valid and returns early otherwise. + But since listeners were not notified when the object got disposed, + `QtAccessibleEventListener::disposing` wasn't called, which would + have taken care of invalidating the `QtAccessibleWidget`, in which + case this early return would have happened instead of the crash. + + This behaves as expected now with this commit in place. + + stderr output of the crash: + + terminate called after throwing an instance of 'com::sun::star::lang::DisposedException' + + Backtrace: + + Thread 1 received signal SIGABRT, Aborted. + __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 + 44 ./nptl/pthread_kill.c: No such file or directory. + (gdb) bt + #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 + #1 0x00007f5bc1ca815f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 + #2 0x00007f5bc1c5a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 + #3 0x00007f5bc1c444b2 in __GI_abort () at ./stdlib/abort.c:79 + #4 0x00007f5bc18a09eb in () at /lib/x86_64-linux-gnu/libstdc++.so.6 + #5 0x00007f5bc18affca in () at /lib/x86_64-linux-gnu/libstdc++.so.6 + #6 0x00007f5bc18b0035 in () at /lib/x86_64-linux-gnu/libstdc++.so.6 + #7 0x00007f5bc18b0288 in () at /lib/x86_64-linux-gnu/libstdc++.so.6 + #8 0x00007f5bc02b4550 in accessibility::AccessibleContextBase::ThrowIfDisposed() (this=0x55a6fc7e7da0) at .../libreoffice/editeng/source/accessibility/AccessibleContextBase.cxx:494 + #9 0x00007f5bbcf7d54e in accessibility::AccessibleShape::getAccessibleName() (this=0x55a6fc7e7da0) at .../libreoffice/svx/source/accessibility/AccessibleShape.cxx:280 + #10 0x00007f5bada62107 in QtAccessibleWidget::text(QAccessible::Text) const (this=0x55a6fad4fe20, text=QAccessible::Name) at .../libreoffice/vcl/qt6/../qt5/QtAccessibleWidget.cxx:362 + #11 0x00007f5bac5552d2 in AtSpiAdaptor::accessibleInterface(QAccessibleInterface*, QString const&, QDBusMessage const&, QDBusConnection const&) (this=0x55a6f769bce0, interface=0x55a6fad4fe20, function=..., message=..., connection=...) + at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1545 + #12 0x00007f5bac553cce in AtSpiAdaptor::handleMessage(QDBusMessage const&, QDBusConnection const&) (this=0x55a6f769bce0, message=..., connection=...) + at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1432 + #13 0x00007f5baaa88943 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, QDBusMessage const&, int) (this=0x7f5ba4010f30, node=..., msg=..., pathStartPos=27) + at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1448 + #14 0x00007f5baaa89628 in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x7f5ba4026980) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1604 + #15 0x00007f5bad044013 in QObject::event(QEvent*) (this=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:1447 + #16 0x00007f5bab1a6986 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=0x55a6f631c3e0, receiver=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3298 + #17 0x00007f5bab1a6797 in QApplication::notify(QObject*, QEvent*) (this=0x55a6f63bb840, receiver=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3249 + #18 0x00007f5bacfb0212 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55a6f769bce0, event=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1138 + #19 0x00007f5bacfb0dbb in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55a6f769bce0, event=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1581 + #20 0x00007f5bacfb2474 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=0x0, event_type=0, data=0x55a6f6337df0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1936 + #21 0x00007f5bacfb160e in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=0x0, event_type=0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1770 + #22 0x00007f5bad43441c in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x55a6f642f710) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:244 + #23 0x00007f5bb47111f4 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #24 0x00007f5bb4714317 in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #25 0x00007f5bb4714930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 + #26 0x00007f5bad434cb1 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55a6f6435dc0, flags=...) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:394 + #27 0x00007f5baa929e18 in QXcbGlibEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55a6f6435dc0, flags=...) at .../qt5/qtbase/src/plugins/platforms/xcb/qxcbeventdispatcher.cpp:96 + #28 0x00007f5badad8bea in QtInstance::ImplYield(bool, bool) (this=0x55a6f6442080, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:424 + #29 0x00007f5badad8d13 in QtInstance::DoYield(bool, bool) (this=0x55a6f6442080, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:435 + #30 0x00007f5bb8734af6 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:386 + #31 0x00007f5bb8735894 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:470 + #32 0x00007f5bb87347e9 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:364 + #33 0x00007f5bc1e36e66 in desktop::Desktop::Main() (this=0x7ffc62160570) at .../libreoffice/desktop/source/app/app.cxx:1614 + #34 0x00007f5bb8753ca0 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229 + #35 0x00007f5bb8753fb5 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261 + #36 0x00007f5bc1ea4101 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94 + #37 0x000055a6f46e19d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51 + #38 0x000055a6f46e19ba in main (argc=2, argv=0x7ffc62160798) at .../libreoffice/desktop/source/app/main.c:49 + + Change-Id: Iae8a9ff61df99094b4cd73da895d1f6ac850c0c9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162493 + Tested-by: Jenkins + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + (cherry picked from commit 77874b76c50d704b26543175375dcfa65c4fd620) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162537 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-24 Szymon Kłos <szymon.klos@collabora.com> [9a19639b2bcfecc4387e720e6c01c3ba57ed00b7] + + Use correct type when getting document colors + + After commit 0460be8848b0ce02c07183e41dd7137ac3b94164 + Send document colors with lok callback + + There was issue detected by CI: + /sc/source/core/data/document10.cxx:198:46: runtime error: downcast of address 0x6100000efa40 which does not point to an object of type 'const SvxColorItem' + 0x6100000efa40: note: object is of type 'SvxBrushItem' + 00 00 00 00 b0 79 19 48 ce 7f 00 00 01 00 00 00 94 00 be be 4c 17 00 00 a0 be be be cc cc ff 00 + ^~~~~~~~~~~~~~~~~~~~~~~ + vptr for 'SvxBrushItem' + #0 0x7fce1fbed369 in ScDocument::GetDocColors() /sc/source/core/data/document10.cxx:198:46 + + Change-Id: I41f28b6bb54d7720d58c16d75b9d116a53f106cc + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162076 + Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> + Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162501 + Tested-by: Jenkins + +2024-01-24 Michael Weghorn <m.weghorn@posteo.de> [ac136a069ef69fd7e9c71256a93499475631794b] + + tdf#159333 qt a11y: Process shortcuts only once + + As described in + + commit 69e708868f6046cada955a16bca966370ce3218a + Author: Michael Weghorn <m.weghorn@posteo.de> + Date: Thu Feb 20 08:14:36 2020 +0100 + + tdf#130794 qt5: Actually, ignore non-spontaneous QEvent::ShortcutOverride + + and the previous + + commit 034f56015c1c7a61faede33fb5306f63b5585632 + Author: Michael Weghorn <m.weghorn@posteo.de> + Date: Mon Feb 17 10:38:15 2020 +0100 + + tdf#126785 qt5: Ignore external QEvent::ShortcutOverride + + it refers to, duplicate events of type + `QEvent::ShortcutOverride` are received when a11y is + active, so those commits introduced ignoring of the + non-spontaneous one, and leaving processing for the + spontaneous event only, thus preventing duplication of + typed text. + + However, keyboard shortcuts like Ctrl+V were still + processed twice: While they're only processed once + in `QtWidget::handleEvent` (for the spontaneous + event of type `QEvent::ShortcutOverride`), the keyboard + shortcut was additionally handled as the shortcut to + activate the action that's used for the menu entries, + e.g. the "Edit" -> "Paste" menu entry for Ctrl+V + (s. class `QtMenu`, where those are set). + + Accept the non-spontaneous `QEvent::ShortcutOverride` + event to prevent that from happening. + + Quoting the `QEvent::ShortcutOverride` doc [1]: + + > Key press in child, for overriding shortcut key handling (QKeyEvent). + > When a shortcut is about to trigger, ShortcutOverride is sent to the + > active window. This allows clients (e.g. widgets) to signal that they + > will handle the shortcut themselves, by accepting the event. If the + > shortcut override is accepted, the event is delivered as a normal key + > press to the focus widget. Otherwise, it triggers the shortcut action, + > if one exists. + + With this commit in place, the shortcut is only + processed once, as expected. + + Potentially, this should ideally be addressed on Qt + side in the future, see the discussion in tdf#126785. + + The duplication happens since this qtbase commit + (no longer with a local revert of it): [2] + + commit 7c532891e0be2cf78c89738e175b3d312d305e4e + Date: Tue Apr 17 16:45:09 2018 +0200 + + Send ShortcutOverride event when receiving a non-spontaneous key press + + Since 2020, there a pending Qt change by Alexander Volkov + suggesting to avoid the duplicate events by filtering them + out in `QSpiApplicationAdaptor::eventFilter` on qtbase + side: [3] + + With that change not being merged yet, fix this on LO side + for now. + + [1] https://doc.qt.io/qt-6/qevent.html#Type-enum + [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=7c532891e0be2cf78c89738e175b3d312d305e4e + [3] https://codereview.qt-project.org/c/qt/qtbase/+/295892 + + Change-Id: I28cb11914ae81284e050bff0deb39d95e8073ce0 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162430 + Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + (cherry picked from commit f4cc37c06ae15923df6b15777f2526008c2b4ca6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162453 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-01-25 Oliver Specht <oliver.specht@cib.de> [ebee4f6a811ff5e9b0d9d4ae21e349ae3b0cdfdd] +2024-01-24 László Németh <nemeth@numbertext.org> [de8a6c90c7aa5d26f758a590bad955cd62251702] - tdf#158830 fixes regression introduces with tdf#158044 + tdf#106733 sw: fix bad downcast in SwTextNode::GetLang() - Removing paragraph attributes equal to style attributes now works also - for paragraphs within tables. - This fixes also the regressions documented in tdf#158978 and tdf#158982 + Fix bad cast of SvxNoHyphenItem to SvxLanguageItem + reported by <https://ci.libreoffice.org/job/lo_ubsan/3049/>: - Change-Id: I9f430e23fd33cff4d6ec1d1954969666f0080574 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161824 + /sw/source/core/txtnode/thints.cxx:3560:16: runtime error: downcast of address 0x6030005e44d0 which does not point to an object of type 'const SvxLanguageItem' + 0x6030005e44d0: note: object is of type 'SvxNoHyphenItem' + 1a 00 00 00 90 e3 d5 77 5c 7f 00 00 00 00 00 00 13 00 be be 16 00 00 00 92 01 be be 00 00 00 00 + ^~~~~~~~~~~~~~~~~~~~~~~ + vptr for 'SvxNoHyphenItem' + #0 0x7f5bda7e8c0c in SwTextNode::GetLang(int, int, unsigned short, bool) const /sw/source/core/txtnode/thints.cxx:3560:16 + + Regression since commit b5e275f47a54bd7fee39dad516a433fde5be872d + "tdf#106733 sw: implement CharNoHyphenation". + + Change-Id: I0c6f60a4074f8fd6da26674cace47f5c5e32afd6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162401 Tested-by: Jenkins - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: László Németh <nemeth@numbertext.org> + (cherry picked from commit 9193e61d3e7b850b3715c848c09434e24855340b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162379 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-24 László Németh <nemeth@numbertext.org> [04c92ff9cfec039f7fc03277de46d77bb3109431] + + tdf#106733 sw: implement CharNoHyphenation + + Implement CharNoHyphenation character property to + disable automatic hyphenation of words in paragraphs + with enabled hyphenation. + + Fix also fo:hyphenate mapping to CharNoHyphenation + using automatic inversion of their boolean values + defined by xmloff's XML_TYPE_NBOOL, as suggested by + Michael Stahl. + + Update also the test for tdf#159102 to check the available + hyphenation dictionary (also custom hyphenation patterns + work only with supported locales of the hyphenator). + + Note: patch of thints.cxx contains also partial revert + of commit 53b289eabb3d265b47bc7fb6cc430291c97f0c0b + "use more TypedWhichId". + + Follow-up to commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372 + "tdf#106733 xmloff: keep fo:hyphenate in character formatting". + + Change-Id: If99b94ddcd44a5c2426e646be149078a3b9773b6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162300 + Tested-by: László Németh <nemeth@numbertext.org> + Reviewed-by: László Németh <nemeth@numbertext.org> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162283 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-24 Miklos Vajna <vmiklos@collabora.com> [5df7c66193d55af944b3269f11374e60da437c0b] + + tdf#159017 sw floattable: only shift to the right when needed + + Regression from commit 868140fcc1311259b9d5f666637b33d226511a53 + (tdf#60558 sw floattable: allow wrap of table on the right of a + floattable, 2023-12-05), the document had an inline table, followed by a + floating table, and we moved the inline table to the right even if the + left hand side of the floating table already had enough space. + + What happens here is that nominally the inline table's original position + overlaps, but because the table width is small enough, such an overlap + doesn't actually happen. In this case, it's not needed to shift the + inline table to the right. + + Fix the problem by making the check that decides whether it's necessary + to increment the left margin of the table more strict: it's not enough + to have enough space on the right of the fly, it's also needed to *not* + have enough space on the left side. + + This keeps the original "floating table wrapped by inline table on the + right" use-case working, but restores the ~no left margin for the inline + table for the new bugdoc. + + Change-Id: Ifb30d90ca6dba7cc4a402d8a4445251120b575ae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162447 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + Tested-by: Jenkins + (cherry picked from commit 6e3ad6ca0ae6cf62056610ddae9097973a887d99) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162464 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> - Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> - (cherry picked from commit 204d50a07501bf8445a8a0526f68987373834318) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162109 - (cherry picked from commit ad172c0fe26212dccfabe11e534ac53b82816ec9) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162133 - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> -2024-01-24 Stephan Bergmann <stephan.bergmann@allotropia.de> [5bb295c263803fbf39562aa7e95f8d32a77ac854] +2024-01-23 Stephan Bergmann <stephan.bergmann@allotropia.de> [dec29bf4c7844d6cc3231b93ca1bb56243caabfe] MAR update, too big to (not) fail @@ -139,175 +2769,217 @@ (cherry picked from commit 4582da4ad473e256975c86054033eb7d238d464e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162455 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> - (cherry picked from commit dec29bf4c7844d6cc3231b93ca1bb56243caabfe) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162459 - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-01-24 Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> [ef96ca7f3b839f591b6258d1b3565a2bd7d5ad79] +2024-01-23 Martin Srebotnjak <miles@filmsi.net> [d29208007d2f0d3de489d813900afa9667869d76] - tdf#158664 Ignore Notifications when SlideShow is inactive + Update git submodules - The impl SlideshowImpl gets notifications for changes from - the ObjectModel, but needs to ignore them when SlideShow - is not active/running. For discussion how to do this see - comments in task. + * Update translations from branch 'libreoffice-24-2' + to a83581f0967e2361ec420899df5319e228ed8994 + - Updated Slovenian translation + + Change-Id: I0fbab3525dc988b1294d825d4e09f60f9f1ec874 + +2024-01-23 Sarper Akdemir <sarper.akdemir.extern@allotropia.de> [3add4092d29b9b03c00dfa24caa917a3fc84540b] + + tdf#156830: fix faulty transformation order in cairo canvas for patterns - Change-Id: Ic251af4b82f0f4b48d8d9b0127dd2f6015966935 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161922 + Change-Id: Ib58e845c23dd14bbc3b96e5549a722b650d593a6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162069 Tested-by: Jenkins - Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> - (cherry picked from commit 2184890a0eebc55aa24cbe61de5b8918d958c65f) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161932 + Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de> + (cherry picked from commit 84055d875ead6d7862cd8ddc5697a280240411fe) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162008 + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-01-23 Caolán McNamara <caolan.mcnamara@collabora.com> [bdc5f71c94d44834aa8ad863d9c19325d59ce36a] + + use a ScopeGuard to restore the original map mode + + in these cases the original map mode was *not* always restored, + but the intent seems to be like the others that the mapmode should + be the same on exit as on enter. + + Change-Id: Id7b668a9977c4c84df5234288baca8bd6f4232e5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162276 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit f259a4636308fbdb8c5d8b9f430e3d53018f327b) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161944 - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Jenkins -2024-01-24 Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> [89807b69090d657bbd52dce74be4bfe024179036] +2024-01-23 Stephan Bergmann <stephan.bergmann@allotropia.de> [674ad9be4b002b99db3b5c7ac035c3430c6c7780] - tdf#159186 Use changed value when editing string-list a second time + Create MAR updates from msi rather than from archive - Change-Id: I0e26a053b3b5fb04abf87894bcfebccea8bdd26f - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162074 + ...as the former is more convenient for release engineering (see the discussion + in the comments at + <https://gerrit.libreoffice.org/c/core/+/162157/1#message-8d7ebbcc64a87ee8e4a073ae1a05e3b74f5a3d6a> + "Also enable --with-package-format=archive for LibreOfficeWin64.conf"). + + Instead of ONLINEUPDATE_MAR_OLDARCHIVE and ONLINEUPDATE_MAR_OLDMETADATA make + variables, the create-partial-info target now only needs an + ONLINEUPDATE_MAR_OLDMSI make variable. + + TODO: There are two issues when comparing the content of msi files (extracted + with msiexec /a), which the old code comparing the content of archives had tried + to somewhat (but not fully) address with the metadata files that I had invented + (and now reverted): For one, msiexec /a also extracts content that would + normally be installed somewhere else in the system (e.g., it extracts Fonts, + System, and System64 directories). Differences in those directories will cause + a MAR update to create those directories in the installation directory, rather + than to update the corresponding files in their actual locations. For another, + optional components are not recognized as such, but their content must be added + to the MAR file as add/patch-if, not as plain add/patch. To work around that, + for now *all* files are added as add/patch-if, conditional on the files + themselves. Thus, addition of files will cause a MAR update to miss them. + + (As they now exclusively operate on msi files, the create-update-info and + create-partial-info targets are no longer meaningful for non-Windows platforms, + so drop the non-Windows bin/update/create_full_mar_for_languages.py part.) + + Change-Id: Ifb55b5e7d1a201b4f50a27cb449a634b96c2e29b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162399 Tested-by: Jenkins - Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> - (cherry picked from commit 76ce6466b814bb9ff119f4f83795a2aeefc28793) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162097 - Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> - Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> - (cherry picked from commit 395c8cfb770e7424fd99b884f568a32fcc7a728f) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162145 + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 1dd40d6f488c46a0946ea773cb7a741f34bbb49f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162374 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> -2024-01-24 Matt K <mattkse@gmail.com> [51233ec34207c8be256d8d75800fa3ca495c5ca4] +2024-01-23 Noel Grandin <noel.grandin@collabora.co.uk> [49bb4229ded946a411f2d6677da7f9f4155af941] - tdf#151752 Fix crash when selecting unprotected cells and copy/pasting + fix bug in renaming chart objects - The problem is that the code attemps to index into maTabs when looping - through clipboard ranges, but maTabs.size() can be 0 at that point - thus resulting in a crash. The fix is to first check if maTabs.size() - is greater than 0 before doing the looping. + introduced by + commit c5bb73cae7c172ad0f02f8c67dd57b53337f1d78 + Author: Kohei Yoshida <kohei.yoshida@suse.com> + Date: Tue Jan 31 16:03:46 2012 -0500 + Get the whole thing to build after the method sig change in + SdrObject. - Change-Id: Ib2fc4c9f847f87f44a68ad6d73c2745d79b5caa5 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162032 + Change-Id: I1ca887d09857f6476980381853a9ae4946fd03e1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162364 Tested-by: Jenkins - Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> - (cherry picked from commit 59927dedc31eb5d51b417a02ae927eb578b90bd6) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162090 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit a381ac7b0fa95ce340bd1b384c946fbd19d87393) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162095 - Reviewed-by: Matt K <mattkse@gmail.com> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> + (cherry picked from commit 0ad94d52c022a0acb20be21b5a1dfcf445e12f0c) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162377 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-01-24 Jim Raykowski <raykowj@gmail.com> [553b91ef4204d0d6473f45ceadb76d6e24a08879] +2024-01-23 Justin Luth <justin.luth@collabora.com> [3c0a6102ce26c546c0c448a8d7468dea92623273] - tdf#159147 Fix crash when editing hyperlink while navigator is open + tdf#154703 writerfilter framePr: avoid unexpected frame borders - by assuring the SwURLFieldContent::SwTextINetFormat pointer is still - valid before trying to bring the hyperlink content to attention + This fixes my regressive 7.6 commit + 31ea6305b6a763ee48f639562313d9bd109a2923 - Change-Id: I7f672576ab2869c5483284b543e99e46a558acc9 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162013 + The text's first border checked (the left one) returned void + because the property SetState was DONTCARE. + Then it SETS the text's left border to be nothing + (I presume to remove the border from the paragraph since + it is moving it onto frame). + Well, apparently that act of setting one border sets all of them + (which makes sense since it would be one box item, + and once the box item exists, it has a definition for each border). + + Therefore on the the next steps of the for loop, + the remaining borders will exist (as nothing) + and be dutifully moved to the frame. + + Apparently the default for a frame is a box with DEFINED borders, + so omitting the moving of a nothing border resulted in a stray edge. + + make CppunitTest_sw_ooxmlexport21 \ + CPPUNIT_TEST_NAME=testTdf159207_footerFramePrBorder + + Change-Id: I217d02678b368f70643be91c4466927b4ca53988 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162409 Tested-by: Jenkins - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Jim Raykowski <raykowj@gmail.com> - (cherry picked from commit b2500f0e32b33eec2740dc370238f66fb8b50ffb) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162212 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit a6ce9960c37928cb8a27383dc8e10125011131c9) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162216 - Reviewed-by: Hossein <hossein@libreoffice.org> + Reviewed-by: Justin Luth <jluth@mail.com> + (cherry picked from commit f43efd5473862edbdad0feb7f78c7be02914e997) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162375 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-24 Mike Kaganski <mike.kaganski@collabora.com> [53c9b06f7bda62efb97bb383ac0002234e4aa5e8] +2024-01-23 Caolán McNamara <caolan.mcnamara@collabora.com> [9f14ca93e1f1d31b453cd4403eb146e63949e6e0] - tdf#159271: do not try to put fields' spaces to hole portions + use a ScopeGuard to restore the original map mode - Change-Id: Ic1b3f9602089cc773f9c3adc0be09a3be08d690f - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162269 + in all these cases the original map mode was always restored so + there is no change for these examples. + + Change-Id: Iec24b2cd269b9408dac6404e054b3bb989ec7744 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162306 Tested-by: Jenkins - Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162293 - Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 8cbf48ac9d3e0d5c420e45b59bf761f51ad395fe) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162281 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 30ed30b1117a41f016aa5b09ce21d2cb3004fdc3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162275 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-24 Mike Kaganski <mike.kaganski@collabora.com> [81b59e7d7eb35fd0e707a04ef926a97ae9be86df] +2024-01-23 Mike Kaganski <mike.kaganski@collabora.com> [ccad5b30548072249b8d8abf1c43de8350271f54] - tdf#159313: pass properties in correct order + tdf#159259: make sure to set FieldStartRange in sdt helper - Regression after commit c4fc18308074634e9578ad12d94d937f259aa22a - (Autocorrect: Add option for autoformat bulleted lists after space, - 2023-09-07). + ... also for field case. + Unfortunately, it is not really clear, if the anagement of this could + be moved to DomainMapper_Impl. There are several insertion contexts; + they may use different insertion points; there maybe could be cases + when an inserted content should not go into the current sdt (?). Thus, + I didn't put the code into DomainMapper_Impl::appendTextContent(), + where the field character is inserted. Instead, I added code to check + and set the start range in the same place as for the normal text: we + know for sure, that if it were a normal text, we would append it to + GetCurrentTextRange()->getEnd() - so do the same for fields. - Change-Id: I35fafc1441b4f67886a86d4d67764a91146b8ece - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162359 + My concern that still stays is that the use of hasUnusedText looks + hackish and fragile. Inserted fields don't set it - so the code that + depends on empty sdt will not notice it. OTOH, it can't set it: this + would break inserting field result for an already inserted command. + Possibly all handling of sdt should be refactored at some point. + + Change-Id: I7a783aab2400d9a9c1f9f2e5607c872cb58d346b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162398 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> - (cherry picked from commit ca33b8b35a10243dc13e68c93e7c7512eef937ec) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162289 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 480e15fa4f641ed5d312d4399fa0c5d37e9c10f3) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162383 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162427 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-23 Stephan Bergmann <stephan.bergmann@allotropia.de> [b3acf10af5e1aba02528afc330e73d680055e712] +2024-01-23 Tibor Nagy <tibor.nagy.extern@allotropia.de> [67ae17ad8a74620eb744976d56f8d763893e847c] - Update solenv/flatpak-manifest.in + tdf#156718 PPTX import: fix the different formatting in table style - * Incorporate - <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d9e2f088aafe41c3c9cc4af14e935777dba794c1> - "Update gvfs-1.52.1.tar.xz to 1.52.2 (#272)" + when the PPTX file only has table style id, but no table style content. - Change-Id: I95bee83408caab8e27eae978068f8ec4e87a9c12 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161956 + Change-Id: Ia3416478716a50beb6837988e98697fd88e916d9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162368 Tested-by: Jenkins - Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> - (cherry picked from commit 2a12e2e6593cdd7b8b9978a6aec6910a92600cf3) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161943 - Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit 6ae9d6ea0497b5935678c826940b14893a6531d0) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162102 - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> + (cherry picked from commit 27a1eccae1763b8efa17c909820f57f84361d308) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162378 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> -2024-01-23 Martin Srebotnjak <miles@filmsi.net> [9fb8f1eb205774b8621748773896e7c2e71f685b] +2024-01-23 Mike Kaganski <mike.kaganski@collabora.com> [883aa0695524d171c9009c87b4f32488b134629f] - Update git submodules + Related: tdf#159259 Drop obsolete exclusion of framePr inside sdt - * Update translations from branch 'libreoffice-24-2-0' - to 90030b3e9c82fbfb5017849222e5bcfd28690327 - - Updated Slovenian translation - - Change-Id: I0fbab3525dc988b1294d825d4e09f60f9f1ec874 - -2024-01-23 Julien Nabet <serval2412@yahoo.fr> [781e8620a2c48d541c80f82fdfc122881eee4bc5] + Commit 73bd937420b9a99e1e35950e3f9dcbcfd874876d (n#780853 fix DOCX + import of w:sdtContent in table cell, 2012-09-25) had introduced a + restriction, where a framePr was ignored, when inside an sdt. It + was required to allow table import, which broke otherwise. + + Since then, the situation has obviously changed; the test case for + the change, added in commit 7ea71eb8a28c4b41949299ff7d4b391486c90eea + (n#780853 testcase, 2012-09-25) passes after removal of the check. + + This check disallows importing sdt in frame. This makes the bugdoc + of tdf#159259 to import the sdt in frame. The Lorem Ipsum paragraph + is still enclosed into the sdt - to be fixed in a follow-up. + + Change-Id: I60fbb2dd6f753682217d86e4f8d315f1883c6e83 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162258 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 4d0f2d5ec9f7f988a1493916ae35bac1986c95a8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162384 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-23 Julien Nabet <serval2412@yahoo.fr> [06726e12cad769a2b28c3598792f08f0c8cb4ea1] tdf#159326: Command-F assigned to both Find and Find and Replace in Calc @@ -320,11 +2992,10 @@ Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162382 - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Patrick Luby <plubius@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162376 + Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> -2024-01-23 Patrick Luby <plubius@libreoffice.org> [0989275534bda8cd559e80b8579bba7271344e7d] +2024-01-23 Patrick Luby <plubius@libreoffice.org> [8163882de6308e46b261af9e75906d1d05c4eb08] tdf#159025 skip undo if SwTableNode is a nullptr @@ -338,106 +3009,549 @@ Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@libreoffice.org> (cherry picked from commit f414c61f8dd2617baa0851525b8a7a630c5e34da) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162227 - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> - Tested-by: Patrick Luby <plubius@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162225 -2024-01-23 Mike Kaganski <mike.kaganski@collabora.com> [0fd7ede0fbf93c1c8e2baa95bc76ef9d8fbf3eb0] +2024-01-23 László Németh <nemeth@numbertext.org> [d8116658ecf66d915ae8cf6510a76ee628c45431] - tdf#159174: there may be no tabs in the clipboard document + tdf#159102 sw smart justify: fix automatic hyphenation - Change-Id: I053d91bf44e39e14ade9face14084a107d0df898 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162041 + As before with soft hyphens, automatic hyphenation + could result too much shrinking, because of calculating + with an extra non-existing space in the line. + + Also try to shrink the line only if a space likely + will be available in it. + + During testing, extend user dictionary temporarily + with custom automatic hyphenation to avoid of false tests + because of non-available hyphenation patterns. (Note: maybe + the other tests with non-user dictionary based automatic + hyphenations are not correct.) + + Follow-up to commit d511367c102ef2ada0f73dbe81744d39865d58ba + "tdf#195085 sw smart justify: fix bad shrinking at soft hyphen". + + Change-Id: I58ecb8f1ea9f55ef2457d7ff4aca6aefa59a6dd1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162199 Tested-by: Jenkins - Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> - (cherry picked from commit 0b93cc83993b3cd78aa05556342839a21c96dc5a) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162092 + Reviewed-by: László Németh <nemeth@numbertext.org> + (cherry picked from commit 7c1f4dd740c32050480f3ab678805ad3c4c748bb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162219 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - (cherry picked from commit 41afcf4fa89abe23177e6a26d1a9e8611f351852) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162100 - Reviewed-by: Hossein <hossein@libreoffice.org> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-23 Stephan Bergmann <stephan.bergmann@allotropia.de> [eb482b5a819658240113d32ec0b9dac2f2f5f0dd] +2024-01-23 Mike Kaganski <mike.kaganski@collabora.com> [0455f4c13c5e0d055c92f84c3e71aad32a062a35] - Adapt Flatpak build to new external/argon2 + tdf#159313: pass properties in correct order - Change-Id: I584956151b036e1ba781439205a76f579f32c064 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161955 + Regression after commit c4fc18308074634e9578ad12d94d937f259aa22a + (Autocorrect: Add option for autoformat bulleted lists after space, + 2023-09-07). + + Change-Id: I35fafc1441b4f67886a86d4d67764a91146b8ece + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162359 Tested-by: Jenkins - Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> - (cherry picked from commit 2b1a4f6309437128077c33e27262c052a408b9ba) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161990 + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit ca33b8b35a10243dc13e68c93e7c7512eef937ec) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162289 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - (cherry picked from commit 6ed4050f16265bfb02090592c6e88813796ac68d) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162101 + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-22 Matt K <mattkse@gmail.com> [d6466f9b1ec73011145d429d120aaaa03b52718b] + + tdf#132810 Prevent more crashes on gallery objects + + This change is a follow-up to https://gerrit.libreoffice.org/c/core/+/161950 + where there is still a crash occurring on application close, and + a general crash when using gallery objects. The fix is to check for object + existence or if the object has the destructor bit set before using the + objects. + + Here is the callstack for the assert that was removed: + + > swlo.dll!SwClient::GetRegisteredIn() Line 166 C++ + swlo.dll!SwContact::GetFormat() Line 112 C++ + swlo.dll!SwAnchoredDrawObject::GetFrameFormat() Line 622 C++ + swlo.dll!SwAnchoredObject::FindAnchorCharFrame() Line 719 C++ + swlo.dll!SwAnchoredObject::GetAnchorFrameContainingAnchPos() Line 132 C++ + swlo.dll!SwAnchoredObject::FindPageFrameOfAnchor() Line 697 C++ + swlo.dll!SwObjectFormatterLayFrame::AdditionalFormatObjsOnPage() Line 144 C++ + swlo.dll!SwObjectFormatterLayFrame::DoFormatObjs() Line 94 C++ + swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction) Line 160 C++ + swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext) Line 565 C++ + swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext) Line 390 C++ + swlo.dll!SwViewShell::ImplEndAction(const bool bIdleEnd) Line 308 C++ + swlo.dll!SwViewShell::EndAction(const bool bIdleEnd) Line 628 C++ + swlo.dll!SwCursorShell::EndAction(const bool bIdleEnd) Line 266 C++ + swlo.dll!SwEditShell::EndAllAction() Line 102 C++ + swlo.dll!SwWrtShell::Do(SwWrtShell::DoType eDoType, unsigned short nCnt, unsigned short nOffset) Line 60 C++ + swlo.dll!SwBaseShell::ExecUndo(SfxRequest & rReq) Line 655 C++ + + Change-Id: I90bd40f3ae864ec9655340c342ddc16b59d79aba + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162349 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 6840c242684986483624557a405a00e91ea048e9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162370 + Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-22 Rafael Lima <rafael.palma.lima@gmail.com> [df5fea3fab250a11b37d0803716d740e4fab2ba6] +2024-01-22 Mike Kaganski <mike.kaganski@collabora.com> [b2fe91897ac4f55bac93aa9f499ed8f29baecd7d] - Update git submodules + tdf#158139: show autotext / word completion tooltips also for delayed flush - * Update helpcontent2 from branch 'libreoffice-24-2-0' - to c2520523383ab38a49b9f61cc05b74ed49de046c - - Silence strings for translation in sf_dataset.xhp - - Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2 - Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940 - Tested-by: Jenkins - Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - (cherry picked from commit e464f139740062a8da409d74c2942205dbe99aa0) - Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161999 - (cherry picked from commit 8a46af6d1523f0092c0a000cce688ec4916b9ef9) - Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162373 - Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> - -2024-01-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [f464c66e17c1547446b7c230f2ecdd49e5d3b7bb] + The problem was that commit 843af72bcc9047867588e29c8e10b84a5e58d70e (make + win32 variant AnyInput() not deliver events (tdf#140293), 2021-02-11) made + AnyInput ~always return true, when called in SwEditWin::KeyInput. Calling + AnyInput(KEYBOARD) there is to query if there are more pending characters. + But in its new form on Windows, it tells if there are any keyboard-related + window events in the queue, where e.g. WM_KEYUP counts, which is for the + same keypress (WM_KEYDOWN) that is being handled right now - even though + those messages will not produce new characters. + + When AnyInput() returns true, a delayed flush timer starts. Only immediate + flush was accompanied by tooltips. + + To make sure that the tooltip is shown also for delayed flush, move the + tooltip code into SwEditWin::FlushInBuffer. Store the 'bNormalChar' flag + (which controlled if the tooltip was shown) in a new member in SwEditWin. + + Change-Id: I51686b25f8d86df48ae9574ab8f3eb1d0e6ca985 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162350 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit d49b0c3654e50ff9b74545140e6f19e008009c33) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162372 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [bb87c874f0865dcb33bd63722d0310313c11d93f] Update git submodules - * Update translations from branch 'libreoffice-24-2-0' - to 392c7b7ba064c5f2934c4b2725f69803d2e5ab01 + * Update translations from branch 'libreoffice-24-2' + to 0045ade72422c916469476a785ef81c12fb8bf05 - update sl translation for gerrit#161999 that change broke string freeze but can be auto-handled Change-Id: I8d76c9702b378c93037a2d82c44fe3b7eb1a89b4 - (cherry picked from commit 0045ade72422c916469476a785ef81c12fb8bf05) -2024-01-19 Julien Nabet <serval2412@yahoo.fr> [e5a0d2f48893af6480f5539208ee202ee536a033] +2024-01-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [e5cb77798dfe7d6e8dacdca89b7d48d1342e2054] - tdf#159213: fix Base crash when choosing "Help" in relations design (kf5) + Update git submodules - There are 2 parts here: - 1) in vcl/qt5: - - for release versions: avoid to call QtAccessibleRegistry::getQObject on a null object - - for debug version: add an assertion on object to check it's not null + * Update helpcontent2 from branch 'libreoffice-24-2' + to 2b0885774389f5bc85cc697294f05212f44d2392 + - Revert "tdf#156156: add Slide Transition sidebar deck help button's HID" + + This reverts commit d529ecdee07d04f261fd13d05ecf2e0ee9f18a4b. + + Reason for revert: merged after string freeze + + Change-Id: I955aed0f12d265fc05d2903d44743ecba8d8c0f4 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162274 + Tested-by: Jenkins + Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> + Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> + +2024-01-22 László Németh <nemeth@numbertext.org> [05292d3fd50c64ac0b2a927334c39fe63aa3a108] + + tdf#106733 xmloff: keep fo:hyphenate in character formatting - 2) in svtools: - the specific root cause was in EditBrowseBox::DeactivateCell, - we must check m_aImpl->m_xActiveCell in addition to isAccessibleAlive() + In the case of character formatting, map fo:hyphenate to the + unused CharNoHyphenation character property to keep it + during ODF import/export instead of losing it completely. - Import remark: I had a very naive/bandaid patch at the beginning - this one is entirely thanks to Michael Weghorn + This is the first step to disable hyphenation for single + words or text spans in paragraphs with automatic hyphenation. - Change-Id: I90214e9c5b7c0aa45481915d7be6020a7dc8c42e - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162182 - Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Note: using fo:hyphenate as character property is part of + the ODF standard. + + Note: the old workaround to disable hyphenation, changing + the language of the text to None had got some serious fallbacks: + losing spell checking and losing language-dependent text + layout (supported by both OpenType and Graphite font engines + in LibreOffice). + + Change-Id: I9565c3efbbb6e6d970fb03710e8c932ad72ab57e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162257 Tested-by: Jenkins - (cherry picked from commit 1a637a07a0fb23f4d4bfac69378caff7ee965737) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162141 - (cherry picked from commit 491fb3b8723d6d2725326b145b35328cb89a118a) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162149 + Reviewed-by: László Németh <nemeth@numbertext.org> + (cherry picked from commit 956f81ebc9d70507a4a976bfe42c99175dbf3632) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162272 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-22 Justin Luth <justin.luth@collabora.com> [51a1ce9ca77c7559957abd8daf2e51b2e0f5d17b] + + tdf#153909 docx import: wrap through shapes shouldn't FollowTextFlow + + This resolves a NISZ 6.4.0 regression from + commit 27d04f6dbf38aa28fb7215590d578c4567db5770 + tdf#119038 DOCX: fix FollowTextFlow handling + + MSO is all over the place in how they implement layoutInCell + (aka FollowTextFlow in LO). There are lots of compat15 differences + for this, but I don't notice compat coming into play with this bug. + + For reference, see commit e993638d5ecd33783f2eebdccfa87a81e5a8a2c5 + Author: Miklos Vajna on Mon Jan 24 12:53:25 2022 +0100 + DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone> + + I'm sure this is the WRONG code spot for handling FollowTextFlow, + but anywhere else and we lose the "it came from a vml shape" + limiting information, so I'm not going to try to relocate this code. + + Inline (as-character) shapes ignore layoutInCell, + so the type of anchor (floating or inline) shouldn't matter + and therefore doesn't need to be part of the if () clause. + + The header can be special (in compat14 it means everything + is wrap through), but at least in this case it is not limited + to IsInHeaderHeader. Using a non-header as the unit test. + + make CppunitTest_sw_ooxmlexport21 \ + CPPUNIT_TEST_NAME=testTdf153909_followTextFlow + + The first patchset contains a list of all of the unit tests + that were impacted by this patch: nothing interesting. + + Change-Id: I0c4c7924833550533ad1b0b7609840a666d4d589 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162324 + Reviewed-by: Justin Luth <jluth@mail.com> + Tested-by: Jenkins + (cherry picked from commit ad0266eb84eafa32ccc4e0ddf3c6392860bc9b13) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162286 + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + +2024-01-22 Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> [13be76e4d58db7ff892dff900e7734ac424bd8dd] + + tdf#146487 Don't show generic diagram title when there is an empty title given + + Bugdoc has autoTitleDeleted set to false (so title should be visible), but then an empty title is given. + In this case no default string should be added to the title, only in case of Pie Charts. + Any other Chart types show the default title in MS-Office. + + Co-authored-by: Balazs Varga <balazs.varga.extern@allotropia.de> + + Change-Id: Ib445099a4a3d113cff6b1ffdfd093fe41c34716b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155681 + Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> + Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> + (cherry picked from commit c205194b8c54011af4b2cd34fbc00f4885883643) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162270 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + +2024-01-21 Jim Raykowski <raykowj@gmail.com> [cafcc50570f9edaaebe74d2152bae5df1cc2edfe] + + tdf#159147 followup + + Avoid unnecessary looping by immediate return from the function after + bringing content to attention. + + Change-Id: I670dc5d0991d96e7ce2872d329e969f9c341d163 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162291 + Tested-by: Jenkins + Reviewed-by: Jim Raykowski <raykowj@gmail.com> + (cherry picked from commit a08197e7c376c72685260ae923483ae99f929d35) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162279 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [53d8675436cb500adff0f9f6aa0063b9c00962dd] + + tdf#139631 sw_redlinehide: fix IntelligentCut feature with redlines + + Unfortunately forgot to adapt SwCursorShell::GetChar() to use the + SwTextFrame instead of the SwTextNode, so it returns non-visible + (deleted) characters to SwWrtShell::IntelligentCut(), breaking one of + our oldest AI features. + + (regression from sw_redlinehide) + + Change-Id: I0c19944159e7e3af323bfe626c0e496ad745ef35 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162253 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit ab2b0bd10481e9d0bb5bfea09ab0b034bb246c52) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162271 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [f472defff73d495f564a0d8a84f24bc3739c9603] + + sw: layout: prevent bad page break in table with 0-height rows + + The bugdoc contains a table with most rows having a hidden-paragraph + field in every paragraph, and no cell border or padding. + + The SwTabFrame is initially split across 6 pages, which should all be + joined, as there are only 3 visible rows, but the last follow is never + joined. + + This is because SwTabFrame::Join() of the next-to-last follow doesn't + invalidate the SwTabFrame, because Grow(0) doesn't invalidate, and + later formatting anything in the moved SwRowFrame doesn't invalidate + either as it is all height 0. + + Try to fix this by guessing that the row will have height 0 (even if + it's not formatted yet). + + Change-Id: Ic8246ac91c741f5a215f89dc159c44d7c7cf2ce1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162203 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit ab7893544dc6be6dc192dffefd57cd5ddd421c35) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162223 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [45f3d436d0a1271b42c22d9244cc24d237c94ff9] + + tdf#105844 add test for ODF wholesome encryption with macro signature + + ... plus manifest schema extension. + + Change-Id: I73721db8620e97bd58556f9a71afcb0a33f6c7e8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161898 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 4d6e9d5e155da1dde05233eb87691e2a454162f6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161866 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [3f9979db2331e9cdf73743cc68a3ce7174ea54fa] + + tdf#105844 xmlsecurity: fix test failure on WNT + + Commit 4d6e9d5e155da1dde05233eb87691e2a454162f6 added 2 tests that + always fail on WNT, unfortunately Jenkins doesn't actually run the + tests. + + There are 3 certificates involved: + "Xmlsecurity RSA Test Root CA" + "Xmlsecurity Intermediate Root CA" + "Xmlsecurity RSA Test example Alice" + + In the signature XML, there are 3 elements that contain or reference + certificates: + + 1. X509Data - xmlsecurity produces only the signing certificate here + 2. xd:SigningCertificate (XAdES) - again only the signing certificate + 3. xd:EncapsulatedX509Certificate (XAdES) - xmlsecurity produces the + full certificate chain here + + All of these elements *could* contain the full certificate chain, but in + LO-produced XML signatures only 3. does. + + The problem is that the function CheckUnitTestStore() that looks up + a certificate in a unit-test-specific CA store via + $LIBO_TEST_CRYPTOAPI_PKCS7 can only handle a root certificate, it does + not recursively retrieve and check a certificate chain. + + The SecurityEnvironment_MSCryptImpl::verifyCertificate() already has a + parameter "seqCerts" to pass in the full certificate chain, but due to + the way the data from the XML is processed, it gets passed only the + content of the X509Data element(s), which, for LO-produced signatures, + do not contain the full certificate chain. + + Instead of improving the unit-test-specific function, let's try to get + all the certificates out of the XML signature, and then pass them to + verifyCertificate(). + + Of course this requires some consistency checks so that the verification + can't be fooled by different certificates in different XML elements. + + Change-Id: I8ca541887ceac2dfb6af5d96a5565cfa58d7f682 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162170 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 3e9a700091872480dd085f0928d1d30b7d74cfd7) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162139 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [908abf0b0e36fd1c6e8d3df48e9c35ce911c9bda] + + tdf#158783 sw: SwCursorShell::GotoTOXMark() must actually move cursor + + The problem was that the buttons in SwIndexMarkPane got the + next/previous mark, but SwCursorShell::GotoTOXMark() may return the + next/previous mark without actually moving the cursor. + + It happens that the current mark is outside a table and the next mark is + inside a table, then UpdateCursor() doesn't accept the invalid cursor + range and resets the point to its previous position. + + Change-Id: I5c0fb4a9bbcbdd479581172834b6eda76a5abbc1 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161970 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 3fefff7ce29a234694343105c50c7bc3259a9cb8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161949 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [b955e86071e91c7f6d0047f383f225881db7b417] + + tdf#105844 package: ODF wholesome encryption: use package version + + ... to init the Version property. + + The problem is that the outer storage loaded from a wholesome ODF + encrypted document doesn't have a Version, because it doesn't (directly) + contain a document and has no "/" file-entry. + + Extract the root element's package version attribute and use it. + + The Storage API doesn't distinguish much between the package version and + the root document's (i.e. root folder's) version. + + Change-Id: I0fd5f999e9adee674d73fc542402512d0e204897 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161897 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit f1117fbfcd931d4ea2fccfb56f154aa6186d384b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161865 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-20 Michael Stahl <michael.stahl@allotropia.de> [8f5c108297fb4816318172f4c7240438f956bb60] + + tdf#105844 package: ManifestImport: handle argon2 attributes in ... + + ... standard namespace too. + + Change-Id: I46804795da2009dfd8bb95b9286933728a132e5b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161785 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit bac43054e2997235ce98432bc9cb6c434120e4b2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161764 + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-19 Rafael Lima <rafael.palma.lima@gmail.com> [8472ffa70887b8f68d7e8f17faef377a83b0695e] + + tdf#159247 Fix crash while adding control with default properties (Dialog Editor) + + Controls created using the Ctrl+toolbar (which adds a control with default properties) did not have a parent form, which causes the crash. + + Change-Id: Ic2f469e6656a93bbed25d86092384f81b21aaca5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162217 + Tested-by: Jenkins + Reviewed-by: Patrick Luby <plubius@libreoffice.org> + Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> + (cherry picked from commit c4e5b1b934fc3c59fb35ae6c02a0ddf8501a6d28) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162278 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Hossein <hossein@libreoffice.org> - Tested-by: Michael Weghorn <m.weghorn@posteo.de> -2024-01-18 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [b5887fe96b87ad7130d4c34718a6fa5aaac98632] +2024-01-19 Mike Kaganski <mike.kaganski@collabora.com> [0f436a2fe6dfe8b2a7b159a94ed7a8706a1b4482] + + tdf#159271: do not try to put fields' spaces to hole portions + + Change-Id: Ic1b3f9602089cc773f9c3adc0be09a3be08d690f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162269 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162293 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-19 Attila Szűcs <attila.szucs@collabora.com> [1c7c0cdb90f703b963ec88180d12324e4b3afa2e] + + tdf#134401 SD: export to pptx: autoGrow->textWordWrap + + PPTX doesn't have autoGrowWidth and autoGrowHeight, + but it does have TextWordWrap which is similar. + If autoGrowWidth and autoGrowHeight are set in the document, + then they are exported to PPTX as TextWordWrap = "none". + + Without this patch, PowerPoint may wrap some texts into more + lines as Impress does. This is because some text may rendered + at sligtly different sizes in PowerPoint as in Impress. + (maybe it is just a rounding difference) + Even 1% (or less) size difference is enought, because when + autoGrowthWidth and autoGrowthHeight is set, then there is a + good chance, the textbox rectangle is exactly as big as the text. + + Change-Id: I2cdba68c66c43507c5007a9e395b87ddeeea2372 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162152 + Tested-by: Jenkins + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit dc5a761df436f5d9de781d1fa6cf7d010f8be0e8) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162210 + Reviewed-by: Andras Timar <andras.timar@collabora.com> + +2024-01-18 Michael Stahl <michael.stahl@allotropia.de> [d41053defd59257a13916a096da40db152b4b41e] + + tdf#158277 sw_redlinehide: fix find bar string + + FindTextFieldControl::SetTextToSelected_Impl() uses the XModel to + retrieve the currently selected text, which naturally includes deleted + text. + + Instead, use view API XTextViewCursor to get the visible selected text. + + (regression from commit ae2232366f00e08c1855667cfaf068269ac9af2f) + + Change-Id: I302ea90a7407af6e3ae7b62a2f373dccb33b8275 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162245 + Tested-by: Jenkins + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 1f540c49e68b28a360ee5c32d60ab1bed3837eec) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162229 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-18 Kevin Suo <suokunlong@126.com> [f14e942e84942b42956a058e737742f5d19daa96] + + tdf#158314: show Empty and Error entries as non-selected and inactive... + + ...when hidden by autofilter. + + The "show hidden filter elements as inactive" feature was added and improved by: + + commit 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1 + (tdf#117276 sc: Show hidden filter elements as inactive elements) + + commit 2085e90fe8ac129bc4dbac4612d1ea7544335dae + (FilteredRow is not a property of the column, tdf#117276 follow-up) + + commit 7321db3cadc8c0e4437ca04e5dcb652734ea9c26 + (Related tdf#117276 sc: Show hidden filter elements as inactive elements) + + commit 19533948370dc1ccd7334dbe1a8b7fc8330b10c0 + (Name FilteredRow what it is, not hidden; tdf#117276 follow-up) + + Those changes correctly made normal hidden filter elements as inactive, + but failed to do so for Empty and Error entries. + + This patch shows the hidden Empty and Error entries as inactive and unselected. + Also, do not show the Empty entry at the top of the list in case it is inactive. + + Change-Id: Ibcd758cebc0692b04b162cdfc3e06eceb86b17da + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162166 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Kevin Suo <suokunlong@126.com> + Tested-by: Kevin Suo <suokunlong@126.com> + (cherry picked from commit 2e844921083ee45a36454ea3f03c1796439e4d16) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162224 + Tested-by: Jenkins + +2024-01-18 Caolán McNamara <caolan.mcnamara@collabora.com> [e3159bd2e036cd5a44ea296685a41904d660e773] + + merge float fix from gcc3_linux_x86-64 to gcc3_macosx_x86-64 + + presumably we need the same fix there as done with: + + commit 3bcc14b4e2b226f97e937ca7a152218f8276ee39 + Author: Stephan Bergmann <sbergman@redhat.com> + Date: Thu Aug 3 13:21:44 2023 +0200 + + Fix handling of float vs. double values + + Change-Id: I7d6420dc954cdc320c9478172878e2a272ab2745 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162193 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 5bc1d4bea295695b193cab61b92ba89bcbe169cd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162214 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-18 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [1b415b33651f6cbf57658a0d1ae822f1fa7f12ec] tdf#159243 fix packaging of Noto fonts/fix Armenian UI on macOS @@ -457,31 +3571,239 @@ (cherry picked from commit ea46522272a97ad429d6e8ae47cc548aeca50334) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162218 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - (cherry picked from commit c9a3477b4e52fc899e52eca605018d1c62f0ae76) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162220 + +2024-01-17 Jim Raykowski <raykowj@gmail.com> [e8877f971a4b50e58bbbe3df1e14cde1a2e0d694] + + tdf#159147 Fix crash when editing hyperlink while navigator is open + + by assuring the SwURLFieldContent::SwTextINetFormat pointer is still + valid before trying to bring the hyperlink content to attention + + Change-Id: I7f672576ab2869c5483284b543e99e46a558acc9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162013 + Tested-by: Jenkins + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Jim Raykowski <raykowj@gmail.com> + (cherry picked from commit b2500f0e32b33eec2740dc370238f66fb8b50ffb) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162212 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Reviewed-by: Hossein <hossein@libreoffice.org> + +2024-01-17 Matthew Kogan <matthew@epoq.co.uk> [ee0a6a4179b17b76dfd97982ef87d92661afc28c] + + tdf#159101 sw: Fix space appearing at start of line when field wraps + + Adding the ' ' to ScanPortionEnd fails pretty quickly with infinite + loop. + + The important part of fixing the forum-mso-en-13115.docx was that the + SetHasFollow(true) condition is not affected by a ' '. + + (regression from commit 21473f46fda5f1c7f220493667a96fff7c78a7b3) + + Change-Id: I6452673c0fe05ca549b63a398a977fc71db64bae + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162167 + Tested-by: Jenkins + Reviewed-by: Matthew Kogan <matthew@epoq.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> - Tested-by: Michael Stahl <michael.stahl@allotropia.de> + (cherry picked from commit 4cdb542348b20d8a558cd6413c7cccdc50241fa9) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162146 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> -2024-01-16 Eike Rathke <erack@redhat.com> [73dd4d13f503d09d6d20a349a5bf9052680f592a] +2024-01-17 Mike Kaganski <mike.kaganski@collabora.com> [806d07ffa3fa8e0810a00d570c7cfa844cc226ee] - Resolves: tdf#159148 Accept int32 hours:minutes:seconds input + tdf#135083: make sure to apply pending paragraph properties, even without - ... and detect overflow to result in text instead of 00:00 input loss. + ... trailing \par. + Commit a6ae84cc296d4d28e9a48a57406e955138c87a80 (tdf#70318: Prevent + extra empty paragraph in clipboard RTF content, 2015-11-10) made sure + to not emit trailing \par for RTF clipboard content. The problem was, + that in the absense of the \par, the settings of the last paragraph + were not applied (this happens in DomainMapper_Impl::finishParagraph). - Change-Id: Ib2b9f16ab6c3c2963c5a2058c27366219f090096 - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161977 - Reviewed-by: Eike Rathke <erack@redhat.com> + This change makes sure to call dispatchSymbol(RTFKeyword::PAR) + (which eventually calls the mentioned method and applies pending para + properties). Since this also adds a new paragraph (which needs to be + avoided), a new flag is introduced, set by Stream::markLastParagraph. + Its purpose is to make sure that all properties are applied to para, + as opposed to bRemove argument to DomainMapper::finishParagraph, which + prevents setting some properties (e.g., related to numbering - see + DomainMapper::lcl_utext). + + Change-Id: Ia5e368e540c30f95058c81a280a62205aa85398b + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162154 Tested-by: Jenkins - (cherry picked from commit e69192b51fc00cbc38006230364af07983a9a827) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161995 + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162191 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-17 Julien Nabet <serval2412@yahoo.fr> [2797c7f803792f3539fc86ac5af06da23ec7cc2e] + + tdf#159213: fix Base crash when choosing "Help" in relations design (kf5) + + There are 2 parts here: + 1) in vcl/qt5: + - for release versions: avoid to call QtAccessibleRegistry::getQObject on a null object + - for debug version: add an assertion on object to check it's not null + + 2) in svtools: + the specific root cause was in EditBrowseBox::DeactivateCell, + we must check m_aImpl->m_xActiveCell in addition to isAccessibleAlive() + + Import remark: I had a very naive/bandaid patch at the beginning + this one is entirely thanks to Michael Weghorn + + Change-Id: I90214e9c5b7c0aa45481915d7be6020a7dc8c42e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162182 + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Tested-by: Jenkins + (cherry picked from commit 1a637a07a0fb23f4d4bfac69378caff7ee965737) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162141 + +2024-01-17 Noel Grandin <noel.grandin@collabora.co.uk> [b7219afbb13b923376ec5055209c92b087cc2c53] + + tdf#158950 Paste as RTF loses char color and paragraph alignment from styles + + This logic partially originated in + + commit 8e8f9388c323ad3c32cef3f91609ad19386b7d56 + Author: Miklos Vajna <vmiklos@collabora.co.uk> + Date: Tue Apr 22 12:53:24 2014 +0200 + Related: fdo#77600 RTF import: RTFValue::equals: compare attribute + content + + But it is rather weird to compare RTFSprms this way, comparing each + attribute to a parent RTFValue. + + Making the comparison more "normal" fixes the reported bug while not + breaking fdo#77600 + + Change-Id: Iee224c7bc9542c359f8a71086230e4b53c1c3e16 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162164 + Reviewed-by: Regina Henschel <rb.henschel@t-online.de> + Tested-by: Jenkins + Reviewed-by: Miklos Vajna <vmiklos@collabora.com> + (cherry picked from commit f6a559ccacaab875d1aa1da70e3011592158e9d4) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162142 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> - Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> -2024-01-16 Caolán McNamara <caolan.mcnamara@collabora.com> [27338affafc845b37bb59c9ad2bf1a35a0f07c0c] +2024-01-16 Rafael Lima <rafael.palma.lima@gmail.com> [66f829f1f41800ca9e31f0dd82fa78fdad02a77a] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 3a01a710608f9237d25f509056cc41ad73e43da6 + - Silence strings for translation in sf_database.xhp + + Change-Id: Ibbccb617adbb97da9f892ead789db8f643f78f83 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161930 + Tested-by: Jenkins + Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> + (cherry picked from commit d6168024a68482349db0c02713e79d37a31519ce) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162137 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-01-16 Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> [395c8cfb770e7424fd99b884f568a32fcc7a728f] + + tdf#159186 Use changed value when editing string-list a second time + + Change-Id: I0e26a053b3b5fb04abf87894bcfebccea8bdd26f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162074 + Tested-by: Jenkins + Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> + (cherry picked from commit 76ce6466b814bb9ff119f4f83795a2aeefc28793) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162097 + Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> + +2024-01-16 Julien Nabet <serval2412@yahoo.fr> [18f4c113329855f71b7084c3ad9983e04f54b2de] + + Fix location of an g_object_unref in vcl/glomenu + + Change-Id: Icef8e74867758c815e1a55ae0906dead9b70ae6d + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162131 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-16 Mike Kaganski <mike.kaganski@collabora.com> [e7285c5e520a35d34bce66fd1fe5bcd7771f9978] + + tdf#140330: do not deduplicate conditional formatting in undo context + + Change-Id: If9c64a7af46ca601b3c47a80642d914facafdc62 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162084 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit dc75960fdee6cac2d9dd6b45ac3090f30f92b3ce) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162104 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-16 Julien Nabet <serval2412@yahoo.fr> [0d00a60fdfb22765dcc30e42a987186436099c35] + + Add missing g_free in salnativewidgets-gtk + reorder ones in cpdmgr (vcl) + + Change-Id: I2608a2fe238d124f3a158438e8219fbc63f750d8 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162132 + Tested-by: Jenkins + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Stephan Bergmann <stephan.bergmann@allotropia.de> [8f72aa782500f456f02f18fa74f6b3b6c9b5e90c] + + Flatpak: Work around patched libpng in org.freedesktop.Sdk + + see + <https://github.com/flathub/org.libreoffice.LibreOffice/pull/268/commits/7c79189f674c7cc88f0ab2790d8d198f4a855182> + "Work around patched libpng in org.freedesktop.Sdk": + + ...which carries + <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/873b28450476c434a3f6fa86cb1874b11968a479> + "elements/base/libpng.bst: Add support for animated PNGs", thus handles "acTL" + chunks by itself, thus doesn't call the LibreOffice handle_unknown_chunk + function (in vcl/source/filter/png/PngImageReader.cxx) for such chunks, thus + never sets APNGInfo::mbIsApng to true, so causes CppunitTest_vcl_png_test to + fail with + + > PngFilterTest.cxx:382:Assertion + > Test name: PngFilterTest::testApng + > assertion failed + > - Expression: aGraphic.IsAnimated() + + (<https://buildbot.flathub.org/#/builders/6/builds/92958>) since + <https://git.libreoffice.org/core/+/bf944e33569e4a1d6236a54671b7320cdc6ffaf6%5E%21> + "tdf#104877 Add basic APNG format support". + + The patch appears to originate from + <https://sourceforge.net/projects/libpng-apng/>, and it might be possible to + adapt the LibreOffice code to also work with such a patched libpng (whose png.h + defines PNG_APGN_SUPPORTED). However, for now just use LibreOffice's own + external/libpng instead of the patched one. + + Change-Id: Ib67056d11dfa6456920a18216a3b2bbec45f3662 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162112 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 223bfa24cdeee2ed45ff8d9ab7bb0b92eb8af587) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162107 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Oliver Specht <oliver.specht@cib.de> [b65a2bc14c1553846bd0f4910951a0a964b3cde5] + + tdf#158830 fixes regression introduces with tdf#158044 + + Removing paragraph attributes equal to style attributes now works also + for paragraphs within tables. + This fixes also the regressions documented in tdf#158978 and tdf#158982 + + Change-Id: I9f430e23fd33cff4d6ec1d1954969666f0080574 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161824 + Tested-by: Jenkins + Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> + Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> + (cherry picked from commit 204d50a07501bf8445a8a0526f68987373834318) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162109 + +2024-01-15 Caolán McNamara <caolan.mcnamara@collabora.com> [fc1350b990364765256ea48863363ae857d65fe5] crashtesting: null deref of xValueSeq @@ -502,29 +3824,258 @@ Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162103 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <jluth@mail.com> - (cherry picked from commit 1a64228c8fa995cfb068dbb719caf4e6f5bfa7cd) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162106 - Tested-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-15 Jean-Pierre Ledure <jp@ledure.be> [4651a5eb1b913d61d015c8fe2d713110bd2c5c50] + + ScriptForge (SF_Array) fix tdf#158976 Shuffle() + + The algorithm used to shuffle a 1D array + prevented any item of the array to remain + in the same entry after the shuffle. + + This has been fixed. The potential targeted entries + to receive an item include the actual entry. + + This change might impact existing scripts that + have Randomize()d their sorts to always get the + same shuffle results. This should impact test + scripts only. + + SF_Array.Shuffle() is available in Basic only. + No impact on help pages. + + Change-Id: If56d901f4af68f8889a7352c306bae6e3443ae97 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161987 + Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> + Tested-by: Jenkins + (cherry picked from commit ca9168b8ad842c86b2168e12bb98087b9f8139bd) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162009 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Mike Kaganski <mike.kaganski@collabora.com> [41afcf4fa89abe23177e6a26d1a9e8611f351852] + + tdf#159174: there may be no tabs in the clipboard document + + Change-Id: I053d91bf44e39e14ade9face14084a107d0df898 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162041 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 0b93cc83993b3cd78aa05556342839a21c96dc5a) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162092 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Mike Kaganski <mike.kaganski@collabora.com> [5c233dae8fb921a10921afa999d40ef2dbfc07ba] + + Let SwAnchoredObject::GetFrameFormat return pointer, and drop HasFrameFormat + + In commit 19062c98da5b2e9edc7a99068fa06a83c7578826, it was important to + check if objects have frame format before using GetFrameFormat. + + Thic change makes it simpler amd more obvious. Also, it allows to avoid + two calls to GetUserCall, by obtaining the pointer once and checking it. + + Change-Id: I980fcba9e369e107f3d062e8cab0a34e02384290 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162044 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162079 + +2024-01-15 Matt K <mattkse@gmail.com> [a72dad4e4c0d41b61e453919401fcefc8e5e9b43] + + tdf#132810 Prevent crashes with gallery objects + + The problem is the formats for the gallery objects + may be non-existent but the code attempts to use + them anyway, causing crashes. The fix is to check + for the existence of the proper format objects + before using them, so as to prevent the crashes. + I tested creating/deleting multiple objects with + multiple rounds of undo/redo and believe this change + to cover all the crashes that can occur (there were + several). + + Change-Id: I9d5d704eaa381be861ac1758ad58269706437a27 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161950 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162078 + +2024-01-15 Matt K <mattkse@gmail.com> [fe1d56b3bc895d23f7e53fb7e2414862403099a0] + + tdf#159171 Prevent crash after selecting unprotected cells 2 times + + The problem is that the code tries to check for a table on a clip- + board doc, but doesn't find any so it propagates nullptr back to + the caller, which is then used without being checked thereby + leading to a crash. The fix is to check the result of the table + check of clipboard doc before doing any operations with it, thus + preventing the crash. + + Change-Id: Ieb4a52d0c1cb713d5c14930e5e559e5bf520b330 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162033 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 3b10bbacb8a12a00c35683eeaae4a75046a84aac) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162091 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Thorsten Behrens <thorsten.behrens@allotropia.de> [d5fde3f3fc9da416089baecef4f43e904b3969da] + + Fix obscure xpdfimport crash on missing fonts + + Invert logic, such that the case WMode == 0 and no font set now run + the former else branch. Happened here for an obscure pdf I was missing + some fonts for. + + Change-Id: I2825c914a04f6a95d459eeeffb8091ed8f1819dc + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162029 + Tested-by: Jenkins + Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> + (cherry picked from commit 1637610478c4493c29a29286b66250ef47507681) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162093 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> -2024-01-15 Caolán McNamara <caolan.mcnamara@collabora.com> [e0237d26c6b07f79ab7d4c702b0d0c4241039ac2] +2024-01-15 Matt K <mattkse@gmail.com> [a381ac7b0fa95ce340bd1b384c946fbd19d87393] - Resolves: tdf#159138 don't expand dialog to fit excessively long urls + tdf#151752 Fix crash when selecting unprotected cells and copy/pasting - this widget is the one that ends up controlling the insert hyperlink - dialog width + The problem is that the code attemps to index into maTabs when looping + through clipboard ranges, but maTabs.size() can be 0 at that point + thus resulting in a crash. The fix is to first check if maTabs.size() + is greater than 0 before doing the looping. - Change-Id: I09aaa32e96c4ddcc3e608cb24e67a669d376120f - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161961 + Change-Id: Ib2fc4c9f847f87f44a68ad6d73c2745d79b5caa5 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162032 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 59927dedc31eb5d51b417a02ae927eb578b90bd6) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162090 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-15 Stephan Bergmann <stephan.bergmann@allotropia.de> [300c18921cc67fa3202184f19f48b8ea654207b7] + + Further adapting of create-partial-info + + ...along the lines of what had already been done for create-update-info, passing + files to the mar executable with an -f files.txt instead of on the command line + (which could grow too long for Windows), and taking the archive metadata into + account. + + For the latter, `make create-partial-info` now expects a second make variable, + ONLINEUPDATE_MAR_OLDMETADATA, in addition to ONLINEUPDATE_MAR_OLDARCHIVE. And + there is a new TODO in update/create_partial_update.py that the old and new + metadata should be compared for problematic changes. (For now, any such changes + would just get lost by an update.) + + Change-Id: Ide45adedb72958fc32c5b26aa7ebb01530ccf3d7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161972 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit a00266e2f8967f8eea0ce4d13c818e33ae188399) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161991 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-15 Stephan Bergmann <stephan.bergmann@allotropia.de> [15159fabd8c6c994a0010fc17f8b471263bb5380] + + Windows MAR update issues with program/{setup,version}.ini + + At least on Windows, our MSI install sets differ from our archive install sets + in that their program/setup.ini and program/version.ini files have differing + content: For one, they have ProductCode, UpdateCode, and MsiProductVersion (the + latter only in version.ini) lines that have empty values in archive install sets + and non-empty values in MSI install sets. For another, setup.ini in MSI install + sets has additional ALLUSERS, BASISINSTALLLOCATION, FINDPRODUCT, + INSTALLLOCATION, OFFICEINSTALLLOCATION, and UREINSTALLLOCATION lines that are + completely missing in archive install sets. + + This is a problem when building MAR updates with create-partial-info: Both ini + files contain the buildid, so will always change between builds, so will always + be recorded in MAR updates. But when they are recorded as "patch", actually + applying the MAR update file (generated from archive install sets) to an + installation (originating from an MSI install set) will fail, as the size of the + ini file in the installation doesn't match the expected size recorded in the MAR + update file. + + I naively but strongly assume that those differences in ini file content are + historic junk by now that have no practical consequences (i.e., I assume that no + code actually makes use of those ini file entries). Which would mean that it + should actually be harmless to replace an installation's (MSI-originating) ini + files with smaller (archive-originating) ones during an update. + + So for now I work around that problem by always forcing these two files to be + recorded as a full "add" rather than as a "patch" in the generated MAR update + file. + + In parallel, I will look into the history of all those problematic ini file + entries, and will try to verify that they are indeed unused junk, and will try + to clean that up. (So that ultimately there will be no more differences between + MSI and archive versions.) + + Change-Id: I9b22bd83889b569598162c37f9bf1a0857177063 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161974 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 9f7d7fe531527f9039bbbca5e6e75f09b2d175f2) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161992 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-15 Eike Rathke <erack@redhat.com> [9d5b078120f1151e9afaf30ca8e088a871c5d443] + + Resolves: tdf#159148 Accept int32 hours:minutes:seconds input + + ... and detect overflow to result in text instead of 00:00 input loss. + + Change-Id: Ib2b9f16ab6c3c2963c5a2058c27366219f090096 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161977 + Reviewed-by: Eike Rathke <erack@redhat.com> + Tested-by: Jenkins + (cherry picked from commit e69192b51fc00cbc38006230364af07983a9a827) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161993 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-15 Justin Luth <justin.luth@collabora.com> [8132f0eb48d1b1601b690c43bcd4991c86dd1217] + + tdf#139915 tdf#159157 writerfilter: fix image position with TEXT_LINE + + This is an IMAGE followup to vmiklos' shape/textbox fix in + LO 7.2 commit 2f21e4f357ec60450df84ddd858c3cf0a4711b02 + + Images follow a different code path, but needed the same treatment. + + Change-Id: I974944c7fbb4e0fa6aa52ac239c6a16ec7f927e6 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161986 Tested-by: Jenkins - (cherry picked from commit a25b8e353e3ac6383a63f3626b2d0cb88baaf872) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161945 - Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> - Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + Reviewed-by: Justin Luth <jluth@mail.com> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161988 + +2024-01-15 Justin Luth <justin.luth@collabora.com> [54ad2fd256224804181050f60c0668aa24cc82f7] -2024-01-14 Patrick Luby <plubius@libreoffice.org> [a93cd8a77777e9704617d82db2d421154de3ff92] + tdf#139915 DOCX export: fix anchored obj position with TEXT_LINE + + The position of objects was waffling back and forth + between "above" or "below" every round-trip. + For example, the unit test was alternating between 410 and 3951. + + make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf97371 + + This is an export followup to vmiklos' import fix in + LO 7.2 commit 2f21e4f357ec60450df84ddd858c3cf0a4711b02 + + I noticed that import still does not correctly position images: + make CppunitTest_sw_ooxmlexport8 CPPUNIT_TEST_NAME=testN747461 + so I created tdf#159157 and tdf#159158 as follow-up bugs for that. + + Change-Id: I29864d53f3b5e2fc9830793275f17a11eac0516f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161985 + Tested-by: Jenkins + Reviewed-by: Justin Luth <jluth@mail.com> + (cherry picked from commit c45bf5f4ae858d5d0532ee9b58fcbf23e94e2d75) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161996 + Tested-by: Justin Luth <jluth@mail.com> + +2024-01-14 Patrick Luby <plubius@libreoffice.org> [753981dd0cbbdedeca4fa95681f6d65d370a758f] tdf#159089 dispose custom accessible here and unset for `m_xDrawingArea` @@ -537,27 +4088,239 @@ Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org> (cherry picked from commit 244bd399732017615bab2c34c2b29d6a80d27ae9) - Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162007 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162006 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> - Tested-by: Patrick Luby <plubius@libreoffice.org> -2024-01-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [d39acddc34f7dc3784e7dfed7293edda2e43cd9a] +2024-01-14 Julien Nabet <serval2412@yahoo.fr> [86549619dfe7457da34d712372e34cc467ef027b] - bump product version to 24.2.0.2.0+ + Add missing g_list_free in GtkInstanceComboBox ctr - Change-Id: Ic7c96aeb7ec5d623b013ffe17efd26143740f0c5 + Change-Id: I1cb70afb229036209c635e52c9b22f619025f368 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162000 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> -2024-01-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [025e3b4d0cfde00144d984b3949bbf4d3b92560d] +2024-01-13 Julien Nabet <serval2412@yahoo.fr> [f2155b5c6051d68659bea45c0331b53eaaced45d] - Branch libreoffice-24-2-0 + Add missing gdk_event_free (vcl/gtkinst) - This is 'libreoffice-24-2-0' - the stable branch for the 24.2.0 release. - Only very safe changes, reviewed by three people are allowed. + Change-Id: I8bef4c3303f8f2fd89c1cf7cec35536c38d9d4d7 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162001 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-13 Julien Nabet <serval2412@yahoo.fr> [ef21e36ee580c098a92e493795c412adf8562743] + + Add missing g_bytes_unref in GtkSalMenu::AddMenuBarButton - If you want to commit more complicated fix for the next 24.2.x release, - please use the 'libreoffice-24-2' branch. + Change-Id: I00b8a73cfe02abc561ddf67c0e6e4ad612c27422 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162004 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-13 Julien Nabet <serval2412@yahoo.fr> [f1e45b80c396f90d763d3e2e5bcd3baf12383127] + + Add missing g_object_thaw_notify before an early return (vcl/gtkinst) - If you want to build something cool, unstable, and risky, use master. + Change-Id: I3ba4bfd9a302e03dd25e4635dfbb0a41d265349e + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162002 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-13 Julien Nabet <serval2412@yahoo.fr> [d7e4bb5acd38f4827a8f0d0aade8b44d18a1a2ba] + + Add missing g_object_unref (vcl/gtksalmenu) + + Change-Id: I07db3d7a03da94b53ad49188c229c134dc2f663c + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162003 + Tested-by: Jenkins + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + +2024-01-13 Stéphane Guillou <stephane.guillou@libreoffice.org> [054541f449f1d131b2aa50e1d6e35080d388a164] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to d529ecdee07d04f261fd13d05ecf2e0ee9f18a4b + - tdf#156156: add Slide Transition sidebar deck help button's HID + + and document how to access it. + + Change-Id: I3f5c8e0f65f704389ed27989b29cca2cf0279302 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161107 + Tested-by: Jenkins + Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> + (cherry picked from commit c8244945b9d36822a2a35edca7bb9111f39ef282) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161636 + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-01-13 Rafael Lima <rafael.palma.lima@gmail.com> [b3d64e6fbdaccf558cdbd1ac4da8d53c623ebb56] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 8a46af6d1523f0092c0a000cce688ec4916b9ef9 + - Silence strings for translation in sf_dataset.xhp + + Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit e464f139740062a8da409d74c2942205dbe99aa0) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161999 + +2024-01-13 Julien Nabet <serval2412@yahoo.fr> [491465696ae47e1f30c315e5e1845b8d978dfb0d] + + Add missing gtk_tree_path_free (vcl/gtkinst) + + Change-Id: If178d41cd65cce3d07357fadb532059cc4d1c1a9 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161983 + Reviewed-by: Julien Nabet <serval2412@yahoo.fr> + Tested-by: Jenkins + Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> + Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> + (cherry picked from commit 90cac17d5299e0d7e1b73f4bc34fc089fd8cdd3f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161997 + +2024-01-12 Mike Kaganski <mike.kaganski@collabora.com> [45023ae9619cdc4332afb8f743d1695a23e8d866] + + tdf#156443, tdf#159079, tdf#158112: support Windows Alt codes >=256 + + This change in fact disables Alt+NumPad accelerators. Alt+Number will + still work, when Number is from main keyboard. + + Since this intercepts Alt+NumPad completely, it also disables movement + of caret ny NumPad arrows, when NumLock is off. + + Change-Id: I82a3b0521f94038a84fa4dae2e3b1cfd4d4e23ac + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161891 + Tested-by: Jenkins + Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> + (cherry picked from commit 772da0f1aa6891a0b31d45d99a5978c65ed24e34) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161860 + Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> + Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + +2024-01-12 Stephan Bergmann <stephan.bergmann@allotropia.de> [6ed4050f16265bfb02090592c6e88813796ac68d] + + Adapt Flatpak build to new external/argon2 + + Change-Id: I584956151b036e1ba781439205a76f579f32c064 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161955 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 2b1a4f6309437128077c33e27262c052a408b9ba) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161990 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-12 Stephan Bergmann <stephan.bergmann@allotropia.de> [6ae9d6ea0497b5935678c826940b14893a6531d0] + + Update solenv/flatpak-manifest.in + + * Incorporate + <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d9e2f088aafe41c3c9cc4af14e935777dba794c1> + "Update gvfs-1.52.1.tar.xz to 1.52.2 (#272)" + + Change-Id: I95bee83408caab8e27eae978068f8ec4e87a9c12 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161956 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 2a12e2e6593cdd7b8b9978a6aec6910a92600cf3) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161943 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-12 Caolán McNamara <caolan.mcnamara@collabora.com> [a25b8e353e3ac6383a63f3626b2d0cb88baaf872] + + Resolves: tdf#159138 don't expand dialog to fit excessively long urls + + this widget is the one that ends up controlling the insert hyperlink + dialog width + + Change-Id: I09aaa32e96c4ddcc3e608cb24e67a669d376120f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161961 + Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + Tested-by: Jenkins + +2024-01-12 Stephan Bergmann <stephan.bergmann@allotropia.de> [f7accbfdf3231bfa48f42533e2bcbb27b8a4af04] + + Fix `make create-partial-info` (for Windows, at least) + + I got lost trying to figure out how the original + bin/update/create_partial_update.py code was meant to obtain old and new + installation trees to diff, so I simplified that down to the create-partial-info + make target now expecting an ONLINEUPDATE_MAR_OLDARCHIVE make variable that + points at the old archive install set. (And the + --with-online-update-mar-serverurl configure option is gone for good again.) + The remaining changes are similar to what was needed in + 28bad382face10be75af3875e44dde89fbc78108 "Fix `make create-update-info` (for + Windows, at least)". (And the mbsdiff and mar tools expect Windows-style + pathnames, but mktemp returns a Unix-style pathname in cygwin shell scripts, so + this needed an additional Windows-only external/onlineupdate/cygpath.patch.) + + Change-Id: I40690210d62e3f26fb2d574914a0dd4323e6cd62 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161924 + Tested-by: Jenkins + Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> + (cherry picked from commit 44ea2602e3ed8839012582a466775f10da86ee4b) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161937 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-12 Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de> [f259a4636308fbdb8c5d8b9f430e3d53018f327b] + + tdf#158664 Ignore Notifications when SlideShow is inactive + + The impl SlideshowImpl gets notifications for changes from + the ObjectModel, but needs to ignore them when SlideShow + is not active/running. For discussion how to do this see + comments in task. + + Change-Id: Ic251af4b82f0f4b48d8d9b0127dd2f6015966935 + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161922 + Tested-by: Jenkins + Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> + (cherry picked from commit 2184890a0eebc55aa24cbe61de5b8918d958c65f) + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161932 + Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> + +2024-01-12 Regina Henschel <rb.henschel@t-online.de> [f5431af083eb1cde85505dddf19600a7b8f52020] + + tdf#159049 use RTF_LINE for EE_FEATURE_LINEBR for copy + + Copy of simple text uses ImpEditEngine::WriteItemAsRTF() method. + Error was, that in case of a line break ('\n') the string + OOO_STRING_SVTOOLS_RTF_SL was written, but it needs to be the string + OOO_STRING_SVTOOLS_RTF_LINE. + + Change-Id: I1c2ff2087c563b26e26d8768dfcfd1645be91d2f + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161842 + Tested-by: Jenkins + Reviewed-by: Regina Henschel <rb.henschel@t-online.de> + Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> + Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161954 + +2024-01-11 Rafael Lima <rafael.palma.lima@gmail.com> [7a0513ce48ed6da73eec22ba20ea8a7dcce8ec1d] + + Update git submodules + + * Update helpcontent2 from branch 'libreoffice-24-2' + to 4a851d785063f7286f134810ef87ee5e945a3ba7 + - Silence string for translation in sf_intro.xhp + + Change-Id: I12d48417dc979e85138b78f906fae3486f9673b4 + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161938 + Tested-by: Jenkins + Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + (cherry picked from commit 3ed389a88b0650556d19ad64ad7b6f66ef4bee0d) + Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161939 + Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> + +2024-01-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [6cc31ef3fe6335d9e997ad6897f4c8f1a23cb07c] + + bump product version to 24.2.1.0.0+ + + Change-Id: Ia5f3014edabb54205d1b3c4f5f32cb7cfbb70ed5 2024-01-11 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [2177c6faacfb50699754b6075c828631d0e7174a] |