1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <swmodeltestbase.hxx>
#include <unotools/mediadescriptor.hxx>
#include <unotxdoc.hxx>
#include <docsh.hxx>
#include <wrtsh.hxx>
#include <swdtflvr.hxx>
#include <frameformats.hxx>
#include <fmtcntnt.hxx>
/// Covers sw/source/core/undo/ fixes.
class SwCoreUndoTest : public SwModelTestBase
{
public:
SwCoreUndoTest()
: SwModelTestBase("/sw/qa/core/undo/data/")
{
}
};
CPPUNIT_TEST_FIXTURE(SwCoreUndoTest, testTextboxCutSave)
{
// Load the document and select all.
createSwDoc("textbox-cut-save.docx");
SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument*>(mxComponent.get());
SwDocShell* pDocShell = pTextDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
pWrtShell->SelAll();
// Cut.
rtl::Reference<SwTransferable> pTransfer = new SwTransferable(*pWrtShell);
pTransfer->Cut();
// Undo.
pWrtShell->Undo();
// Save.
uno::Reference<frame::XStorable> xStorable(mxComponent, uno::UNO_QUERY);
utl::MediaDescriptor aMediaDescriptor;
aMediaDescriptor["FilterName"] <<= OUString("Office Open XML Text");
// Without the accompanying fix in place, this test would have failed with:
// void sax_fastparser::FastSaxSerializer::endDocument(): Assertion `mbMarkStackEmpty && maMarkStack.empty()' failed.
// i.e. failed to save because we tried to write not-well-formed XML.
xStorable->storeToURL(maTempFile.GetURL(), aMediaDescriptor.getAsConstPropertyValueList());
}
CPPUNIT_TEST_FIXTURE(SwCoreUndoTest, testTextboxCutUndo)
{
createSwDoc("textbox-cut-undo.docx");
SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument*>(mxComponent.get());
SwDocShell* pDocShell = pTextDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
SwDoc* pDoc = pDocShell->GetDoc();
selectShape(1);
rtl::Reference<SwTransferable> pTransfer = new SwTransferable(*pWrtShell);
pTransfer->Cut();
auto& rSpzFrameFormats = *pDoc->GetSpzFrameFormats();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(0), rSpzFrameFormats.size());
pWrtShell->Undo();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), rSpzFrameFormats.size());
const SwNodeIndex* pIndex1 = rSpzFrameFormats[0]->GetContent().GetContentIdx();
const SwNodeIndex* pIndex2 = rSpzFrameFormats[1]->GetContent().GetContentIdx();
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 5
// - Actual : 8
// i.e. the draw frame format had a wrong node index in its content.
CPPUNIT_ASSERT_EQUAL(pIndex1->GetIndex(), pIndex2->GetIndex());
}
CPPUNIT_TEST_FIXTURE(SwCoreUndoTest, testTableCopyRedline)
{
// Given a document with two table cells and redlining enabled:
createSwDoc("table-copy-redline.odt");
SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument*>(mxComponent.get());
SwDocShell* pDocShell = pTextDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
// When doing select-all, copy, paste and undo:
pWrtShell->SelAll();
rtl::Reference<SwTransferable> pTransfer = new SwTransferable(*pWrtShell);
pTransfer->Copy();
TransferableDataHelper aHelper(pTransfer);
SwTransferable::Paste(*pWrtShell, aHelper);
// Without the accompanying fix in place, this test would have crashed.
pWrtShell->Undo();
}
CPPUNIT_TEST_FIXTURE(SwCoreUndoTest, testImagePropsCreateUndoAndModifyDoc)
{
createSwDoc("image-as-character.odt");
SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument*>(mxComponent.get());
SwDocShell* pDocShell = pTextDoc->GetDocShell();
SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
css::uno::Reference<css::beans::XPropertySet> xImage(
pTextDoc->getGraphicObjects()->getByName("Image1"), css::uno::UNO_QUERY_THROW);
CPPUNIT_ASSERT(pTextDoc->isSetModifiedEnabled());
CPPUNIT_ASSERT(!pTextDoc->isModified());
CPPUNIT_ASSERT(!pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
// Check that modifications of the geometry mark document dirty, and create an undo
xImage->setPropertyValue("RelativeWidth", css::uno::Any(sal_Int16(80)));
// Without the fix, this would fail
CPPUNIT_ASSERT(pTextDoc->isModified());
CPPUNIT_ASSERT(pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
pWrtShell->Undo();
CPPUNIT_ASSERT(!pTextDoc->isModified());
CPPUNIT_ASSERT(!pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
// Check that modifications of anchor mark document dirty, and create an undo
xImage->setPropertyValue("AnchorType",
css::uno::Any(css::text::TextContentAnchorType_AT_PARAGRAPH));
CPPUNIT_ASSERT(pTextDoc->isModified());
CPPUNIT_ASSERT(pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
pWrtShell->Undo();
CPPUNIT_ASSERT(!pTextDoc->isModified());
CPPUNIT_ASSERT(!pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
// Check that setting the same values do not make it dirty and do not add undo
xImage->setPropertyValue("RelativeWidth", xImage->getPropertyValue("RelativeWidth"));
xImage->setPropertyValue("AnchorType", xImage->getPropertyValue("AnchorType"));
CPPUNIT_ASSERT(!pTextDoc->isModified());
CPPUNIT_ASSERT(!pWrtShell->GetLastUndoInfo(nullptr, nullptr, nullptr));
}
CPPUNIT_TEST_FIXTURE(SwCoreUndoTest, testAnchorTypeChangePosition)
{
// Given a document with a textbox (draw + fly format pair) + an inner image:
createSwDoc("anchor-type-change-position.docx");
selectShape(1);
SwDoc* pDoc = getSwDoc();
const auto& rFormats = *pDoc->GetSpzFrameFormats();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(3), rFormats.size());
Point aOldPos;
{
const SwFormatHoriOrient& rHoriOrient = rFormats[0]->GetHoriOrient();
const SwFormatVertOrient& rVertOrient = rFormats[0]->GetVertOrient();
aOldPos = Point(rHoriOrient.GetPos(), rVertOrient.GetPos());
}
// When changing the anchor type + undo:
dispatchCommand(mxComponent, ".uno:SetAnchorToChar", {});
dispatchCommand(mxComponent, ".uno:Undo", {});
// Then make sure the old position is also restored:
const SwFormatHoriOrient& rHoriOrient = rFormats[0]->GetHoriOrient();
const SwFormatVertOrient& rVertOrient = rFormats[0]->GetVertOrient();
Point aNewPos(rHoriOrient.GetPos(), rVertOrient.GetPos());
// Without the accompanying fix in place, this test would have failed with:
// - Expected: 789,213
// - Actual : 1578,3425
// i.e. there was a big, unexpected increase in the vertical position after undo.
CPPUNIT_ASSERT_EQUAL(aOldPos, aNewPos);
}
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
