2 files changed, 182 insertions, 0 deletions
diff --git a/lib/Lintian/Check/Images/Filenames.pm b/lib/Lintian/Check/Images/Filenames.pm
new file mode 100644
index 0000000..d728cc6
--- /dev/null
+++ b/lib/Lintian/Check/Images/Filenames.pm
@@ -0,0 +1,126 @@
+# images/filenames -- lintian check script -*- perl -*-
+
+# Copyright (C) 2019 Felix Lechner
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Images::Filenames;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+my @image_formats = (
+    {
+        name => 'PNG',
+        file_type => qr/^PNG image data/,
+        good_name => sub { $_[0] =~ /\.(?:png|PNG)$/ }
+    },
+    {
+        name => 'JPEG',
+        file_type => qr/^JPEG image data/,
+        good_name => sub { $_[0] =~ /\.(?:jpe?g|JPE?G)$/ }
+    },
+    {
+        name => 'GIF',
+        file_type => qr/^GIF image data/,
+        good_name => sub { $_[0] =~ /\.(?:gif|GIF)$/ }
+    },
+    {
+        name => 'TIFF',
+        file_type => qr/^TIFF image data/,
+        good_name => sub { $_[0] =~ /\.(?:tiff?|TIFF?)$/ }
+    },
+    {
+        name => 'XPM',
+        file_type => qr/^X pixmap image/,
+        good_name => sub { $_[0] =~ /\.(?:xpm|XPM)$/ }
+    },
+    {
+        name => 'Netpbm',
+        file_type => qr/^Netpbm image data/,
+        good_name => sub { $_[0] =~ /\.(?:p[bgpn]m|P[BGPN]M)$/ }
+    },
+    {
+        name => 'SVG',
+        file_type => qr/^SVG Scalable Vector Graphics image/,
+        good_name => sub { $_[0] =~ /\.(?:svg|SVG)$/ }
+    },
+);
+
+# ICO format developed into a container and may contain PNG
+
+sub visit_installed_files {
+    my ($self, $item) = @_;
+
+    return
+      unless $item->is_file;
+
+    my $our_format;
+
+    for my $format (@image_formats) {
+
+        if ($item->file_type =~ $format->{file_type}) {
+            $our_format = $format;
+            last;
+        }
+    }
+
+    # not an image
+    return
+      unless $our_format;
+
+    return
+      if $our_format->{good_name}->($item->name);
+
+    my $conflicting_format;
+
+    my @other_formats = grep { $_ != $our_format } @image_formats;
+    for my $format (@other_formats) {
+
+        if ($format->{good_name}->($item->name)) {
+            $conflicting_format = $format;
+            last;
+        }
+    }
+
+    if ($conflicting_format) {
+
+        $self->pointed_hint('image-file-has-conflicting-name',
+            $item->pointer, '(is ' . $our_format->{name} . ')')
+          unless $our_format->{good_name}->($item->name);
+
+    } else {
+        $self->pointed_hint('image-file-has-unexpected-name',
+            $item->pointer, '(is ' . $our_format->{name} . ')');
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et
diff --git a/lib/Lintian/Check/Images/Thumbnails.pm b/lib/Lintian/Check/Images/Thumbnails.pm
new file mode 100644
index 0000000..c8cc430
--- /dev/null
+++ b/lib/Lintian/Check/Images/Thumbnails.pm
@@ -0,0 +1,56 @@
+# images/thumbnails -- lintian check script -*- perl -*-
+
+# Copyright (C) 1998 Christian Schwarz and Richard Braakman
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::Check::Images::Thumbnails;
+
+use v5.20;
+use warnings;
+use utf8;
+
+use Moo;
+use namespace::clean;
+
+with 'Lintian::Check';
+
+sub visit_installed_files {
+    my ($self, $item) = @_;
+
+    if (   $item->is_dir
+        && $item->name =~ m{/\.xvpics/?$}) {
+
+        $self->pointed_hint('package-contains-xvpics-dir', $item->pointer);
+    }
+
+    if (   $item->is_dir
+        && $item->name =~ m{/\.thumbnails/?$}) {
+
+        $self->pointed_hint('package-contains-thumbnails-dir', $item->pointer);
+    }
+
+    return;
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 sr et