1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
|
# archive/file/name/length -- lintian check script -*- perl -*-
# Copyright (C) 2011 Niels Thykier <niels@thykier.net>
# Copyright (C) 2021 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Archive::File::Name::Length;
use v5.20;
use warnings;
use utf8;
use Const::Fast;
use File::Basename;
use Moo;
use namespace::clean;
with 'Lintian::Check';
const my $SPACE => q{ };
const my $FILENAME_LENGTH_LIMIT => 80;
# We could derive this from data/fields/architectures, but that
# contains things like kopensolaris-sparc64 and kfreebsd-sparc64,
# neither of which Debian officially supports.
const my $LONGEST_ARCHITECTURE => length 'kfreebsd-amd64';
sub always {
my ($self) = @_;
# Skip auto-generated packages (dbgsym)
return
if $self->processable->fields->declares('Auto-Built-Package');
my $basename = basename($self->processable->path);
# remove salsaci suffix
my $nosalsabasename = $basename;
$nosalsabasename
=~ s/[+]salsaci[+]\d+[+]\d+(_[[:alnum:]]+\.[[:alnum:]]+)$/$1/;
my $adjusted_length
= length($nosalsabasename)
- length($self->processable->architecture)
+ $LONGEST_ARCHITECTURE;
$self->hint('package-has-long-file-name', $basename)
if $adjusted_length > $FILENAME_LENGTH_LIMIT;
return;
}
sub source {
my ($self) = @_;
my @lines = $self->processable->fields->trimmed_list('Files', qr/\n/);
for my $line (@lines) {
my (undef, undef, $name) = split($SPACE, $line);
next
unless length $name;
$self->hint('source-package-component-has-long-file-name', $name)
if length $name > $FILENAME_LENGTH_LIMIT;
}
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
