1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
# debian/control/prerequisite/development -- lintian check script -*- perl -*-
#
# Copyright (C) 2004 Marc Brockschmidt
# Copyright (C) 2020 Chris Lamb <lamby@debian.org>
# Copyright (C) 2020-2021 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Debian::Control::Prerequisite::Development;
use v5.20;
use warnings;
use utf8;
use Const::Fast;
use List::SomeUtils qw(any);
use Moo;
use namespace::clean;
with 'Lintian::Check';
const my $EMPTY => q{};
sub source {
my ($self) = @_;
my $control = $self->processable->debian_control;
for my $installable ($control->installables) {
my $installable_fields = $control->installable_fields($installable);
next
unless $installable =~ /-dev$/;
my $field = 'Depends';
next
unless $installable_fields->declares($field);
my $control_item= $self->processable->debian_control->item;
my $position = $installable_fields->position($field);
my $pointer = $control_item->pointer($position);
my @depends
= $installable_fields->trimmed_list($field, qr{ \s* , \s* }x);
for my $other_name ($control->installables) {
next
if $other_name =~ /-(?:dev|docs?|common)$/;
next
unless $other_name =~ /^lib[\w.+-]+\d/;
my @relevant
= grep { m{ (?: ^ | [\s|] ) \Q$other_name\E (?: [\s|(] | \z ) }x }
@depends;
# If there are any alternatives here, something special is
# going on. Assume that the maintainer knows what they're
# doing. Otherwise, separate out just the versions.
next
if any { m{ [|] }x } @relevant;
my @unsorted;
for my $package (@relevant) {
$package =~ m{^ [\w.+-]+ \s* [(] ([^)]+) [)] }x;
push(@unsorted, ($1 // $EMPTY));
}
my @versions = sort @unsorted;
my $context;
# If there's only one mention of this package, the dependency
# should be tight. Otherwise, there should be both >>/>= and
# <</<= dependencies that mention the source, binary, or
# upstream version. If there are more than three mentions of
# the package, again something is weird going on, so we assume
# they know what they're doing.
if (@relevant == 1) {
unless ($versions[0]
=~ /^\s*=\s*\$\{(?:binary:Version|Source-Version)\}/) {
# Allow "pkg (= ${source:Version})" if (but only if)
# the target is an arch:all package. This happens
# with a lot of mono-packages.
#
# Note, we do not check if the -dev package is
# arch:all as well. The version-substvars check
# handles that for us.
next
if $control->installable_fields($other_name)
->value('Architecture') eq 'all'
&& $versions[0]
=~ m{^ \s* = \s* \$[{]source:Version[}] }x;
$context = $relevant[0];
}
} elsif (@relevant == 2) {
unless (
$versions[0] =~ m{^ \s* <[=<] \s* \$[{]
(?: (?:binary|source):(?:Upstream-)?Version
| Source-Version) [}] }xsm
&& $versions[1] =~ m{^ \s* >[=>] \s* \$[{]
(?: (?:binary|source):(?:Upstream-)?Version
| Source-Version) [}] }xsm
) {
$context = "$relevant[0], $relevant[1]";
}
}
$self->pointed_hint('weak-library-dev-dependency',
$pointer, "(in section for $installable)",
$field, $context)
if length $context;
}
}
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
