1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
# languages/ocaml/byte-code/misplaced/package -- lintian check script -*- perl -*-
#
# Copyright (C) 2009 Stephane Glondu
# Copyright (C) 2021 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Languages::Ocaml::ByteCode::Misplaced::Package;
use v5.20;
use warnings;
use utf8;
use Const::Fast;
use List::SomeUtils qw(first_value);
use Moo;
use namespace::clean;
with 'Lintian::Check';
const my $EMPTY => q{};
const my $SLASH => q{/};
has development_files => (is => 'rw', default => sub { [] });
has is_dev_package => (
is => 'rw',
lazy => 1,
default => sub {
my ($self) = @_;
# is it a development package?
return 1
if (
$self->processable->name =~ m{
(?: -dev
|\A camlp[45](?:-extra)?
|\A ocaml (?:
-nox
|-interp
|-compiler-libs
)?
)\Z}xsm
);
return 0;
}
);
sub visit_installed_files {
my ($self, $item) = @_;
# .cma, .cmo and .cmxs are excluded because they can be plugins
push(@{$self->development_files}, $item->name)
if $item->name =~ m{ [.] cm (?: i | xa? ) $}x;
return;
}
sub installable {
my ($self) = @_;
my $count = scalar @{$self->development_files};
my $plural = ($count == 1) ? $EMPTY : 's';
my $prefix = longest_common_prefix(@{$self->development_files});
# strip trailing slash
$prefix =~ s{ / $}{}x
unless $prefix eq $SLASH;
# non-dev packages should not ship .cmi, .cmx or .cmxa files
$self->hint('ocaml-dev-file-in-nondev-package',
"$count file$plural in $prefix")
if $count > 0
&& !$self->is_dev_package;
return;
}
sub longest_common_prefix {
my (@paths) = @_;
my %prefixes;
for my $path (@paths) {
my $truncated = $path;
# first operation drops the file name
while ($truncated =~ s{ / [^/]* $}{}x) {
++$prefixes{$truncated};
}
}
my @by_descending_length = reverse sort keys %prefixes;
my $common = first_value { $prefixes{$_} == @paths } @by_descending_length;
$common ||= $SLASH;
return $common;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|