1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
# languages/perl -- lintian check script -*- perl -*-
# Copyright (C) 1998 Christian Schwarz and Richard Braakman
# Copyright (C) 2021 Felix Lechner
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, you can find it on the World Wide
# Web at https://www.gnu.org/copyleft/gpl.html, or write to the Free
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
package Lintian::Check::Languages::Perl;
use v5.20;
use warnings;
use utf8;
use Unicode::UTF8 qw(encode_utf8);
use Moo;
use namespace::clean;
with 'Lintian::Check';
has perl_sources_in_lib => (is => 'rw', default => sub { [] });
has has_perl_binaries => (is => 'rw', default => 0);
sub visit_installed_files {
my ($self, $item) = @_;
# perllocal.pod
$self->pointed_hint('package-installs-perllocal-pod', $item->pointer)
if $item->name =~ m{^usr/lib/perl.*/perllocal.pod$};
# .packlist files
if ($item->name =~ m{^usr/lib/perl.*/.packlist$}) {
$self->pointed_hint('package-installs-packlist', $item->pointer);
}elsif ($item->name =~ m{^usr/lib/(?:[^/]+/)?perl5/.*\.p[lm]$}) {
push @{$self->perl_sources_in_lib}, $item;
}elsif ($item->name =~ m{^usr/lib/(?:[^/]+/)?perl5/.*\.(?:bs|so)$}) {
$self->has_perl_binaries(1);
}
# perl modules
if ($item->name =~ m{^usr/(?:share|lib)/perl/\S}) {
# check if it's the "perl" package itself
$self->pointed_hint('perl-module-in-core-directory', $item->pointer)
unless $self->processable->source_name eq 'perl';
}
# perl modules using old libraries
# we do the same check on perl scripts in checks/scripts
my $dep = $self->processable->relation('strong');
if ( $item->is_file
&& $item->name =~ /\.pm$/
&& !$dep->satisfies('libperl4-corelibs-perl | perl (<< 5.12.3-7)')) {
open(my $fd, '<', $item->unpacked_path)
or die encode_utf8('Cannot open ' . $item->unpacked_path);
my $position = 1;
while (my $line = <$fd>) {
if (
$line =~ m{ (?:do|require)\s+['"] # do/require
# Huge list of perl4 modules...
(abbrev|assert|bigfloat|bigint|bigrat
|cacheout|complete|ctime|dotsh|exceptions
|fastcwd|find|finddepth|flush|getcwd|getopt
|getopts|hostname|importenv|look|newgetopt
|open2|open3|pwd|shellwords|stat|syslog
|tainted|termcap|timelocal|validate)
# ... so they end with ".pl" rather than ".pm"
\.pl['"]
}xsm
) {
my $module = $1;
$self->pointed_hint('perl-module-uses-perl4-libs-without-dep',
$item->pointer($position), "$module.pl");
}
} continue {
++$position;
}
close $fd;
}
return;
}
sub installable {
my ($self) = @_;
unless ($self->has_perl_binaries) {
$self->pointed_hint('package-installs-nonbinary-perl-in-usr-lib-perl5',
$_->pointer)
for @{$self->perl_sources_in_lib};
}
return;
}
1;
# Local Variables:
# indent-tabs-mode: nil
# cperl-indent-level: 4
# End:
# vim: syntax=perl sw=4 sts=4 sr et
|
