1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
|
#!/usr/bin/python3
#
# Copyright (C) 2019 Canonical Ltd
#
# SPDX-License-Identifier: GPL-2.0+
import base64
import os
import shutil
import tempfile
import unittest
import apt_pkg
import testcommon
import apt
import apt.progress.base
import apt.progress.text
# A change in APT to early fail acquire items with weak hashes caused it
# to call progress methods before calling Start(), which confused python-apt's
# locking handling. Hence we need to skip such tests for now, until we can test
# against an apt version with the fix:
#
# https://salsa.debian.org/apt-team/apt/commit/84176f6c
#
RUN_CRASHING_TESTS = False
# Message APT gives us when hashes are too weak
CACHE_MSG_WEAK_HASH = (
"Insufficient information available to perform this download securely"
)
class TestSignedUsable(testcommon.TestCase):
"""Test fetch_binary() and fetch_source() signature checking."""
def setUp(self):
testcommon.TestCase.setUp(self)
apt_pkg.config.clear("APT::Update::Post-Invoke")
apt_pkg.config.clear("APT::Update::Post-Invoke-Success")
self.chroot_path = chroot_path = tempfile.mkdtemp()
repo_path = os.path.abspath("./data/test-signed-usable-repo/")
# Inits the dirs for us
apt.cache.Cache(rootdir=chroot_path)
# Change directory
self.cwd = os.getcwd()
os.chdir(chroot_path)
with open(
os.path.join(self.chroot_path, "etc/apt/sources.list"), "w"
) as sources_list:
sources_list.write("deb copy:%s/signed/ /\n" % repo_path)
sources_list.write("deb copy:%s/unsigned/ /\n" % repo_path)
sources_list.write("deb-src copy:%s/signed/ /\n" % repo_path)
sources_list.write("deb-src copy:%s/unsigned/ /\n" % repo_path)
with open(os.path.join(repo_path, "key.gpg.base64"), "rb") as pubkey64:
with open(
os.path.join(self.chroot_path, "etc/apt/trusted.gpg"), "wb"
) as tgt:
tgt.write(base64.b64decode(pubkey64.read()))
self.cache = apt.cache.Cache(rootdir=chroot_path)
apt_pkg.config["Acquire::AllowInsecureRepositories"] = "true"
self.cache.update()
apt_pkg.config["Acquire::AllowInsecureRepositories"] = "false"
self.cache.open()
self.progress = apt.progress.text.AcquireProgress
apt.progress.text.AcquireProgress = apt.progress.base.AcquireProgress
# Disable actual installation of downloaded items
self.cache.install_archives = (
lambda *a, **b: apt_pkg.PackageManager.RESULT_COMPLETED
)
def tearDown(self):
# this resets the rootdir apt_pkg.config to ensure it does not
# "pollute" the later tests
apt.cache.Cache(rootdir="/")
os.chdir(self.cwd)
shutil.rmtree(self.chroot_path)
apt.progress.text.AcquireProgress = self.progress
def doInstall(self, name, bargs):
self.cache[name].mark_install()
try:
with apt.progress.base.InstallProgress() as ip:
self.cache.commit(install_progress=ip, **bargs)
finally:
for fname in os.listdir(
os.path.join(self.chroot_path, "var/cache/apt/archives")
):
if os.path.isfile(
os.path.join(self.chroot_path, "var/cache/apt/archives", fname)
):
os.unlink(
os.path.join(self.chroot_path, "var/cache/apt/archives", fname)
)
self.cache[name].mark_keep()
def doFetchArchives(self, name, bargs):
fetcher = apt_pkg.Acquire()
self.cache[name].mark_install()
try:
self.cache.fetch_archives(fetcher=fetcher, **bargs)
finally:
for fname in os.listdir(
os.path.join(self.chroot_path, "var/cache/apt/archives")
):
if fname.endswith(".deb"):
os.unlink(
os.path.join(self.chroot_path, "var/cache/apt/archives", fname)
)
self.cache[name].mark_keep()
def testDefaultDenyButExplicitAllowUnauthenticated(self):
"""Deny by config (default), but pass allow_unauthenticated=True"""
bargs = dict(allow_unauthenticated=True)
sargs = dict(allow_unauthenticated=True, unpack=False)
self.doInstall("signed-usable", bargs)
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"signed-not-usable",
bargs,
)
self.doInstall("unsigned-usable", bargs)
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"unsigned-unusable",
bargs,
)
self.doFetchArchives("signed-usable", bargs)
self.doFetchArchives("unsigned-usable", bargs)
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"signed-not-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"unsigned-unusable",
bargs,
)
self.cache["signed-usable"].candidate.fetch_binary(**bargs)
self.cache["signed-usable"].candidate.fetch_source(**sargs)
self.cache["signed-not-usable"].candidate.fetch_binary(**bargs)
self.cache["signed-not-usable"].candidate.fetch_source(**sargs)
self.cache["unsigned-usable"].candidate.fetch_binary(**bargs)
self.cache["unsigned-usable"].candidate.fetch_source(**sargs)
self.cache["unsigned-unusable"].candidate.fetch_binary(**bargs)
self.cache["unsigned-unusable"].candidate.fetch_source(**sargs)
def testDefaultAllow(self):
"""Allow by config APT::Get::AllowUnauthenticated = True"""
apt_pkg.config["APT::Get::AllowUnauthenticated"] = "true"
bargs = dict()
sargs = dict(unpack=False)
self.doInstall("signed-usable", bargs)
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"signed-not-usable",
bargs,
)
self.doInstall("unsigned-usable", bargs)
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"unsigned-unusable",
bargs,
)
self.doFetchArchives("signed-usable", bargs)
self.doFetchArchives("unsigned-usable", bargs)
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"signed-not-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"unsigned-unusable",
bargs,
)
self.cache["signed-usable"].candidate.fetch_binary(**bargs)
self.cache["signed-usable"].candidate.fetch_source(**sargs)
self.cache["signed-not-usable"].candidate.fetch_binary(**bargs)
self.cache["signed-not-usable"].candidate.fetch_source(**sargs)
self.cache["unsigned-usable"].candidate.fetch_binary(**bargs)
self.cache["unsigned-usable"].candidate.fetch_source(**sargs)
self.cache["unsigned-unusable"].candidate.fetch_binary(**bargs)
self.cache["unsigned-unusable"].candidate.fetch_source(**sargs)
def testDefaultDeny(self):
"""Test APT::Get::AllowUnauthenticated = False (default)"""
self.doInstall("signed-usable", {})
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"signed-not-usable",
{},
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doInstall,
"unsigned-usable",
{},
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doInstall,
"unsigned-unusable",
{},
)
self.doFetchArchives("signed-usable", {})
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"signed-not-usable",
{},
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doFetchArchives,
"unsigned-usable",
{},
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doFetchArchives,
"unsigned-unusable",
{},
)
self.cache["signed-usable"].candidate.fetch_binary()
self.cache["signed-usable"].candidate.fetch_source(unpack=False)
self.assertRaisesRegex(
apt.package.UntrustedError,
": No trusted hash",
self.cache["signed-not-usable"].candidate.fetch_binary,
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": No trusted hash",
self.cache["signed-not-usable"].candidate.fetch_source,
unpack=False,
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-usable"].candidate.fetch_binary,
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-usable"].candidate.fetch_source,
unpack=False,
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-unusable"].candidate.fetch_binary,
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-unusable"].candidate.fetch_source,
unpack=False,
)
def testDefaultAllowButExplicitDeny(self):
"""Allow by config, but pass allow_unauthenticated=False"""
apt_pkg.config["APT::Get::AllowUnauthenticated"] = "true"
bargs = dict(allow_unauthenticated=False)
sargs = dict(allow_unauthenticated=False, unpack=False)
self.doInstall("signed-usable", bargs)
if RUN_CRASHING_TESTS:
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doInstall,
"signed-not-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doInstall,
"unsigned-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doInstall,
"unsigned-unusable",
bargs,
)
self.doFetchArchives("signed-usable", bargs)
self.assertRaisesRegex(
apt.cache.FetchFailedException,
CACHE_MSG_WEAK_HASH,
self.doFetchArchives,
"signed-not-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doFetchArchives,
"unsigned-usable",
bargs,
)
self.assertRaisesRegex(
apt.cache.UntrustedException,
"Untrusted packages:",
self.doFetchArchives,
"unsigned-unusable",
bargs,
)
self.cache["signed-usable"].candidate.fetch_binary(**bargs)
self.cache["signed-usable"].candidate.fetch_source(**sargs)
self.assertRaisesRegex(
apt.package.UntrustedError,
": No trusted hash",
self.cache["signed-not-usable"].candidate.fetch_binary,
**bargs
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": No trusted hash",
self.cache["signed-not-usable"].candidate.fetch_source,
**sargs
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-usable"].candidate.fetch_binary,
**bargs
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-usable"].candidate.fetch_source,
**sargs
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-unusable"].candidate.fetch_binary,
**bargs
)
self.assertRaisesRegex(
apt.package.UntrustedError,
": Source",
self.cache["unsigned-unusable"].candidate.fetch_source,
**sargs
)
if __name__ == "__main__":
unittest.main()
|
