1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
|
/*
* Remmina - The GTK+ Remote Desktop Client
* Copyright (C) 2009-2011 Vic Lee
* Copyright (C) 2014-2015 Antenore Gatta, Fabio Castelli, Giovanni Panozzo
* Copyright (C) 2023-2024 Hiroyuki Tanaka, Sunil Bhat
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*
* In addition, as a special exception, the copyright holders give
* permission to link the code of portions of this program with the
* OpenSSL library under certain conditions as described in each
* individual source file, and distribute linked combinations
* including the two.
* You must obey the GNU General Public License in all respects
* for all of the code used other than OpenSSL.
* If you modify file(s) with this exception, you may extend this exception
* to your version of the file(s), but you are not obligated to do so.
* If you do not wish to do so, delete this exception statement from your
* version.
* If you delete this exception statement from all source
* files in the program, then also delete it here.
*
*/
#include <glib/gi18n.h>
#include <string.h>
#include "remmina_log.h"
#include "remmina_bug_report.h"
#include "remmina_public.h"
#include "remmina/remmina_trace_calls.h"
#include "remmina_info.h"
#include "remmina_curl_connector.h"
#include "remmina_utils.h"
#if !JSON_CHECK_VERSION(1, 2, 0)
#define json_node_unref(x) json_node_free(x)
#endif
#define BUG_REPORT_UPLOAD_URL "https://info.remmina.org/bug_report/bug_report"
static RemminaBugReportDialog *remmina_bug_report_dialog;
#define GET_OBJECT(object_name) gtk_builder_get_object(remmina_bug_report_dialog->builder, object_name)
#define TEMP_LOG_TEXT_FILE_NAME "remmina_shorter_logs.log"
#define COMPRESSED_LOG_FILE_NAME "remmina_log_file.gz"
#define LOG_RECENT_WINDOW 4000
#define MAX_DESCRIPTION_LENGTH 8000
const char *bug_report_preview_text_md = \
"## Problem Description\n"
"\n"
"Write a detailed description of the problem.\n"
"\n"
"## What is the expected correct behavior?\n"
"\n"
"(What you want to see instead.)\n"
"\n"
"## Remote System Description\n"
"\n"
"* Server (OS name and version):\n"
"* Special notes regarding the remote system (i.e. gateways, tunnel, etc.):\n"
"\n"
"## Debugging\n"
"\n"
"Please check the Include Debug Data box to allow for debug log to be sent with this bug report\n"
"\n"
"## Local System Description\n"
"\n"
"* Client (OS name and version):\n"
"* Remmina version ( ```remmina --version``` ):\n"
"* Installation(s):\n"
" - [ ] Distribution package.\n"
" - [ ] PPA.\n"
" - [ ] Snap.\n"
" - [ ] Flatpak.\n"
" - [ ] Compiled from sources.\n"
" - [ ] Other - detail:\n"
"* Desktop environment (GNOME, Unity, KDE, ..):\n"
"* Plugin(s):\n"
" - [ ] RDP - freerdp version ( ```xfreerdp --version``` ):\n"
" - [ ] VNC\n"
" - [ ] SSH\n"
" - [ ] SFTP\n"
" - [ ] SPICE\n"
" - [ ] WWW\n"
" - [ ] EXEC\n"
" - [ ] Other (please specify):\n"
"* GTK backend (Wayland, Xorg):\n"
"\n";
/* Show the bug report dialog from the file ui/remmina_bug_report.glade */
void remmina_bug_report_open(GtkWindow *parent)
{
TRACE_CALL(__func__);
GtkTextBuffer* bug_report_preview_text_buffer;
remmina_bug_report_dialog = g_new0(RemminaBugReportDialog, 1);
remmina_bug_report_dialog->builder = remmina_public_gtk_builder_new_from_resource ("/org/remmina/Remmina/src/../data/ui/remmina_bug_report.glade");
remmina_bug_report_dialog->dialog = GTK_WIDGET(gtk_builder_get_object(remmina_bug_report_dialog->builder, "RemminaBugReportDialog"));
remmina_bug_report_dialog->bug_report_submit_button = GTK_BUTTON(GET_OBJECT("bug_report_submit_button"));
remmina_bug_report_dialog->bug_report_name_entry = GTK_ENTRY(GET_OBJECT("bug_report_name_entry"));
remmina_bug_report_dialog->bug_report_email_entry = GTK_ENTRY(GET_OBJECT("bug_report_email_entry"));
remmina_bug_report_dialog->bug_report_title_entry = GTK_ENTRY(GET_OBJECT("bug_report_title_entry"));
remmina_bug_report_dialog->bug_report_description_textview = GTK_TEXT_VIEW(GET_OBJECT("bug_report_description_textview"));
remmina_bug_report_dialog->bug_report_submit_status_label = GTK_LABEL(GET_OBJECT("bug_report_submit_status_label"));
remmina_bug_report_dialog->bug_report_debug_data_check_button = GTK_CHECK_BUTTON(GET_OBJECT("bug_report_debug_data_check_button"));
remmina_bug_report_dialog->bug_report_include_system_info_check_button = GTK_CHECK_BUTTON(GET_OBJECT("bug_report_include_system_info_check_button"));
// Set bug report markdown text in bug description window
bug_report_preview_text_buffer = gtk_text_buffer_new(NULL);
gtk_text_buffer_set_text(bug_report_preview_text_buffer, bug_report_preview_text_md, strlen(bug_report_preview_text_md));
gtk_text_view_set_buffer(remmina_bug_report_dialog->bug_report_description_textview, bug_report_preview_text_buffer);
if (parent) {
gtk_window_set_transient_for(GTK_WINDOW(remmina_bug_report_dialog->dialog), parent);
gtk_window_set_destroy_with_parent(GTK_WINDOW(remmina_bug_report_dialog->dialog), TRUE);
}
g_signal_connect(remmina_bug_report_dialog->bug_report_submit_button, "clicked",
G_CALLBACK(remmina_bug_report_dialog_on_action_submit), (gpointer)remmina_bug_report_dialog);
gtk_window_present(GTK_WINDOW(remmina_bug_report_dialog->dialog));
g_object_unref(bug_report_preview_text_buffer);
}
void remmina_bug_report_dialog_on_action_submit(GSimpleAction *action, GVariant *param, gpointer data)
{
TRACE_CALL(__func__);
JsonGenerator *g;
JsonObject *o;
gchar *b;
REMMINA_DEBUG("Submit Button Clicked. Uploading Bug Report data.");
gchar *markup = GRAY_TEXT("Sending Bug Report...");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
// Store bug report info in JSON blob and encode before submitting
JsonNode *bug_report_data = remmina_bug_report_get_all();
if (bug_report_data == NULL || (o = json_node_get_object(bug_report_data)) == NULL) {
REMMINA_DEBUG("Failed to grab bug report data, no request is sent");
gchar *markup = RED_TEXT("Failure: Unable to generate bug report message. Please try again.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
json_node_unref(bug_report_data);
return;
} else if (strcmp(json_object_get_string_member(json_node_get_object(bug_report_data), "Name"), "") == 0) {
REMMINA_DEBUG("No text in name entry of bug report data, no request is sent");
gchar *markup = RED_TEXT("Failure: Name/Username is required. Please enter a Name/Username.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
json_node_unref(bug_report_data);
return;
} else {
gchar *email_text = g_strdup(json_object_get_string_member(json_node_get_object(bug_report_data), "Email"));
if (strcmp(email_text, "") == 0) {
REMMINA_DEBUG("No text in email entry of bug report data, no request is sent");
gchar *markup = RED_TEXT("Failure: Email is required. Please enter an email.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
g_free(email_text);
json_node_unref(bug_report_data);
return;
} else {
gchar *save_ptr;
gchar *check_for_at_symbol = strtok_r(email_text, "@", &save_ptr);
gchar *check_for_dot = strtok_r(NULL, ".", &save_ptr);
gchar *check_for_domain = strtok_r(NULL, "", &save_ptr);
if (check_for_at_symbol == NULL || check_for_dot == NULL || check_for_domain == NULL) {
REMMINA_DEBUG("Text in email entry of bug report data is not a valid email, no request is sent");
gchar *markup = RED_TEXT("Failure: A valid email is required. Email is missing a prefix or domain.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
g_free(email_text);
json_node_unref(bug_report_data);
return;
} else if (strpbrk(check_for_at_symbol, "@.") != NULL || strpbrk(check_for_dot, "@.") != NULL || strpbrk(check_for_domain, "@.") != NULL) {
REMMINA_DEBUG("Text in email entry of bug report data is not a valid email, no request is sent");
gchar *markup = RED_TEXT("Failure: A valid email is required. Email contains extra @ and . characters.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
g_free(email_text);
json_node_unref(bug_report_data);
return;
}
}
g_free(email_text);
if (strcmp(json_object_get_string_member(json_node_get_object(bug_report_data), "Bug_Title"), "") == 0) {
REMMINA_DEBUG("No text in bug title entry of bug report data, no request is sent");
gchar *markup = RED_TEXT("Failure: Bug Title is required. Please enter a Bug Title.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
json_node_unref(bug_report_data);
return;
} else if (strcmp(json_object_get_string_member(json_node_get_object(bug_report_data), "Bug_Description"), "") == 0 ||
strcmp(json_object_get_string_member(json_node_get_object(bug_report_data), "Bug_Description"), bug_report_preview_text_md) == 0) {
REMMINA_DEBUG("No text in bug description of bug report data, no request is sent");
gchar *markup = RED_TEXT("Failure: Bug Description is required. Please fill out the template.");
gtk_label_set_markup(remmina_bug_report_dialog->bug_report_submit_status_label, markup);
g_free(markup);
json_node_unref(bug_report_data);
return;
}
}
g = json_generator_new();
json_generator_set_root(g, bug_report_data);
b = json_generator_to_data(g, NULL);
g_object_unref(g);
remmina_curl_compose_message(b, "POST", BUG_REPORT_UPLOAD_URL, remmina_bug_report_dialog->bug_report_submit_status_label);
json_node_unref(bug_report_data);
}
JsonNode *remmina_bug_report_get_all()
{
TRACE_CALL(__func__);
JsonBuilder *b_inner, *b_outer; // holds entire JSON blob
JsonGenerator *g;
JsonNode *n; // temp JSON node
gchar *unenc_b, *enc_b;
gchar *uid;
// Initialize JSON blob
b_outer = json_builder_new();
if (b_outer == NULL) {
g_object_unref(b_outer);
return NULL;
}
json_builder_begin_object(b_outer);
gboolean include_debug_data = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(remmina_bug_report_dialog->bug_report_debug_data_check_button));
gboolean include_system_info = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(remmina_bug_report_dialog->bug_report_include_system_info_check_button));
if (include_debug_data || include_system_info) {
b_inner = json_builder_new();
if (b_inner == NULL) {
g_object_unref(b_inner);
g_object_unref(b_outer);
return NULL;
}
json_builder_begin_object(b_inner);
if (include_system_info){
n = remmina_info_stats_get_all();
json_builder_set_member_name(b_outer, "System_Info_Enabled");
json_builder_add_string_value(b_outer, "ON");
json_builder_set_member_name(b_inner, "System_Info");
json_builder_add_value(b_inner, n);
}
else{
json_builder_set_member_name(b_outer, "System_Info_Enabled");
json_builder_add_string_value(b_outer, "OFF");
}
if (include_debug_data){
gboolean log_file_result;
gchar *log_text;
gsize log_length;
GError *log_read_error;
gchar *log_filename = g_build_filename(g_get_tmp_dir(), LOG_FILE_NAME, NULL);
log_file_result = g_file_get_contents(log_filename, &log_text, &log_length, &log_read_error);
g_free(log_filename);
if (!log_file_result && log_read_error == NULL) {
REMMINA_DEBUG("Failed to grab entire log text, read error: %s", log_read_error->message);
}
gboolean shorter_logs_result;
gchar *temp_log_filename = g_build_filename(g_get_tmp_dir(), TEMP_LOG_TEXT_FILE_NAME, NULL);
gchar *recent_log_text;
if (log_length <= LOG_RECENT_WINDOW) {
recent_log_text = log_text;
shorter_logs_result = g_file_set_contents(temp_log_filename, recent_log_text, log_length, NULL);
}
else {
recent_log_text = log_text + (log_length - LOG_RECENT_WINDOW);
shorter_logs_result = g_file_set_contents(temp_log_filename, recent_log_text, LOG_RECENT_WINDOW, NULL);
}
g_free(log_text);
if (!shorter_logs_result) {
REMMINA_DEBUG("Failed to write recent window of logs to temp file.");
}
gchar *comp_log_filename = g_build_filename(g_get_tmp_dir(), COMPRESSED_LOG_FILE_NAME, NULL);
GFile *in = g_file_new_for_path(temp_log_filename);
GFile *out = g_file_new_for_path(comp_log_filename);
// Clear out old compressed log file to prevent appending
g_file_delete(out, NULL, NULL);
remmina_compress_from_file_to_file(in, out);
g_free(temp_log_filename);
gboolean com_log_file_result;
gchar *compressed_logs;
gsize com_log_length;
GError *com_log_read_error;
com_log_file_result = g_file_get_contents(comp_log_filename, &compressed_logs, &com_log_length, &com_log_read_error);
n = json_node_alloc();
if (!com_log_file_result && com_log_read_error != NULL) {
REMMINA_DEBUG("Failed to grab entire compressed log text, read error: %s", com_log_read_error->message);
json_node_init_string(n, "");
}
else {
gchar *logs_base64 = g_base64_encode((guchar *)compressed_logs, com_log_length);
json_node_init_string(n, logs_base64);
g_free(logs_base64);
}
json_builder_set_member_name(b_outer, "Debug_Log_Enabled");
json_builder_add_string_value(b_outer, "ON");
json_builder_set_member_name(b_inner, "Compressed_Logs");
json_builder_add_value(b_inner, n);
g_free(compressed_logs);
g_free(comp_log_filename);
}
else{
json_builder_set_member_name(b_outer, "Debug_Log_Enabled");
json_builder_add_string_value(b_outer, "OFF");
}
// Wrap up by setting n to the final JSON blob
json_builder_end_object(b_inner);
n = json_builder_get_root(b_inner);
g_object_unref(b_inner);
g = json_generator_new();
json_generator_set_root(g, n);
json_node_unref(n);
unenc_b = json_generator_to_data(g, NULL); // unenc_b=bug report data
g_object_unref(g);
// Now base64 encode report data
enc_b = g_base64_encode((guchar *)unenc_b, strlen(unenc_b));
if (enc_b == NULL) {
g_object_unref(b_outer);
g_free(unenc_b);
REMMINA_DEBUG("Failed to encode inner JSON");
return NULL;
}
g_free(unenc_b);
json_builder_set_member_name(b_outer, "encdata");
json_builder_add_string_value(b_outer, enc_b);
g_free(enc_b);
}
else {
json_builder_set_member_name(b_outer, "System_Info_Enabled");
json_builder_add_string_value(b_outer, "OFF");
json_builder_set_member_name(b_outer, "Debug_Log_Enabled");
json_builder_add_string_value(b_outer, "OFF");
}
n = remmina_info_stats_get_uid();
uid = g_strdup(json_node_get_string(n));
json_builder_set_member_name(b_outer, "UID");
json_builder_add_string_value(b_outer, uid);
// Allocate new json node for each text entry and add to total blob
n = json_node_alloc();
json_node_init_string(n, gtk_entry_get_text(remmina_bug_report_dialog->bug_report_name_entry));
json_builder_set_member_name(b_outer, "Name");
json_builder_add_value(b_outer, n);
n = json_node_alloc();
json_node_init_string(n, gtk_entry_get_text(remmina_bug_report_dialog->bug_report_email_entry));
json_builder_set_member_name(b_outer, "Email");
json_builder_add_value(b_outer, n);
n = json_node_alloc();
json_node_init_string(n, gtk_entry_get_text(remmina_bug_report_dialog->bug_report_title_entry));
json_builder_set_member_name(b_outer, "Bug_Title");
json_builder_add_value(b_outer, n);
GtkTextBuffer *buffer;
gchar *description_text;
GtkTextIter start, end;
buffer = gtk_text_view_get_buffer(remmina_bug_report_dialog->bug_report_description_textview);
gtk_text_buffer_get_start_iter(buffer, &start);
gtk_text_buffer_get_iter_at_offset(buffer, &end, MAX_DESCRIPTION_LENGTH);
description_text = gtk_text_buffer_get_text(buffer, &start, &end, FALSE);
n = json_node_alloc();
json_node_init_string(n, description_text);
json_builder_set_member_name(b_outer, "Bug_Description");
json_builder_add_value(b_outer, n);
json_builder_end_object(b_outer);
n = json_builder_get_root(b_outer);
g_object_unref(b_outer);
g_free(uid);
return n;
}
|