1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
|
#![warn(clippy::enum_variant_names)]
#![allow(non_camel_case_types, clippy::upper_case_acronyms)]
enum FakeCallType {
CALL,
CREATE,
}
enum FakeCallType2 {
CALL,
CREATELL,
}
enum Foo {
//~^ ERROR: all variants have the same prefix: `c`
cFoo,
//~^ ERROR: variant name ends with the enum's name
//~| NOTE: `-D clippy::enum-variant-names` implied by `-D warnings`
cBar,
cBaz,
}
enum Fooo {
cFoo, // no error, threshold is 3 variants by default
cBar,
}
enum Food {
//~^ ERROR: all variants have the same prefix: `Food`
FoodGood,
//~^ ERROR: variant name starts with the enum's name
FoodMiddle,
//~^ ERROR: variant name starts with the enum's name
FoodBad,
//~^ ERROR: variant name starts with the enum's name
}
enum Stuff {
StuffBad, // no error
}
enum BadCallType {
//~^ ERROR: all variants have the same prefix: `CallType`
CallTypeCall,
CallTypeCreate,
CallTypeDestroy,
}
enum TwoCallType {
// no error
CallTypeCall,
CallTypeCreate,
}
enum Consts {
//~^ ERROR: all variants have the same prefix: `Constant`
ConstantInt,
ConstantCake,
ConstantLie,
}
enum Two {
// no error here
ConstantInt,
ConstantInfer,
}
enum Something {
//~^ ERROR: all variants have the same prefix: `C`
CCall,
CCreate,
CCryogenize,
}
enum Seal {
With,
Without,
}
enum Seall {
With,
WithOut,
Withbroken,
}
enum Sealll {
With,
WithOut,
}
enum Seallll {
//~^ ERROR: all variants have the same prefix: `WithOut`
WithOutCake,
WithOutTea,
WithOut,
}
enum NonCaps {
Prefix的,
PrefixTea,
PrefixCake,
}
pub enum PubSeall {
WithOutCake,
WithOutTea,
WithOut,
}
#[allow(clippy::enum_variant_names)]
pub mod allowed {
pub enum PubAllowed {
SomeThis,
SomeThat,
SomeOtherWhat,
}
}
// should not lint
enum Pat {
Foo,
Bar,
Path,
}
// should not lint
enum N {
Pos,
Neg,
Float,
}
// should not lint
enum Peek {
Peek1,
Peek2,
Peek3,
}
// should not lint
pub enum NetworkLayer {
Layer2,
Layer3,
}
// should lint suggesting `IData`, not only `Data` (see #4639)
enum IDataRequest {
//~^ ERROR: all variants have the same postfix: `IData`
PutIData(String),
GetIData(String),
DeleteUnpubIData(String),
}
enum HIDataRequest {
//~^ ERROR: all variants have the same postfix: `HIData`
PutHIData(String),
GetHIData(String),
DeleteUnpubHIData(String),
}
enum North {
Normal,
NoLeft,
NoRight,
}
// #8324
enum Phase {
PreLookup,
Lookup,
PostLookup,
}
mod issue9018 {
enum DoLint {
//~^ ERROR: all variants have the same prefix: `_Type`
_TypeCreate,
_TypeRead,
_TypeUpdate,
_TypeDestroy,
}
enum DoLintToo {
//~^ ERROR: all variants have the same postfix: `Type`
_CreateType,
_UpdateType,
_DeleteType,
}
enum DoNotLint {
_Foo,
_Bar,
_Baz,
}
}
mod allow_attributes_on_variants {
enum Enum {
#[allow(clippy::enum_variant_names)]
EnumStartsWith,
#[allow(clippy::enum_variant_names)]
EndsWithEnum,
Foo,
}
}
mod issue11494 {
// variant order should not affect lint
enum Data {
Valid,
Invalid,
DataDependent,
//~^ ERROR: variant name starts with the enum's name
}
enum Datas {
DatasDependent,
//~^ ERROR: variant name starts with the enum's name
Valid,
Invalid,
}
}
fn main() {}
|
