1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
//@compile-flags: --test
#![warn(clippy::eq_op)]
#![allow(clippy::double_parens, clippy::identity_op, clippy::nonminimal_bool)]
#![allow(clippy::suspicious_xor_used_as_pow)]
fn main() {
// simple values and comparisons
let _ = 1 == 1;
let _ = "no" == "no";
// even though I agree that no means no ;-)
let _ = false != false;
let _ = 1.5 < 1.5;
let _ = 1u64 >= 1u64;
// casts, methods, parentheses
let _ = (1u32 as u64) & (1u32 as u64);
#[rustfmt::skip]
{
let _ = 1 ^ ((((((1))))));
};
// unary and binary operators
let _ = (-(2) < -(2));
let _ = ((1 + 1) & (1 + 1) == (1 + 1) & (1 + 1));
let _ = (1 * 2) + (3 * 4) == 1 * 2 + 3 * 4;
// various other things
let _ = ([1] != [1]);
let _ = ((1, 2) != (1, 2));
let _ = vec![1, 2, 3] == vec![1, 2, 3]; //no error yet, as we don't match macros
// const folding
let _ = 1 + 1 == 2;
let _ = 1 - 1 == 0;
let _ = 1 - 1;
let _ = 1 / 1;
let _ = true && true;
let _ = true || true;
let a: u32 = 0;
let b: u32 = 0;
let _ = a == b && b == a;
let _ = a != b && b != a;
let _ = a < b && b > a;
let _ = a <= b && b >= a;
let mut a = vec![1];
let _ = a == a;
let _ = 2 * a.len() == 2 * a.len(); // ok, functions
let _ = a.pop() == a.pop(); // ok, functions
check_ignore_macro();
// named constants
const A: u32 = 10;
const B: u32 = 10;
const C: u32 = A / B; // ok, different named constants
const D: u32 = A / A;
}
macro_rules! check_if_named_foo {
($expression:expr) => {
if stringify!($expression) == "foo" {
println!("foo!");
} else {
println!("not foo.");
}
};
}
macro_rules! bool_macro {
($expression:expr) => {
true
};
}
fn check_ignore_macro() {
check_if_named_foo!(foo);
// checks if the lint ignores macros with `!` operator
let _ = !bool_macro!(1) && !bool_macro!("");
}
struct Nested {
inner: ((i32,), (i32,), (i32,)),
}
fn check_nested(n1: &Nested, n2: &Nested) -> bool {
// `n2.inner.0.0` mistyped as `n1.inner.0.0`
(n1.inner.0).0 == (n1.inner.0).0 && (n1.inner.1).0 == (n2.inner.1).0 && (n1.inner.2).0 == (n2.inner.2).0
}
#[test]
fn eq_op_shouldnt_trigger_in_tests() {
let a = 1;
let result = a + 1 == 1 + a;
assert!(result);
}
#[test]
fn eq_op_macros_shouldnt_trigger_in_tests() {
let a = 1;
let b = 2;
assert_eq!(a, a);
assert_eq!(a + b, b + a);
}
|
