blob: a2112d7b730050323636201d69937687f121ac33 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
|
#![warn(clippy::for_kv_map)]
#![allow(clippy::used_underscore_binding)]
use std::collections::*;
use std::rc::Rc;
fn main() {
let m: HashMap<u64, u64> = HashMap::new();
for v in m.values() {
//~^ ERROR: you seem to want to iterate on a map's values
//~| NOTE: `-D clippy::for-kv-map` implied by `-D warnings`
let _v = v;
}
let m: Rc<HashMap<u64, u64>> = Rc::new(HashMap::new());
for v in (*m).values() {
//~^ ERROR: you seem to want to iterate on a map's values
let _v = v;
// Here the `*` is not actually necessary, but the test tests that we don't
// suggest
// `in *m.values()` as we used to
}
let mut m: HashMap<u64, u64> = HashMap::new();
for v in m.values_mut() {
//~^ ERROR: you seem to want to iterate on a map's values
let _v = v;
}
let m: &mut HashMap<u64, u64> = &mut HashMap::new();
for v in (*m).values_mut() {
//~^ ERROR: you seem to want to iterate on a map's values
let _v = v;
}
let m: HashMap<u64, u64> = HashMap::new();
let rm = &m;
for k in rm.keys() {
//~^ ERROR: you seem to want to iterate on a map's keys
let _k = k;
}
// The following should not produce warnings.
let m: HashMap<u64, u64> = HashMap::new();
// No error, _value is actually used
for (k, _value) in &m {
let _ = _value;
let _k = k;
}
let m: HashMap<u64, String> = Default::default();
for (_, v) in m {
let _v = v;
}
}
|
