1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
#![warn(clippy::all)]
#![allow(clippy::manual_clamp)]
use std::cmp::{max as my_max, max, min as my_min, min};
const LARGE: usize = 3;
struct NotOrd(u64);
impl NotOrd {
fn min(self, x: u64) -> NotOrd {
NotOrd(x)
}
fn max(self, x: u64) -> NotOrd {
NotOrd(x)
}
}
fn main() {
let x = 2usize;
min(1, max(3, x));
//~^ ERROR: this `min`/`max` combination leads to constant result
//~| NOTE: `-D clippy::min-max` implied by `-D warnings`
min(max(3, x), 1);
//~^ ERROR: this `min`/`max` combination leads to constant result
max(min(x, 1), 3);
//~^ ERROR: this `min`/`max` combination leads to constant result
max(3, min(x, 1));
//~^ ERROR: this `min`/`max` combination leads to constant result
my_max(3, my_min(x, 1));
//~^ ERROR: this `min`/`max` combination leads to constant result
min(3, max(1, x)); // ok, could be 1, 2 or 3 depending on x
min(1, max(LARGE, x)); // no error, we don't lookup consts here
let y = 2isize;
min(max(y, -1), 3);
let s = "Hello";
min("Apple", max("Zoo", s));
//~^ ERROR: this `min`/`max` combination leads to constant result
max(min(s, "Apple"), "Zoo");
//~^ ERROR: this `min`/`max` combination leads to constant result
max("Apple", min(s, "Zoo")); // ok
let f = 3f32;
x.min(1).max(3);
//~^ ERROR: this `min`/`max` combination leads to constant result
x.max(3).min(1);
//~^ ERROR: this `min`/`max` combination leads to constant result
f.max(3f32).min(1f32);
//~^ ERROR: this `min`/`max` combination leads to constant result
x.max(1).min(3); // ok
x.min(3).max(1); // ok
f.min(3f32).max(1f32); // ok
max(x.min(1), 3);
//~^ ERROR: this `min`/`max` combination leads to constant result
min(x.max(1), 3); // ok
s.max("Zoo").min("Apple");
//~^ ERROR: this `min`/`max` combination leads to constant result
s.min("Apple").max("Zoo");
//~^ ERROR: this `min`/`max` combination leads to constant result
s.min("Zoo").max("Apple"); // ok
let not_ord = NotOrd(1);
not_ord.min(1).max(3); // ok
}
|
