blob: c891c9de3aeca8bc9ebfa92df29b8d16e8688aaa (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
#![warn(clippy::needless_continue)]
#![allow(clippy::uninlined_format_args)]
macro_rules! zero {
($x:expr) => {
$x == 0
};
}
macro_rules! nonzero {
($x:expr) => {
!zero!($x)
};
}
#[allow(clippy::nonminimal_bool)]
fn main() {
let mut i = 1;
while i < 10 {
i += 1;
if i % 2 == 0 && i % 3 == 0 {
println!("{}", i);
println!("{}", i + 1);
if i % 5 == 0 {
println!("{}", i + 2);
}
let i = 0;
println!("bar {} ", i);
} else {
continue;
}
println!("bleh");
{
println!("blah");
}
// some comments that also should ideally be included in the
// output of the lint suggestion if possible.
if !(!(i == 2) || !(i == 5)) {
println!("lama");
}
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
continue;
} else {
println!("Blabber");
println!("Jabber");
}
println!("bleh");
}
}
fn simple_loop() {
loop {
continue; // should lint here
}
}
fn simple_loop2() {
loop {
println!("bleh");
continue; // should lint here
}
}
#[rustfmt::skip]
fn simple_loop3() {
loop {
continue // should lint here
}
}
#[rustfmt::skip]
fn simple_loop4() {
loop {
println!("bleh");
continue // should lint here
}
}
mod issue_2329 {
fn condition() -> bool {
unimplemented!()
}
fn update_condition() {}
// only the outer loop has a label
fn foo() {
'outer: loop {
println!("Entry");
while condition() {
update_condition();
if condition() {
println!("foo-1");
} else {
continue 'outer; // should not lint here
}
println!("foo-2");
update_condition();
if condition() {
continue 'outer; // should not lint here
} else {
println!("foo-3");
}
println!("foo-4");
}
}
}
// both loops have labels
fn bar() {
'outer: loop {
println!("Entry");
'inner: while condition() {
update_condition();
if condition() {
println!("bar-1");
} else {
continue 'outer; // should not lint here
}
println!("bar-2");
update_condition();
if condition() {
println!("bar-3");
} else {
continue 'inner; // should lint here
}
println!("bar-4");
update_condition();
if condition() {
continue; // should lint here
} else {
println!("bar-5");
}
println!("bar-6");
}
}
}
}
|
