1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
//@aux-build:proc_macros.rs
#![allow(
clippy::needless_return,
clippy::no_effect,
clippy::unit_arg,
clippy::useless_conversion,
clippy::diverging_sub_expression,
clippy::let_unit_value,
unused
)]
#[macro_use]
extern crate proc_macros;
fn a() -> u32 {
return 0;
}
fn b() -> Result<u32, u32> {
return Err(0);
}
// Do not lint
fn c() -> Option<()> {
return None?;
}
fn main() -> Result<(), ()> {
return Err(())?;
return Ok::<(), ()>(());
Err(())?;
Ok::<(), ()>(());
return Err(().into());
external! {
return Err(())?;
}
with_span! {
return Err(())?;
}
// Issue #11765
// Should not lint
let Some(s) = Some("") else {
return Err(())?;
};
let Some(s) = Some("") else {
let Some(s) = Some("") else {
return Err(())?;
};
return Err(())?;
};
let Some(_): Option<()> = ({
return Err(())?;
}) else {
panic!();
};
Err(())
}
fn issue11616() -> Result<(), ()> {
let _x: String = {
return Err(())?;
};
let _x: () = {
return Err(())?;
//~^ ERROR: unneeded `return` statement with `?` operator
};
let _x = match 1 {
1 => vec![1, 2],
_ => {
return Err(())?;
},
};
Ok(())
}
|