blob: 2d392c593b3e7e58cc2d160067f48eb43b1f7a1c (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
|
//! This test case utilizes `f64` an easy example for `PartialOrd` only types
//! but the lint itself actually validates any expression where the left
//! operand implements `PartialOrd` but not `Ord`.
use std::cmp::Ordering;
#[allow(clippy::unnested_or_patterns, clippy::match_like_matches_macro)]
#[warn(clippy::neg_cmp_op_on_partial_ord)]
fn main() {
let a_value = 1.0;
let another_value = 7.0;
// --- Bad ---
// Not Less but potentially Greater, Equal or Uncomparable.
let _not_less = !(a_value < another_value);
// Not Less or Equal but potentially Greater or Uncomparable.
let _not_less_or_equal = !(a_value <= another_value);
// Not Greater but potentially Less, Equal or Uncomparable.
let _not_greater = !(a_value > another_value);
// Not Greater or Equal but potentially Less or Uncomparable.
let _not_greater_or_equal = !(a_value >= another_value);
// --- Good ---
let _not_less = match a_value.partial_cmp(&another_value) {
None | Some(Ordering::Greater) | Some(Ordering::Equal) => true,
_ => false,
};
let _not_less_or_equal = match a_value.partial_cmp(&another_value) {
None | Some(Ordering::Greater) => true,
_ => false,
};
let _not_greater = match a_value.partial_cmp(&another_value) {
None | Some(Ordering::Less) | Some(Ordering::Equal) => true,
_ => false,
};
let _not_greater_or_equal = match a_value.partial_cmp(&another_value) {
None | Some(Ordering::Less) => true,
_ => false,
};
// --- Should not trigger ---
let _ = a_value < another_value;
let _ = a_value <= another_value;
let _ = a_value > another_value;
let _ = a_value >= another_value;
// --- regression tests ---
// Issue 2856: False positive on assert!()
//
// The macro always negates the result of the given comparison in its
// internal check which automatically triggered the lint. As it's an
// external macro there was no chance to do anything about it which led
// to an exempting of all external macros.
assert!(a_value < another_value);
}
|
