1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
|
#![allow(dead_code, clippy::missing_safety_doc, clippy::extra_unused_lifetimes)]
#![warn(clippy::new_without_default)]
pub struct Foo;
impl Foo {
pub fn new() -> Foo {
Foo
}
}
pub struct Bar;
impl Bar {
pub fn new() -> Self {
Bar
}
}
pub struct Ok;
impl Ok {
pub fn new() -> Self {
Ok
}
}
impl Default for Ok {
fn default() -> Self {
Ok
}
}
pub struct Params;
impl Params {
pub fn new(_: u32) -> Self {
Params
}
}
pub struct GenericsOk<T> {
bar: T,
}
impl<U> Default for GenericsOk<U> {
fn default() -> Self {
unimplemented!();
}
}
impl<'c, V> GenericsOk<V> {
pub fn new() -> GenericsOk<V> {
unimplemented!()
}
}
pub struct LtOk<'a> {
foo: &'a bool,
}
impl<'b> Default for LtOk<'b> {
fn default() -> Self {
unimplemented!();
}
}
impl<'c> LtOk<'c> {
pub fn new() -> LtOk<'c> {
unimplemented!()
}
}
pub struct LtKo<'a> {
foo: &'a bool,
}
impl<'c> LtKo<'c> {
pub fn new() -> LtKo<'c> {
unimplemented!()
}
// FIXME: that suggestion is missing lifetimes
}
struct Private;
impl Private {
fn new() -> Private {
unimplemented!()
} // We don't lint private items
}
struct PrivateStruct;
impl PrivateStruct {
pub fn new() -> PrivateStruct {
unimplemented!()
} // We don't lint public items on private structs
}
pub struct PrivateItem;
impl PrivateItem {
fn new() -> PrivateItem {
unimplemented!()
} // We don't lint private items on public structs
}
struct Const;
impl Const {
pub const fn new() -> Const {
Const
} // const fns can't be implemented via Default
}
pub struct IgnoreGenericNew;
impl IgnoreGenericNew {
pub fn new<T>() -> Self {
IgnoreGenericNew
} // the derived Default does not make sense here as the result depends on T
}
pub trait TraitWithNew: Sized {
fn new() -> Self {
panic!()
}
}
pub struct IgnoreUnsafeNew;
impl IgnoreUnsafeNew {
pub unsafe fn new() -> Self {
IgnoreUnsafeNew
}
}
#[derive(Default)]
pub struct OptionRefWrapper<'a, T>(Option<&'a T>);
impl<'a, T> OptionRefWrapper<'a, T> {
pub fn new() -> Self {
OptionRefWrapper(None)
}
}
pub struct Allow(Foo);
impl Allow {
#[allow(clippy::new_without_default)]
pub fn new() -> Self {
unimplemented!()
}
}
pub struct AllowDerive;
impl AllowDerive {
#[allow(clippy::new_without_default)]
pub fn new() -> Self {
unimplemented!()
}
}
pub struct NewNotEqualToDerive {
foo: i32,
}
impl NewNotEqualToDerive {
// This `new` implementation is not equal to a derived `Default`, so do not suggest deriving.
pub fn new() -> Self {
NewNotEqualToDerive { foo: 1 }
}
}
// see #6933
pub struct FooGenerics<T>(std::marker::PhantomData<T>);
impl<T> FooGenerics<T> {
pub fn new() -> Self {
Self(Default::default())
}
}
pub struct BarGenerics<T>(std::marker::PhantomData<T>);
impl<T: Copy> BarGenerics<T> {
pub fn new() -> Self {
Self(Default::default())
}
}
pub mod issue7220 {
pub struct Foo<T> {
_bar: *mut T,
}
impl<T> Foo<T> {
pub fn new() -> Self {
todo!()
}
}
}
// see issue #8152
// This should not create any lints
pub struct DocHidden;
impl DocHidden {
#[doc(hidden)]
pub fn new() -> Self {
DocHidden
}
}
fn main() {}
pub struct IgnoreConstGenericNew(usize);
impl IgnoreConstGenericNew {
pub fn new<const N: usize>() -> Self {
Self(N)
}
}
pub struct IgnoreLifetimeNew;
impl IgnoreLifetimeNew {
pub fn new<'a>() -> Self {
Self
}
}
|
