summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/tests/ui/redundant_else.rs
blob: 64f566735cd95c366eb04b65ffdbe563ea57ee1e (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
#![warn(clippy::redundant_else)]
#![allow(clippy::needless_return, clippy::if_same_then_else, clippy::needless_late_init)]

fn main() {
    loop {
        // break
        if foo() {
            println!("Love your neighbor;");
            break;
        } else {
            println!("yet don't pull down your hedge.");
        }
        // continue
        if foo() {
            println!("He that lies down with Dogs,");
            continue;
        } else {
            println!("shall rise up with fleas.");
        }
        // match block
        if foo() {
            match foo() {
                1 => break,
                _ => return,
            }
        } else {
            println!("You may delay, but time will not.");
        }
    }
    // else if
    if foo() {
        return;
    } else if foo() {
        return;
    } else {
        println!("A fat kitchen makes a lean will.");
    }
    // let binding outside of block
    let _ = {
        if foo() {
            return;
        } else {
            1
        }
    };
    // else if with let binding outside of block
    let _ = {
        if foo() {
            return;
        } else if foo() {
            return;
        } else {
            2
        }
    };
    // inside if let
    let _ = if let Some(1) = foo() {
        let _ = 1;
        if foo() {
            return;
        } else {
            1
        }
    } else {
        1
    };

    //
    // non-lint cases
    //

    // sanity check
    if foo() {
        let _ = 1;
    } else {
        println!("Who is wise? He that learns from every one.");
    }
    // else if without else
    if foo() {
        return;
    } else if foo() {
        foo()
    };
    // nested if return
    if foo() {
        if foo() {
            return;
        }
    } else {
        foo()
    };
    // match with non-breaking branch
    if foo() {
        match foo() {
            1 => foo(),
            _ => return,
        }
    } else {
        println!("Three may keep a secret, if two of them are dead.");
    }
    // let binding
    let _ = if foo() {
        return;
    } else {
        1
    };
    // assign
    let mut a;
    a = if foo() {
        return;
    } else {
        1
    };
    // assign-op
    a += if foo() {
        return;
    } else {
        1
    };
    // if return else if else
    if foo() {
        return;
    } else if foo() {
        1
    } else {
        2
    };
    // if else if return else
    if foo() {
        1
    } else if foo() {
        return;
    } else {
        2
    };
    // else if with let binding
    let _ = if foo() {
        return;
    } else if foo() {
        return;
    } else {
        2
    };
    // inside function call
    Box::new(if foo() {
        return;
    } else {
        1
    });
}

fn foo<T>() -> T {
    unimplemented!("I'm not Santa Claus")
}