1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
#![warn(clippy::unused_self)]
#![allow(clippy::boxed_local, clippy::fn_params_excessive_bools)]
mod unused_self {
use std::pin::Pin;
use std::sync::{Arc, Mutex};
struct A;
impl A {
fn unused_self_move(self) {}
//~^ ERROR: unused `self` argument
fn unused_self_ref(&self) {}
//~^ ERROR: unused `self` argument
fn unused_self_mut_ref(&mut self) {}
//~^ ERROR: unused `self` argument
fn unused_self_pin_ref(self: Pin<&Self>) {}
//~^ ERROR: unused `self` argument
fn unused_self_pin_mut_ref(self: Pin<&mut Self>) {}
//~^ ERROR: unused `self` argument
fn unused_self_pin_nested(self: Pin<Arc<Self>>) {}
//~^ ERROR: unused `self` argument
fn unused_self_box(self: Box<Self>) {}
//~^ ERROR: unused `self` argument
fn unused_with_other_used_args(&self, x: u8, y: u8) -> u8 {
//~^ ERROR: unused `self` argument
x + y
}
fn unused_self_class_method(&self) {
//~^ ERROR: unused `self` argument
Self::static_method();
}
fn static_method() {}
}
}
mod unused_self_allow {
struct A;
impl A {
// shouldn't trigger
#[allow(clippy::unused_self)]
fn unused_self_move(self) {}
}
struct B;
// shouldn't trigger
#[allow(clippy::unused_self)]
impl B {
fn unused_self_move(self) {}
}
struct C;
#[allow(clippy::unused_self)]
impl C {
#[warn(clippy::unused_self)]
fn some_fn((): ()) {}
// shouldn't trigger
fn unused_self_move(self) {}
}
pub struct D;
impl D {
// shouldn't trigger for public methods
pub fn unused_self_move(self) {}
}
pub struct E;
impl E {
// shouldn't trigger if body contains todo!()
pub fn unused_self_todo(self) {
let x = 42;
todo!()
}
}
}
pub use unused_self_allow::D;
mod used_self {
use std::pin::Pin;
struct A {
x: u8,
}
impl A {
fn used_self_move(self) -> u8 {
self.x
}
fn used_self_ref(&self) -> u8 {
self.x
}
fn used_self_mut_ref(&mut self) {
self.x += 1
}
fn used_self_pin_ref(self: Pin<&Self>) -> u8 {
self.x
}
fn used_self_box(self: Box<Self>) -> u8 {
self.x
}
fn used_self_with_other_unused_args(&self, x: u8, y: u8) -> u8 {
self.x
}
fn used_in_nested_closure(&self) -> u8 {
let mut a = || -> u8 { self.x };
a()
}
#[allow(clippy::collapsible_if)]
fn used_self_method_nested_conditions(&self, a: bool, b: bool, c: bool, d: bool) {
if a {
if b {
if c {
if d {
self.used_self_ref();
}
}
}
}
}
fn foo(&self) -> u32 {
let mut sum = 0u32;
for i in 0..self.x {
sum += i as u32;
}
sum
}
fn bar(&mut self, x: u8) -> u32 {
let mut y = 0u32;
for i in 0..x {
y += self.foo()
}
y
}
}
}
mod not_applicable {
use std::fmt;
struct A;
impl fmt::Debug for A {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "A")
}
}
impl A {
fn method(x: u8, y: u8) {}
}
trait B {
fn method(&self) {}
}
}
fn main() {}
|
