blob: 4d7db9de8138e5a5bb36680e867b2e1af3197ed0 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
#!/bin/sh
#
# Check smbclient can (or cannot) delete a directory containing veto files.
# BUG: https://bugzilla.samba.org/show_bug.cgi?id=14878
#
if [ $# -lt 6 ]; then
cat <<EOF
Usage: $0 SERVER SERVER_IP USERNAME PASSWORD SHAREPATH SMBCLIENT
EOF
exit 1
fi
SERVER=${1}
SERVER_IP=${2}
USERNAME=${3}
PASSWORD=${4}
SHAREPATH=${5}
SMBCLIENT=${6}
shift 6
SMBCLIENT="$VALGRIND ${SMBCLIENT}"
ADDARGS="$@"
incdir=$(dirname "$0")/../../../testprogs/blackbox
. "$incdir"/subunit.sh
failed=0
rmdir_path="$SHAREPATH/dir"
test_veto_nodelete_rmdir()
{
local veto_path="$rmdir_path/veto_name1"
local msdfs_link_path="$rmdir_path/dfs_link"
local tmpfile=$PREFIX/smbclient.in.$$
# Create rmdir directory.
mkdir -p "$rmdir_path"
# Create veto file underneath.
touch "$veto_path"
# Create msdfs link underneath.
ln -s "msdfs:$SERVER_IP\\ro-tmp" "$msdfs_link_path"
cat >"$tmpfile" <<EOF
cd dir
ls
quit
EOF
local cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT //$SERVER/veto_files_nodelete -U$USERNAME%$PASSWORD $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval "$cmd")
ret=$?
# Check for smbclient error.
if [ $ret != 0 ]; then
echo "Failed accessing share veto_files_nodelete - $ret"
echo "$out"
return 1
fi
# We should only see the dfs_link file.
echo "$out" | grep dfs_link
ret=$?
if [ $ret -ne 0 ]; then
echo "Failed to see dfs_link in share veto_files_nodelete"
echo "$out"
return 1
fi
# Now remove the dfs_link file.
rm -rf "$msdfs_link_path"
# Try and remove the directory, should fail with NT_STATUS_DIRECTORY_NOT_EMPTY.
cat >"$tmpfile" <<EOF
rd dir
quit
EOF
local cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT //$SERVER/veto_files_nodelete -U$USERNAME%$PASSWORD $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval "$cmd")
ret=$?
# Check for smbclient error.
if [ $ret != 0 ]; then
echo "Failed accessing share veto_files_nodelete - $ret"
echo "$out"
return 1
fi
# We should get NT_STATUS_DIRECTORY_NOT_EMPTY.
echo "$out" | grep NT_STATUS_DIRECTORY_NOT_EMPTY
ret=$?
if [ $ret -ne 0 ]; then
echo "Failed to get error NT_STATUS_DIRECTORY_NOT_EMPTY in share veto_files_nodelete"
echo "$out"
return 1
fi
# remove the veto file - directory should now be empty.
rm -rf "$veto_path"
# Try and remove the directory, should now succeed.
cat >"$tmpfile" <<EOF
rd dir
quit
EOF
local cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT //$SERVER/veto_files_nodelete -U$USERNAME%$PASSWORD $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval "$cmd")
ret=$?
# Check for smbclient error.
if [ $ret != 0 ]; then
echo "Failed accessing share veto_files_nodelete - $ret"
echo "$out"
return 1
fi
# We should get no NT_STATUS_ errors.
echo "$out" | grep NT_STATUS_
ret=$?
if [ $ret -eq 0 ]; then
echo "Got error NT_STATUS_ in share veto_files_nodelete"
echo "$out"
return 1
fi
return 0
}
test_veto_delete_rmdir()
{
local veto_path="$rmdir_path/veto_name1"
local msdfs_link_path="$rmdir_path/dfs_link"
local tmpfile=$PREFIX/smbclient.in.$$
# Create rmdir directory.
mkdir -p "$rmdir_path"
# Create veto file underneath.
touch "$veto_path"
# Create msdfs link underneath.
ln -s "msdfs:$SERVER_IP\\ro-tmp" "$msdfs_link_path"
cat >"$tmpfile" <<EOF
cd dir
ls
quit
EOF
local cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT //$SERVER/veto_files_delete -U$USERNAME%$PASSWORD $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval "$cmd")
ret=$?
# Check for smbclient error.
if [ $ret != 0 ]; then
echo "Failed accessing share veto_files_delete - $ret"
echo "$out"
return 1
fi
# We should only see the dfs_link file.
echo "$out" | grep dfs_link
ret=$?
if [ $ret -ne 0 ]; then
echo "Failed to see dfs_link in share veto_files_delete"
echo "$out"
return 1
fi
# Now remove the dfs_link file.
rm -rf "$msdfs_link_path"
# Try and remove the directory, should now succeed.
cat >"$tmpfile" <<EOF
rd dir
quit
EOF
local cmd='CLI_FORCE_INTERACTIVE=yes $SMBCLIENT //$SERVER/veto_files_delete -U$USERNAME%$PASSWORD $ADDARGS < $tmpfile 2>&1'
eval echo "$cmd"
out=$(eval "$cmd")
ret=$?
# Check for smbclient error.
if [ $ret != 0 ]; then
echo "Failed accessing share veto_files_delete - $ret"
echo "$out"
return 1
fi
# We should get no NT_STATUS_ errors.
echo "$out" | grep NT_STATUS_
ret=$?
if [ $ret -eq 0 ]; then
echo "Got error NT_STATUS_ in share veto_files_delete"
echo "$out"
return 1
fi
return 0
}
testit "rmdir cannot delete directory containing a veto file" \
test_veto_nodelete_rmdir || failed=$(expr "$failed" + 1)
rm -rf "$rmdir_path"
testit "rmdir can delete directory containing a veto file" \
test_veto_delete_rmdir || failed=$(expr "$failed" + 1)
rm -rf "$rmdir_path"
exit "$failed"
|
