1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
|
/* Copyright (C) 2007-2020 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Breno Silva <breno.silva@gmail.com>
* \author Anoop Saldanha <anoopsaldanha@gmail.com>
*
* Implements the reference keyword support
*/
#include "suricata-common.h"
#include "suricata.h"
#include "detect.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-mpm.h"
#include "decode.h"
#include "flow-var.h"
#include "decode-events.h"
#include "stream-tcp.h"
#include "util-reference-config.h"
#include "detect-reference.h"
#include "util-unittest.h"
#include "util-byte.h"
#include "util-debug.h"
#define PARSE_REGEX "^\\s*([A-Za-z0-9]+)\\s*,\"?\\s*\"?\\s*([a-zA-Z0-9\\-_\\.\\/\\?\\=]+)\"?\\s*\"?"
static DetectParseRegex parse_regex;
#ifdef UNITTESTS
static void ReferenceRegisterTests(void);
#endif
static int DetectReferenceSetup(DetectEngineCtx *, Signature *s, const char *str);
/**
* \brief Registration function for the reference: keyword
*/
void DetectReferenceRegister(void)
{
sigmatch_table[DETECT_REFERENCE].name = "reference";
sigmatch_table[DETECT_REFERENCE].desc = "direct to places where information about the rule can be found";
sigmatch_table[DETECT_REFERENCE].url = "/rules/meta.html#reference";
sigmatch_table[DETECT_REFERENCE].Setup = DetectReferenceSetup;
#ifdef UNITTESTS
sigmatch_table[DETECT_REFERENCE].RegisterTests = ReferenceRegisterTests;
#endif
DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
}
/**
* \brief Free a Reference object
*/
void DetectReferenceFree(DetectReference *ref)
{
SCEnter();
if (ref->reference != NULL) {
SCFree(ref->reference);
}
SCFree(ref);
SCReturn;
}
/**
* \internal
* \brief This function is used to parse reference options passed via reference: keyword
*
* \param rawstr Pointer to the user provided reference options.
*
* \retval ref Pointer to signature reference on success.
* \retval NULL On failure.
*/
static DetectReference *DetectReferenceParse(const char *rawstr, DetectEngineCtx *de_ctx)
{
SCEnter();
int res = 0;
size_t pcre2len;
char key[REFERENCE_SYSTEM_NAME_MAX] = "";
char content[REFERENCE_CONTENT_NAME_MAX] = "";
pcre2_match_data *match = NULL;
int ret = DetectParsePcreExec(&parse_regex, &match, rawstr, 0, 0);
if (ret < 2) {
SCLogError("Unable to parse \"reference\" "
"keyword argument - \"%s\". Invalid argument.",
rawstr);
if (match) {
pcre2_match_data_free(match);
}
return NULL;
}
DetectReference *ref = SCCalloc(1, sizeof(DetectReference));
if (unlikely(ref == NULL)) {
pcre2_match_data_free(match);
return NULL;
}
pcre2len = sizeof(key);
res = pcre2_substring_copy_bynumber(match, 1, (PCRE2_UCHAR8 *)key, &pcre2len);
if (res < 0) {
SCLogError("pcre2_substring_copy_bynumber failed");
goto error;
}
pcre2len = sizeof(content);
res = pcre2_substring_copy_bynumber(match, 2, (PCRE2_UCHAR8 *)content, &pcre2len);
if (res < 0) {
SCLogError("pcre2_substring_copy_bynumber failed");
goto error;
}
if (strlen(key) == 0 || strlen(content) == 0)
goto error;
SCRConfReference *lookup_ref_conf = SCRConfGetReference(key, de_ctx);
if (lookup_ref_conf != NULL) {
ref->key = lookup_ref_conf->url;
} else {
if (SigMatchStrictEnabled(DETECT_REFERENCE)) {
SCLogError("unknown reference key \"%s\"", key);
goto error;
}
SCLogWarning("unknown reference key \"%s\"", key);
char str[2048];
snprintf(str, sizeof(str), "config reference: %s undefined\n", key);
if (SCRConfAddReference(de_ctx, str) < 0)
goto error;
lookup_ref_conf = SCRConfGetReference(key, de_ctx);
if (lookup_ref_conf == NULL)
goto error;
}
/* make a copy so we can free pcre's substring */
ref->reference = SCStrdup(content);
if (ref->reference == NULL) {
SCLogError("strdup failed: %s", strerror(errno));
goto error;
}
pcre2_match_data_free(match);
/* free the substrings */
SCReturnPtr(ref, "Reference");
error:
if (match) {
pcre2_match_data_free(match);
}
DetectReferenceFree(ref);
SCReturnPtr(NULL, "Reference");
}
/**
* \internal
* \brief Used to add the parsed reference into the current signature.
*
* \param de_ctx Pointer to the Detection Engine Context.
* \param s Pointer to the Current Signature.
* \param m Pointer to the Current SigMatch.
* \param rawstr Pointer to the user provided reference options.
*
* \retval 0 On Success.
* \retval -1 On Failure.
*/
static int DetectReferenceSetup(DetectEngineCtx *de_ctx, Signature *s,
const char *rawstr)
{
SCEnter();
DetectReference *sig_refs = NULL;
DetectReference *ref = DetectReferenceParse(rawstr, de_ctx);
if (ref == NULL)
SCReturnInt(-1);
SCLogDebug("ref %s %s", ref->key, ref->reference);
if (s->references == NULL) {
s->references = ref;
} else {
sig_refs = s->references;
while (sig_refs->next != NULL) {
sig_refs = sig_refs->next;
}
sig_refs->next = ref;
ref->next = NULL;
}
SCReturnInt(0);
}
/***************************************Unittests******************************/
#ifdef UNITTESTS
/**
* \test one valid reference.
*
* \retval 1 on success.
* \retval 0 on failure.
*/
static int DetectReferenceParseTest01(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
de_ctx->flags |= DE_QUIET;
FILE *fd = SCRConfGenerateValidDummyReferenceConfigFD01();
FAIL_IF_NULL(fd);
SCRConfLoadReferenceConfigFile(de_ctx, fd);
Signature *s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any "
"(msg:\"One reference\"; reference:one,001-2010; sid:2;)");
FAIL_IF_NULL(s);
FAIL_IF_NULL(s->references);
DetectReference *ref = s->references;
FAIL_IF (strcmp(ref->key, "http://www.one.com") != 0);
FAIL_IF (strcmp(ref->reference, "001-2010") != 0);
DetectEngineCtxFree(de_ctx);
PASS;
}
/**
* \test for two valid references.
*
* \retval 1 on success.
* \retval 0 on failure.
*/
static int DetectReferenceParseTest02(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
de_ctx->flags |= DE_QUIET;
FILE *fd = SCRConfGenerateValidDummyReferenceConfigFD01();
FAIL_IF_NULL(fd);
SCRConfLoadReferenceConfigFile(de_ctx, fd);
Signature *s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any "
"(msg:\"Two references\"; "
"reference:one,openinfosecdoundation.txt; "
"reference:two,001-2010; sid:2;)");
FAIL_IF_NULL(s);
FAIL_IF_NULL(s->references);
FAIL_IF_NULL(s->references->next);
DetectReference *ref = s->references;
FAIL_IF (strcmp(ref->key, "http://www.one.com") != 0);
FAIL_IF (strcmp(ref->reference, "openinfosecdoundation.txt") != 0);
ref = s->references->next;
FAIL_IF (strcmp(ref->key, "http://www.two.com") != 0);
FAIL_IF (strcmp(ref->reference, "001-2010") != 0);
DetectEngineCtxFree(de_ctx);
PASS;
}
/**
* \test parsing: invalid reference.
*
* \retval 1 on success.
* \retval 0 on failure.
*/
static int DetectReferenceParseTest03(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
de_ctx->flags |= DE_QUIET;
FILE *fd = SCRConfGenerateValidDummyReferenceConfigFD01();
FAIL_IF_NULL(fd);
SCRConfLoadReferenceConfigFile(de_ctx, fd);
Signature *s = DetectEngineAppendSig(de_ctx, "alert icmp any any -> any any "
"(msg:\"invalid ref\"; "
"reference:unknownkey,001-2010; sid:2;)");
FAIL_IF_NULL(s);
DetectEngineCtxFree(de_ctx);
PASS;
}
static void ReferenceRegisterTests(void)
{
UtRegisterTest("DetectReferenceParseTest01", DetectReferenceParseTest01);
UtRegisterTest("DetectReferenceParseTest02", DetectReferenceParseTest02);
UtRegisterTest("DetectReferenceParseTest03", DetectReferenceParseTest03);
}
#endif /* UNITTESTS */
|