1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
|
/* Copyright (C) 2007-2020 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Pablo Rincon <pablo.rincon.crespo@gmail.com>
*
* Implements RPC keyword
*/
#include "suricata-common.h"
#include "decode.h"
#include "detect.h"
#include "detect-rpc.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-mpm.h"
#include "detect-engine-siggroup.h"
#include "detect-engine-address.h"
#include "detect-engine-build.h"
#include "util-unittest.h"
#include "util-unittest-helper.h"
#include "util-debug.h"
#include "util-byte.h"
/**
* \brief Regex for parsing our rpc options
*/
#define PARSE_REGEX "^\\s*([0-9]{0,10})\\s*(?:,\\s*([0-9]{0,10}|[*])\\s*(?:,\\s*([0-9]{0,10}|[*]))?)?\\s*$"
static DetectParseRegex parse_regex;
static int DetectRpcMatch (DetectEngineThreadCtx *, Packet *,
const Signature *, const SigMatchCtx *);
static int DetectRpcSetup (DetectEngineCtx *, Signature *, const char *);
#ifdef UNITTESTS
static void DetectRpcRegisterTests(void);
#endif
void DetectRpcFree(DetectEngineCtx *, void *);
/**
* \brief Registration function for rpc keyword
*/
void DetectRpcRegister (void)
{
sigmatch_table[DETECT_RPC].name = "rpc";
sigmatch_table[DETECT_RPC].desc = "match RPC procedure numbers and RPC version";
sigmatch_table[DETECT_RPC].url = "/rules/payload-keywords.html#rpc";
sigmatch_table[DETECT_RPC].Match = DetectRpcMatch;
sigmatch_table[DETECT_RPC].Setup = DetectRpcSetup;
sigmatch_table[DETECT_RPC].Free = DetectRpcFree;
#ifdef UNITTESTS
sigmatch_table[DETECT_RPC].RegisterTests = DetectRpcRegisterTests;
#endif
DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
}
/*
* returns 0: no match
* 1: match
* -1: error
*/
/**
* \brief This function is used to match rpc request set on a packet with those passed via rpc
*
* \param t pointer to thread vars
* \param det_ctx pointer to the pattern matcher thread
* \param p pointer to the current packet
* \param m pointer to the sigmatch that we will cast into DetectRpcData
*
* \retval 0 no match
* \retval 1 match
*/
static int DetectRpcMatch (DetectEngineThreadCtx *det_ctx, Packet *p,
const Signature *s, const SigMatchCtx *ctx)
{
/* PrintRawDataFp(stdout, p->payload, p->payload_len); */
const DetectRpcData *rd = (const DetectRpcData *)ctx;
char *rpcmsg = (char *)p->payload;
if (PKT_IS_TCP(p)) {
/* if Rpc msg too small */
if (p->payload_len < 28) {
SCLogDebug("TCP packet to small for the rpc msg (%u)", p->payload_len);
return 0;
}
rpcmsg += 4;
} else if (PKT_IS_UDP(p)) {
/* if Rpc msg too small */
if (p->payload_len < 24) {
SCLogDebug("UDP packet to small for the rpc msg (%u)", p->payload_len);
return 0;
}
} else {
SCLogDebug("No valid proto for the rpc message");
return 0;
}
/* Point through the rpc msg structure. Use SCNtohl() to compare values */
RpcMsg *msg = (RpcMsg *)rpcmsg;
/* If its not a call, no match */
if (SCNtohl(msg->type) != 0) {
SCLogDebug("RPC message type is not a call");
return 0;
}
if (SCNtohl(msg->prog) != rd->program)
return 0;
if ((rd->flags & DETECT_RPC_CHECK_VERSION) && SCNtohl(msg->vers) != rd->program_version)
return 0;
if ((rd->flags & DETECT_RPC_CHECK_PROCEDURE) && SCNtohl(msg->proc) != rd->procedure)
return 0;
SCLogDebug("prog:%u pver:%u proc:%u matched", SCNtohl(msg->prog), SCNtohl(msg->vers), SCNtohl(msg->proc));
return 1;
}
/**
* \brief This function is used to parse rpc options passed via rpc keyword
*
* \param de_ctx Pointer to the detection engine context
* \param rpcstr Pointer to the user provided rpc options
*
* \retval rd pointer to DetectRpcData on success
* \retval NULL on failure
*/
static DetectRpcData *DetectRpcParse (DetectEngineCtx *de_ctx, const char *rpcstr)
{
DetectRpcData *rd = NULL;
char *args[3] = {NULL,NULL,NULL};
int res = 0;
size_t pcre2_len;
pcre2_match_data *match = NULL;
int ret = DetectParsePcreExec(&parse_regex, &match, rpcstr, 0, 0);
if (ret < 1 || ret > 4) {
SCLogError("parse error, ret %" PRId32 ", string %s", ret, rpcstr);
goto error;
}
if (ret > 1) {
const char *str_ptr;
res = pcre2_substring_get_bynumber(match, 1, (PCRE2_UCHAR8 **)&str_ptr, &pcre2_len);
if (res < 0) {
SCLogError("pcre2_substring_get_bynumber failed");
goto error;
}
args[0] = (char *)str_ptr;
if (ret > 2) {
res = pcre2_substring_get_bynumber(match, 2, (PCRE2_UCHAR8 **)&str_ptr, &pcre2_len);
if (res < 0) {
SCLogError("pcre2_substring_get_bynumber failed");
goto error;
}
args[1] = (char *)str_ptr;
}
if (ret > 3) {
res = pcre2_substring_get_bynumber(match, 3, (PCRE2_UCHAR8 **)&str_ptr, &pcre2_len);
if (res < 0) {
SCLogError("pcre2_substring_get_bynumber failed");
goto error;
}
args[2] = (char *)str_ptr;
}
}
rd = SCMalloc(sizeof(DetectRpcData));
if (unlikely(rd == NULL))
goto error;
rd->flags = 0;
rd->program = 0;
rd->program_version = 0;
rd->procedure = 0;
int i;
for (i = 0; i < (ret - 1); i++) {
if (args[i]) {
switch (i) {
case 0:
if (StringParseUint32(&rd->program, 10, strlen(args[i]), args[i]) <= 0) {
SCLogError("Invalid size specified for the rpc program:\"%s\"", args[i]);
goto error;
}
rd->flags |= DETECT_RPC_CHECK_PROGRAM;
break;
case 1:
if (args[i][0] != '*') {
if (StringParseUint32(&rd->program_version, 10, strlen(args[i]), args[i]) <= 0) {
SCLogError(
"Invalid size specified for the rpc version:\"%s\"", args[i]);
goto error;
}
rd->flags |= DETECT_RPC_CHECK_VERSION;
}
break;
case 2:
if (args[i][0] != '*') {
if (StringParseUint32(&rd->procedure, 10, strlen(args[i]), args[i]) <= 0) {
SCLogError(
"Invalid size specified for the rpc procedure:\"%s\"", args[i]);
goto error;
}
rd->flags |= DETECT_RPC_CHECK_PROCEDURE;
}
break;
}
} else {
SCLogError("invalid rpc option %s", rpcstr);
goto error;
}
}
for (i = 0; i < (ret -1); i++){
if (args[i] != NULL)
pcre2_substring_free((PCRE2_UCHAR8 *)args[i]);
}
pcre2_match_data_free(match);
return rd;
error:
if (match) {
pcre2_match_data_free(match);
}
for (i = 0; i < (ret -1) && i < 3; i++){
if (args[i] != NULL)
pcre2_substring_free((PCRE2_UCHAR8 *)args[i]);
}
if (rd != NULL)
DetectRpcFree(de_ctx, rd);
return NULL;
}
/**
* \brief this function is used to add the parsed rpcdata into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature
* \param m pointer to the Current SigMatch
* \param rpcstr pointer to the user provided rpc options
*
* \retval 0 on Success
* \retval -1 on Failure
*/
int DetectRpcSetup (DetectEngineCtx *de_ctx, Signature *s, const char *rpcstr)
{
DetectRpcData *rd = NULL;
SigMatch *sm = NULL;
rd = DetectRpcParse(de_ctx, rpcstr);
if (rd == NULL) goto error;
sm = SigMatchAlloc();
if (sm == NULL)
goto error;
sm->type = DETECT_RPC;
sm->ctx = (SigMatchCtx *)rd;
SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_MATCH);
s->flags |= SIG_FLAG_REQUIRE_PACKET;
return 0;
error:
if (rd != NULL) DetectRpcFree(de_ctx, rd);
if (sm != NULL) SCFree(sm);
return -1;
}
/**
* \brief this function will free memory associated with DetectRpcData
*
* \param rd pointer to DetectRpcData
*/
void DetectRpcFree(DetectEngineCtx *de_ctx, void *ptr)
{
SCEnter();
if (ptr == NULL) {
SCReturn;
}
DetectRpcData *rd = (DetectRpcData *)ptr;
SCFree(rd);
SCReturn;
}
#ifdef UNITTESTS
#include "detect-engine-alert.h"
/**
* \test DetectRpcTestParse01 is a test to make sure that we return "something"
* when given valid rpc opt
*/
static int DetectRpcTestParse01 (void)
{
DetectRpcData *rd = DetectRpcParse(NULL, "123,444,555");
FAIL_IF_NULL(rd);
DetectRpcFree(NULL, rd);
PASS;
}
/**
* \test DetectRpcTestParse02 is a test for setting the established rpc opt
*/
static int DetectRpcTestParse02 (void)
{
DetectRpcData *rd = NULL;
rd = DetectRpcParse(NULL, "111,222,333");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 222);
FAIL_IF_NOT(rd->procedure == 333);
DetectRpcFree(NULL, rd);
PASS;
}
/**
* \test DetectRpcTestParse03 is a test for checking the wildcards
* and not specified fields
*/
static int DetectRpcTestParse03 (void)
{
DetectRpcData *rd = NULL;
rd = DetectRpcParse(NULL, "111,*,333");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 0);
FAIL_IF_NOT(rd->procedure == 333);
DetectRpcFree(NULL, rd);
rd = DetectRpcParse(NULL, "111,222,*");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 222);
FAIL_IF_NOT(rd->procedure == 0);
DetectRpcFree(NULL, rd);
rd = DetectRpcParse(NULL, "111,*,*");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 0);
FAIL_IF_NOT(rd->procedure == 0);
DetectRpcFree(NULL, rd);
rd = DetectRpcParse(NULL, "111,222");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 222);
FAIL_IF_NOT(rd->procedure == 0);
DetectRpcFree(NULL, rd);
rd = DetectRpcParse(NULL, "111");
FAIL_IF_NULL(rd);
FAIL_IF_NOT(rd->flags & DETECT_RPC_CHECK_PROGRAM);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_VERSION);
FAIL_IF(rd->flags & DETECT_RPC_CHECK_PROCEDURE);
FAIL_IF_NOT(rd->program == 111);
FAIL_IF_NOT(rd->program_version == 0);
FAIL_IF_NOT(rd->procedure == 0);
DetectRpcFree(NULL, rd);
PASS;
}
/**
* \test DetectRpcTestParse04 is a test for check the discarding of empty options
*/
static int DetectRpcTestParse04 (void)
{
DetectRpcData *rd = NULL;
rd = DetectRpcParse(NULL, "");
FAIL_IF_NOT_NULL(rd);
DetectRpcFree(NULL, rd);
PASS;
}
/**
* \test DetectRpcTestParse05 is a test for check invalid values
*/
static int DetectRpcTestParse05 (void)
{
DetectRpcData *rd = NULL;
rd = DetectRpcParse(NULL, "111,aaa,*");
FAIL_IF_NOT_NULL(rd);
DetectRpcFree(NULL, rd);
PASS;
}
/**
* \test DetectRpcTestParse05 is a test to check the match function
*/
static int DetectRpcTestSig01(void)
{
/* RPC Call */
uint8_t buf[] = {
/* XID */
0x64,0xb2,0xb3,0x75,
/* Message type: Call (0) */
0x00,0x00,0x00,0x00,
/* RPC Version (2) */
0x00,0x00,0x00,0x02,
/* Program portmap (100000) */
0x00,0x01,0x86,0xa0,
/* Program version (2) */
0x00,0x00,0x00,0x02,
/* Program procedure (3) = GETPORT */
0x00,0x00,0x00,0x03,
/* AUTH_NULL */
0x00,0x00,0x00,0x00,
/* Length 0 */
0x00,0x00,0x00,0x00,
/* VERIFIER NULL */
0x00,0x00,0x00,0x00,
/* Length 0 */
0x00,0x00,0x00,0x00,
/* Program portmap */
0x00,0x01,0x86,0xa2,
/* Version 2 */
0x00,0x00,0x00,0x02,
/* Proto UDP */
0x00,0x00,0x00,0x11,
/* Port 0 */
0x00,0x00,0x00,0x00 };
uint16_t buflen = sizeof(buf);
Packet *p = NULL;
Signature *s = NULL;
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;
memset(&th_v, 0, sizeof(th_v));
p = UTHBuildPacket(buf, buflen, IPPROTO_UDP);
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
de_ctx->flags |= DE_QUIET;
s = DetectEngineAppendSig(de_ctx,
"alert udp any any -> any any (msg:\"RPC Get Port Call\"; rpc:100000, 2, 3; sid:1;)");
FAIL_IF_NULL(s);
s = DetectEngineAppendSig(de_ctx,
"alert udp any any -> any any (msg:\"RPC Get Port Call\"; rpc:100000, 2, *; sid:2;)");
FAIL_IF_NULL(s);
s = DetectEngineAppendSig(de_ctx,
"alert udp any any -> any any (msg:\"RPC Get Port Call\"; rpc:100000, *, 3; sid:3;)");
FAIL_IF_NULL(s);
s = DetectEngineAppendSig(de_ctx,
"alert udp any any -> any any (msg:\"RPC Get Port Call\"; rpc:100000, *, *; sid:4;)");
FAIL_IF_NULL(s);
s = DetectEngineAppendSig(de_ctx, "alert udp any any -> any any (msg:\"RPC Get XXX Call.. no "
"match\"; rpc:123456, *, 3; sid:5;)");
FAIL_IF_NULL(s);
SigGroupBuild(de_ctx);
DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
FAIL_IF(PacketAlertCheck(p, 1) == 0);
FAIL_IF(PacketAlertCheck(p, 2) == 0);
FAIL_IF(PacketAlertCheck(p, 3) == 0);
FAIL_IF(PacketAlertCheck(p, 4) == 0);
FAIL_IF(PacketAlertCheck(p, 5) > 0);
DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
DetectEngineCtxFree(de_ctx);
UTHFreePackets(&p, 1);
PASS;
}
/**
* \brief this function registers unit tests for DetectRpc
*/
static void DetectRpcRegisterTests(void)
{
UtRegisterTest("DetectRpcTestParse01", DetectRpcTestParse01);
UtRegisterTest("DetectRpcTestParse02", DetectRpcTestParse02);
UtRegisterTest("DetectRpcTestParse03", DetectRpcTestParse03);
UtRegisterTest("DetectRpcTestParse04", DetectRpcTestParse04);
UtRegisterTest("DetectRpcTestParse05", DetectRpcTestParse05);
UtRegisterTest("DetectRpcTestSig01", DetectRpcTestSig01);
}
#endif /* UNITTESTS */
|