1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
/* Copyright (C) 2007-2021 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Victor Julien <victor@inliniac.net>
*
* Implements the sid keyword
*/
#include "suricata-common.h"
#include "detect.h"
#include "detect-engine.h"
#include "detect-parse.h"
#include "detect-sid.h"
#include "util-debug.h"
#include "util-error.h"
#include "util-unittest.h"
static int DetectSidSetup (DetectEngineCtx *, Signature *, const char *);
#ifdef UNITTESTS
static void DetectSidRegisterTests(void);
#endif
void DetectSidRegister (void)
{
sigmatch_table[DETECT_SID].name = "sid";
sigmatch_table[DETECT_SID].desc = "set rule ID";
sigmatch_table[DETECT_SID].url = "/rules/meta.html#sid-signature-id";
sigmatch_table[DETECT_SID].Match = NULL;
sigmatch_table[DETECT_SID].Setup = DetectSidSetup;
#ifdef UNITTESTS
sigmatch_table[DETECT_SID].RegisterTests = DetectSidRegisterTests;
#endif
}
static int DetectSidSetup (DetectEngineCtx *de_ctx, Signature *s, const char *sidstr)
{
unsigned long id = 0;
char *endptr = NULL;
id = strtoul(sidstr, &endptr, 10);
if (endptr == NULL || *endptr != '\0') {
SCLogError("invalid character as arg "
"to sid keyword");
goto error;
}
if (id >= UINT_MAX) {
SCLogError("sid value too high, max %u", UINT_MAX);
goto error;
}
if (id == 0) {
SCLogError("sid value 0 is invalid");
goto error;
}
if (s->id > 0) {
SCLogError("duplicated 'sid' keyword detected");
goto error;
}
s->id = (uint32_t)id;
return 0;
error:
return -1;
}
#ifdef UNITTESTS
static int SidTestParse01(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
Signature *s =
DetectEngineAppendSig(de_ctx, "alert tcp 1.2.3.4 any -> any any (sid:1; gid:1;)");
FAIL_IF_NULL(s);
FAIL_IF(s->id != 1);
DetectEngineCtxFree(de_ctx);
PASS;
}
static int SidTestParse02(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
FAIL_IF_NOT_NULL(
DetectEngineAppendSig(de_ctx, "alert tcp 1.2.3.4 any -> any any (sid:a; gid:1;)"));
DetectEngineCtxFree(de_ctx);
PASS;
}
static int SidTestParse03(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
FAIL_IF_NOT_NULL(DetectEngineAppendSig(
de_ctx, "alert tcp any any -> any any (content:\"ABC\"; sid:\";)"));
DetectEngineCtxFree(de_ctx);
PASS;
}
static int SidTestParse04(void)
{
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
FAIL_IF_NULL(de_ctx);
FAIL_IF_NOT_NULL(DetectEngineAppendSig(
de_ctx, "alert tcp any any -> any any (content:\"ABC\"; sid: 0;)"));
/* Let's also make sure that Suricata fails a rule which doesn't have a sid at all */
FAIL_IF_NOT_NULL(
DetectEngineAppendSig(de_ctx, "alert tcp any any -> any any (content:\"ABC\";)"));
DetectEngineCtxFree(de_ctx);
PASS;
}
/**
* \brief Register DetectSid unit tests.
*/
static void DetectSidRegisterTests(void)
{
UtRegisterTest("SidTestParse01", SidTestParse01);
UtRegisterTest("SidTestParse02", SidTestParse02);
UtRegisterTest("SidTestParse03", SidTestParse03);
UtRegisterTest("SidTestParse04", SidTestParse04);
}
#endif /* UNITTESTS */
|
