1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
AddonTestUtils.init(this);
AddonTestUtils.usePrivilegedSignatures = id => id.startsWith("privileged");
add_task(async function setup() {
await ExtensionTestUtils.startAddonManager();
});
add_task(async function test_hidden() {
let xpi1 = createTempWebExtensionFile({
manifest: {
browser_specific_settings: {
gecko: {
id: "privileged@tests.mozilla.org",
},
},
name: "Hidden Extension",
hidden: true,
},
});
let xpi2 = createTempWebExtensionFile({
manifest: {
browser_specific_settings: {
gecko: {
id: "unprivileged@tests.mozilla.org",
},
},
name: "Non-Hidden Extension",
hidden: true,
},
});
await promiseInstallAllFiles([xpi1, xpi2]);
let [addon1, addon2] = await promiseAddonsByIDs([
"privileged@tests.mozilla.org",
"unprivileged@tests.mozilla.org",
]);
ok(addon1.isPrivileged, "Privileged is privileged");
ok(addon1.hidden, "Privileged extension should be hidden");
ok(!addon2.isPrivileged, "Unprivileged extension is not privileged");
ok(!addon2.hidden, "Unprivileged extension should not be hidden");
await promiseRestartManager();
[addon1, addon2] = await promiseAddonsByIDs([
"privileged@tests.mozilla.org",
"unprivileged@tests.mozilla.org",
]);
ok(addon1.isPrivileged, "Privileged is privileged");
ok(addon1.hidden, "Privileged extension should be hidden");
ok(!addon2.isPrivileged, "Unprivileged extension is not privileged");
ok(!addon2.hidden, "Unprivileged extension should not be hidden");
let extension = ExtensionTestUtils.loadExtension({
useAddonManager: "temporary",
manifest: {
browser_specific_settings: { gecko: { id: "privileged@but-temporary" } },
hidden: true,
},
});
await extension.startup();
let tempAddon = extension.addon;
ok(tempAddon.isPrivileged, "Temporary add-on is privileged");
ok(
!tempAddon.hidden,
"Temporary add-on is not hidden despite being privileged"
);
await extension.unload();
});
add_task(
{
pref_set: [["extensions.manifestV3.enabled", true]],
},
async function test_hidden_and_browser_action_props_are_mutually_exclusive() {
const TEST_CASES = [
{
title: "hidden and browser_action",
manifest: {
hidden: true,
browser_action: {},
},
expectError: true,
},
{
title: "hidden and page_action",
manifest: {
hidden: true,
page_action: {},
},
expectError: true,
},
{
title: "hidden, browser_action and page_action",
manifest: {
hidden: true,
browser_action: {},
page_action: {},
},
expectError: true,
},
{
title: "hidden and no browser_action or page_action",
manifest: {
hidden: true,
},
expectError: false,
},
{
title: "not hidden and browser_action",
manifest: {
hidden: false,
browser_action: {},
},
expectError: false,
},
{
title: "not hidden and page_action",
manifest: {
hidden: false,
page_action: {},
},
expectError: false,
},
{
title: "no hidden prop and browser_action",
manifest: {
browser_action: {},
},
expectError: false,
},
{
title: "hidden and action",
manifest: {
manifest_version: 3,
hidden: true,
action: {},
},
expectError: true,
},
{
title: "hidden, action and page_action",
manifest: {
manifest_version: 3,
hidden: true,
action: {},
page_action: {},
},
expectError: true,
},
{
title: "no hidden prop and action",
manifest: {
manifest_version: 3,
action: {},
},
expectError: false,
},
{
title: "no hidden prop and page_action",
manifest: {
page_action: {},
},
expectError: false,
},
{
title: "hidden and action but not privileged",
manifest: {
manifest_version: 3,
hidden: true,
action: {},
},
expectError: false,
isPrivileged: false,
},
{
title: "hidden and browser_action but not privileged",
manifest: {
hidden: true,
browser_action: {},
},
expectError: false,
isPrivileged: false,
},
{
title: "hidden and page_action but not privileged",
manifest: {
hidden: true,
page_action: {},
},
expectError: false,
isPrivileged: false,
},
];
let count = 0;
for (const {
title,
manifest,
expectError,
isPrivileged = true,
} of TEST_CASES) {
info(`== ${title} ==`);
// Thunderbird doesn't have page actions.
if (manifest.page_action && AppConstants.MOZ_APP_NAME == "thunderbird") {
continue;
}
const extension = ExtensionTestUtils.loadExtension({
manifest: {
browser_specific_settings: {
gecko: {
id: `${isPrivileged ? "" : "not-"}privileged@ext-${count++}`,
},
},
permissions: ["mozillaAddons"],
...manifest,
},
background() {
/* globals browser */
browser.test.sendMessage("ok");
},
isPrivileged,
});
if (expectError) {
await Assert.rejects(
extension.startup(),
/Cannot use browser and\/or page actions in hidden add-ons/,
"expected extension not started"
);
} else {
await extension.startup();
await extension.awaitMessage("ok");
await extension.unload();
}
}
}
);
|
