summaryrefslogtreecommitdiffstats
path: root/wiretap/blf.c
diff options
context:
space:
mode:
Diffstat (limited to 'wiretap/blf.c')
-rw-r--r--wiretap/blf.c2755
1 files changed, 2071 insertions, 684 deletions
diff --git a/wiretap/blf.c b/wiretap/blf.c
index 176db32f..9443ba44 100644
--- a/wiretap/blf.c
+++ b/wiretap/blf.c
@@ -27,23 +27,31 @@
#include <epan/value_string.h>
#include <wsutil/wslog.h>
#include <wsutil/exported_pdu_tlvs.h>
+#include <wsutil/strtoi.h>
#include "file_wrappers.h"
#include "wtap-int.h"
+#ifdef HAVE_ZLIBNG
+#include <zlib-ng.h>
+#define ZLIB_PREFIX(x) zng_ ## x
+typedef zng_stream zlib_stream;
+#else
#ifdef HAVE_ZLIB
-#define ZLIB_CONST
+#define ZLIB_PREFIX(x) x
#include <zlib.h>
+typedef z_stream zlib_stream;
#endif /* HAVE_ZLIB */
+#endif
-static const guint8 blf_magic[] = { 'L', 'O', 'G', 'G' };
-static const guint8 blf_obj_magic[] = { 'L', 'O', 'B', 'J' };
+static const uint8_t blf_magic[] = { 'L', 'O', 'G', 'G' };
+static const uint8_t blf_obj_magic[] = { 'L', 'O', 'B', 'J' };
static int blf_file_type_subtype = -1;
void register_blf(void);
-static gboolean blf_read(wtap *wth, wtap_rec *rec, Buffer *buf, int *err, gchar **err_info, gint64 *data_offset);
-static gboolean blf_seek_read(wtap *wth, gint64 seek_off, wtap_rec* rec, Buffer *buf, int *err, gchar **err_info);
+static bool blf_read(wtap *wth, wtap_rec *rec, Buffer *buf, int *err, char **err_info, int64_t *data_offset);
+static bool blf_seek_read(wtap *wth, int64_t seek_off, wtap_rec* rec, Buffer *buf, int *err, char **err_info);
static void blf_close(wtap *wth);
/*
@@ -53,34 +61,30 @@ static void blf_close(wtap *wth);
* ...
*
* The "real" positions, length, etc. reference this layout and not the file.
- * When no compression is used the file is accessed directly.
*/
-
typedef struct blf_log_container {
- gint64 infile_start_pos; /* start position of log container in file */
- guint64 infile_length; /* length of log container in file */
- guint64 infile_data_start; /* start position of data in log container in file */
+ int64_t infile_start_pos; /* start position of log container in file */
+ uint64_t infile_length; /* length of log container in file */
+ uint64_t infile_data_start; /* start position of data in log container in file */
- gint64 real_start_pos; /* decompressed (virtual) start position including header */
- guint64 real_length; /* decompressed length */
- gint64 real_first_object_pos; /* where does the first obj start? */
- guint64 real_leftover_bytes; /* how many bytes are left over for the next container? */
+ uint64_t real_start_pos; /* decompressed (virtual) start position including header */
+ uint64_t real_length; /* decompressed length */
- guint16 compression_method; /* 0: uncompressed, 2: zlib */
+ uint16_t compression_method; /* 0: uncompressed, 2: zlib */
unsigned char *real_data; /* cache for decompressed data */
} blf_log_container_t;
typedef struct blf_data {
- gint64 start_of_last_obj;
- gint64 current_real_seek_pos;
- guint64 start_offset_ns;
+ int64_t start_of_last_obj;
+ int64_t current_real_seek_pos;
+ uint64_t start_offset_ns;
- guint current_log_container;
- GArray *log_containers;
+ GArray *log_containers;
GHashTable *channel_to_iface_ht;
- guint32 next_interface_id;
+ GHashTable *channel_to_name_ht;
+ uint32_t next_interface_id;
} blf_t;
typedef struct blf_params {
@@ -88,71 +92,78 @@ typedef struct blf_params {
wtap_rec *rec;
Buffer *buf;
FILE_T fh;
+ bool random;
+ bool pipe;
blf_t *blf_data;
} blf_params_t;
typedef struct blf_channel_to_iface_entry {
- int pkt_encap;
- guint16 channel;
- guint16 hwchannel;
- guint32 interface_id;
+ int pkt_encap;
+ uint16_t channel;
+ uint16_t hwchannel;
+ uint32_t interface_id;
} blf_channel_to_iface_entry_t;
static void
-blf_free_key(gpointer key) {
+blf_free_key(void *key) {
g_free(key);
}
static void
-blf_free_channel_to_iface_entry(gpointer data) {
+blf_free_channel_to_iface_entry(void *data) {
g_free(data);
}
-static gint64
-blf_calc_key_value(int pkt_encap, guint16 channel, guint16 hwchannel) {
- return (gint64)(((guint64)pkt_encap << 32) | ((guint64)hwchannel << 16) | (guint64)channel);
+static void
+blf_free_channel_to_name_entry(void *data) {
+ g_free(data);
+}
+
+static int64_t
+blf_calc_key_value(int pkt_encap, uint16_t channel, uint16_t hwchannel) {
+ return (int64_t)(((uint64_t)pkt_encap << 32) | ((uint64_t)hwchannel << 16) | (uint64_t)channel);
}
-static void add_interface_name(wtap_block_t *int_data, int pkt_encap, guint16 channel, guint16 hwchannel, gchar *name) {
+static void add_interface_name(wtap_block_t int_data, int pkt_encap, uint16_t channel, uint16_t hwchannel, char *name) {
if (name != NULL) {
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "%s", name);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "%s", name);
} else {
switch (pkt_encap) {
case WTAP_ENCAP_ETHERNET:
/* we use UINT16_MAX to encode no hwchannel */
if (hwchannel == UINT16_MAX) {
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "ETH-%u", channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "ETH-%u", channel);
} else {
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "ETH-%u-%u", channel, hwchannel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "ETH-%u-%u", channel, hwchannel);
}
break;
case WTAP_ENCAP_IEEE_802_11:
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "WLAN-%u", channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "WLAN-%u", channel);
break;
case WTAP_ENCAP_FLEXRAY:
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "FR-%u", channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "FR-%u", channel);
break;
case WTAP_ENCAP_LIN:
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "LIN-%u", channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "LIN-%u", channel);
break;
case WTAP_ENCAP_SOCKETCAN:
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "CAN-%u", channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "CAN-%u", channel);
break;
default:
- wtap_block_add_string_option_format(*int_data, OPT_IDB_NAME, "ENCAP_%d-%u", pkt_encap, channel);
+ wtap_block_add_string_option_format(int_data, OPT_IDB_NAME, "ENCAP_%d-%u", pkt_encap, channel);
}
}
}
-static guint32
-blf_add_interface(blf_params_t *params, int pkt_encap, guint32 channel, guint16 hwchannel, gchar *name) {
+static uint32_t
+blf_add_interface(blf_params_t *params, int pkt_encap, uint32_t channel, uint16_t hwchannel, char *name) {
wtap_block_t int_data = wtap_block_create(WTAP_BLOCK_IF_ID_AND_INFO);
wtapng_if_descr_mandatory_t *if_descr_mand = (wtapng_if_descr_mandatory_t*)wtap_block_get_mandatory_data(int_data);
blf_channel_to_iface_entry_t *item = NULL;
if_descr_mand->wtap_encap = pkt_encap;
- add_interface_name(&int_data, pkt_encap, channel, hwchannel, name);
+ add_interface_name(int_data, pkt_encap, channel, hwchannel, name);
/*
* The time stamp resolution in these files can be per-record;
* the maximum resolution is nanoseconds, so we specify that
@@ -177,8 +188,8 @@ blf_add_interface(blf_params_t *params, int pkt_encap, guint32 channel, guint16
}
}
- gint64 *key = NULL;
- key = g_new(gint64, 1);
+ int64_t *key = NULL;
+ key = g_new(int64_t, 1);
*key = blf_calc_key_value(pkt_encap, channel, hwchannel);
item = g_new(blf_channel_to_iface_entry_t, 1);
@@ -191,10 +202,70 @@ blf_add_interface(blf_params_t *params, int pkt_encap, guint32 channel, guint16
return item->interface_id;
}
-static guint32
-blf_lookup_interface(blf_params_t *params, int pkt_encap, guint16 channel, guint16 hwchannel, gchar *name) {
- gint64 key = blf_calc_key_value(pkt_encap, channel, hwchannel);
- blf_channel_to_iface_entry_t *item = NULL;
+/** This is used to save the interface name without creating it.
+ *
+ * This approach allows up to update the name of the interface
+ * up until the first captured packet.
+ */
+static bool
+// NOLINTNEXTLINE(misc-no-recursion)
+blf_prepare_interface_name(blf_params_t* params, int pkt_encap, uint16_t channel, uint16_t hwchannel, char* name, bool force_new_name) {
+ int64_t key = blf_calc_key_value(pkt_encap, channel, hwchannel);
+ char* old_name;
+ char* new_name;
+ char* iface_name;
+ int64_t* new_key;
+ bool ret;
+
+ if (params->blf_data->channel_to_name_ht == NULL) {
+ return false;
+ }
+
+ old_name = (char *)g_hash_table_lookup(params->blf_data->channel_to_name_ht, &key);
+
+ if (old_name != NULL && force_new_name) {
+ if (!g_hash_table_remove(params->blf_data->channel_to_name_ht, &key)) {
+ return false;
+ }
+
+ old_name = NULL;
+ }
+
+ if (old_name == NULL && name != NULL) {
+ new_key = g_new(int64_t, 1);
+ *new_key = key;
+ new_name = ws_strdup(name);
+ if (!g_hash_table_insert(params->blf_data->channel_to_name_ht, new_key, new_name)) {
+ return false;
+ }
+ }
+ else {
+ new_name = old_name;
+ }
+
+ if (pkt_encap == WTAP_ENCAP_ETHERNET) {
+ /* Just for Ethernet, prepare the equivalent STATUS interface */
+ iface_name = new_name != NULL ? ws_strdup_printf("STATUS-%s", new_name) : NULL;
+
+ // We recurse here once.
+ ret = blf_prepare_interface_name(params, WTAP_ENCAP_WIRESHARK_UPPER_PDU, channel, hwchannel, iface_name, force_new_name);
+ if (iface_name) {
+ g_free(iface_name);
+ }
+ if (!ret) {
+ return false;
+ }
+ }
+
+ return true;
+}
+
+static uint32_t
+blf_lookup_interface(blf_params_t *params, int pkt_encap, uint16_t channel, uint16_t hwchannel, char *name) {
+ int64_t key = blf_calc_key_value(pkt_encap, channel, hwchannel);
+ blf_channel_to_iface_entry_t* item;
+ char* saved_name;
+ uint32_t ret;
if (params->blf_data->channel_to_iface_ht == NULL) {
return 0;
@@ -204,8 +275,19 @@ blf_lookup_interface(blf_params_t *params, int pkt_encap, guint16 channel, guint
if (item != NULL) {
return item->interface_id;
- } else {
- return blf_add_interface(params, pkt_encap, channel, hwchannel, name);
+ }
+ else {
+ saved_name = (char*)g_hash_table_lookup(params->blf_data->channel_to_name_ht, &key);
+
+ if (saved_name != NULL) {
+ ret = blf_add_interface(params, pkt_encap, channel, hwchannel, saved_name);
+ g_hash_table_remove(params->blf_data->channel_to_name_ht, &key);
+
+ return ret;
+ }
+ else {
+ return blf_add_interface(params, pkt_encap, channel, hwchannel, name);
+ }
}
}
@@ -299,6 +381,17 @@ fix_endianness_blf_ethernetframeheader_ex(blf_ethernetframeheader_ex_t *header)
}
static void
+fix_endianness_blf_ethernet_rxerror(blf_ethernet_rxerror_t* header) {
+ header->struct_length = GUINT16_FROM_LE(header->struct_length);
+ header->channel = GUINT16_FROM_LE(header->channel);
+ header->direction = GUINT16_FROM_LE(header->direction);
+ header->hw_channel = GUINT16_FROM_LE(header->hw_channel);
+ header->frame_checksum = GUINT32_FROM_LE(header->frame_checksum);
+ header->frame_length = GUINT16_FROM_LE(header->frame_length);
+ header->error = GUINT32_FROM_LE(header->error);
+}
+
+static void
fix_endianness_blf_wlanframeheader(blf_wlanframeheader_t* header) {
header->channel = GUINT16_FROM_LE(header->channel);
header->flags = GUINT16_FROM_LE(header->flags);
@@ -429,6 +522,86 @@ fix_endianness_blf_linmessage(blf_linmessage_t* message) {
}
static void
+fix_endianness_blf_linbusevent(blf_linbusevent_t* linbusevent) {
+ linbusevent->sof = GUINT64_FROM_LE(linbusevent->sof);
+ linbusevent->eventBaudrate = GUINT32_FROM_LE(linbusevent->eventBaudrate);
+ linbusevent->channel = GUINT16_FROM_LE(linbusevent->channel);
+}
+
+static void
+fix_endianness_blf_linsynchfieldevent(blf_linsynchfieldevent_t* linsynchfieldevent) {
+ fix_endianness_blf_linbusevent(&linsynchfieldevent->linBusEvent);
+ linsynchfieldevent->synchBreakLength = GUINT64_FROM_LE(linsynchfieldevent->synchBreakLength);
+ linsynchfieldevent->synchDelLength = GUINT64_FROM_LE(linsynchfieldevent->synchDelLength);
+}
+
+static void
+fix_endianness_blf_linmessagedescriptor(blf_linmessagedescriptor_t* linmessagedescriptor) {
+ fix_endianness_blf_linsynchfieldevent(&linmessagedescriptor->linSynchFieldEvent);
+ linmessagedescriptor->supplierId = GUINT16_FROM_LE(linmessagedescriptor->supplierId);
+ linmessagedescriptor->messageId = GUINT16_FROM_LE(linmessagedescriptor->messageId);
+}
+
+static void
+fix_endianness_blf_lindatabytetimestampevent(blf_lindatabytetimestampevent_t* lindatabytetimestampevent) {
+ int i;
+ fix_endianness_blf_linmessagedescriptor(&lindatabytetimestampevent->linMessageDescriptor);
+ for (i = 0; i < 9; i++) {
+ lindatabytetimestampevent->databyteTimestamps[i] = GUINT64_FROM_LE(lindatabytetimestampevent->databyteTimestamps[i]);
+ }
+}
+
+static void
+fix_endianness_blf_linmessage2(blf_linmessage2_t* message) {
+ fix_endianness_blf_lindatabytetimestampevent(&message->linDataByteTimestampEvent);
+ message->crc = GUINT16_FROM_LE(message->crc);
+/* skip the optional part
+ message->respBaudrate = GUINT32_FROM_LE(message->respBaudrate);
+ message->exactHeaderBaudrate = GUINT64_FROM_LE(message->exactHeaderBaudrate);
+ message->earlyStopBitOffset = GUINT32_FROM_LE(message->earlyStopBitOffset);
+ message->earlyStopBitOffsetResponse = GUINT32_FROM_LE(message->earlyStopBitOffsetResponse);
+*/
+}
+
+static void
+fix_endianness_blf_lincrcerror2(blf_lincrcerror2_t* message) {
+ fix_endianness_blf_lindatabytetimestampevent(&message->linDataByteTimestampEvent);
+ message->crc = GUINT16_FROM_LE(message->crc);
+/* skip the optional part
+ message->respBaudrate = GUINT32_FROM_LE(message->respBaudrate);
+ message->exactHeaderBaudrate = GUINT64_FROM_LE(message->exactHeaderBaudrate);
+ message->earlyStopBitOffset = GUINT32_FROM_LE(message->earlyStopBitOffset);
+ message->earlyStopBitOffsetResponse = GUINT32_FROM_LE(message->earlyStopBitOffsetResponse);
+*/
+}
+
+static void
+fix_endianness_blf_linrcverror2(blf_linrcverror2_t* message) {
+ fix_endianness_blf_lindatabytetimestampevent(&message->linDataByteTimestampEvent);
+/* skip the optional part
+ message->respBaudrate = GUINT32_FROM_LE(message->respBaudrate);
+ message->exactHeaderBaudrate = GUINT64_FROM_LE(message->exactHeaderBaudrate);
+ message->earlyStopBitOffset = GUINT32_FROM_LE(message->earlyStopBitOffset);
+ message->earlyStopBitOffsetResponse = GUINT32_FROM_LE(message->earlyStopBitOffsetResponse);
+*/
+}
+
+static void
+fix_endianness_blf_linsenderror2(blf_linsenderror2_t* message) {
+ fix_endianness_blf_linmessagedescriptor(&message->linMessageDescriptor);
+ message->eoh = GUINT64_FROM_LE(message->eoh);
+/* skip the optional part
+ message->exactHeaderBaudrate = GUINT64_FROM_LE(message->exactHeaderBaudrate);
+ message->earlyStopBitOffset = GUINT32_FROM_LE(message->earlyStopBitOffset);
+*/
+}
+
+static void
+fix_endianness_blf_linwakeupevent2(blf_linwakeupevent2_t* message) {
+ fix_endianness_blf_linbusevent(&message->linBusEvent);
+}
+
+static void
fix_endianness_blf_apptext_header(blf_apptext_t *header) {
header->source = GUINT32_FROM_LE(header->source);
header->reservedAppText1 = GUINT32_FROM_LE(header->reservedAppText1);
@@ -452,133 +625,175 @@ fix_endianness_blf_ethernet_status_header(blf_ethernet_status_t* header) {
}
static void
+fix_endianness_blf_ethernet_phystate_header(blf_ethernet_phystate_t* header) {
+ header->channel = GUINT16_FROM_LE(header->channel);
+ header->flags = GUINT16_FROM_LE(header->flags);
+}
+
+static void
blf_init_logcontainer(blf_log_container_t *tmp) {
tmp->infile_start_pos = 0;
tmp->infile_length = 0;
tmp->infile_data_start = 0;
tmp->real_start_pos = 0;
tmp->real_length = 0;
- tmp->real_first_object_pos = -1;
- tmp->real_leftover_bytes = G_MAXUINT64;
tmp->real_data = NULL;
tmp->compression_method = 0;
}
-static void
-blf_add_logcontainer(blf_t *blf_data, blf_log_container_t log_container) {
- if (blf_data->log_containers == NULL) {
- blf_data->log_containers = g_array_sized_new(FALSE, FALSE, sizeof(blf_log_container_t), 1);
- blf_data->current_log_container = 0;
- } else {
- blf_data->current_log_container++;
- }
+int
+blf_logcontainers_cmp(const void *a, const void *b) {
+ blf_log_container_t* container_a = (blf_log_container_t*)a;
+ blf_log_container_t* container_b = (blf_log_container_t*)b;
- g_array_append_val(blf_data->log_containers, log_container);
+ if (container_a->real_start_pos < container_b->real_start_pos) {
+ return -1;
+ }
+ else if (container_a->real_start_pos > container_b->real_start_pos) {
+ return 1;
+ }
+ else {
+ return 0;
+ }
}
-static gboolean
-blf_get_logcontainer_by_index(blf_t *blf_data, guint container_index, blf_log_container_t **ret) {
- if (blf_data == NULL || blf_data->log_containers == NULL || container_index >= blf_data->log_containers->len) {
- return FALSE;
- }
+int
+blf_logcontainers_search(const void *a, const void *b) {
+ blf_log_container_t* container_a = (blf_log_container_t*)a;
+ uint64_t pos = *(uint64_t*)b;
- *ret = &g_array_index(blf_data->log_containers, blf_log_container_t, container_index);
- return TRUE;
+ if (container_a->real_start_pos > pos) {
+ return 1;
+ }
+ else if (pos >= container_a->real_start_pos + container_a->real_length) {
+ return -1;
+ }
+ else {
+ return 0;
+ }
}
-static gboolean
-blf_find_logcontainer_for_address(blf_t *blf_data, gint64 pos, blf_log_container_t **container, gint *container_index) {
- blf_log_container_t *tmp;
+/** Ensures the given log container is in memory
+ *
+ * If the log container already is not already in memory,
+ * it reads it from the current seek position, allocating a
+ * properly sized buffer.
+ * The file offset must be set to the start of the container
+ * data (container->infile_data_start) before calling this function.
+ */
+static bool
+blf_pull_logcontainer_into_memory(blf_params_t *params, blf_log_container_t *container, int *err, char **err_info) {
- if (blf_data == NULL || blf_data->log_containers == NULL) {
- return FALSE;
+ if (container == NULL) {
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory called with NULL container");
+ return false;
}
- for (guint i = 0; i < blf_data->log_containers->len; i++) {
- tmp = &g_array_index(blf_data->log_containers, blf_log_container_t, i);
- if (tmp->real_start_pos <= pos && pos < tmp->real_start_pos + (gint64)tmp->real_length) {
- *container = tmp;
- *container_index = i;
- return TRUE;
- }
+ if (container->real_data != NULL) {
+ return true;
}
- return FALSE;
-}
-
-static gboolean
-blf_pull_logcontainer_into_memory(blf_params_t *params, guint index_log_container, int *err, gchar **err_info) {
- blf_t *blf_data = params->blf_data;
- blf_log_container_t tmp;
-
- if (index_log_container >= blf_data->log_containers->len) {
+ /* pull compressed data into buffer */
+ if (container->infile_start_pos < 0) {
/*
* XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
* malformed file (WTAP_ERR_BAD_FILE)?
*/
*err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: index_log_container (%u) >= blf_data->log_containers->len (%u)",
- index_log_container, blf_data->log_containers->len);
- return FALSE;
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: container.infile_start_pos (%" PRId64 ") < 0",
+ container->infile_start_pos);
+ return false;
}
-
- tmp = g_array_index(blf_data->log_containers, blf_log_container_t, index_log_container);
-
- if (tmp.real_data != NULL) {
- return TRUE;
+ if (container->infile_data_start < (uint64_t)container->infile_start_pos) {
+ /*
+ * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
+ * malformed file (WTAP_ERR_BAD_FILE)?
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: container.infile_data_start (%" PRIu64 ") < container.infile_start_pos (%" PRId64 ")",
+ container->infile_data_start, container->infile_start_pos);
+ return false;
+ }
+ if (container->infile_length < container->infile_data_start - (uint64_t)container->infile_start_pos) {
+ /*
+ * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
+ * malformed file (WTAP_ERR_BAD_FILE)?
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: container.infile_length (%" PRIu64 ") < (container.infile_data_start (%" PRIu64 ") - container.infile_start_pos (%" PRId64 ")) = %" PRIu64,
+ container->infile_length,
+ container->infile_data_start, container->infile_start_pos,
+ container->infile_data_start - (uint64_t)container->infile_start_pos);
+ return false;
+ }
+ uint64_t data_length = container->infile_length - (container->infile_data_start - (uint64_t)container->infile_start_pos);
+ if (data_length > UINT_MAX) {
+ /*
+ * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
+ * malformed file (WTAP_ERR_BAD_FILE)?
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: data_length (%" PRIu64 ") > UINT_MAX",
+ data_length);
+ return false;
}
- if (tmp.compression_method == BLF_COMPRESSION_ZLIB) {
-#ifdef HAVE_ZLIB
- if (file_seek(params->fh, tmp.infile_data_start, SEEK_SET, err) == -1) {
- return FALSE;
+ if (container->real_length == 0) {
+ ws_info("blf_pull_logcontainer_into_memory: found container with 0 length");
+ /* Skip empty container */
+ if (!wtap_read_bytes_or_eof(params->fh, NULL, (unsigned int)data_length, err, err_info)) {
+ if (*err == WTAP_ERR_SHORT_READ) {
+ /*
+ * XXX - our caller will turn this into an EOF.
+ * How *should* it be treated?
+ * For now, we turn it into Yet Another Internal Error,
+ * pending having better documentation of the file
+ * format.
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup("blf_pull_logcontainer_into_memory: short read on 0-length container");
+ }
+ return false;
}
+ return true;
+ }
- /* pull compressed data into buffer */
- if (tmp.infile_start_pos < 0) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: tmp.infile_start_pos (%" G_GINT64_FORMAT ") < 0",
- tmp.infile_start_pos);
- return FALSE;
- }
- if (tmp.infile_data_start < (guint64)tmp.infile_start_pos) {
+ if (container->compression_method == BLF_COMPRESSION_NONE) {
+ unsigned char* buf = g_try_malloc((size_t)container->real_length);
+ if (buf == NULL) {
/*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
+ * XXX - our caller will turn this into an EOF.
+ * How *should* it be treated?
+ * For now, we turn it into Yet Another Internal Error,
+ * pending having better documentation of the file
+ * format.
*/
*err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: tmp.infile_data_start (%" G_GUINT64_FORMAT ") < tmp.infile_start_pos (%" G_GINT64_FORMAT ")",
- tmp.infile_data_start, tmp.infile_start_pos);
- return FALSE;
+ *err_info = ws_strdup("blf_pull_logcontainer_into_memory: cannot allocate memory");
}
- if (tmp.infile_length < tmp.infile_data_start - (guint64)tmp.infile_start_pos) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: tmp.infile_length (%" G_GUINT64_FORMAT ") < (tmp.infile_data_start (%" G_GUINT64_FORMAT ") - tmp.infile_start_pos (%" G_GINT64_FORMAT ")) = %" G_GUINT64_FORMAT,
- tmp.infile_length,
- tmp.infile_data_start, tmp.infile_start_pos,
- tmp.infile_data_start - (guint64)tmp.infile_start_pos);
- return FALSE;
- }
- guint64 data_length = tmp.infile_length - (tmp.infile_data_start - (guint64)tmp.infile_start_pos);
- if (data_length > UINT_MAX) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: data_length (%" G_GUINT64_FORMAT ") > UINT_MAX",
- data_length);
- return FALSE;
+ if (!wtap_read_bytes_or_eof(params->fh, buf, (unsigned int)data_length, err, err_info)) {
+ g_free(buf);
+ if (*err == WTAP_ERR_SHORT_READ) {
+ /*
+ * XXX - our caller will turn this into an EOF.
+ * How *should* it be treated?
+ * For now, we turn it into Yet Another Internal Error,
+ * pending having better documentation of the file
+ * format.
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup("blf_pull_logcontainer_into_memory: short read on uncompressed data");
+ }
+ return false;
}
- unsigned char *compressed_data = g_try_malloc0((gsize)tmp.infile_length);
+ container->real_data = buf;
+ return true;
+
+ }
+ else if (container->compression_method == BLF_COMPRESSION_ZLIB) {
+#if defined (HAVE_ZLIB) || defined (HAVE_ZLIBNG)
+ unsigned char *compressed_data = g_try_malloc((size_t)data_length);
if (!wtap_read_bytes_or_eof(params->fh, compressed_data, (unsigned int)data_length, err, err_info)) {
g_free(compressed_data);
if (*err == WTAP_ERR_SHORT_READ) {
@@ -592,19 +807,30 @@ blf_pull_logcontainer_into_memory(blf_params_t *params, guint index_log_containe
*err = WTAP_ERR_INTERNAL;
*err_info = ws_strdup("blf_pull_logcontainer_into_memory: short read on compressed data");
}
- return FALSE;
+ return false;
}
- unsigned char *buf = g_try_malloc0((gsize)tmp.real_length);
- z_stream infstream = {0};
+ unsigned char *buf = g_try_malloc((size_t)container->real_length);
+ if (buf == NULL) {
+ /*
+ * XXX - our caller will turn this into an EOF.
+ * How *should* it be treated?
+ * For now, we turn it into Yet Another Internal Error,
+ * pending having better documentation of the file
+ * format.
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup("blf_pull_logcontainer_into_memory: cannot allocate memory");
+ }
+ zlib_stream infstream = {0};
infstream.avail_in = (unsigned int)data_length;
infstream.next_in = compressed_data;
- infstream.avail_out = (unsigned int)tmp.real_length;
+ infstream.avail_out = (unsigned int)container->real_length;
infstream.next_out = buf;
/* the actual DE-compression work. */
- if (Z_OK != inflateInit(&infstream)) {
+ if (Z_OK != ZLIB_PREFIX(inflateInit)(&infstream)) {
/*
* XXX - check the error code and handle this appropriately.
*/
@@ -612,21 +838,19 @@ blf_pull_logcontainer_into_memory(blf_params_t *params, guint index_log_containe
g_free(compressed_data);
*err = WTAP_ERR_INTERNAL;
if (infstream.msg != NULL) {
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateInit failed for LogContainer %u, message\"%s\"",
- index_log_container,
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateInit failed for LogContainer, message\"%s\"",
infstream.msg);
} else {
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateInit failed for LogContainer %u",
- index_log_container);
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateInit failed for LogContainer");
}
- ws_debug("inflateInit failed for LogContainer %u", index_log_container);
+ ws_debug("inflateInit failed for LogContainer");
if (infstream.msg != NULL) {
ws_debug("inflateInit returned: \"%s\"", infstream.msg);
}
- return FALSE;
+ return false;
}
- int ret = inflate(&infstream, Z_NO_FLUSH);
+ int ret = ZLIB_PREFIX(inflate)(&infstream, Z_NO_FLUSH);
/* Z_OK should not happen here since we know how big the buffer should be */
if (Z_STREAM_END != ret) {
switch (ret) {
@@ -675,16 +899,16 @@ blf_pull_logcontainer_into_memory(blf_params_t *params, guint index_log_containe
}
g_free(buf);
g_free(compressed_data);
- ws_debug("inflate failed (return code %d) for LogContainer %u", ret, index_log_container);
+ ws_debug("inflate failed (return code %d) for LogContainer", ret);
if (infstream.msg != NULL) {
ws_debug("inflate returned: \"%s\"", infstream.msg);
}
/* Free up any dynamically-allocated memory in infstream */
- inflateEnd(&infstream);
- return FALSE;
+ ZLIB_PREFIX(inflateEnd)(&infstream);
+ return false;
}
- if (Z_OK != inflateEnd(&infstream)) {
+ if (Z_OK != ZLIB_PREFIX(inflateEnd)(&infstream)) {
/*
* The zlib manual says this only returns Z_OK on success
* and Z_STREAM_ERROR if the stream state was inconsistent.
@@ -698,336 +922,378 @@ blf_pull_logcontainer_into_memory(blf_params_t *params, guint index_log_containe
* fails.
*/
*err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateEnd failed for LogContainer %u", index_log_container);
+ *err_info = ws_strdup_printf("blf_pull_logcontainer_into_memory: inflateEnd failed for LogContainer");
g_free(buf);
g_free(compressed_data);
- ws_debug("inflateEnd failed for LogContainer %u", index_log_container);
+ ws_debug("inflateEnd failed for LogContainer");
if (infstream.msg != NULL) {
ws_debug("inflateEnd returned: \"%s\"", infstream.msg);
}
- return FALSE;
+ return false;
}
g_free(compressed_data);
- tmp.real_data = buf;
- g_array_index(blf_data->log_containers, blf_log_container_t, index_log_container) = tmp;
- return TRUE;
+ container->real_data = buf;
+ return true;
#else
+ (void) params;
*err = WTAP_ERR_DECOMPRESSION_NOT_SUPPORTED;
*err_info = ws_strdup("blf_pull_logcontainer_into_memory: reading gzip-compressed containers isn't supported");
- return FALSE;
+ return false;
#endif
}
- return FALSE;
+ return false;
}
-static gboolean
-blf_read_bytes_or_eof(blf_params_t *params, guint64 real_pos, void *target_buffer, unsigned int count, int *err, gchar **err_info) {
- blf_log_container_t *start_container;
- blf_log_container_t *end_container;
- blf_log_container_t *current_container;
+/** Finds the next log container starting at the current file offset
+ *
+ * Adds the container to the containers array for later access
+ */
+static bool
+blf_find_next_logcontainer(blf_params_t* params, int* err, char** err_info) {
+ blf_blockheader_t header;
+ blf_logcontainerheader_t logcontainer_header;
+ blf_log_container_t tmp;
+ unsigned char* header_ptr;
+ unsigned int i;
- gint start_container_index = -1;
- gint end_container_index = -1;
- gint current_container_index = -1;
+ uint64_t current_real_start;
+ if (params->blf_data->log_containers->len == 0) {
+ current_real_start = 0;
+ }
+ else {
+ blf_log_container_t* container = &g_array_index(params->blf_data->log_containers, blf_log_container_t, params->blf_data->log_containers->len - 1);
+ current_real_start = container->real_start_pos + container->real_length;
+ }
- unsigned int copied = 0;
- unsigned int data_left;
- unsigned int start_in_buf;
+ header_ptr = (unsigned char*)&header;
+ i = 0;
- unsigned char *buf = (unsigned char *)target_buffer;
+ /** Find Object
+ *
+ * We read one byte at a time so that we don't have to seek backward (allows us to do a linear read)
+ */
+ while (i < sizeof(blf_obj_magic)) {
+ if (!wtap_read_bytes_or_eof(params->fh, &header_ptr[i], 1, err, err_info)) {
+ ws_debug("we found end of file");
+ return false;
+ }
+ if (header_ptr[i] != blf_obj_magic[i]) {
+ if (params->pipe) {
+ ws_debug("container object magic is not LOBJ");
+ }
+ else {
+ ws_debug("container object magic is not LOBJ (pos: 0x%" PRIx64 ")", file_tell(params->fh) - 1);
+ }
+ if (i > 0) {
+ int j = i;
- if (!blf_find_logcontainer_for_address(params->blf_data, real_pos, &start_container, &start_container_index)) {
- /*
- * XXX - why is this treated as an EOF rather than an error?
- * *err appears to be 0, which means our caller treats it as an
- * EOF, at least when reading the log object header.
- */
- ws_debug("cannot read data because start position cannot be mapped");
- return FALSE;
+ while (memcmp(&header_ptr[i - j + 1], blf_obj_magic, j)) {
+ /* Check if the last j bytes match the first j bytes of the magic */
+ j--;
+ }
+
+ /* The last j bytes match, and the first j bytes are already in the buffer, since j<=i */
+ i = j;
+ }
+ }
+ else {
+ /* Character matches */
+ i++;
+ }
}
- if (!blf_find_logcontainer_for_address(params->blf_data, real_pos + count - 1, &end_container, &end_container_index)) {
- /*
- * XXX - why is this treated as an EOF rather than an error?
- * *err appears to be 0, which means our caller treats it as an
- * EOF, at least when reading the log object header.
- */
- ws_debug("cannot read data because end position cannot be mapped");
- return FALSE;
+
+ if (!wtap_read_bytes_or_eof(params->fh, &header.header_length, sizeof(blf_blockheader_t) - sizeof(blf_obj_magic), err, err_info)) {
+ ws_debug("we found end of file");
+ return false;
}
- current_container_index = start_container_index;
- current_container = start_container;
- start_in_buf = (unsigned int)real_pos - (unsigned int)start_container->real_start_pos;
+ fix_endianness_blf_blockheader(&header);
- switch (start_container->compression_method) {
- case BLF_COMPRESSION_NONE:
- while (current_container_index <= end_container_index) {
- if (!blf_get_logcontainer_by_index(params->blf_data, current_container_index, &current_container)) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_read_bytes_or_eof: cannot refresh container");
- ws_debug("cannot refresh container");
- return FALSE;
- }
+ if (header.header_length < sizeof(blf_blockheader_t)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup("blf: header length too short while looking for object");
+ return false;
+ }
- data_left = (unsigned int)(current_container->real_length - start_in_buf);
+ if (header.header_type != BLF_HEADER_TYPE_DEFAULT) {
+ *err = WTAP_ERR_UNSUPPORTED;
+ *err_info = ws_strdup_printf("blf: unknown header type (%u), I know only BLF_HEADER_TYPE_DEFAULT (1)", header.header_type);
+ return false;
+ }
- if (file_seek(params->fh, current_container->infile_data_start + start_in_buf, SEEK_SET, err) < 0) {
- ws_debug("cannot seek data");
- return FALSE;
- }
+ if (header.object_length < header.header_length) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup("blf: header object length less than header length while looking for objects");
+ return false;
+ }
- if (data_left < (count - copied)) {
- if (!wtap_read_bytes_or_eof(params->fh, buf + copied, data_left, err, err_info)) {
- ws_debug("cannot read data");
- return FALSE;
- }
- copied += data_left;
- current_container_index++;
- start_in_buf = 0;
- } else {
- if (!wtap_read_bytes_or_eof(params->fh, buf + copied, count - copied, err, err_info)) {
- ws_debug("cannot read data");
- return FALSE;
- }
- return TRUE;
+ if (header.object_type == BLF_OBJTYPE_LOG_CONTAINER) {
+ /* skip unknown header part if needed */
+ if (header.header_length > sizeof(blf_blockheader_t)) {
+ /* seek over unknown header part */
+ if (!wtap_read_bytes(params->fh, NULL, header.header_length - sizeof(blf_blockheader_t), err, err_info)) {
+ ws_debug("error skipping unknown header bytes in log container");
+ return false;
}
}
- break;
- case BLF_COMPRESSION_ZLIB:
- while (current_container_index <= end_container_index) {
- if (!blf_pull_logcontainer_into_memory(params, current_container_index, err, err_info)) {
- return FALSE;
- }
+ /* Read the log container header */
+ if (!wtap_read_bytes_or_eof(params->fh, &logcontainer_header, sizeof(blf_logcontainerheader_t), err, err_info)) {
+ ws_debug("not enough bytes for log container header");
+ return false;
+ }
- if (!blf_get_logcontainer_by_index(params->blf_data, current_container_index, &current_container)) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_read_bytes_or_eof: cannot refresh container");
- ws_debug("cannot refresh container");
- return FALSE;
- }
+ fix_endianness_blf_logcontainerheader(&logcontainer_header);
- if (current_container->real_data == NULL) {
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_read_bytes_or_eof: pulling in container failed hard");
- ws_debug("pulling in container failed hard");
- return FALSE;
- }
+ blf_init_logcontainer(&tmp);
+
+ if (params->pipe) {
+ tmp.infile_start_pos = 0;
+ tmp.infile_data_start = sizeof(blf_logcontainerheader_t) + header.header_length;
+ }
+ else {
+ tmp.infile_data_start = file_tell(params->fh);
+ tmp.infile_start_pos = tmp.infile_data_start - sizeof(blf_logcontainerheader_t) - header.header_length;
+ }
+ tmp.infile_length = header.object_length;
- data_left = (unsigned int)(current_container->real_length - start_in_buf);
+ tmp.real_start_pos = current_real_start;
+ tmp.real_length = logcontainer_header.uncompressed_size;
+ tmp.compression_method = logcontainer_header.compression_method;
- if (data_left < (count - copied)) {
- memcpy(buf + copied, current_container->real_data + start_in_buf, (unsigned int)data_left);
- copied += data_left;
- current_container_index++;
- start_in_buf = 0;
- } else {
- memcpy(buf + copied, current_container->real_data + start_in_buf, count - copied);
- return TRUE;
+ ws_debug("found log container with real_pos=0x%" PRIx64 ", real_length=0x%" PRIx64, tmp.real_start_pos, tmp.real_length);
+ }
+ else {
+ ws_debug("found BLF object without log container");
+
+ /* Create a fake log container for the lone object.
+ * In order to avoid seeking backwards, we need to pull the fake log container now.
+ */
+ unsigned char* buf = g_try_malloc((size_t)header.object_length);
+ if (buf == NULL) {
+ /*
+ * XXX - we need an "out of memory" error code here.
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup("blf_find_next_logcontainer: cannot allocate memory");
+ return false;
+ }
+
+ memcpy(buf, &header, sizeof(blf_blockheader_t));
+
+ if (header.object_length > sizeof(blf_blockheader_t)) {
+ if (!wtap_read_bytes(params->fh, buf + sizeof(blf_blockheader_t), header.object_length - sizeof(blf_blockheader_t), err, err_info)) {
+ g_free(buf);
+ ws_debug("cannot pull object without log container");
+ return false;
}
}
- /*
- * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
- * malformed file (WTAP_ERR_BAD_FILE)?
- */
- *err = WTAP_ERR_INTERNAL;
- *err_info = ws_strdup_printf("blf_read_bytes_or_eof: ran out of items in container");
- return FALSE;
- break;
- default:
- *err = WTAP_ERR_UNSUPPORTED;
- *err_info = ws_strdup_printf("blf: unknown compression method %u",
- start_container->compression_method);
- ws_debug("unknown compression method");
- return FALSE;
+ blf_init_logcontainer(&tmp);
+
+ tmp.infile_start_pos = params->pipe ? 0 : (file_tell(params->fh) - header.object_length);
+ tmp.infile_data_start = tmp.infile_start_pos;
+ tmp.infile_length = header.object_length;
+
+ tmp.real_start_pos = current_real_start;
+ tmp.real_length = header.object_length;
+ tmp.compression_method = BLF_COMPRESSION_NONE;
+
+ tmp.real_data = buf;
+
+ ws_debug("found non-log-container object with real_pos=0x%" PRIx64 ", real_length=0x%" PRIx64, tmp.real_start_pos, tmp.real_length);
}
- return FALSE;
+ g_array_append_val(params->blf_data->log_containers, tmp);
+
+ return true;
}
-static gboolean
-blf_read_bytes(blf_params_t *params, guint64 real_pos, void *target_buffer, unsigned int count, int *err, gchar **err_info) {
- if (!blf_read_bytes_or_eof(params, real_pos, target_buffer, count, err, err_info)) {
- if (*err == 0) {
- *err = WTAP_ERR_SHORT_READ;
- }
- return FALSE;
+static bool
+blf_pull_next_logcontainer(blf_params_t* params, int* err, char** err_info) {
+ blf_log_container_t* container;
+ if (!blf_find_next_logcontainer(params, err, err_info)) {
+ return false;
+ }
+ /* Is there a next log container to pull? */
+ if (params->blf_data->log_containers->len == 0) {
+ /* No. */
+ return false;
+ }
+ container = &g_array_index(params->blf_data->log_containers, blf_log_container_t, params->blf_data->log_containers->len - 1);
+ if (!blf_pull_logcontainer_into_memory(params, container, err, err_info)) {
+ return false;
}
- return TRUE;
+ return true;
}
-/* this is only called once on open to figure out the layout of the file */
-static gboolean
-blf_scan_file_for_logcontainers(blf_params_t *params, int *err, gchar **err_info) {
- blf_blockheader_t header;
- blf_logcontainerheader_t logcontainer_header;
- blf_log_container_t tmp;
+static bool
+blf_read_bytes_or_eof(blf_params_t *params, uint64_t real_pos, void *target_buffer, uint64_t count, int *err, char **err_info) {
+ blf_log_container_t* container;
+ unsigned container_index;
- guint64 current_start_pos;
- guint64 current_real_start = 0;
+ uint64_t end_pos = real_pos + count;
- while (1) {
- current_start_pos = file_tell(params->fh);
+ uint64_t copied = 0;
+ uint64_t data_left;
+ uint64_t start_in_buf;
- /* Find Object */
- while (1) {
- if (!wtap_read_bytes_or_eof(params->fh, &header, sizeof header, err, err_info)) {
- ws_debug("we found end of file");
-
- /* lets ignore some bytes at the end since some implementations think it is ok to add a few zero bytes */
- if (*err == WTAP_ERR_SHORT_READ) {
- *err = 0;
- }
-
- /* Either succeed on an EOF or fail. */
- return *err == 0;
- }
+ unsigned char *buf = (unsigned char *)target_buffer;
- fix_endianness_blf_blockheader(&header);
+ if (count == 0) {
+ ws_debug("called blf_read_bytes_or_eof with 0 count");
+ return false;
+ }
- if (memcmp(header.magic, blf_obj_magic, sizeof(blf_obj_magic))) {
- ws_debug("object magic is not LOBJ (pos: 0x%" PRIx64 ")", current_start_pos);
- } else {
- break;
- }
+ if (count > UINT32_MAX) {
+ ws_debug("trying to read too many bytes");
+ return false;
+ }
+ if (params->random) {
+ /*
+ * Do a binary search for the container in which real_pos
+ * is included.
+ */
+ if (!g_array_binary_search(params->blf_data->log_containers, &real_pos, blf_logcontainers_search, &container_index)) {
/*
- * we are moving back and try again but 1 byte later
- * TODO: better understand how this paddings works...
- * Note that, in at least one capture - the Example.blf
- * file attached to
- * https://gitlab.com/wireshark/wireshark/-/issues/19269 -
- * one of the log container objects is aligned on a 2-byte
- * bundary but *not* on a 4-byte boundary, with 3 bytes
- * of padding.
+ * XXX - why is this treated as an EOF rather than an error?
+ * *err appears to be 0, which means our caller treats it as an
+ * EOF, at least when reading the log object header.
*/
- current_start_pos++;
- if (file_seek(params->fh, current_start_pos, SEEK_SET, err) < 0) {
- return FALSE;
- }
+ ws_debug("cannot read data because start position cannot be mapped");
+ return false;
}
-
- if (header.header_length < sizeof(blf_blockheader_t)) {
- *err = WTAP_ERR_BAD_FILE;
- *err_info = ws_strdup("blf: log container header length too short");
- return FALSE;
+ container = &g_array_index(params->blf_data->log_containers, blf_log_container_t, container_index);
+ }
+ else {
+ if (params->blf_data->log_containers->len == 0) {
+ /*
+ * This is the first (linear) pass, and we haven't yet
+ * added any containers. Pull the next log container
+ * into memory, so that the array isn't empty.
+ */
+ if (!blf_pull_next_logcontainer(params, err, err_info)) {
+ return false;
+ }
}
- if (header.header_type != BLF_HEADER_TYPE_DEFAULT) {
- *err = WTAP_ERR_UNSUPPORTED;
- *err_info = ws_strdup_printf("blf: unknown header type (%u), I know only BLF_HEADER_TYPE_DEFAULT (1)", header.header_type);
- return FALSE;
- }
+ /*
+ * Search backwards in the array, from the last entry to the
+ * first, to find the log container in which real_pos is
+ * included.
+ */
+ container_index = params->blf_data->log_containers->len;
+ do {
+ container = &g_array_index(params->blf_data->log_containers, blf_log_container_t, --container_index);
+ } while (real_pos < container->real_start_pos && container_index > 0); /* For some reason we skipped past the correct container */
+ }
- if (header.object_length < header.header_length) {
- *err = WTAP_ERR_BAD_FILE;
- *err_info = ws_strdup("blf: log container header object length less than log container header length");
- return FALSE;
- }
+ while (real_pos < end_pos) {
- switch (header.object_type) {
- case BLF_OBJTYPE_LOG_CONTAINER:
- /* skip unknown header part if needed */
- if (header.header_length - sizeof(blf_blockheader_t) > 0) {
- /* seek over unknown header part */
- if (file_seek(params->fh, current_start_pos + header.header_length, SEEK_SET, err) < 0) {
- ws_debug("cannot seek file for skipping unknown header bytes in log container");
- return FALSE;
+ while (real_pos >= container->real_start_pos + container->real_length) {
+ container_index++;
+ if (!params->random) { /* First (linear) pass */
+ if (!blf_pull_next_logcontainer(params, err, err_info)) {
+ return false;
}
}
-
- /* Read the log container header */
- if (!wtap_read_bytes_or_eof(params->fh, &logcontainer_header, sizeof(blf_logcontainerheader_t), err, err_info)) {
- ws_debug("not enough bytes for log container header");
- return FALSE;
+ if (container_index >= params->blf_data->log_containers->len) {
+ ws_debug("cannot find real_pos in container");
+ return false;
}
+ container = &g_array_index(params->blf_data->log_containers, blf_log_container_t, container_index);
+ if (real_pos < container->real_start_pos) {
+ ws_debug("cannot find real_pos in container");
+ return false;
+ }
+ }
- fix_endianness_blf_logcontainerheader(&logcontainer_header);
-
- blf_init_logcontainer(&tmp);
+ if (real_pos < container->real_start_pos) {
+ ws_debug("cannot find real_pos in container");
+ return false;
+ }
- tmp.infile_start_pos = current_start_pos;
- tmp.infile_data_start = file_tell(params->fh);
- tmp.infile_length = header.object_length;
+ start_in_buf = real_pos - container->real_start_pos;
- tmp.real_start_pos = current_real_start;
- tmp.real_length = logcontainer_header.uncompressed_size;
- tmp.compression_method = logcontainer_header.compression_method;
+ if (params->random) {
+ if (file_seek(params->fh, container->infile_data_start, SEEK_SET, err) == -1) {
+ return false;
+ }
+ if (!blf_pull_logcontainer_into_memory(params, container, err, err_info)) {
+ return false;
+ }
+ }
- /* set up next start position */
- current_real_start += logcontainer_header.uncompressed_size;
+ data_left = container->real_length - start_in_buf;
- if (file_seek(params->fh, current_start_pos + MAX(MAX(16, header.object_length), header.header_length), SEEK_SET, err) < 0) {
- ws_debug("cannot seek file for skipping log container bytes");
- return FALSE;
- }
+ if (data_left < (count - copied)) {
+ memcpy(buf + copied, container->real_data + start_in_buf, data_left);
+ copied += data_left;
+ real_pos += data_left;
+ }
+ else {
+ memcpy(buf + copied, container->real_data + start_in_buf, count - copied);
+ return true;
+ }
- blf_add_logcontainer(params->blf_data, tmp);
+ }
- break;
- default:
- ws_debug("we found a non BLF log container on top level. this is unexpected.");
+ /*
+ * XXX - does this represent a bug (WTAP_ERR_INTERNAL) or a
+ * malformed file (WTAP_ERR_BAD_FILE)?
+ */
+ *err = WTAP_ERR_INTERNAL;
+ *err_info = ws_strdup_printf("blf_read_bytes_or_eof: ran out of containers");
+ return false;
+}
- /* TODO: maybe create "fake Log Container" for this */
- if (file_seek(params->fh, current_start_pos + MAX(MAX(16, header.object_length), header.header_length), SEEK_SET, err) < 0) {
- return FALSE;
- }
+static bool
+blf_read_bytes(blf_params_t *params, uint64_t real_pos, void *target_buffer, uint64_t count, int *err, char **err_info) {
+ if (!blf_read_bytes_or_eof(params, real_pos, target_buffer, count, err, err_info)) {
+ if (*err == 0) {
+ *err = WTAP_ERR_SHORT_READ;
}
+ return false;
}
-
- return TRUE;
+ return true;
}
static void
-blf_init_rec(blf_params_t *params, guint32 flags, guint64 object_timestamp, int pkt_encap, guint16 channel, guint16 hwchannel, guint caplen, guint len) {
+blf_init_rec(blf_params_t *params, uint32_t flags, uint64_t object_timestamp, int pkt_encap, uint16_t channel, uint16_t hwchannel, unsigned caplen, unsigned len) {
params->rec->rec_type = REC_TYPE_PACKET;
params->rec->block = wtap_block_create(WTAP_BLOCK_PACKET);
- params->rec->presence_flags = WTAP_HAS_TS | WTAP_HAS_CAP_LEN | WTAP_HAS_INTERFACE_ID;
+ params->rec->presence_flags = WTAP_HAS_CAP_LEN | WTAP_HAS_INTERFACE_ID;
+ params->rec->ts_rel_cap_valid = false;
switch (flags) {
case BLF_TIMESTAMP_RESOLUTION_10US:
+ params->rec->presence_flags |= WTAP_HAS_TS;
params->rec->tsprec = WTAP_TSPREC_10_USEC;
object_timestamp *= 10000;
object_timestamp += params->blf_data->start_offset_ns;
+ params->rec->ts_rel_cap_valid = true;
break;
case BLF_TIMESTAMP_RESOLUTION_1NS:
+ params->rec->presence_flags |= WTAP_HAS_TS;
params->rec->tsprec = WTAP_TSPREC_NSEC;
object_timestamp += params->blf_data->start_offset_ns;
+ params->rec->ts_rel_cap_valid = true;
break;
default:
- if (flags == 0 && object_timestamp == 0) {
- /* This is not an error, but is used for metadata at the beginning of the file. */
- params->rec->tsprec = WTAP_TSPREC_NSEC;
- object_timestamp = params->blf_data->start_offset_ns;
- }
- else {
+ /* Metadata objects have both flags and timestamp equal to zero, so that combination is not an error. */
+ if (flags != 0 || object_timestamp != 0) {
/*
* XXX - report this as an error?
*
* Or provide a mechanism to allow file readers to report
* a warning (an error that the reader tries to work
* around and that the caller should report)?
- *
- * Set the timestamp to params->blf_data->start_offset_ns also here?
*/
ws_debug("Unknown combination of flags and timestamp (0x%x, %" PRIu64 ")", flags, object_timestamp);
- params->rec->tsprec = WTAP_TSPREC_NSEC;
object_timestamp = 0;
}
break;
@@ -1041,7 +1307,6 @@ blf_init_rec(blf_params_t *params, guint32 flags, guint64 object_timestamp, int
tmp_ts.secs = params->blf_data->start_offset_ns / (1000 * 1000 * 1000);
tmp_ts.nsecs = params->blf_data->start_offset_ns % (1000 * 1000 * 1000);
nstime_delta(&params->rec->ts_rel_cap, &params->rec->ts, &tmp_ts);
- params->rec->ts_rel_cap_valid = true;
params->rec->rec_header.packet_header.pkt_encap = pkt_encap;
params->rec->rec_header.packet_header.interface_id = blf_lookup_interface(params, pkt_encap, channel, hwchannel, NULL);
@@ -1050,8 +1315,8 @@ blf_init_rec(blf_params_t *params, guint32 flags, guint64 object_timestamp, int
}
static void
-blf_add_direction_option(blf_params_t *params, guint16 direction) {
- guint32 tmp = 0; /* dont care */
+blf_add_direction_option(blf_params_t *params, uint16_t direction) {
+ uint32_t tmp = 0; /* dont care */
switch (direction) {
case BLF_DIR_RX:
@@ -1067,73 +1332,73 @@ blf_add_direction_option(blf_params_t *params, guint16 direction) {
wtap_block_add_uint32_option(params->rec->block, 0x0002, tmp);
}
-static gboolean
-blf_read_log_object_header(blf_params_t *params, int *err, gchar **err_info, gint64 header2_start, gint64 data_start, blf_logobjectheader_t *logheader) {
- if (data_start - header2_start < (gint64)sizeof(blf_logobjectheader_t)) {
+static bool
+blf_read_log_object_header(blf_params_t *params, int *err, char **err_info, int64_t header2_start, int64_t data_start, blf_logobjectheader_t *logheader) {
+ if (data_start - header2_start < (int64_t)sizeof(blf_logobjectheader_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: not enough bytes for log object header");
ws_debug("not enough bytes for timestamp header");
- return FALSE;
+ return false;
}
if (!blf_read_bytes_or_eof(params, header2_start, logheader, sizeof(*logheader), err, err_info)) {
ws_debug("not enough bytes for logheader");
- return FALSE;
+ return false;
}
fix_endianness_blf_logobjectheader(logheader);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_log_object_header2(blf_params_t *params, int *err, gchar **err_info, gint64 header2_start, gint64 data_start, blf_logobjectheader2_t *logheader) {
- if (data_start - header2_start < (gint64)sizeof(blf_logobjectheader2_t)) {
+static bool
+blf_read_log_object_header2(blf_params_t *params, int *err, char **err_info, int64_t header2_start, int64_t data_start, blf_logobjectheader2_t *logheader) {
+ if (data_start - header2_start < (int64_t)sizeof(blf_logobjectheader2_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: not enough bytes for log object header");
ws_debug("not enough bytes for timestamp header");
- return FALSE;
+ return false;
}
if (!blf_read_bytes_or_eof(params, header2_start, logheader, sizeof(*logheader), err, err_info)) {
ws_debug("not enough bytes for logheader");
- return FALSE;
+ return false;
}
fix_endianness_blf_logobjectheader2(logheader);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_log_object_header3(blf_params_t *params, int *err, gchar **err_info, gint64 header2_start, gint64 data_start, blf_logobjectheader3_t *logheader) {
- if (data_start - header2_start < (gint64)sizeof(blf_logobjectheader3_t)) {
+static bool
+blf_read_log_object_header3(blf_params_t *params, int *err, char **err_info, int64_t header2_start, int64_t data_start, blf_logobjectheader3_t *logheader) {
+ if (data_start - header2_start < (int64_t)sizeof(blf_logobjectheader3_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: not enough bytes for log object header");
ws_debug("not enough bytes for timestamp header");
- return FALSE;
+ return false;
}
if (!blf_read_bytes_or_eof(params, header2_start, logheader, sizeof(*logheader), err, err_info)) {
ws_debug("not enough bytes for logheader");
- return FALSE;
+ return false;
}
fix_endianness_blf_logobjectheader3(logheader);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_ethernetframe(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_ethernetframe(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_ethernetframeheader_t ethheader;
- guint8 tmpbuf[18];
- guint caplen, len;
+ uint8_t tmpbuf[18];
+ unsigned caplen, len;
if (object_length < (data_start - block_start) + (int) sizeof(blf_ethernetframeheader_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: ETHERNET_FRAME: not enough bytes for ethernet frame header in object");
ws_debug("not enough bytes for ethernet frame header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &ethheader, sizeof(ethheader), err, err_info)) {
ws_debug("not enough bytes for ethernet frame header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_ethernetframeheader(&ethheader);
@@ -1164,45 +1429,46 @@ blf_read_ethernetframe(blf_params_t *params, int *err, gchar **err_info, gint64
tmpbuf[15] = (ethheader.tci & 0x00ff);
tmpbuf[16] = (ethheader.ethtype & 0xff00) >> 8;
tmpbuf[17] = (ethheader.ethtype & 0x00ff);
- ws_buffer_assure_space(params->buf, (gsize)18 + ethheader.payloadlength);
- ws_buffer_append(params->buf, tmpbuf, (gsize)18);
- caplen = ((guint32)18 + ethheader.payloadlength);
- len = ((guint32)18 + ethheader.payloadlength);
+ ws_buffer_assure_space(params->buf, (size_t)18 + ethheader.payloadlength);
+ ws_buffer_append(params->buf, tmpbuf, (size_t)18);
+ caplen = ((uint32_t)18 + ethheader.payloadlength);
+ len = ((uint32_t)18 + ethheader.payloadlength);
} else {
tmpbuf[12] = (ethheader.ethtype & 0xff00) >> 8;
tmpbuf[13] = (ethheader.ethtype & 0x00ff);
- ws_buffer_assure_space(params->buf, (gsize)14 + ethheader.payloadlength);
- ws_buffer_append(params->buf, tmpbuf, (gsize)14);
- caplen = ((guint32)14 + ethheader.payloadlength);
- len = ((guint32)14 + ethheader.payloadlength);
+ ws_buffer_assure_space(params->buf, (size_t)14 + ethheader.payloadlength);
+ ws_buffer_append(params->buf, tmpbuf, (size_t)14);
+ caplen = ((uint32_t)14 + ethheader.payloadlength);
+ len = ((uint32_t)14 + ethheader.payloadlength);
}
if (!blf_read_bytes(params, data_start + sizeof(blf_ethernetframeheader_t), ws_buffer_end_ptr(params->buf), ethheader.payloadlength, err, err_info)) {
ws_debug("copying ethernet frame failed");
- return FALSE;
+ return false;
}
params->buf->first_free += ethheader.payloadlength;
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, UINT16_MAX, caplen, len);
blf_add_direction_option(params, ethheader.direction);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_ethernetframe_ext(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_ethernetframe_ext(blf_params_t *params, int *err, char **err_info, int64_t block_start,int64_t data_start,
+ int64_t object_length, uint32_t flags, uint64_t object_timestamp, gboolean error) {
blf_ethernetframeheader_ex_t ethheader;
if (object_length < (data_start - block_start) + (int) sizeof(blf_ethernetframeheader_ex_t)) {
*err = WTAP_ERR_BAD_FILE;
- *err_info = ws_strdup_printf("blf: ETHERNET_FRAME_EX: not enough bytes for ethernet frame header in object");
+ *err_info = ws_strdup_printf("blf: %s: not enough bytes for ethernet frame header in object", error ? "ETHERNET_ERROR_EX" : "ETHERNET_FRAME_EX");
ws_debug("not enough bytes for ethernet frame header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &ethheader, sizeof(blf_ethernetframeheader_ex_t), err, err_info)) {
ws_debug("not enough bytes for ethernet frame header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_ethernetframeheader_ex(&ethheader);
@@ -1210,40 +1476,89 @@ blf_read_ethernetframe_ext(blf_params_t *params, int *err, gchar **err_info, gin
if (object_length - (data_start - block_start) - sizeof(blf_ethernetframeheader_ex_t) < ethheader.frame_length) {
*err = WTAP_ERR_BAD_FILE;
- *err_info = ws_strdup_printf("blf: ETHERNET_FRAME_EX: frame too short");
+ *err_info = ws_strdup_printf("blf: %s: frame too short", error ? "ETHERNET_ERROR_EX" : "ETHERNET_FRAME_EX");
ws_debug("frame too short");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start + sizeof(blf_ethernetframeheader_ex_t), ws_buffer_start_ptr(params->buf), ethheader.frame_length, err, err_info)) {
ws_debug("copying ethernet frame failed");
- return FALSE;
+ return false;
+ }
+
+ if (ethheader.flags & BLF_ETHERNET_EX_HARDWARECHANNEL) {
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, ethheader.hw_channel, ethheader.frame_length, ethheader.frame_length);
+ wtap_block_add_uint32_option(params->rec->block, OPT_PKT_QUEUE, ethheader.hw_channel);
+ }
+ else {
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, UINT16_MAX, ethheader.frame_length, ethheader.frame_length);
+ }
+
+ blf_add_direction_option(params, ethheader.direction);
+
+ return true;
+}
+
+static bool
+blf_read_ethernet_rxerror(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_ethernet_rxerror_t ethheader;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(blf_ethernet_rxerror_t)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: ETHERNET_RXERROR: not enough bytes for ethernet frame header in object");
+ ws_debug("not enough bytes for ethernet rx error header in object");
+ return false;
}
- blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, ethheader.hw_channel, ethheader.frame_length, ethheader.frame_length);
- wtap_block_add_uint32_option(params->rec->block, OPT_PKT_QUEUE, ethheader.hw_channel);
+ if (!blf_read_bytes(params, data_start, &ethheader, sizeof(blf_ethernet_rxerror_t), err, err_info)) {
+ ws_debug("not enough bytes for ethernet rx error header in file");
+ return false;
+ }
+ fix_endianness_blf_ethernet_rxerror(&ethheader);
+
+ ws_buffer_assure_space(params->buf, ethheader.frame_length);
+
+ if (object_length - (data_start - block_start) < ethheader.frame_length) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: ETHERNET_RXERROR: frame too short");
+ ws_debug("frame too short");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start + sizeof(blf_ethernet_rxerror_t), ws_buffer_start_ptr(params->buf), ethheader.frame_length, err, err_info)) {
+ ws_debug("copying ethernet rx error failed");
+ return false;
+ }
+
+ if (ethheader.hw_channel != 0) { /* In this object type, a value of 0 is considered invalid. */
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, ethheader.hw_channel, ethheader.frame_length, ethheader.frame_length);
+ wtap_block_add_uint32_option(params->rec->block, OPT_PKT_QUEUE, ethheader.hw_channel);
+ }
+ else {
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_ETHERNET, ethheader.channel, UINT16_MAX, ethheader.frame_length, ethheader.frame_length);
+ }
blf_add_direction_option(params, ethheader.direction);
- return TRUE;
+ return true;
}
/*
* XXX - provide radio information to our caller in the pseudo-header.
*/
-static gboolean
-blf_read_wlanframe(blf_params_t* params, int* err, gchar** err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_wlanframe(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_wlanframeheader_t wlanheader;
if (object_length < (data_start - block_start) + (int)sizeof(blf_wlanframeheader_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: WLAN_FRAME: not enough bytes for wlan frame header in object");
ws_debug("not enough bytes for wlan frame header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &wlanheader, sizeof(blf_wlanframeheader_t), err, err_info)) {
ws_debug("not enough bytes for wlan frame header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_wlanframeheader(&wlanheader);
@@ -1253,28 +1568,28 @@ blf_read_wlanframe(blf_params_t* params, int* err, gchar** err_info, gint64 bloc
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: WLAN_FRAME: frame too short");
ws_debug("frame too short");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start + sizeof(blf_wlanframeheader_t), ws_buffer_start_ptr(params->buf), wlanheader.frame_length, err, err_info)) {
ws_debug("copying wlan frame failed");
- return FALSE;
+ return false;
}
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_IEEE_802_11, wlanheader.channel, UINT16_MAX, wlanheader.frame_length, wlanheader.frame_length);
blf_add_direction_option(params, wlanheader.direction);
- return TRUE;
+ return true;
}
-static guint8 can_dlc_to_length[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 8, 8, 8, 8, 8, 8, 8 };
-static guint8 canfd_dlc_to_length[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 12, 16, 20, 24, 32, 48, 64 };
+static uint8_t can_dlc_to_length[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 8, 8, 8, 8, 8, 8, 8 };
+static uint8_t canfd_dlc_to_length[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 12, 16, 20, 24, 32, 48, 64 };
-static gboolean
-blf_can_fill_buf_and_rec(blf_params_t *params, int *err, gchar **err_info, guint32 canid, guint8 payload_length, guint8 payload_length_valid, guint64 start_position,
- guint32 flags, guint64 object_timestamp, guint16 channel, guint8 canfd_flags) {
- guint8 tmpbuf[8];
- guint caplen, len;
+static bool
+blf_can_fill_buf_and_rec(blf_params_t *params, int *err, char **err_info, uint32_t canid, uint8_t payload_length, uint8_t payload_length_valid, uint64_t start_position,
+ uint32_t flags, uint64_t object_timestamp, uint16_t channel, uint8_t canfd_flags) {
+ uint8_t tmpbuf[8];
+ unsigned caplen, len;
tmpbuf[0] = (canid & 0xff000000) >> 24;
tmpbuf[1] = (canid & 0x00ff0000) >> 16;
@@ -1292,34 +1607,34 @@ blf_can_fill_buf_and_rec(blf_params_t *params, int *err, gchar **err_info, guint
if (payload_length_valid > 0 && !blf_read_bytes(params, start_position, ws_buffer_end_ptr(params->buf), payload_length_valid, err, err_info)) {
ws_debug("copying can payload failed");
- return FALSE;
+ return false;
}
params->buf->first_free += payload_length_valid;
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_SOCKETCAN, channel, UINT16_MAX, caplen, len);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canmessage(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp, gboolean can_message2) {
+static bool
+blf_read_canmessage(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, bool can_message2) {
blf_canmessage_t canheader;
blf_canmessage2_trailer_t can2trailer;
- guint32 canid;
- guint8 payload_length;
+ uint32_t canid;
+ uint8_t payload_length;
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: %s: not enough bytes for can header in object",
can_message2 ? "CAN_MESSAGE2" : "CAN_MESSAGE");
ws_debug("not enough bytes for can header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for can header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canmessage(&canheader);
@@ -1339,7 +1654,7 @@ blf_read_canmessage(blf_params_t *params, int *err, gchar **err_info, gint64 blo
}
if (!blf_can_fill_buf_and_rec(params, err, err_info, canid, payload_length, payload_length, data_start + sizeof(canheader), flags, object_timestamp, canheader.channel, 0)) {
- return FALSE;
+ return false;
}
/* actually, we do not really need the data, right now.... */
@@ -1348,40 +1663,40 @@ blf_read_canmessage(blf_params_t *params, int *err, gchar **err_info, gint64 blo
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_MESSAGE2: not enough bytes for can message 2 trailer");
ws_debug("not enough bytes for can message 2 trailer");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start + sizeof(canheader) + 8, &can2trailer, sizeof(can2trailer), err, err_info)) {
ws_debug("not enough bytes for can message 2 trailer in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canmessage2_trailer(&can2trailer);
}
blf_add_direction_option(params, (canheader.flags & BLF_CANMESSAGE_FLAG_TX) == BLF_CANMESSAGE_FLAG_TX ? BLF_DIR_TX: BLF_DIR_RX);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canfdmessage(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_canfdmessage(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_canfdmessage_t canheader;
- gboolean canfd;
- guint32 canid;
- guint8 payload_length;
- guint8 payload_length_valid;
- guint8 canfd_flags;
+ bool canfd;
+ uint32_t canid;
+ uint8_t payload_length;
+ uint8_t payload_length_valid;
+ uint8_t canfd_flags;
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_FD_MESSAGE: not enough bytes for canfd header in object");
ws_debug("not enough bytes for canfd header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for canfd header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canfdmessage(&canheader);
@@ -1415,38 +1730,38 @@ blf_read_canfdmessage(blf_params_t *params, int *err, gchar **err_info, gint64 b
if (payload_length_valid > object_length - (data_start - block_start) + sizeof(canheader)) {
ws_debug("shortening can payload because buffer is too short!");
- payload_length_valid = (guint8)(object_length - (data_start - block_start));
+ payload_length_valid = (uint8_t)(object_length - (data_start - block_start));
}
if (!blf_can_fill_buf_and_rec(params, err, err_info, canid, payload_length, payload_length_valid, data_start + sizeof(canheader), flags, object_timestamp, canheader.channel, canfd_flags)) {
- return FALSE;
+ return false;
}
blf_add_direction_option(params, (canheader.flags & BLF_CANMESSAGE_FLAG_TX) == BLF_CANMESSAGE_FLAG_TX ? BLF_DIR_TX : BLF_DIR_RX);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canfdmessage64(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_canfdmessage64(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_canfdmessage64_t canheader;
- gboolean canfd;
- guint32 canid;
- guint8 payload_length;
- guint8 payload_length_valid;
- guint8 canfd_flags;
+ bool canfd;
+ uint32_t canid;
+ uint8_t payload_length;
+ uint8_t payload_length_valid;
+ uint8_t canfd_flags;
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_FD_MESSAGE_64: not enough bytes for canfd header in object");
ws_debug("not enough bytes for canfd header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for canfd header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canfdmessage64(&canheader);
@@ -1480,35 +1795,35 @@ blf_read_canfdmessage64(blf_params_t *params, int *err, gchar **err_info, gint64
if (payload_length_valid > object_length - (data_start - block_start)) {
ws_debug("shortening can payload because buffer is too short!");
- payload_length_valid = (guint8)(object_length - (data_start - block_start));
+ payload_length_valid = (uint8_t)(object_length - (data_start - block_start));
}
if (!blf_can_fill_buf_and_rec(params, err, err_info, canid, payload_length, payload_length_valid, data_start + sizeof(canheader), flags, object_timestamp, canheader.channel, canfd_flags)) {
- return FALSE;
+ return false;
}
blf_add_direction_option(params, canheader.dir);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canerror(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_canerror(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, bool overload) {
blf_canerror_t canheader;
- guint32 canid;
- guint8 payload_length;
- guint8 tmpbuf[16] = {0};
+ uint32_t canid;
+ uint8_t payload_length;
+ uint8_t tmpbuf[16] = {0};
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_ERROR: not enough bytes for canerror header in object");
ws_debug("not enough bytes for canerror header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for canerror header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canerror(&canheader);
@@ -1518,6 +1833,11 @@ blf_read_canerror(blf_params_t *params, int *err, gchar **err_info, gint64 block
// Fixed packet data length for socketcan error messages
payload_length = CAN_ERR_DLC;
+ if (overload) {
+ tmpbuf[10] = CAN_ERR_PROT_OVERLOAD;
+ canid |= CAN_ERR_PROT;
+ }
+
tmpbuf[0] = (canid & 0xff000000) >> 24;
tmpbuf[1] = (canid & 0x00ff0000) >> 16;
tmpbuf[2] = (canid & 0x0000ff00) >> 8;
@@ -1528,30 +1848,30 @@ blf_read_canerror(blf_params_t *params, int *err, gchar **err_info, gint64 block
ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_SOCKETCAN, canheader.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canerrorext(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_canerrorext(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_canerrorext_t canheader;
- gboolean err_ack = false;
- gboolean err_prot = false;
- gboolean direction_tx;
- guint32 canid;
- guint8 payload_length;
- guint8 tmpbuf[16] = {0};
+ bool err_ack = false;
+ bool err_prot = false;
+ bool direction_tx;
+ uint32_t canid;
+ uint8_t payload_length;
+ uint8_t tmpbuf[16] = {0};
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_ERROR_EXT: not enough bytes for canerrorext header in object");
ws_debug("not enough bytes for canerrorext header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for canerrorext header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canerrorext(&canheader);
@@ -1617,30 +1937,30 @@ blf_read_canerrorext(blf_params_t *params, int *err, gchar **err_info, gint64 bl
direction_tx = (canheader.errorCodeExt & BLF_CANERROREXT_EXTECC_TX) == BLF_CANERROREXT_EXTECC_TX;
blf_add_direction_option(params, direction_tx ? BLF_DIR_TX: BLF_DIR_RX);
}
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_canfderror64(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_canfderror64(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_canfderror64_t canheader;
- gboolean err_ack = false;
- gboolean err_prot = false;
- gboolean direction_tx;
- guint32 canid;
- guint8 payload_length;
- guint8 tmpbuf[16] = {0};
+ bool err_ack = false;
+ bool err_prot = false;
+ bool direction_tx;
+ uint32_t canid;
+ uint8_t payload_length;
+ uint8_t tmpbuf[16] = {0};
if (object_length < (data_start - block_start) + (int) sizeof(canheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: CAN_FD_ERROR_64: not enough bytes for canfderror header in object");
ws_debug("not enough bytes for canfderror header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &canheader, sizeof(canheader), err, err_info)) {
ws_debug("not enough bytes for canfderror header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_canfderror64(&canheader);
@@ -1707,28 +2027,28 @@ blf_read_canfderror64(blf_params_t *params, int *err, gchar **err_info, gint64 b
direction_tx = (canheader.errorCodeExt & BLF_CANERROREXT_EXTECC_TX) == BLF_CANERROREXT_EXTECC_TX;
blf_add_direction_option(params, direction_tx ? BLF_DIR_TX: BLF_DIR_RX);
}
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_flexraydata(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_flexraydata(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_flexraydata_t frheader;
- guint8 payload_length;
- guint8 payload_length_valid;
- guint8 tmpbuf[7];
- guint caplen, len;
+ uint8_t payload_length;
+ uint8_t payload_length_valid;
+ uint8_t tmpbuf[7];
+ unsigned caplen, len;
if (object_length < (data_start - block_start) + (int) sizeof(frheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: FLEXRAY_DATA: not enough bytes for flexrayheader in object");
ws_debug("not enough bytes for flexrayheader in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &frheader, sizeof(frheader), err, err_info)) {
ws_debug("not enough bytes for flexrayheader header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_flexraydata(&frheader);
@@ -1741,7 +2061,7 @@ blf_read_flexraydata(blf_params_t *params, int *err, gchar **err_info, gint64 bl
if (payload_length_valid > object_length - (data_start - block_start) - sizeof(frheader)) {
ws_debug("shortening FlexRay payload because buffer is too short!");
- payload_length_valid = (guint8)(object_length - (data_start - block_start) - sizeof(frheader));
+ payload_length_valid = (uint8_t)(object_length - (data_start - block_start) - sizeof(frheader));
}
if (frheader.channel != 0 && frheader.channel != 1) {
@@ -1772,35 +2092,35 @@ blf_read_flexraydata(blf_params_t *params, int *err, gchar **err_info, gint64 bl
if (payload_length_valid > 0 && !blf_read_bytes(params, data_start + sizeof(frheader), ws_buffer_end_ptr(params->buf), payload_length_valid, err, err_info)) {
ws_debug("copying flexray payload failed");
- return FALSE;
+ return false;
}
params->buf->first_free += payload_length_valid;
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_FLEXRAY, frheader.channel, UINT16_MAX, caplen, len);
blf_add_direction_option(params, frheader.dir);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_flexraymessage(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_flexraymessage(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
blf_flexraymessage_t frheader;
- guint8 payload_length;
- guint8 payload_length_valid;
- guint8 tmpbuf[7];
- guint caplen, len;
+ uint8_t payload_length;
+ uint8_t payload_length_valid;
+ uint8_t tmpbuf[7];
+ unsigned caplen, len;
if (object_length < (data_start - block_start) + (int) sizeof(frheader)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: FLEXRAY_MESSAGE: not enough bytes for flexrayheader in object");
ws_debug("not enough bytes for flexrayheader in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &frheader, sizeof(frheader), err, err_info)) {
ws_debug("not enough bytes for flexrayheader header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_flexraymessage(&frheader);
@@ -1813,7 +2133,7 @@ blf_read_flexraymessage(blf_params_t *params, int *err, gchar **err_info, gint64
if (payload_length_valid > object_length - (data_start - block_start) - sizeof(frheader)) {
ws_debug("shortening FlexRay payload because buffer is too short!");
- payload_length_valid = (guint8)(object_length - (data_start - block_start) - sizeof(frheader));
+ payload_length_valid = (uint8_t)(object_length - (data_start - block_start) - sizeof(frheader));
}
if (frheader.channel != 0 && frheader.channel != 1) {
@@ -1861,41 +2181,41 @@ blf_read_flexraymessage(blf_params_t *params, int *err, gchar **err_info, gint64
if (payload_length_valid > 0 && !blf_read_bytes(params, data_start + sizeof(frheader), ws_buffer_end_ptr(params->buf), payload_length_valid, err, err_info)) {
ws_debug("copying flexray payload failed");
- return FALSE;
+ return false;
}
params->buf->first_free += payload_length_valid;
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_FLEXRAY, frheader.channel, UINT16_MAX, caplen, len);
blf_add_direction_option(params, frheader.dir);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_flexrayrcvmessageex(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp, gboolean ext) {
+static bool
+blf_read_flexrayrcvmessageex(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, bool ext) {
blf_flexrayrcvmessage_t frheader;
- guint16 payload_length;
- guint16 payload_length_valid;
- guint8 tmpbuf[7];
- gint frheadersize = sizeof(frheader);
- guint caplen, len;
+ uint16_t payload_length;
+ uint16_t payload_length_valid;
+ uint8_t tmpbuf[7];
+ int frheadersize = sizeof(frheader);
+ unsigned caplen, len;
if (ext) {
frheadersize += 40;
}
- if ((gint64)object_length < (data_start - block_start) + frheadersize) {
+ if ((int64_t)object_length < (data_start - block_start) + frheadersize) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: %s: not enough bytes for flexrayheader in object",
ext ? "FLEXRAY_RCVMESSAGE_EX" : "FLEXRAY_RCVMESSAGE");
ws_debug("not enough bytes for flexrayheader in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &frheader, sizeof(frheader), err, err_info)) {
ws_debug("not enough bytes for flexrayheader header in file");
- return FALSE;
+ return false;
}
fix_endianness_blf_flexrayrcvmessage(&frheader);
@@ -1913,7 +2233,7 @@ blf_read_flexrayrcvmessageex(blf_params_t *params, int *err, gchar **err_info, g
if (payload_length_valid > object_length - (data_start - block_start) - frheadersize) {
ws_debug("shortening FlexRay payload because buffer is too short!");
- payload_length_valid = (guint8)(object_length - (data_start - block_start) - frheadersize);
+ payload_length_valid = (uint8_t)(object_length - (data_start - block_start) - frheadersize);
}
/* Measurement Header */
@@ -1958,33 +2278,33 @@ blf_read_flexrayrcvmessageex(blf_params_t *params, int *err, gchar **err_info, g
if (payload_length_valid > 0 && !blf_read_bytes(params, data_start + frheadersize, ws_buffer_end_ptr(params->buf), payload_length_valid, err, err_info)) {
ws_debug("copying flexray payload failed");
- return FALSE;
+ return false;
}
params->buf->first_free += payload_length_valid;
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_FLEXRAY, frheader.channelMask, UINT16_MAX, caplen, len);
blf_add_direction_option(params, frheader.dir);
- return TRUE;
+ return true;
}
-static gboolean
-blf_read_linmessage(blf_params_t* params, int* err, gchar** err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_linmessage(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, bool crc_error) {
blf_linmessage_t linmessage;
- guint8 payload_length;
- guint len;
+ uint8_t payload_length;
+ unsigned len;
if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
*err = WTAP_ERR_BAD_FILE;
- *err_info = ws_strdup_printf("blf: LIN_MESSAGE: not enough bytes for linmessage in object");
- ws_debug("not enough bytes for linmessage in object");
- return FALSE;
+ *err_info = ws_strdup_printf("blf: %s: not enough bytes for %s in object", crc_error ? "LIN_CRC_ERROR" : "LIN_MESSAGE", crc_error ? "lincrcerror" : "linmessage");
+ ws_debug("not enough bytes for %s in object", crc_error ? "lincrcerror" : "linmessage");
+ return false;
}
if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
- ws_debug("not enough bytes for linmessage in file");
- return FALSE;
+ ws_debug("not enough bytes for %s in file", crc_error ? "lincrcerror" : "linmessage");
+ return false;
}
fix_endianness_blf_linmessage(&linmessage);
@@ -1993,16 +2313,20 @@ blf_read_linmessage(blf_params_t* params, int* err, gchar** err_info, gint64 blo
payload_length = MIN(linmessage.dlc, 8);
- guint8 tmpbuf[8];
+ uint8_t tmpbuf[8];
tmpbuf[0] = 1; /* message format rev = 1 */
tmpbuf[1] = 0; /* reserved */
tmpbuf[2] = 0; /* reserved */
tmpbuf[3] = 0; /* reserved */
- tmpbuf[4] = (linmessage.dlc << 4) | 0; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
- tmpbuf[5] = linmessage.id; /* parity (2bit) | id (6bit) */
- tmpbuf[6] = (guint8)(linmessage.crc & 0xff); /* checksum */
+ tmpbuf[4] = linmessage.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = linmessage.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = (uint8_t)(linmessage.crc & 0xff); /* checksum */
tmpbuf[7] = 0; /* errors */
+ if (crc_error) {
+ tmpbuf[7] |= 0x08;
+ }
+
ws_buffer_assure_space(params->buf, sizeof(tmpbuf) + payload_length);
ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
ws_buffer_append(params->buf, linmessage.data, payload_length);
@@ -2011,11 +2335,879 @@ blf_read_linmessage(blf_params_t* params, int* err, gchar** err_info, gint64 blo
blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.channel, UINT16_MAX, len, len);
blf_add_direction_option(params, linmessage.dir);
- return TRUE;
+ return true;
+}
+
+static bool
+blf_read_linrcverror(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_linrcverror_t linmessage;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_RCV_ERROR: not enough bytes for linrcverror in object");
+ ws_debug("not enough bytes for linrcverror in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for linrcverror in file");
+ return false;
+ }
+ linmessage.channel = GUINT16_FROM_LE(linmessage.channel);
+
+ linmessage.dlc &= 0x0f;
+ linmessage.id &= 0x3f;
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = linmessage.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ /* XXX - This object can represent many different error types.
+ * For now we always treat it as framing error,
+ * but in the future we should expand it. */
+ tmpbuf[7] = 0x02; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+static bool
+blf_read_linsenderror(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_linsenderror_t linmessage;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_SND_ERROR: not enough bytes for linsenderror in object");
+ ws_debug("not enough bytes for linsenderror in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for linsenderror in file");
+ return false;
+ }
+ linmessage.channel = GUINT16_FROM_LE(linmessage.channel);
+
+ linmessage.dlc &= 0x0f;
+ linmessage.id &= 0x3f;
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = linmessage.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ tmpbuf[7] = 0x01; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+static bool
+blf_read_linwakeupevent(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_linwakeupevent_t linevent;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linevent)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_WAKEUP: not enough bytes for linwakeup in object");
+ ws_debug("not enough bytes for linwakeup in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linevent, sizeof(linevent), err, err_info)) {
+ ws_debug("not enough bytes for linwakeup in file");
+ return false;
+ }
+ linevent.channel = GUINT16_FROM_LE(linevent.channel);
+
+ uint8_t tmpbuf[12]; /* LIN events have a fixed length of 12 bytes */
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = 3 << 2; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = 0; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ tmpbuf[7] = 0; /* errors */
+
+ /* Wake-up event */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x04;
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linevent.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+static bool
+blf_read_linmessage2(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, uint16_t object_version) {
+ blf_linmessage2_t linmessage;
+
+ uint8_t payload_length;
+ unsigned len;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_MESSAGE2: not enough bytes for linmessage2 in object");
+ ws_debug("not enough bytes for linmessage2 in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for linmessage2 in file");
+ return false;
+ }
+ fix_endianness_blf_linmessage2(&linmessage);
+
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc &= 0x0f;
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.id &= 0x3f;
+
+ payload_length = MIN(linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc, 8);
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ if (object_version >= 1) { /* The 'checksumModel' field is valid only if objectVersion >= 1 */
+ switch (linmessage.linDataByteTimestampEvent.linMessageDescriptor.checksumModel) {
+ case 0:
+ tmpbuf[4] |= 1; /* Classic */
+ break;
+ case 1:
+ tmpbuf[4] |= 2; /* Enhanced */
+ break;
+ default:
+ break;
+ }
+ }
+ tmpbuf[5] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = (uint8_t)(linmessage.crc & 0xff); /* checksum */
+ tmpbuf[7] = 0; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf) + payload_length);
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, linmessage.data, payload_length);
+ len = sizeof(tmpbuf) + payload_length;
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.linDataByteTimestampEvent.linMessageDescriptor.linSynchFieldEvent.linBusEvent.channel, UINT16_MAX, len, len);
+ blf_add_direction_option(params, linmessage.dir);
+
+ return true;
+}
+
+static bool
+blf_read_lincrcerror2(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, uint16_t object_version) {
+ blf_lincrcerror2_t linmessage;
+
+ uint8_t payload_length;
+ unsigned len;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_CRC_ERROR2: not enough bytes for lincrcerror2 in object");
+ ws_debug("not enough bytes for lincrcerror2 in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for lincrcerror2 in file");
+ return false;
+ }
+ fix_endianness_blf_lincrcerror2(&linmessage);
+
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc &= 0x0f;
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.id &= 0x3f;
+
+ payload_length = MIN(linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc, 8);
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ if (object_version >= 1) { /* The 'checksumModel' field is valid only if objectVersion >= 1 */
+ switch (linmessage.linDataByteTimestampEvent.linMessageDescriptor.checksumModel) {
+ case 0:
+ tmpbuf[4] |= 1; /* Classic */
+ break;
+ case 1:
+ tmpbuf[4] |= 2; /* Enhanced */
+ break;
+ default:
+ break;
+ }
+ }
+ tmpbuf[5] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = (uint8_t)(linmessage.crc & 0xff); /* checksum */
+ tmpbuf[7] = 0x08; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf) + payload_length);
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, linmessage.data, payload_length);
+ len = sizeof(tmpbuf) + payload_length;
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.linDataByteTimestampEvent.linMessageDescriptor.linSynchFieldEvent.linBusEvent.channel, UINT16_MAX, len, len);
+ blf_add_direction_option(params, linmessage.dir);
+
+ return true;
+}
+
+static bool
+blf_read_linrcverror2(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, uint16_t object_version) {
+ blf_linrcverror2_t linmessage;
+
+ uint8_t payload_length;
+ unsigned len;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_RCV_ERROR2: not enough bytes for linrcverror2 in object");
+ ws_debug("not enough bytes for linrcverror2 in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for linrcverror2 in file");
+ return false;
+ }
+ fix_endianness_blf_linrcverror2(&linmessage);
+
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc &= 0x0f;
+ linmessage.linDataByteTimestampEvent.linMessageDescriptor.id &= 0x3f;
+
+ if (linmessage.hasDataBytes) {
+ payload_length = MIN(linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc, 8);
+ }
+ else {
+ payload_length = 0;
+ }
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ if (object_version >= 1) { /* The 'checksumModel' field is valid only if objectVersion >= 1 */
+ switch (linmessage.linDataByteTimestampEvent.linMessageDescriptor.checksumModel) {
+ case 0:
+ tmpbuf[4] |= 1; /* Classic */
+ break;
+ case 1:
+ tmpbuf[4] |= 2; /* Enhanced */
+ break;
+ default:
+ break;
+ }
+ }
+ tmpbuf[5] = linmessage.linDataByteTimestampEvent.linMessageDescriptor.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ /* XXX - This object can represent many different error types.
+ * For now we always treat it as framing error,
+ * but in the future we should expand it. */
+ tmpbuf[7] = 0x02; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf) + payload_length);
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+ if (payload_length > 0) {
+ ws_buffer_append(params->buf, linmessage.data, payload_length);
+ }
+ len = sizeof(tmpbuf) + payload_length;
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.linDataByteTimestampEvent.linMessageDescriptor.linSynchFieldEvent.linBusEvent.channel, UINT16_MAX, len, len);
+
+ return true;
+}
+
+static bool
+blf_read_linsenderror2(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, uint16_t object_version) {
+ blf_linsenderror2_t linmessage;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linmessage)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_SND_ERROR2: not enough bytes for linsenderror2 in object");
+ ws_debug("not enough bytes for linsenderror2 in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linmessage, sizeof(linmessage), err, err_info)) {
+ ws_debug("not enough bytes for linsenderror2 in file");
+ return false;
+ }
+ fix_endianness_blf_linsenderror2(&linmessage);
+
+ linmessage.linMessageDescriptor.dlc &= 0x0f;
+ linmessage.linMessageDescriptor.id &= 0x3f;
+
+ uint8_t tmpbuf[8];
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = linmessage.linMessageDescriptor.dlc << 4; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ if (object_version >= 1) { /* The 'checksumModel' field is valid only if objectVersion >= 1 */
+ switch (linmessage.linMessageDescriptor.checksumModel) {
+ case 0:
+ tmpbuf[4] |= 1; /* Classic */
+ break;
+ case 1:
+ tmpbuf[4] |= 2; /* Enhanced */
+ break;
+ default:
+ break;
+ }
+ }
+ tmpbuf[5] = linmessage.linMessageDescriptor.id; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ tmpbuf[7] = 0x01; /* errors */
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linmessage.linMessageDescriptor.linSynchFieldEvent.linBusEvent.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+static bool
+blf_read_linwakeupevent2(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_linwakeupevent2_t linevent;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linevent)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_WAKEUP2: not enough bytes for linwakeup2 in object");
+ ws_debug("not enough bytes for linwakeup2 in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linevent, sizeof(linevent), err, err_info)) {
+ ws_debug("not enough bytes for linwakeup2 in file");
+ return false;
+ }
+ fix_endianness_blf_linwakeupevent2(&linevent);
+
+ uint8_t tmpbuf[12]; /* LIN events have a fixed length of 12 bytes */
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = 3 << 2; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = 0; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ tmpbuf[7] = 0; /* errors */
+
+ /* Wake-up event */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x04;
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linevent.linBusEvent.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+static bool
+blf_read_linsleepmodeevent(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_linsleepmodeevent_t linevent;
+
+ if (object_length < (data_start - block_start) + (int)sizeof(linevent)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: LIN_SLEEP: not enough bytes for linsleep in object");
+ ws_debug("not enough bytes for linsleep in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &linevent, sizeof(linevent), err, err_info)) {
+ ws_debug("not enough bytes for linsleep in file");
+ return false;
+ }
+ linevent.channel = GUINT16_FROM_LE(linevent.channel);
+
+ uint8_t tmpbuf[12]; /* LIN events have a fixed length of 12 bytes */
+ tmpbuf[0] = 1; /* message format rev = 1 */
+ tmpbuf[1] = 0; /* reserved */
+ tmpbuf[2] = 0; /* reserved */
+ tmpbuf[3] = 0; /* reserved */
+ tmpbuf[4] = 3 << 2; /* dlc (4bit) | type (2bit) | checksum type (2bit) */
+ tmpbuf[5] = 0; /* parity (2bit) | id (6bit) */
+ tmpbuf[6] = 0; /* checksum */
+ tmpbuf[7] = 0; /* errors */
+
+ switch (linevent.reason) {
+ case BLF_LIN_SLEEP_REASON_GO_TO_SLEEP_FRAME:
+ /* Go-to-Sleep event by Go-to-Sleep frame */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x01;
+ break;
+ case BLF_LIN_SLEEP_REASON_BUS_IDLE_TIMEOUT:
+ case BLF_LIN_SLEEP_REASON_SILENT_SLEEPMODE_CMD:
+ /* Go-to-Sleep event by Inactivity for more than 4s */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x02;
+ break;
+ case BLF_LIN_WU_REASON_EXTERNAL_WAKEUP_SIG:
+ case BLF_LIN_WU_REASON_INTERNAL_WAKEUP_SIG:
+ case BLF_LIN_WU_REASON_BUS_TRAFFIC: /* There's no "wake-up by bus traffic" event in the LIN packet. */
+ /* Wake-up event by Wake-up signal */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x04;
+ break;
+ case BLF_LIN_WU_SLEEP_REASON_START_STATE:
+ case BLF_LIN_NO_SLEEP_REASON_BUS_TRAFFIC:
+ /* If we're just reporting on the initial state,
+ * or the interface doesn't want to go to sleep,
+ * report the current state as "event". */
+ if (linevent.flags & 0x2) {
+ /* Wake-up event by Wake-up signal */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x04;
+ }
+ else {
+ /* Go-to-Sleep event by Inactivity for more than 4s */
+ tmpbuf[8] = 0xB0;
+ tmpbuf[9] = 0xB0;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x02;
+ }
+ break;
+ default:
+ tmpbuf[8] = 0x00;
+ tmpbuf[9] = 0x00;
+ tmpbuf[10] = 0x00;
+ tmpbuf[11] = 0x00;
+ break;
+ }
+
+ ws_buffer_assure_space(params->buf, sizeof(tmpbuf));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(tmpbuf));
+
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_LIN, linevent.channel, UINT16_MAX, sizeof(tmpbuf), sizeof(tmpbuf));
+
+ return true;
+}
+
+uint16_t blf_get_xml_channel_number(const char* start, const char* end) {
+ char* text;
+ size_t len;
+ uint16_t res;
+
+ if (start == NULL || end == NULL || end <= start) {
+ return UINT16_MAX;
+ }
+
+ len = (size_t)(end - start);
+ text = g_try_malloc(len + 1); /* Accommodate '\0' */
+ if (text == NULL) {
+ ws_debug("cannot allocate memory");
+ return UINT16_MAX;
+ }
+ memcpy(text, start, len);
+ text[len] = '\0';
+
+ if (!ws_strtou16(text, NULL, &res)) {
+ res = UINT16_MAX;
+ }
+
+ g_free(text);
+ return res;
+}
+
+char* blf_get_xml_channel_name(const char* start, const char* end) {
+ char* text;
+ size_t len;
+
+ if (start == NULL || end == NULL || end <= start) {
+ return NULL;
+ }
+
+ len = (size_t)(end - start);
+ text = g_try_malloc(len + 1); /* Accommodate '\0' */
+ if (text == NULL) {
+ ws_debug("cannot allocate memory");
+ return NULL;
+ }
+ memcpy(text, start, len);
+ text[len] = '\0';
+
+ return text;
+}
+
+bool blf_parse_xml_port(const char* start, const char* end, char** name, uint16_t* hwchannel, bool* simulated) {
+ static const char name_magic[] = "name=";
+ static const char hwchannel_magic[] = "hwchannel=";
+ static const char simulated_magic[] = "simulated=";
+
+ char* text;
+ size_t len;
+ char** tokens;
+ char* token;
+
+ if (start == NULL || end == NULL || name == NULL || end <= start) {
+ return false;
+ }
+
+ len = (size_t)(end - start);
+ text = g_try_malloc(len + 1); /* Accommodate '\0' */
+ if (text == NULL) {
+ ws_debug("cannot allocate memory");
+ return false;
+ }
+ memcpy(text, start, len);
+ text[len] = '\0';
+
+ tokens = g_strsplit_set(text, ";", -1);
+ g_free(text);
+ if (tokens == NULL) {
+ ws_debug("cannot split XML port data");
+ return false;
+ }
+
+ *name = NULL;
+ *hwchannel = UINT16_MAX;
+ *simulated = false;
+
+ for (int i = 0; tokens[i] != NULL; i++) {
+ token = tokens[i];
+ if (strncmp(token, name_magic, strlen(name_magic)) == 0) {
+ if (*name == NULL) { /* Avoid memory leak in case of malformed string */
+ *name = ws_strdup(token + strlen(name_magic));
+ }
+ }
+ else if (strncmp(token, hwchannel_magic, strlen(hwchannel_magic)) == 0) {
+ if (!ws_strtou16(token + strlen(hwchannel_magic), NULL, hwchannel)) {
+ *hwchannel = UINT16_MAX;
+ }
+ }
+ else if (strncmp(token, simulated_magic, strlen(simulated_magic)) == 0) {
+ if (strlen(token) > strlen(simulated_magic) && token[strlen(simulated_magic)] != '0') {
+ *simulated = true; /* TODO: Find a way to use this information */
+ }
+ }
+ }
+
+ g_strfreev(tokens);
+
+ return true;
+}
+
+int blf_get_xml_pkt_encap(const char* start, const char* end) {
+ size_t len;
+
+ if (start == NULL || end == NULL || end <= start) {
+ return 0;
+ }
+
+ len = (size_t)(end - start);
+
+ if (strncmp(start, "CAN", len) == 0) {
+ return WTAP_ENCAP_SOCKETCAN;
+ }
+ if (strncmp(start, "FlexRay", len) == 0) {
+ return WTAP_ENCAP_FLEXRAY;
+ }
+ if (strncmp(start, "LIN", len) == 0) {
+ return WTAP_ENCAP_LIN;
+ }
+ if (strncmp(start, "Ethernet", len) == 0) {
+ return WTAP_ENCAP_ETHERNET;
+ }
+ if (strncmp(start, "WLAN", len) == 0) { /* Not confirmed with a real capture */
+ return WTAP_ENCAP_IEEE_802_11;
+ }
+
+ return 0xffffffff;
+}
+
+/** Finds a NULL-terminated string in a block of memory.
+ *
+ * 'start' points to the first byte of the block of memory.
+ * 'end' points to the first byte after the end of the block of memory,
+ * so that the size of the block is end-start.
+ * 'str' is a NULL-terminated string.
+ */
+const char* blf_strmem(const char* start, const char* end, const char* str) {
+ if (start == NULL || end == NULL || str == NULL || end <= start) {
+ return NULL;
+ }
+
+ return ws_memmem(start, end - start, str, strlen(str));
+}
+
+/** Extracts the channel and port names from a channels XML.
+ *
+ * A sample channels XML looks like this:
+ *
+ * <?xml version="1.0" encoding="UTF-8"?>
+ * <channels version="1">
+ * <channel number="1" type="CAN" network="CAN01">
+ * <databases>
+ * <database file="DB.arxml" path="C:\...\" cluster="CAN01" />
+ * <database file="DB.dbc" path="C:\...\" cluster="General" />
+ * </databases>
+ * </channel>
+ * <channel number="1" type="LIN" network="LIN01">
+ * <databases>
+ * <database file="DB.dbc" path="C:\...\" cluster="General" />
+ * <database file="DB.ldf" path="C:\...\" cluster="LIN01" />
+ * </databases>
+ * </channel>
+ * <channel number="1" type="Ethernet" network="ETH01">
+ * <databases>
+ * <database file="DB.dbc" path="C:\...\" cluster="General" />
+ * </databases>
+ * <channel_properties>
+ * <elist name="ports">
+ * <eli name="port">name=Port1;hwchannel=11;simulated=1</eli>
+ * <eli name="port">name=Port2;hwchannel=12;simulated=0</eli>
+ * </elist>
+ * </channel_properties>
+ * </channel>
+ * </channels>
+ */
+static bool
+blf_set_xml_channels(blf_params_t* params, const char* text, size_t len) {
+ static const char xml_magic[] = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>";
+ static const char channels_start_magic[] = "<channels ";
+ static const char channels_end_magic[] = "</channels>";
+ static const char channel_start_magic[] = "<channel ";
+ static const char channel_end_magic[] = "</channel>";
+ static const char number_start_magic[] = "number=\"";
+ static const char number_end_magic[] = "\"";
+ static const char type_start_magic[] = "type=\"";
+ static const char type_end_magic[] = "\"";
+ static const char network_start_magic[] = "network=\"";
+ static const char network_end_magic[] = "\"";
+ static const char ports_start_magic[] = "<elist name=\"ports\">";
+ static const char ports_end_magic[] = "</elist>";
+ static const char port_start_magic[] = "<eli name=\"port\">";
+ static const char port_end_magic[] = "</eli>";
+
+ const char* xml_start;
+ const char* channels_start;
+ const char* channels_end;
+ const char* channel_start;
+ const char* channel_end;
+ const char* number_start;
+ const char* number_end;
+ const char* type_start;
+ const char* type_end;
+ const char* network_start;
+ const char* network_end;
+ const char* ports_start;
+ const char* ports_end;
+ const char* port_start;
+ const char* port_end;
+
+ const char* search_start;
+ bool res;
+
+ int pkt_encap;
+ uint16_t channel;
+ uint16_t hwchannel = UINT16_MAX;
+ char* channel_name = NULL;
+ char* port_name = NULL;
+ bool simulated = false;
+ char* iface_name = NULL;
+
+ if (text == NULL || len < strlen(xml_magic)) {
+ return false;
+ }
+
+ xml_start = blf_strmem(text, text + len, xml_magic);
+ if (xml_start == NULL) {
+ ws_debug("no valid xml magic found");
+ return false;
+ }
+ search_start = xml_start + strlen(xml_magic);
+
+ channels_start = blf_strmem(search_start, text + len, channels_start_magic);
+ channels_end = blf_strmem(search_start, text + len, channels_end_magic);
+ if (channels_start == NULL || channels_end == NULL || channels_end <= channels_start + strlen(channels_start_magic)) {
+ ws_debug("no channels tag found in xml");
+ return false;
+ }
+ search_start = channels_start + strlen(channels_start_magic);
+
+ while (search_start < channels_end) {
+ channel_start = blf_strmem(search_start, channels_end, channel_start_magic);
+ search_start = search_start + strlen(channel_start_magic);
+ channel_end = blf_strmem(search_start, channels_end, channel_end_magic);
+ if (channel_start == NULL || channel_end == NULL || channel_end <= channel_start + strlen(channel_start_magic)) {
+ ws_debug("found end of channel list");
+ return true;
+ }
+
+ number_start = blf_strmem(channel_start, channel_end, number_start_magic);
+ if (number_start == NULL) {
+ ws_debug("channel without number found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ number_end = blf_strmem(number_start + strlen(number_start_magic), channel_end, number_end_magic);
+ if (number_end == NULL) {
+ ws_debug("channel with malformed number attribute found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ channel = blf_get_xml_channel_number(number_start + strlen(number_start_magic), number_end);
+ if (channel == UINT16_MAX) {
+ ws_debug("invalid channel number found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ type_start = blf_strmem(channel_start, channel_end, type_start_magic);
+ if (type_start == NULL) {
+ ws_debug("channel without type found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ type_end = blf_strmem(type_start + strlen(type_start_magic), channel_end, type_end_magic);
+ if (type_end == NULL) {
+ ws_debug("channel with malformed type attribute found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ pkt_encap = blf_get_xml_pkt_encap(type_start + strlen(type_start_magic), type_end);
+
+ network_start = blf_strmem(channel_start, channel_end, network_start_magic);
+ if (network_start == NULL) {
+ ws_debug("channel without name found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ network_end = blf_strmem(network_start + strlen(network_start_magic), channel_end, network_end_magic);
+ if (network_end == NULL) {
+ ws_debug("channel with malformed network attribute found in xml");
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ channel_name = blf_get_xml_channel_name(network_start + strlen(network_start_magic), network_end);
+ if (channel_name == NULL || strlen(channel_name) == 0) {
+ ws_debug("channel with empty name found in xml");
+ if (channel_name) {
+ g_free(channel_name);
+ channel_name = NULL;
+ }
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ ws_debug("Found channel in XML: PKT_ENCAP: %d, ID: %u, name: %s", pkt_encap, channel, channel_name);
+ blf_prepare_interface_name(params, pkt_encap, channel, UINT16_MAX, channel_name, true);
+
+ search_start = MAX(MAX(number_end + strlen(number_end_magic), type_end + strlen(type_end_magic)), network_end + strlen(network_end_magic));
+
+ ports_start = blf_strmem(search_start, channel_end, ports_start_magic);
+ if (ports_start == NULL) {
+ /* Not an error, channel has no ports */
+ if (channel_name) {
+ g_free(channel_name);
+ channel_name = NULL;
+ }
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ search_start = ports_start + strlen(ports_start_magic);
+
+ ports_end = blf_strmem(search_start, channel_end, ports_end_magic);
+ if (ports_end == NULL) {
+ ws_debug("channel with malformed ports tag found in xml");
+ if (channel_name) {
+ g_free(channel_name);
+ channel_name = NULL;
+ }
+ search_start = channel_end + strlen(channel_end_magic);
+ continue;
+ }
+
+ while (search_start < ports_end) {
+ port_start = blf_strmem(search_start, ports_end, port_start_magic);
+ port_end = blf_strmem(search_start + strlen(port_start_magic), ports_end, port_end_magic);
+ if (port_start == NULL || port_end == NULL || port_end <= port_start + strlen(port_start_magic)) {
+ ws_debug("found end of ports list");
+ search_start = ports_end + strlen(ports_end_magic);
+ continue;
+ }
+
+ res = blf_parse_xml_port(port_start + strlen(port_start_magic), port_end, &port_name, &hwchannel, &simulated);
+ if (!res || port_name == NULL || hwchannel == UINT16_MAX) {
+ if (port_name) {
+ g_free(port_name);
+ port_name = NULL;
+ }
+ ws_debug("port with missing or malformed info found in xml");
+ search_start = port_end + strlen(port_end_magic);
+ continue;
+ }
+
+ iface_name = ws_strdup_printf("%s::%s", channel_name, port_name);
+ ws_debug("Found channel in XML: PKT_ENCAP: %d, ID: %u, HW ID: %u, name: %s", pkt_encap, channel, hwchannel, iface_name);
+ blf_prepare_interface_name(params, pkt_encap, channel, hwchannel, iface_name, true);
+ g_free(iface_name);
+
+ if (port_name) {
+ g_free(port_name);
+ port_name = NULL;
+ }
+
+ search_start = port_end + strlen(port_end_magic);
+ }
+
+ if (channel_name) {
+ g_free(channel_name);
+ channel_name = NULL;
+ }
+
+ search_start = channel_end + strlen(channel_end_magic);
+ }
+
+ return true;
}
static int
-blf_read_apptextmessage(blf_params_t *params, int *err, gchar **err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+blf_read_apptextmessage(blf_params_t *params, int *err, char **err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, size_t metadata_cont) {
blf_apptext_t apptextheader;
if (object_length < (data_start - block_start) + (int)sizeof(apptextheader)) {
@@ -2031,8 +3223,16 @@ blf_read_apptextmessage(blf_params_t *params, int *err, gchar **err_info, gint64
}
fix_endianness_blf_apptext_header(&apptextheader);
+ if (metadata_cont && apptextheader.source != BLF_APPTEXT_METADATA) {
+ /* If we're in the middle of a sequence of metadata objects,
+ * but we get an AppText object from another source,
+ * skip the previously incomplete object and start fresh.
+ */
+ metadata_cont = 0;
+ }
+
/* Add an extra byte for a terminating '\0' */
- gchar* text = g_try_malloc((gsize)apptextheader.textLength + 1);
+ char* text = g_try_malloc((size_t)apptextheader.textLength + 1);
if (!blf_read_bytes(params, data_start + sizeof(apptextheader), text, apptextheader.textLength, err, err_info)) {
ws_debug("not enough bytes for apptext text in file");
@@ -2046,7 +3246,7 @@ blf_read_apptextmessage(blf_params_t *params, int *err, gchar **err_info, gint64
{
/* returns a NULL terminated array of NULL terminates strings */
- gchar** tokens = g_strsplit_set(text, ";", -1);
+ char** tokens = g_strsplit_set(text, ";", -1);
if (tokens == NULL || tokens[0] == NULL || tokens[1] == NULL) {
if (tokens != NULL) {
@@ -2056,7 +3256,7 @@ blf_read_apptextmessage(blf_params_t *params, int *err, gchar **err_info, gint64
return BLF_APPTEXT_CHANNEL;
}
- guint16 channel = (apptextheader.reservedAppText1 >> 8) & 0xff;
+ uint16_t channel = (apptextheader.reservedAppText1 >> 8) & 0xff;
int pkt_encap;
switch ((apptextheader.reservedAppText1 >> 16) & 0xff) {
@@ -2082,64 +3282,113 @@ blf_read_apptextmessage(blf_params_t *params, int *err, gchar **err_info, gint64
default:
pkt_encap = 0xffffffff;
+ break;
}
/* we use lookup to create interface, if not existing yet */
- blf_lookup_interface(params, pkt_encap, channel, UINT16_MAX, tokens[1]);
+ blf_prepare_interface_name(params, pkt_encap, channel, UINT16_MAX, tokens[1], false);
g_strfreev(tokens);
g_free(text);
return BLF_APPTEXT_CHANNEL;
- break;
}
case BLF_APPTEXT_METADATA:
- case BLF_APPTEXT_COMMENT:
- if (apptextheader.textLength < 5) {
- /* Arbitrary length chosen */
- g_free(text);
- return BLF_APPTEXT_CHANNEL; /* Cheat - no block to write */
+ if (metadata_cont) {
+ /* Set the buffer pointer to the end of the previous object */
+ params->buf->first_free = metadata_cont;
+ }
+ else {
+ /* First object of a sequence of one or more */
+ wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_DISSECTOR_NAME, "data-text-lines");
+ wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_PROT_TEXT, "BLF App text");
+ wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_INFO_TEXT, "Metadata");
+ wtap_buffer_append_epdu_end(params->buf);
+ }
+
+ ws_buffer_assure_space(params->buf, apptextheader.textLength);
+ ws_buffer_append(params->buf, text, apptextheader.textLength);
+ g_free(text);
+
+ if ((apptextheader.reservedAppText1 & 0x00ffffff) > apptextheader.textLength) {
+ /* Continues in the next object */
+ return BLF_APPTEXT_CONT;
+ }
+
+ if (((apptextheader.reservedAppText1 >> 24) & 0xff) == BLF_APPTEXT_XML_CHANNELS) {
+ blf_set_xml_channels(params, params->buf->data, ws_buffer_length(params->buf));
}
+
+ /* Override the timestamp with 0 for metadata objects. Thay can only occur at the beginning of the file, and they usually alrady have a timestamp of 0. */
+ blf_init_rec(params, 0, 0, WTAP_ENCAP_WIRESHARK_UPPER_PDU, 0, UINT16_MAX, (uint32_t)ws_buffer_length(params->buf), (uint32_t)ws_buffer_length(params->buf));
+ return BLF_APPTEXT_METADATA;
+ case BLF_APPTEXT_COMMENT:
+ case BLF_APPTEXT_ATTACHMENT:
+ case BLF_APPTEXT_TRACELINE:
+ {
wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_DISSECTOR_NAME, "data-text-lines");
wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_PROT_TEXT, "BLF App text");
- if (apptextheader.source == BLF_APPTEXT_METADATA) {
- wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_INFO_TEXT, "Metadata");
- } else {
- wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_INFO_TEXT, "Comment");
+
+ char* info_line = NULL;
+ switch (apptextheader.source) {
+ case BLF_APPTEXT_COMMENT:
+ info_line = ws_strdup_printf("Comment: %s", text);
+ break;
+ case BLF_APPTEXT_ATTACHMENT:
+ info_line = ws_strdup_printf("Attachment: %s", text);
+ break;
+ case BLF_APPTEXT_TRACELINE:
+ info_line = ws_strdup_printf("Trace line%s: %s", (apptextheader.reservedAppText1 & 0x00000010) ? "" : " (hidden)", text);
+ break;
+ default:
+ break;
}
+ wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_COL_INFO_TEXT, info_line);
wtap_buffer_append_epdu_end(params->buf);
- ws_buffer_assure_space(params->buf, apptextheader.textLength); /* The dissector doesn't need NULL-terminated strings */
- ws_buffer_append(params->buf, text, apptextheader.textLength);
+ size_t text_length = strlen(text); /* The string can contain '\0' before textLength bytes */
+ ws_buffer_assure_space(params->buf, text_length); /* The dissector doesn't need NULL-terminated strings */
+ ws_buffer_append(params->buf, text, text_length);
/* We'll write this as a WS UPPER PDU packet with a text blob */
- blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_WIRESHARK_UPPER_PDU, 0, UINT16_MAX, (guint32)ws_buffer_length(params->buf), (guint32)ws_buffer_length(params->buf));
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_WIRESHARK_UPPER_PDU, 0, UINT16_MAX, (uint32_t)ws_buffer_length(params->buf), (uint32_t)ws_buffer_length(params->buf));
g_free(text);
+ if (info_line) {
+ g_free(info_line);
+ }
return apptextheader.source;
- break;
+ }
default:
g_free(text);
return BLF_APPTEXT_CHANNEL; /* Cheat - no block to write */;
- break;
}
return BLF_APPTEXT_CHANNEL; /* Cheat - no block to write */
}
-static gboolean
-blf_read_ethernet_status(blf_params_t* params, int* err, gchar** err_info, gint64 block_start, gint64 data_start, gint64 object_length, guint32 flags, guint64 object_timestamp) {
+static bool
+blf_read_ethernet_status(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp, uint16_t object_version) {
blf_ethernet_status_t ethernet_status_header;
- guint8 tmpbuf[16];
+ uint8_t tmpbuf[24];
+ uint64_t linkUpDuration;
- if (object_length < (data_start - block_start) + (int)sizeof(ethernet_status_header)) {
+ if (object_length < (data_start - block_start) + (int)sizeof(ethernet_status_header) + (int)(object_version >= 1 ? 8 : 0)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup_printf("blf: ETHERNET_STATUS: not enough bytes for ethernet status header in object");
ws_debug("not enough bytes for ethernet status header in object");
- return FALSE;
+ return false;
}
if (!blf_read_bytes(params, data_start, &ethernet_status_header, sizeof(ethernet_status_header), err, err_info)) {
ws_debug("not enough bytes for ethernet_status_header header in file");
- return FALSE;
+ return false;
+ }
+
+ if (object_version >= 1) {
+ if (!blf_read_bytes(params, data_start + sizeof(ethernet_status_header), &linkUpDuration, 8, err, err_info)) {
+ ws_debug("not enough bytes for ethernet_status_header header in file");
+ return false;
+ }
+ GUINT64_FROM_LE(linkUpDuration);
}
fix_endianness_blf_ethernet_status_header(&ethernet_status_header);
@@ -2161,11 +3410,22 @@ blf_read_ethernet_status(blf_params_t* params, int* err, gchar** err_info, gint6
tmpbuf[14] = (ethernet_status_header.bitrate & 0x0000ff00) >> 8;
tmpbuf[15] = (ethernet_status_header.bitrate & 0x000000ff);
+ if (object_version >= 1) {
+ tmpbuf[16] = (linkUpDuration & UINT64_C(0xff00000000000000)) >> 56;
+ tmpbuf[17] = (linkUpDuration & UINT64_C(0x00ff000000000000)) >> 48;
+ tmpbuf[18] = (linkUpDuration & UINT64_C(0x0000ff0000000000)) >> 40;
+ tmpbuf[19] = (linkUpDuration & UINT64_C(0x000000ff00000000)) >> 32;
+ tmpbuf[20] = (linkUpDuration & UINT64_C(0x00000000ff000000)) >> 24;
+ tmpbuf[21] = (linkUpDuration & UINT64_C(0x0000000000ff0000)) >> 16;
+ tmpbuf[22] = (linkUpDuration & UINT64_C(0x000000000000ff00)) >> 8;
+ tmpbuf[23] = (linkUpDuration & UINT64_C(0x00000000000000ff));
+ }
+
wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_DISSECTOR_NAME, "blf-ethernetstatus-obj");
wtap_buffer_append_epdu_end(params->buf);
ws_buffer_assure_space(params->buf, sizeof(ethernet_status_header));
- ws_buffer_append(params->buf, tmpbuf, (gsize)16);
+ ws_buffer_append(params->buf, tmpbuf, (size_t)(object_version >= 1 ? 24 : 16));
/* We'll write this as a WS UPPER PDU packet with a data blob */
/* This will create an interface with the "name" of the matching
@@ -2178,24 +3438,82 @@ blf_read_ethernet_status(blf_params_t* params, int* err, gchar** err_info, gint6
char* iface_name = ws_strdup_printf("STATUS-ETH-%u-%u", ethernet_status_header.channel, ethernet_status_header.hardwareChannel);
blf_lookup_interface(params, WTAP_ENCAP_WIRESHARK_UPPER_PDU, ethernet_status_header.channel, ethernet_status_header.hardwareChannel, iface_name);
g_free(iface_name);
- blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_WIRESHARK_UPPER_PDU, ethernet_status_header.channel, ethernet_status_header.hardwareChannel, (guint32)ws_buffer_length(params->buf), (guint32)ws_buffer_length(params->buf));
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_WIRESHARK_UPPER_PDU, ethernet_status_header.channel, ethernet_status_header.hardwareChannel, (uint32_t)ws_buffer_length(params->buf), (uint32_t)ws_buffer_length(params->buf));
if ((ethernet_status_header.flags & BLF_ETH_STATUS_HARDWARECHANNEL) == BLF_ETH_STATUS_HARDWARECHANNEL) {
/* If HW channel valid */
wtap_block_add_uint32_option(params->rec->block, OPT_PKT_QUEUE, ethernet_status_header.hardwareChannel);
}
- return TRUE;
+ return true;
+}
+
+static bool
+blf_read_ethernet_phystate(blf_params_t* params, int* err, char** err_info, int64_t block_start, int64_t data_start, int64_t object_length, uint32_t flags, uint64_t object_timestamp) {
+ blf_ethernet_phystate_t ethernet_phystate_header;
+ uint8_t tmpbuf[8];
+
+ if (object_length < (data_start - block_start) + (int)sizeof(ethernet_phystate_header)) {
+ *err = WTAP_ERR_BAD_FILE;
+ *err_info = ws_strdup_printf("blf: ETHERNET_PHY_STATE: not enough bytes for ethernet phystate header in object");
+ ws_debug("not enough bytes for ethernet phystate header in object");
+ return false;
+ }
+
+ if (!blf_read_bytes(params, data_start, &ethernet_phystate_header, sizeof(ethernet_phystate_header), err, err_info)) {
+ ws_debug("not enough bytes for ethernet phystate header in file");
+ return false;
+ }
+
+ fix_endianness_blf_ethernet_phystate_header(&ethernet_phystate_header);
+
+ tmpbuf[0] = (ethernet_phystate_header.channel & 0xff00) >> 8;
+ tmpbuf[1] = (ethernet_phystate_header.channel & 0x00ff);
+ tmpbuf[2] = (ethernet_phystate_header.flags & 0xff00) >> 8;
+ tmpbuf[3] = (ethernet_phystate_header.flags & 0x00ff);
+ tmpbuf[4] = (ethernet_phystate_header.phyState);
+ tmpbuf[5] = (ethernet_phystate_header.phyEvent);
+ tmpbuf[6] = (ethernet_phystate_header.hardwareChannel);
+ tmpbuf[7] = (ethernet_phystate_header.res1);
+
+ wtap_buffer_append_epdu_string(params->buf, EXP_PDU_TAG_DISSECTOR_NAME, "blf-ethernetphystate-obj");
+ wtap_buffer_append_epdu_end(params->buf);
+
+ ws_buffer_assure_space(params->buf, sizeof(ethernet_phystate_header));
+ ws_buffer_append(params->buf, tmpbuf, sizeof(ethernet_phystate_header));
+
+ /* We'll write this as a WS UPPER PDU packet with a data blob */
+ /* This will create an interface with the "name" of the matching
+ * WTAP_ENCAP_ETHERNET interface with the same channel and hardware
+ * channel prefixed with "STATUS" and with a different interface ID,
+ * because IDBs in pcapng can only have one linktype.
+ * The other option would be to write everything as UPPER_PDU, including
+ * the Ethernet data (with one of the "eth_" dissectors.)
+ */
+ char* iface_name = ws_strdup_printf("STATUS-ETH-%u-%u", ethernet_phystate_header.channel, ethernet_phystate_header.hardwareChannel);
+ blf_lookup_interface(params, WTAP_ENCAP_WIRESHARK_UPPER_PDU, ethernet_phystate_header.channel, ethernet_phystate_header.hardwareChannel, iface_name);
+ g_free(iface_name);
+ blf_init_rec(params, flags, object_timestamp, WTAP_ENCAP_WIRESHARK_UPPER_PDU, ethernet_phystate_header.channel, ethernet_phystate_header.hardwareChannel, (uint32_t)ws_buffer_length(params->buf), (uint32_t)ws_buffer_length(params->buf));
+
+ if ((ethernet_phystate_header.flags & BLF_PHY_STATE_HARDWARECHANNEL) == BLF_PHY_STATE_HARDWARECHANNEL) {
+ /* If HW channel valid */
+ wtap_block_add_uint32_option(params->rec->block, OPT_PKT_QUEUE, ethernet_phystate_header.hardwareChannel);
+ }
+
+ return true;
}
-static gboolean
-blf_read_block(blf_params_t *params, gint64 start_pos, int *err, gchar **err_info) {
+static bool
+blf_read_block(blf_params_t *params, int64_t start_pos, int *err, char **err_info) {
blf_blockheader_t header;
blf_logobjectheader_t logheader;
blf_logobjectheader2_t logheader2;
blf_logobjectheader3_t logheader3;
- guint32 flags;
- guint64 object_timestamp;
+ uint32_t flags;
+ uint64_t object_timestamp;
+ uint16_t object_version;
+ int64_t last_metadata_start = 0;
+ size_t metadata_cont = 0;
while (1) {
/* Find Object */
@@ -2211,14 +3529,15 @@ blf_read_block(blf_params_t *params, gint64 start_pos, int *err, gchar **err_inf
*err = 0;
g_free(*err_info);
}
- return FALSE;
+ return false;
}
fix_endianness_blf_blockheader(&header);
if (memcmp(header.magic, blf_obj_magic, sizeof(blf_obj_magic))) {
ws_debug("object magic is not LOBJ (pos: 0x%" PRIx64 ")", start_pos);
- } else {
+ }
+ else {
break;
}
@@ -2228,187 +3547,271 @@ blf_read_block(blf_params_t *params, gint64 start_pos, int *err, gchar **err_inf
}
params->blf_data->start_of_last_obj = start_pos;
+ if (!params->random) {
+ /* Make sure that we start after this object next time,
+ * but only if it's a linear read. We can have random reads
+ * during the linear read, so we have to make sure we don't
+ * lose track of our position.
+ */
+ params->blf_data->current_real_seek_pos = start_pos + MAX(MAX(16, header.object_length), header.header_length);
+ }
+
switch (header.header_type) {
case BLF_HEADER_TYPE_DEFAULT:
if (!blf_read_log_object_header(params, err, err_info, start_pos + sizeof(blf_blockheader_t), start_pos + header.header_length, &logheader)) {
- return FALSE;
+ return false;
}
flags = logheader.flags;
object_timestamp = logheader.object_timestamp;
+ object_version = logheader.object_version;
break;
case BLF_HEADER_TYPE_2:
if (!blf_read_log_object_header2(params, err, err_info, start_pos + sizeof(blf_blockheader_t), start_pos + header.header_length, &logheader2)) {
- return FALSE;
+ return false;
}
flags = logheader2.flags;
object_timestamp = logheader2.object_timestamp;
+ object_version = logheader2.object_version;
break;
case BLF_HEADER_TYPE_3:
if (!blf_read_log_object_header3(params, err, err_info, start_pos + sizeof(blf_blockheader_t), start_pos + header.header_length, &logheader3)) {
- return FALSE;
+ return false;
}
flags = logheader3.flags;
object_timestamp = logheader3.object_timestamp;
+ object_version = logheader3.object_version;
break;
default:
*err = WTAP_ERR_UNSUPPORTED;
*err_info = ws_strdup_printf("blf: unknown header type %u", header.header_type);
ws_debug("unknown header type");
- return FALSE;
+ return false;
}
- /* already making sure that we start after this object next time. */
- params->blf_data->current_real_seek_pos = start_pos + MAX(MAX(16, header.object_length), header.header_length);
+ if (metadata_cont && header.object_type != BLF_OBJTYPE_APP_TEXT) {
+ /* If we're in the middle of a sequence of AppText metadata objects,
+ * but we get an AppText object from another source,
+ * skip the previous incomplete packet and start fresh.
+ */
+ metadata_cont = 0;
+ last_metadata_start = 0;
+ }
switch (header.object_type) {
case BLF_OBJTYPE_LOG_CONTAINER:
*err = WTAP_ERR_UNSUPPORTED;
*err_info = ws_strdup_printf("blf: log container in log container not supported");
ws_debug("log container in log container not supported");
- return FALSE;
- break;
+ return false;
case BLF_OBJTYPE_ETHERNET_FRAME:
return blf_read_ethernetframe(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_ETHERNET_FRAME_EX:
- return blf_read_ethernetframe_ext(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
+ return blf_read_ethernetframe_ext(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, false);
+
+ case BLF_OBJTYPE_ETHERNET_RX_ERROR:
+ return blf_read_ethernet_rxerror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_ETHERNET_ERROR_EX:
+ return blf_read_ethernetframe_ext(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, true);
case BLF_OBJTYPE_WLAN_FRAME:
return blf_read_wlanframe(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_CAN_MESSAGE:
- return blf_read_canmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, FALSE);
- break;
+ return blf_read_canmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, false);
case BLF_OBJTYPE_CAN_ERROR:
- return blf_read_canerror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
+ return blf_read_canerror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, false);
+
+ case BLF_OBJTYPE_CAN_OVERLOAD:
+ return blf_read_canerror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, true);
case BLF_OBJTYPE_CAN_MESSAGE2:
- return blf_read_canmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, TRUE);
- break;
+ return blf_read_canmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, true);
case BLF_OBJTYPE_CAN_ERROR_EXT:
return blf_read_canerrorext(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_CAN_FD_MESSAGE:
return blf_read_canfdmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_CAN_FD_MESSAGE_64:
return blf_read_canfdmessage64(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_CAN_FD_ERROR_64:
return blf_read_canfderror64(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_FLEXRAY_DATA:
return blf_read_flexraydata(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_FLEXRAY_MESSAGE:
return blf_read_flexraymessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
case BLF_OBJTYPE_FLEXRAY_RCVMESSAGE:
- return blf_read_flexrayrcvmessageex(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, FALSE);
- break;
+ return blf_read_flexrayrcvmessageex(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, false);
case BLF_OBJTYPE_FLEXRAY_RCVMESSAGE_EX:
- return blf_read_flexrayrcvmessageex(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, TRUE);
- break;
+ return blf_read_flexrayrcvmessageex(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, true);
case BLF_OBJTYPE_LIN_MESSAGE:
- return blf_read_linmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
- break;
+ return blf_read_linmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, false);
+
+ case BLF_OBJTYPE_LIN_CRC_ERROR:
+ return blf_read_linmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, true);
+
+ case BLF_OBJTYPE_LIN_RCV_ERROR:
+ return blf_read_linrcverror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_LIN_SND_ERROR:
+ return blf_read_linsenderror(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_LIN_WAKEUP:
+ return blf_read_linwakeupevent(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_LIN_MESSAGE2:
+ return blf_read_linmessage2(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, object_version);
+
+ case BLF_OBJTYPE_LIN_CRC_ERROR2:
+ return blf_read_lincrcerror2(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, object_version);
+
+ case BLF_OBJTYPE_LIN_RCV_ERROR2:
+ return blf_read_linrcverror2(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, object_version);
+
+ case BLF_OBJTYPE_LIN_SND_ERROR2:
+ return blf_read_linsenderror2(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, object_version);
+
+ case BLF_OBJTYPE_LIN_WAKEUP2:
+ return blf_read_linwakeupevent2(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_LIN_SLEEP:
+ return blf_read_linsleepmodeevent(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
case BLF_OBJTYPE_APP_TEXT:
{
- int result = blf_read_apptextmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+ int result = blf_read_apptextmessage(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, metadata_cont);
+ if (result == BLF_APPTEXT_CONT) {
+ if (!metadata_cont) {
+ /* First object of a sequence, save its start position */
+ last_metadata_start = start_pos;
+ }
+ /* Save a pointer to the end of the buffer */
+ metadata_cont = params->buf->first_free;
+ }
+ else {
+ if (result == BLF_APPTEXT_METADATA && metadata_cont) {
+ /* Last object of a sequence, restore the start position of the first object */
+ params->blf_data->start_of_last_obj = last_metadata_start;
+ }
+ /* Reset everything and start fresh */
+ last_metadata_start = 0;
+ metadata_cont = 0;
+ }
switch (result) {
case BLF_APPTEXT_FAILED:
- return FALSE;
- case BLF_APPTEXT_METADATA:
- return TRUE;
+ return false;
case BLF_APPTEXT_COMMENT:
- return TRUE;
+ case BLF_APPTEXT_METADATA:
+ case BLF_APPTEXT_ATTACHMENT:
+ case BLF_APPTEXT_TRACELINE:
+ return true;
case BLF_APPTEXT_CHANNEL:
+ case BLF_APPTEXT_CONT:
default:
/* we do not return since there is no packet to show here */
- start_pos += MAX(MAX(16, header.object_length), header.header_length);
+ start_pos += MAX(MAX(16, header.object_length), header.header_length);
+ break;
}
}
break;
case BLF_OBJTYPE_ETHERNET_STATUS:
- return blf_read_ethernet_status(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+ return blf_read_ethernet_status(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp, object_version);
+
+ case BLF_OBJTYPE_ETHERNET_PHY_STATE:
+ return blf_read_ethernet_phystate(params, err, err_info, start_pos, start_pos + header.header_length, header.object_length, flags, object_timestamp);
+
+ case BLF_OBJTYPE_ENV_INTEGER:
+ case BLF_OBJTYPE_ENV_DOUBLE:
+ case BLF_OBJTYPE_ENV_STRING:
+ case BLF_OBJTYPE_ENV_DATA:
+ case BLF_OBJTYPE_SYS_VARIABLE:
+ case BLF_OBJTYPE_RESERVED5: /* Despite the name, this is actually used. Maybe it's worth investigating the content. */
+ case BLF_OBJTYPE_TEST_STRUCTURE:
+ ws_debug("skipping unsupported object type 0x%04x", header.object_type);
+ start_pos += MAX(MAX(16, header.object_length), header.header_length);
break;
default:
- ws_debug("unknown object type 0x%04x", header.object_type);
+ ws_info("unknown object type 0x%04x", header.object_type);
start_pos += MAX(MAX(16, header.object_length), header.header_length);
+ break;
}
}
- return TRUE;
+ return true;
}
-static gboolean blf_read(wtap *wth, wtap_rec *rec, Buffer *buf, int *err, gchar **err_info, gint64 *data_offset) {
+static bool blf_read(wtap *wth, wtap_rec *rec, Buffer *buf, int *err, char **err_info, int64_t *data_offset) {
blf_params_t blf_tmp;
blf_tmp.wth = wth;
blf_tmp.fh = wth->fh;
+ blf_tmp.random = false;
+ blf_tmp.pipe = wth->ispipe;
blf_tmp.rec = rec;
blf_tmp.buf = buf;
blf_tmp.blf_data = (blf_t *)wth->priv;
if (!blf_read_block(&blf_tmp, blf_tmp.blf_data->current_real_seek_pos, err, err_info)) {
- return FALSE;
+ return false;
}
*data_offset = blf_tmp.blf_data->start_of_last_obj;
- return TRUE;
+ return true;
}
-static gboolean blf_seek_read(wtap *wth, gint64 seek_off, wtap_rec *rec, Buffer *buf, int *err, gchar **err_info) {
+static bool blf_seek_read(wtap *wth, int64_t seek_off, wtap_rec *rec, Buffer *buf, int *err, char **err_info) {
blf_params_t blf_tmp;
blf_tmp.wth = wth;
blf_tmp.fh = wth->random_fh;
+ blf_tmp.random = true;
+ blf_tmp.pipe = wth->ispipe;
blf_tmp.rec = rec;
blf_tmp.buf = buf;
blf_tmp.blf_data = (blf_t *)wth->priv;
if (!blf_read_block(&blf_tmp, seek_off, err, err_info)) {
ws_debug("couldn't read packet block (err=%d).", *err);
- return FALSE;
+ return false;
}
- return TRUE;
+ return true;
}
static void blf_free(blf_t *blf) {
- if (blf != NULL && blf->log_containers != NULL) {
- for (guint i = 0; i < blf->log_containers->len; i++) {
- blf_log_container_t *log_container = &g_array_index(blf->log_containers, blf_log_container_t, i);
- if (log_container->real_data != NULL) {
- g_free(log_container->real_data);
+ if (blf != NULL) {
+ if (blf->log_containers != NULL) {
+ for (unsigned i = 0; i < blf->log_containers->len; i++) {
+ blf_log_container_t* log_container = &g_array_index(blf->log_containers, blf_log_container_t, i);
+ if (log_container->real_data != NULL) {
+ g_free(log_container->real_data);
+ }
}
+ g_array_free(blf->log_containers, true);
+ blf->log_containers = NULL;
+ }
+ if (blf->channel_to_iface_ht != NULL) {
+ g_hash_table_destroy(blf->channel_to_iface_ht);
+ blf->channel_to_iface_ht = NULL;
+ }
+ if (blf->channel_to_name_ht != NULL) {
+ g_hash_table_destroy(blf->channel_to_name_ht);
+ blf->channel_to_name_ht = NULL;
}
- g_array_free(blf->log_containers, TRUE);
- blf->log_containers = NULL;
- }
-
- if (blf != NULL && blf->channel_to_iface_ht != NULL) {
- g_hash_table_destroy(blf->channel_to_iface_ht);
- blf->channel_to_iface_ht = NULL;
}
}
@@ -2419,14 +3822,13 @@ static void blf_close(wtap *wth) {
}
wtap_open_return_val
-blf_open(wtap *wth, int *err, gchar **err_info) {
+blf_open(wtap *wth, int *err, char **err_info) {
blf_fileheader_t header;
blf_t *blf;
- blf_params_t params;
ws_debug("opening file");
- if (!wtap_read_bytes_or_eof(wth->fh, &header, sizeof header, err, err_info)) {
+ if (!wtap_read_bytes_or_eof(wth->fh, &header, sizeof(blf_fileheader_t), err, err_info)) {
ws_debug("wtap_read_bytes_or_eof() failed, err = %d.", *err);
if (*err == 0 || *err == WTAP_ERR_SHORT_READ) {
@@ -2452,14 +3854,14 @@ blf_open(wtap *wth, int *err, gchar **err_info) {
/* This seems to be an BLF! */
/* Check for a valid header length */
- if (header.header_length < sizeof(blf_blockheader_t)) {
+ if (header.header_length < sizeof(blf_fileheader_t)) {
*err = WTAP_ERR_BAD_FILE;
*err_info = ws_strdup("blf: file header length too short");
return WTAP_OPEN_ERROR;
}
/* skip past the header, which may include padding/reserved space */
- if (file_seek(wth->fh, header.header_length, SEEK_SET, err) < 0) {
+ if (!wtap_read_bytes(wth->fh, NULL, header.header_length - sizeof(blf_fileheader_t), err, err_info)) {
return WTAP_OPEN_ERROR;
}
@@ -2474,30 +3876,15 @@ blf_open(wtap *wth, int *err, gchar **err_info) {
/* Prepare our private context. */
blf = g_new(blf_t, 1);
- blf->log_containers = NULL;
- blf->current_log_container = 0;
+ blf->log_containers = g_array_new(false, false, sizeof(blf_log_container_t));
blf->current_real_seek_pos = 0;
- blf->start_offset_ns = 1000 * 1000 * 1000 * (guint64)mktime(&timestamp);
+ blf->start_offset_ns = 1000 * 1000 * 1000 * (uint64_t)mktime(&timestamp);
blf->start_offset_ns += 1000 * 1000 * header.start_date.ms;
blf->channel_to_iface_ht = g_hash_table_new_full(g_int64_hash, g_int64_equal, &blf_free_key, &blf_free_channel_to_iface_entry);
+ blf->channel_to_name_ht = g_hash_table_new_full(g_int64_hash, g_int64_equal, &blf_free_key, &blf_free_channel_to_name_entry);
blf->next_interface_id = 0;
- /* embed in params */
- params.blf_data = blf;
- params.buf = NULL;
- params.fh = wth->fh;
- params.rec = NULL;
- params.wth = wth;
- params.blf_data->current_real_seek_pos = 0;
-
- /* lets check out the layout of all log containers */
- if (!blf_scan_file_for_logcontainers(&params, err, err_info)) {
- /* That didn't work. */
- blf_free(blf);
- return WTAP_OPEN_ERROR;
- }
-
wth->priv = (void *)blf;
wth->file_encap = WTAP_ENCAP_NONE;
wth->snapshot_length = 0;
@@ -2523,7 +3910,7 @@ static const struct supported_block_type blf_blocks_supported[] = {
static const struct file_type_subtype_info blf_info = {
"Vector Informatik Binary Logging Format (BLF) logfile", "blf", "blf", NULL,
- FALSE, BLOCKS_SUPPORTED(blf_blocks_supported),
+ false, BLOCKS_SUPPORTED(blf_blocks_supported),
NULL, NULL, NULL
};