1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
|
/*
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
*
* SPDX-License-Identifier: MPL-2.0
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
*
* See the COPYRIGHT file distributed with this work for additional
* information regarding copyright ownership.
*/
#include <inttypes.h>
#include <sched.h> /* IWYU pragma: keep */
#include <setjmp.h>
#include <stdarg.h>
#include <stddef.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#define UNIT_TESTING
#include <cmocka.h>
#include <isc/hex.h>
#include <isc/result.h>
#include <isc/string.h>
#include <isc/util.h>
#include <dns/db.h>
#include <dns/nsec3.h>
#include "zone_p.h"
#include <tests/dns.h>
#define HASH 1
#define FLAGS 0
#define ITER 5
#define SALTLEN 4
#define SALT "FEDCBA98"
/*%
* Structures containing parameters for nsec3param_salttotext_test().
*/
typedef struct {
dns_hash_t hash;
unsigned char flags;
dns_iterations_t iterations;
unsigned char salt_length;
const char *salt;
} nsec3param_rdata_test_params_t;
typedef struct {
nsec3param_rdata_test_params_t lookup;
nsec3param_rdata_test_params_t expect;
bool resalt;
isc_result_t expected_result;
} nsec3param_change_test_params_t;
static void
decode_salt(const char *string, unsigned char *salt, size_t saltlen) {
isc_buffer_t buf;
isc_result_t result;
isc_buffer_init(&buf, salt, saltlen);
result = isc_hex_decodestring(string, &buf);
assert_int_equal(result, ISC_R_SUCCESS);
}
static void
copy_params(nsec3param_rdata_test_params_t from, dns_rdata_nsec3param_t *to,
unsigned char *saltbuf, size_t saltlen) {
to->hash = from.hash;
to->flags = from.flags;
to->iterations = from.iterations;
to->salt_length = from.salt_length;
if (from.salt == NULL) {
to->salt = NULL;
} else if (strcmp(from.salt, "-") == 0) {
DE_CONST("-", to->salt);
} else {
decode_salt(from.salt, saltbuf, saltlen);
to->salt = saltbuf;
}
}
static nsec3param_rdata_test_params_t
rdata_fromparams(uint8_t hash, uint8_t flags, uint16_t iter, uint8_t saltlen,
const char *salt) {
nsec3param_rdata_test_params_t nsec3param;
nsec3param.hash = hash;
nsec3param.flags = flags;
nsec3param.iterations = iter;
nsec3param.salt_length = saltlen;
nsec3param.salt = salt;
return (nsec3param);
}
/*%
* Check whether zone_lookup_nsec3param() finds the correct NSEC3PARAM
* and sets the correct parameters to use in dns_zone_setnsec3param().
*/
static void
nsec3param_change_test(const nsec3param_change_test_params_t *test) {
dns_zone_t *zone = NULL;
dns_rdata_nsec3param_t param, lookup, expect;
isc_result_t result;
unsigned char lookupsalt[255];
unsigned char expectsalt[255];
unsigned char saltbuf[255];
/*
* Prepare a zone along with its signing keys.
*/
result = dns_test_makezone("nsec3", &zone, NULL, false);
assert_int_equal(result, ISC_R_SUCCESS);
result = dns_zone_setfile(
zone, TESTS_DIR "/testdata/nsec3param/nsec3.db.signed",
dns_masterformat_text, &dns_master_style_default);
assert_int_equal(result, ISC_R_SUCCESS);
result = dns_zone_load(zone, false);
assert_int_equal(result, ISC_R_SUCCESS);
/*
* Copy parameters.
*/
copy_params(test->lookup, &lookup, lookupsalt, sizeof(lookupsalt));
copy_params(test->expect, &expect, expectsalt, sizeof(expectsalt));
/*
* Test dns__zone_lookup_nsec3param().
*/
result = dns__zone_lookup_nsec3param(zone, &lookup, ¶m, saltbuf,
test->resalt);
assert_int_equal(result, test->expected_result);
assert_int_equal(param.hash, expect.hash);
assert_int_equal(param.flags, expect.flags);
assert_int_equal(param.iterations, expect.iterations);
assert_int_equal(param.salt_length, expect.salt_length);
assert_non_null(param.salt);
if (expect.salt != NULL) {
int ret = memcmp(param.salt, expect.salt, expect.salt_length);
assert_true(ret == 0);
} else {
/*
* We don't know what the new salt is, but we can compare it
* to the previous salt and test that it has changed.
*/
unsigned char salt[SALTLEN];
int ret;
decode_salt(SALT, salt, SALTLEN);
ret = memcmp(param.salt, salt, SALTLEN);
assert_false(ret == 0);
}
/*
* Detach.
*/
dns_zone_detach(&zone);
}
ISC_RUN_TEST_IMPL(nsec3param_change) {
size_t i;
/*
* Define tests.
*/
const nsec3param_change_test_params_t tests[] = {
/*
* 1. Change nothing (don't care about salt).
* This should return ISC_R_SUCCESS because we are already
* using these NSEC3 parameters.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, NULL),
rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, SALT), false,
ISC_R_SUCCESS },
/*
* 2. Change nothing, but force a resalt.
* This should change the salt. Set 'expect.salt' to NULL to
* test a new salt has been generated.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, NULL),
rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, NULL), true,
DNS_R_NSEC3RESALT },
/*
* 3. Change iterations.
* The NSEC3 paarameters are not found, and there is no
* need to resalt because an explicit salt has been set,
* and resalt is not enforced.
*/
{ rdata_fromparams(HASH, FLAGS, 10, SALTLEN, SALT),
rdata_fromparams(HASH, FLAGS, 10, SALTLEN, SALT), false,
ISC_R_NOTFOUND },
/*
* 4. Change iterations, don't care about the salt.
* We don't care about the salt. Since we need to change the
* NSEC3 parameters, we will also resalt.
*/
{ rdata_fromparams(HASH, FLAGS, 10, SALTLEN, NULL),
rdata_fromparams(HASH, FLAGS, 10, SALTLEN, NULL), false,
DNS_R_NSEC3RESALT },
/*
* 5. Change salt length.
* Changing salt length means we need to resalt.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, 16, NULL),
rdata_fromparams(HASH, FLAGS, ITER, 16, NULL), false,
DNS_R_NSEC3RESALT },
/*
* 6. Set explicit salt.
* A different salt, so the NSEC3 parameters are not found.
* No need to resalt because an explicit salt is available.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, 4, "12345678"),
rdata_fromparams(HASH, FLAGS, ITER, 4, "12345678"), false,
ISC_R_NOTFOUND },
/*
* 7. Same salt.
* Nothing changed, so expect ISC_R_SUCCESS as a result.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, SALT),
rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, SALT), false,
ISC_R_SUCCESS },
/*
* 8. Same salt, and force resalt.
* Nothing changed, but a resalt is enforced.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, SALT),
rdata_fromparams(HASH, FLAGS, ITER, SALTLEN, NULL), true,
DNS_R_NSEC3RESALT },
/*
* 9. No salt.
* Change parameters to use no salt. These parameters are
* not found, and no new salt needs to be generated.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, 0, NULL),
rdata_fromparams(HASH, FLAGS, ITER, 0, "-"), true,
ISC_R_NOTFOUND },
/*
* 10. No salt, explicit.
* Same as above, but set no salt explicitly.
*/
{ rdata_fromparams(HASH, FLAGS, ITER, 0, "-"),
rdata_fromparams(HASH, FLAGS, ITER, 0, "-"), true,
ISC_R_NOTFOUND },
};
UNUSED(state);
/*
* Run tests.
*/
for (i = 0; i < sizeof(tests) / sizeof(tests[0]); i++) {
nsec3param_change_test(&tests[i]);
}
}
ISC_TEST_LIST_START
ISC_TEST_ENTRY(nsec3param_change)
ISC_TEST_LIST_END
ISC_TEST_MAIN
|
