1 files changed, 258 insertions, 0 deletions
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.spec.ts
new file mode 100644
index 000000000..4f95ac1e2
--- /dev/null
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.spec.ts
@@ -0,0 +1,258 @@
+import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { Component } from '@angular/core';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ReactiveFormsModule } from '@angular/forms';
+import { Router, Routes } from '@angular/router';
+import { RouterTestingModule } from '@angular/router/testing';
+
+import { NgbPopoverModule } from '@ng-bootstrap/ng-bootstrap';
+import { ToastrModule } from 'ngx-toastr';
+import { of } from 'rxjs';
+
+import { RoleService } from '~/app/shared/api/role.service';
+import { SettingsService } from '~/app/shared/api/settings.service';
+import { UserService } from '~/app/shared/api/user.service';
+import { ComponentsModule } from '~/app/shared/components/components.module';
+import { LoadingPanelComponent } from '~/app/shared/components/loading-panel/loading-panel.component';
+import { CdFormGroup } from '~/app/shared/forms/cd-form-group';
+import { AuthStorageService } from '~/app/shared/services/auth-storage.service';
+import { ModalService } from '~/app/shared/services/modal.service';
+import { NotificationService } from '~/app/shared/services/notification.service';
+import { PasswordPolicyService } from '~/app/shared/services/password-policy.service';
+import { SharedModule } from '~/app/shared/shared.module';
+import { configureTestBed, FormHelper } from '~/testing/unit-test-helper';
+import { UserFormComponent } from './user-form.component';
+import { UserFormModel } from './user-form.model';
+
+describe('UserFormComponent', () => {
+  let component: UserFormComponent;
+  let form: CdFormGroup;
+  let fixture: ComponentFixture<UserFormComponent>;
+  let httpTesting: HttpTestingController;
+  let userService: UserService;
+  let modalService: ModalService;
+  let router: Router;
+  let formHelper: FormHelper;
+
+  const setUrl = (url: string) => Object.defineProperty(router, 'url', { value: url });
+
+  @Component({ selector: 'cd-fake', template: '' })
+  class FakeComponent {}
+
+  const routes: Routes = [
+    { path: 'login', component: FakeComponent },
+    { path: 'users', component: FakeComponent }
+  ];
+
+  configureTestBed(
+    {
+      imports: [
+        RouterTestingModule.withRoutes(routes),
+        HttpClientTestingModule,
+        ReactiveFormsModule,
+        ComponentsModule,
+        ToastrModule.forRoot(),
+        SharedModule,
+        NgbPopoverModule
+      ],
+      declarations: [UserFormComponent, FakeComponent]
+    },
+    [LoadingPanelComponent]
+  );
+
+  beforeEach(() => {
+    spyOn(TestBed.inject(PasswordPolicyService), 'getHelpText').and.callFake(() => of(''));
+    fixture = TestBed.createComponent(UserFormComponent);
+    component = fixture.componentInstance;
+    form = component.userForm;
+    httpTesting = TestBed.inject(HttpTestingController);
+    userService = TestBed.inject(UserService);
+    modalService = TestBed.inject(ModalService);
+    router = TestBed.inject(Router);
+    spyOn(router, 'navigate');
+    fixture.detectChanges();
+    const notify = TestBed.inject(NotificationService);
+    spyOn(notify, 'show');
+    formHelper = new FormHelper(form);
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+    expect(form).toBeTruthy();
+  });
+
+  describe('create mode', () => {
+    beforeEach(() => {
+      setUrl('/user-management/users/add');
+      component.ngOnInit();
+    });
+
+    it('should not disable fields', () => {
+      [
+        'username',
+        'name',
+        'password',
+        'confirmpassword',
+        'email',
+        'roles',
+        'pwdExpirationDate'
+      ].forEach((key) => expect(form.get(key).disabled).toBeFalsy());
+    });
+
+    it('should validate username required', () => {
+      formHelper.expectErrorChange('username', '', 'required');
+      formHelper.expectValidChange('username', 'user1');
+    });
+
+    it('should validate password match', () => {
+      formHelper.setValue('password', 'aaa');
+      formHelper.expectErrorChange('confirmpassword', 'bbb', 'match');
+      formHelper.expectValidChange('confirmpassword', 'aaa');
+    });
+
+    it('should validate email', () => {
+      formHelper.expectErrorChange('email', 'aaa', 'email');
+    });
+
+    it('should set mode', () => {
+      expect(component.mode).toBeUndefined();
+    });
+
+    it('should submit', () => {
+      const user: UserFormModel = {
+        username: 'user0',
+        password: 'pass0',
+        name: 'User 0',
+        email: 'user0@email.com',
+        roles: ['administrator'],
+        enabled: true,
+        pwdExpirationDate: undefined,
+        pwdUpdateRequired: true
+      };
+      formHelper.setMultipleValues(user);
+      formHelper.setValue('confirmpassword', user.password);
+      component.submit();
+      const userReq = httpTesting.expectOne('api/user');
+      expect(userReq.request.method).toBe('POST');
+      expect(userReq.request.body).toEqual(user);
+      userReq.flush({});
+      expect(router.navigate).toHaveBeenCalledWith(['/user-management/users']);
+    });
+  });
+
+  describe('edit mode', () => {
+    const user: UserFormModel = {
+      username: 'user1',
+      password: undefined,
+      name: 'User 1',
+      email: 'user1@email.com',
+      roles: ['administrator'],
+      enabled: true,
+      pwdExpirationDate: undefined,
+      pwdUpdateRequired: true
+    };
+    const roles = [
+      {
+        name: 'administrator',
+        description: 'Administrator',
+        scopes_permissions: {
+          user: ['create', 'delete', 'read', 'update']
+        }
+      },
+      {
+        name: 'read-only',
+        description: 'Read-Only',
+        scopes_permissions: {
+          user: ['read']
+        }
+      },
+      {
+        name: 'user-manager',
+        description: 'User Manager',
+        scopes_permissions: {
+          user: ['create', 'delete', 'read', 'update']
+        }
+      }
+    ];
+
+    beforeEach(() => {
+      spyOn(userService, 'get').and.callFake(() => of(user));
+      spyOn(TestBed.inject(RoleService), 'list').and.callFake(() => of(roles));
+      setUrl('/user-management/users/edit/user1');
+      spyOn(TestBed.inject(SettingsService), 'getStandardSettings').and.callFake(() =>
+        of({
+          user_pwd_expiration_warning_1: 10,
+          user_pwd_expiration_warning_2: 5,
+          user_pwd_expiration_span: 90
+        })
+      );
+      component.ngOnInit();
+      const req = httpTesting.expectOne('api/role');
+      expect(req.request.method).toBe('GET');
+      req.flush(roles);
+      httpTesting.expectOne('ui-api/standard_settings');
+    });
+
+    afterEach(() => {
+      httpTesting.verify();
+    });
+
+    it('should disable fields if editing', () => {
+      expect(form.get('username').disabled).toBeTruthy();
+      ['name', 'password', 'confirmpassword', 'email', 'roles'].forEach((key) =>
+        expect(form.get(key).disabled).toBeFalsy()
+      );
+    });
+
+    it('should set control values', () => {
+      ['username', 'name', 'email', 'roles'].forEach((key) =>
+        expect(form.getValue(key)).toBe(user[key])
+      );
+      ['password', 'confirmpassword'].forEach((key) => expect(form.getValue(key)).toBeFalsy());
+    });
+
+    it('should set mode', () => {
+      expect(component.mode).toBe('editing');
+    });
+
+    it('should alert if user is removing needed role permission', () => {
+      spyOn(TestBed.inject(AuthStorageService), 'getUsername').and.callFake(() => user.username);
+      let modalBodyTpl = null;
+      spyOn(modalService, 'show').and.callFake((_content, initialState) => {
+        modalBodyTpl = initialState.bodyTpl;
+      });
+      formHelper.setValue('roles', ['read-only']);
+      component.submit();
+      expect(modalBodyTpl).toEqual(component.removeSelfUserReadUpdatePermissionTpl);
+    });
+
+    it('should logout if current user roles have been changed', () => {
+      spyOn(TestBed.inject(AuthStorageService), 'getUsername').and.callFake(() => user.username);
+      formHelper.setValue('roles', ['user-manager']);
+      component.submit();
+      const userReq = httpTesting.expectOne(`api/user/${user.username}`);
+      expect(userReq.request.method).toBe('PUT');
+      userReq.flush({});
+      const authReq = httpTesting.expectOne('api/auth/logout');
+      expect(authReq.request.method).toBe('POST');
+    });
+
+    it('should submit', () => {
+      spyOn(TestBed.inject(AuthStorageService), 'getUsername').and.callFake(() => user.username);
+      component.submit();
+      const userReq = httpTesting.expectOne(`api/user/${user.username}`);
+      expect(userReq.request.method).toBe('PUT');
+      expect(userReq.request.body).toEqual({
+        username: 'user1',
+        password: '',
+        pwdUpdateRequired: true,
+        name: 'User 1',
+        email: 'user1@email.com',
+        roles: ['administrator'],
+        enabled: true
+      });
+      userReq.flush({});
+      expect(router.navigate).toHaveBeenCalledWith(['/user-management/users']);
+    });
+  });
+});